Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test a bunch of integrations against 3.13 #11687

Merged
merged 96 commits into from
Jan 6, 2025

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Dec 11, 2024

This change adds 3.13 to the list of Python versions tested against for many Riot environments. The ones that it leaves without 3.13 tests in place require more effort or specialized knowledge than the ones in this pull request did.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler marked this pull request as ready for review December 19, 2024 16:39
@emmettbutler emmettbutler requested review from a team as code owners December 19, 2024 16:39
@emmettbutler emmettbutler changed the title test a bunch of integrations against 3.13 ci: test a bunch of integrations against 3.13 Dec 19, 2024
@emmettbutler emmettbutler enabled auto-merge (squash) December 19, 2024 17:33
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Dec 20, 2024

Datadog Report

Branch report: emmett.butler/integrations-313
Commit report: ed5dca6
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 34.33s Total duration (35m 16s time saved)

@erikayasuda
Copy link
Contributor

@emmettbutler @vitor-de-araujo Looks like there's a consistent failure on aiopg and sqlalchemy due to a Test Vis coverage snippet 🤔

ddtrace/internal/test_visibility/coverage_lines.py:42: in add
    lines_byte = line_number // 8
E   TypeError: unsupported operand type(s) for //: 'NoneType' and 'int'

@emmettbutler emmettbutler requested a review from a team as a code owner January 6, 2025 14:28
@emmettbutler emmettbutler requested a review from a team as a code owner January 6, 2025 15:38
@emmettbutler emmettbutler requested a review from gnufede January 6, 2025 15:38
@emmettbutler emmettbutler merged commit 148da15 into main Jan 6, 2025
609 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/integrations-313 branch January 6, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants