-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(llmobs): support joining custom evaluations via tags #11535
base: main
Are you sure you want to change the base?
Conversation
|
BenchmarksBenchmark execution time: 2025-01-08 23:33:22 Comparing candidate commit 86d204f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 380 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first quick pass, will do another pass on Monday!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments/suggestions, but approving as none are super unblocking!
Datadog ReportBranch report: ✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 46.07s Total duration (35m 21.75s time saved) |
…-trace-py into evan.li/submit-evaluation-for
This PR implements
LLMObs.submit_evaluation_for
method, which gives users two options for joining custom evaluationsspan_with_tag
argument, which accepts a tuple containing a tag key/value pairspan
argument, which accepts a dictionary containingspan_id
andtrace_id
keysThere are also a couple behavior differences between
submit_evaluation_for
andsubmit_evaluation
. In the new method, wemetadata
argumentperiodic
methodOther changes:
Eval metric writer
Update the eval metric writer to write to the
v2
eval metric endpoint. The main difference with this endpoint is that it accepts ajoin_with
field that holds joining information instead of a top-level trace and span id fields.Deprecate
submit_evaluation
Deprecates
submit_evaluation
. I've set the removal version to be3.0.0
.Checklist
Reviewer Checklist