Skip to content

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Oct 28, 2025

What does this PR do?

Fix wrongly reported test suite durations by handling skipped tests differently in the instrumentation.

Motivation

If a quick and a slow test suite were run together, such as:

// quick-suite.spec.js
test.describe('quick suite', () => {
  test('should be able to run quickly', async () => {
    expect(true).toBe(true)
  })

  test.skip('should skip and not mess up the duration of the test suite', async () => {
    // TODO
  })
})

// slow-suite.spec.js (different file)
test.describe('slow suite', () => {
  test('should be able to run', async () => {
    await new Promise(resolve => setTimeout(resolve, 5000))
    expect(true).toBe(true)
  })
})

The quick suite would be dragged out all the way to the end of the test session because it included a test.skip, even though its duration should be smaller. This is because skipped tests do not go through the same run test functions, so they need to be handled differently in the instrumentation.

This was not caught earlier because it only happened if fullyParallel playwright config was set to true.

Plugin Checklist

  • Integration tests.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Overall package size

Self size: 13.16 MB
Deduped: 115.96 MB
No deduping: 118.17 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.207.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.12 | 95.11 kB | 401.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Oct 28, 2025

Benchmarks

Benchmark execution time: 2025-10-30 11:19:59

Comparing candidate commit bf32542 in PR branch juan-fernandez/fix-test-suite-duration with baseline commit 50146d9 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1606 metrics, 64 unstable metrics.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.04%. Comparing base (50146d9) to head (bf32542).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6770   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files         506      506           
  Lines       21242    21242           
=======================================
  Hits        17852    17852           
  Misses       3390     3390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-test-suite-duration branch from 2c36076 to 7997e11 Compare October 29, 2025 16:09
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-test-suite-duration branch from 384ac74 to 77f33f2 Compare October 30, 2025 10:54
@juan-fernandez juan-fernandez marked this pull request as ready for review October 30, 2025 10:54
@juan-fernandez juan-fernandez requested review from a team as code owners October 30, 2025 10:54
@juan-fernandez juan-fernandez merged commit f0c1e65 into master Oct 30, 2025
763 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-test-suite-duration branch October 30, 2025 14:28
@dd-octo-sts dd-octo-sts bot mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants