-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always check for the latest Node.js version being installed #5504
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b46de9b
Always check for the latest Node.js version being installed
BridgeAR 9fe1e93
Merge branch 'master' into BridgeAR/CI_should_pick_up_new_nodejs_vers…
watson c0b7e1f
Merge branch 'master' into BridgeAR/CI_should_pick_up_new_nodejs_vers…
watson f44a363
Merge branch 'master' into BridgeAR/CI_should_pick_up_new_nodejs_vers…
watson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,13 +36,13 @@ jobs: | |
| integration-guardrails: | ||
| strategy: | ||
| matrix: | ||
| version: [14.0.0, 14, 16.0.0, 16, 18.0.0, 18.1.0, 20.0.0, 22.0.0] | ||
| version: [14.0.0, 14, 16.0.0, eol, 18.0.0, 18.1.0, 20.0.0, 22.0.0] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| - uses: ./.github/actions/node | ||
| with: | ||
| node-version: ${{ matrix.version }} | ||
| version: ${{ matrix.version }} | ||
| - uses: ./.github/actions/install | ||
| - run: node node_modules/.bin/mocha --colors --timeout 30000 integration-tests/init.spec.js | ||
|
|
||
|
|
@@ -53,9 +53,9 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| - uses: ./.github/actions/node | ||
| with: | ||
| node-version: ${{ matrix.version }} | ||
| version: ${{ matrix.version }} | ||
| - run: node ./init | ||
| - run: node ./init | ||
| env: | ||
|
|
@@ -64,17 +64,17 @@ jobs: | |
| integration-playwright: | ||
| strategy: | ||
| matrix: | ||
| version: [18, latest] | ||
| version: [oldest, latest] | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| DD_SERVICE: dd-trace-js-integration-tests | ||
| DD_CIVISIBILITY_AGENTLESS_ENABLED: 1 | ||
| DD_API_KEY: ${{ secrets.DD_API_KEY_CI_APP }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| - uses: ./.github/actions/node | ||
| with: | ||
| node-version: ${{ matrix.version }} | ||
| version: ${{ matrix.version }} | ||
| - uses: ./.github/actions/install | ||
| # Install system dependencies for playwright | ||
| - run: npx playwright install-deps | ||
|
|
@@ -85,7 +85,7 @@ jobs: | |
| integration-ci: | ||
| strategy: | ||
| matrix: | ||
| version: [18, latest] | ||
| version: [oldest, latest] | ||
| framework: [cucumber, selenium, jest, mocha] | ||
| runs-on: ubuntu-latest | ||
| env: | ||
|
|
@@ -94,9 +94,9 @@ jobs: | |
| DD_API_KEY: ${{ secrets.DD_API_KEY_CI_APP }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| - uses: ./.github/actions/node | ||
| with: | ||
| node-version: ${{ matrix.version }} | ||
| version: ${{ matrix.version }} | ||
| - name: Install Google Chrome | ||
| run: | | ||
| sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google-chrome.list' | ||
|
|
@@ -127,7 +127,7 @@ jobs: | |
| # Important: This is outside the minimum supported version of dd-trace-js | ||
| # Node > 16 does not work with [email protected] (not even without our plugin) | ||
| # TODO: figure out what to do with this: we might have to deprecate support for [email protected] | ||
| version: [16, latest] | ||
| version: [eol, latest] | ||
| # 6.7.0 is the minimum version we support | ||
| cypress-version: [6.7.0, latest] | ||
| module-type: ['commonJS', 'esm'] | ||
|
|
@@ -138,9 +138,9 @@ jobs: | |
| DD_API_KEY: ${{ secrets.DD_API_KEY_CI_APP }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| - uses: ./.github/actions/node | ||
| with: | ||
| node-version: ${{ matrix.version }} | ||
| version: ${{ matrix.version }} | ||
| - uses: ./.github/actions/install | ||
| - run: yarn config set ignore-engines true | ||
| - run: yarn test:integration:cypress --ignore-engines | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do this until that the automated process for updating these hashes are expanded to also check the
.github/actionsdirectory. I think right now it's just checking the.github/workflowsrepo. I've been meaning to raise this as an issue. Until then, this will be stuck at this hardcoded hash which is probably not what we wantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind... #5448 will fix it