Skip to content

fix(llmobs): send batches of span events #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025
Merged

fix(llmobs): send batches of span events #5493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d52cbd
batch span events
Mar 27, 2025
23dc325
Merge branch 'master' into evan.li/batch-span-events
lievan Apr 7, 2025
9455f4e
try to fix test
Apr 7, 2025
575d95d
Merge branch 'evan.li/batch-span-events' of github.com:DataDog/dd-tra…
Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/dd-trace/src/llmobs/writers/spans/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ class LLMObsSpanWriter extends BaseWriter {
}

makePayload (events) {
return {
return events.map(event => ({
'_dd.stage': 'raw',
'_dd.tracer_version': tracerVersion,
event_type: this._eventType,
spans: events
}
spans: [event]
}))
}

_truncateSpanEvent (event) {
Expand Down
2 changes: 1 addition & 1 deletion packages/dd-trace/test/llmobs/sdk/typescript/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const testCases = [
file: 'index',
setup: (agent, results = {}) => {
const llmobsRes = agent.assertLlmObsPayloadReceived(({ payload }) => {
results.llmobsSpans = payload.spans
results.llmobsSpans = payload.flatMap(item => item.spans)
})

const apmRes = agent.assertMessageReceived(({ payload }) => {
Expand Down
6 changes: 3 additions & 3 deletions packages/dd-trace/test/llmobs/writers/spans/base.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ describe('LLMObsSpanWriter', () => {

const payload = writer.makePayload(events)

expect(payload['_dd.stage']).to.equal('raw')
expect(payload.event_type).to.equal('span')
expect(payload.spans).to.deep.equal(events)
expect(payload[0]['_dd.stage']).to.equal('raw')
expect(payload[0].event_type).to.equal('span')
expect(payload[0].spans).to.deep.equal(events)
})
})
Loading