-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade(tracer): Support libdatadog's library_config module #5126
base: master
Are you sure you want to change the base?
Conversation
Overall package sizeSelf size: 8.49 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2025-01-17 15:45:04 Comparing candidate commit 83d4172 in PR branch Found 278 performance improvements and 7 performance regressions! Performance is the same for 535 metrics, 23 unstable metrics. scenario:appsec-appsec-enabled-18
scenario:appsec-appsec-enabled-20
scenario:appsec-appsec-enabled-22
scenario:appsec-appsec-enabled-with-attacks-18
scenario:appsec-appsec-enabled-with-attacks-20
scenario:appsec-appsec-enabled-with-attacks-22
scenario:appsec-control-18
scenario:appsec-control-20
scenario:appsec-control-22
scenario:appsec-control-with-attacks-18
scenario:appsec-control-with-attacks-20
scenario:appsec-control-with-attacks-22
scenario:appsec-iast-no-vulnerability-control-18
scenario:appsec-iast-no-vulnerability-control-20
scenario:appsec-iast-no-vulnerability-control-22
scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18
scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20
scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-22
scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18
scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20
scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-22
scenario:appsec-iast-startup-time-control-20
scenario:appsec-iast-startup-time-iast-enabled-18
scenario:appsec-iast-startup-time-iast-enabled-20
scenario:appsec-iast-startup-time-iast-enabled-22
scenario:appsec-iast-with-vulnerability-control-18
scenario:appsec-iast-with-vulnerability-control-20
scenario:appsec-iast-with-vulnerability-control-22
scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18
scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-20
scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-22
scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18
scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20
scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-22
scenario:appsec-startup-time-appsec-enabled-18
scenario:appsec-startup-time-appsec-enabled-20
scenario:appsec-startup-time-appsec-enabled-22
scenario:appsec-startup-time-control-20
scenario:log-skip-log-18
scenario:log-skip-log-22
scenario:log-with-debug-18
scenario:log-with-debug-22
scenario:log-with-error-18
scenario:log-with-error-22
scenario:log-without-log-18
scenario:log-without-log-22
scenario:net-with-tracer-18
scenario:net-with-tracer-20
scenario:net-with-tracer-22
scenario:plugin-bluebird-with-tracer-18
scenario:plugin-bluebird-with-tracer-22
scenario:plugin-dns-with-tracer-18
scenario:plugin-dns-with-tracer-20
scenario:plugin-dns-with-tracer-22
scenario:plugin-graphql-with-async-hooks-22
scenario:plugin-graphql-with-depth-and-collapse-off-18
scenario:plugin-graphql-with-depth-and-collapse-off-20
scenario:plugin-graphql-with-depth-and-collapse-off-22
scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-and-collapse-on-20
scenario:plugin-graphql-with-depth-and-collapse-on-22
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-off-20
scenario:plugin-graphql-with-depth-off-22
scenario:plugin-graphql-with-depth-on-max-18
scenario:plugin-graphql-with-depth-on-max-20
scenario:plugin-graphql-with-depth-on-max-22
scenario:plugin-http-client-with-tracer-18
scenario:plugin-http-client-with-tracer-20
scenario:plugin-http-client-with-tracer-22
scenario:plugin-http-server-querystring-obfuscation-18
scenario:plugin-http-server-querystring-obfuscation-20
scenario:plugin-http-server-querystring-obfuscation-22
scenario:plugin-http-server-with-tracer-18
scenario:plugin-http-server-with-tracer-20
scenario:plugin-http-server-with-tracer-22
scenario:plugin-q-with-tracer-18
scenario:plugin-q-with-tracer-20
scenario:plugin-q-with-tracer-22
scenario:startup-with-tracer-18
scenario:startup-with-tracer-20
scenario:startup-with-tracer-22
|
852b817
to
83d4172
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5126 +/- ##
===========================================
+ Coverage 63.10% 98.13% +35.02%
===========================================
Files 108 1 -107
Lines 3456 107 -3349
===========================================
- Hits 2181 105 -2076
+ Misses 1275 2 -1273 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Supports libdatadog's
library_config
module to configure the tracing libraries from a file on disk that may remotely managed.Motivation
Being able to configure tracing libraries from a file / the UI
Additional Notes
This PR requires a release of
libdatadog-nodejs
& a bump in package.json