Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.54.0 proposal #5048

Merged
merged 6 commits into from
Dec 19, 2024
Merged

v4.54.0 proposal #5048

merged 6 commits into from
Dec 19, 2024

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Dec 19, 2024

  • [4f87373f4b] - (SEMVER-PATCH) fix invalid output for log.trace (Roch Devost) #5047
  • [4e2e71663a] - (SEMVER-MINOR) Add filesystem events to the timeline (Attila Szegedi) #4965
  • [e36f26b039] - (SEMVER-MINOR) Exploit prevention command injection (ishabi) #4966
  • [8ee2d0aef0] - (SEMVER-PATCH) add logging for priority sampler (Ida Liu) #5028
  • [a9a1b1d04a] - (SEMVER-PATCH) [DI] Add test for associating probes with 128 bit span ids (Thomas Watson) #5037

watson and others added 6 commits December 19, 2024 17:24
Includes a major refactor of basic.spec.js to allow for easier testing
of different combinations of envrionment variables.
* add logging

* update logging

* update log traceChannel

* update logging

* make log.trace take callbacks

* fix linter errors

* update log.trace

* Update packages/dd-trace/src/log/index.js

Co-authored-by: Roch Devost <[email protected]>

* update log writter and add tests

* fix linter error

---------

Co-authored-by: Roch Devost <[email protected]>
* Exploit prevention command injection

* fix spawnSync abort error test

* add telemetry tests

* fix sql injection tests on postgres

* add different test

* revert spawnSync changes

* fix linter

* add spawnSync tests

* remove spawnSync not needed test

* fix cmdi params

* Revert "fix cmdi params"

This reverts commit 4a3d766.
* fix invalid output for log.trace

* move string formatting to logger and improve output

* change depth
Copy link

Overall package size

Self size: 8.4 MB
Deduped: 96.71 MB
No deduping: 97.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-19 22:32:14

Comparing candidate commit 3242aa9 in PR branch v4.54.0-proposal with baseline commit 2fa7f97 in branch v4.x.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 1038 metrics, 22 unstable metrics.

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-22

  • 🟥 max_rss_usage [+9.090MB; +11.838MB] or [+7.363%; +9.589%]

scenario:plugin-graphql-with-async-hooks-22

  • 🟥 max_rss_usage [+103.548MB; +120.380MB] or [+19.199%; +22.319%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+62.687MB; +121.813MB] or [+7.235%; +14.058%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+71.915MB; +83.465MB] or [+8.313%; +9.648%]

@rochdev rochdev marked this pull request as ready for review December 19, 2024 22:32
@rochdev rochdev requested a review from a team as a code owner December 19, 2024 22:32
@rochdev rochdev merged commit ab921ed into v4.x Dec 19, 2024
306 checks passed
@rochdev rochdev deleted the v4.54.0-proposal branch December 19, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants