-
Notifications
You must be signed in to change notification settings - Fork 318
Add springboot smoke tests for the open feature SDK #9961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fdda03b to
d926f7a
Compare
6fcda55 to
188fdc6
Compare
188fdc6 to
de1816f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1103955
Total [baseline] (10.822 s) : 0, 10821676
Agent [candidate] (1.11 s) : 0, 1109829
Total [candidate] (10.918 s) : 0, 10918499
section appsec
Agent [baseline] (1.291 s) : 0, 1291214
Total [baseline] (11.195 s) : 0, 11194553
Agent [candidate] (1.291 s) : 0, 1290722
Total [candidate] (11.088 s) : 0, 11087619
section iast
Agent [baseline] (1.241 s) : 0, 1241192
Total [baseline] (11.232 s) : 0, 11231967
Agent [candidate] (1.249 s) : 0, 1248919
Total [candidate] (11.358 s) : 0, 11357668
section profiling
Agent [baseline] (1.235 s) : 0, 1235175
Total [baseline] (11.15 s) : 0, 11149609
Agent [candidate] (1.243 s) : 0, 1242518
Total [candidate] (11.233 s) : 0, 11232869
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (709.259 ms) : 0, 709259
BytebuddyAgent [candidate] (713.738 ms) : 0, 713738
GlobalTracer [baseline] (249.689 ms) : 0, 249689
GlobalTracer [candidate] (250.629 ms) : 0, 250629
AppSec [baseline] (31.994 ms) : 0, 31994
AppSec [candidate] (32.202 ms) : 0, 32202
Debugger [baseline] (63.982 ms) : 0, 63982
Debugger [candidate] (64.256 ms) : 0, 64256
Remote Config [baseline] (636.773 µs) : 0, 637
Remote Config [candidate] (624.372 µs) : 0, 624
Telemetry [baseline] (8.322 ms) : 0, 8322
Telemetry [candidate] (8.312 ms) : 0, 8312
Flare Poller [baseline] (3.781 ms) : 0, 3781
Flare Poller [candidate] (3.724 ms) : 0, 3724
section appsec
crashtracking [baseline] (1.511 ms) : 0, 1511
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (737.501 ms) : 0, 737501
BytebuddyAgent [candidate] (737.03 ms) : 0, 737030
GlobalTracer [baseline] (242.421 ms) : 0, 242421
GlobalTracer [candidate] (242.154 ms) : 0, 242154
AppSec [baseline] (174.841 ms) : 0, 174841
AppSec [candidate] (175.13 ms) : 0, 175130
Debugger [baseline] (62.185 ms) : 0, 62185
Debugger [candidate] (61.993 ms) : 0, 61993
Remote Config [baseline] (666.782 µs) : 0, 667
Remote Config [candidate] (664.756 µs) : 0, 665
Telemetry [baseline] (8.197 ms) : 0, 8197
Telemetry [candidate] (8.256 ms) : 0, 8256
Flare Poller [baseline] (3.842 ms) : 0, 3842
Flare Poller [candidate] (4.02 ms) : 0, 4020
IAST [baseline] (24.888 ms) : 0, 24888
IAST [candidate] (24.89 ms) : 0, 24890
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.522 ms) : 0, 1522
BytebuddyAgent [baseline] (832.82 ms) : 0, 832820
BytebuddyAgent [candidate] (838.645 ms) : 0, 838645
GlobalTracer [baseline] (238.191 ms) : 0, 238191
GlobalTracer [candidate] (238.92 ms) : 0, 238920
AppSec [baseline] (31.02 ms) : 0, 31020
AppSec [candidate] (33.294 ms) : 0, 33294
Debugger [baseline] (60.883 ms) : 0, 60883
Debugger [candidate] (61.103 ms) : 0, 61103
Remote Config [baseline] (542.896 µs) : 0, 543
Remote Config [candidate] (553.958 µs) : 0, 554
Telemetry [baseline] (7.587 ms) : 0, 7587
Telemetry [candidate] (7.637 ms) : 0, 7637
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.506 ms) : 0, 3506
IAST [baseline] (30.328 ms) : 0, 30328
IAST [candidate] (28.689 ms) : 0, 28689
section profiling
ProfilingAgent [baseline] (96.71 ms) : 0, 96710
ProfilingAgent [candidate] (96.931 ms) : 0, 96931
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (737.986 ms) : 0, 737986
BytebuddyAgent [candidate] (742.609 ms) : 0, 742609
GlobalTracer [baseline] (222.524 ms) : 0, 222524
GlobalTracer [candidate] (224.043 ms) : 0, 224043
AppSec [baseline] (32.049 ms) : 0, 32049
AppSec [candidate] (32.406 ms) : 0, 32406
Debugger [baseline] (62.683 ms) : 0, 62683
Debugger [candidate] (63.113 ms) : 0, 63113
Remote Config [baseline] (663.768 µs) : 0, 664
Remote Config [candidate] (646.059 µs) : 0, 646
Telemetry [baseline] (7.959 ms) : 0, 7959
Telemetry [candidate] (8.076 ms) : 0, 8076
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.778 ms) : 0, 3778
Profiling [baseline] (97.302 ms) : 0, 97302
Profiling [candidate] (97.505 ms) : 0, 97505
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.108 s) : 0, 1108072
Total [baseline] (8.847 s) : 0, 8846620
Agent [candidate] (1.1 s) : 0, 1100013
Total [candidate] (8.848 s) : 0, 8847926
section iast
Agent [baseline] (1.241 s) : 0, 1241497
Total [baseline] (9.56 s) : 0, 9559899
Agent [candidate] (1.238 s) : 0, 1237875
Total [candidate] (9.567 s) : 0, 9566661
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.504 ms) : 0, 1504
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (712.967 ms) : 0, 712967
BytebuddyAgent [candidate] (707.767 ms) : 0, 707767
GlobalTracer [baseline] (250.534 ms) : 0, 250534
GlobalTracer [candidate] (248.532 ms) : 0, 248532
AppSec [baseline] (32.365 ms) : 0, 32365
AppSec [candidate] (31.918 ms) : 0, 31918
Debugger [baseline] (63.094 ms) : 0, 63094
Debugger [candidate] (63.159 ms) : 0, 63159
Remote Config [baseline] (634.562 µs) : 0, 635
Remote Config [candidate] (628.991 µs) : 0, 629
Telemetry [baseline] (8.308 ms) : 0, 8308
Telemetry [candidate] (8.149 ms) : 0, 8149
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (3.622 ms) : 0, 3622
section iast
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (834.591 ms) : 0, 834591
BytebuddyAgent [candidate] (830.91 ms) : 0, 830910
GlobalTracer [baseline] (237.92 ms) : 0, 237920
GlobalTracer [candidate] (237.589 ms) : 0, 237589
IAST [baseline] (30.099 ms) : 0, 30099
IAST [candidate] (26.499 ms) : 0, 26499
AppSec [baseline] (31.018 ms) : 0, 31018
AppSec [candidate] (34.718 ms) : 0, 34718
Debugger [baseline] (59.901 ms) : 0, 59901
Debugger [candidate] (60.22 ms) : 0, 60220
Remote Config [baseline] (551.291 µs) : 0, 551
Remote Config [candidate] (547.933 µs) : 0, 548
Telemetry [baseline] (7.568 ms) : 0, 7568
Telemetry [candidate] (7.595 ms) : 0, 7595
Flare Poller [baseline] (3.453 ms) : 0, 3453
Flare Poller [candidate] (3.503 ms) : 0, 3503
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.213 ms) : 1200, 1225
. : milestone, 1213,
iast (3.304 ms) : 3256, 3352
. : milestone, 3304,
iast_FULL (5.854 ms) : 5775, 5934
. : milestone, 5854,
iast_GLOBAL (3.734 ms) : 3682, 3787
. : milestone, 3734,
profiling (2.041 ms) : 2024, 2059
. : milestone, 2041,
tracing (1.832 ms) : 1816, 1848
. : milestone, 1832,
section candidate
no_agent (1.188 ms) : 1177, 1199
. : milestone, 1188,
iast (3.3 ms) : 3250, 3349
. : milestone, 3300,
iast_FULL (6.179 ms) : 6114, 6244
. : milestone, 6179,
iast_GLOBAL (3.82 ms) : 3769, 3870
. : milestone, 3820,
profiling (2.12 ms) : 2100, 2140
. : milestone, 2120,
tracing (1.865 ms) : 1850, 1881
. : milestone, 1865,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section baseline
no_agent (17.703 ms) : 17526, 17879
. : milestone, 17703,
appsec (18.189 ms) : 18004, 18375
. : milestone, 18189,
code_origins (17.572 ms) : 17396, 17748
. : milestone, 17572,
iast (17.573 ms) : 17398, 17748
. : milestone, 17573,
profiling (18.779 ms) : 18586, 18973
. : milestone, 18779,
tracing (17.866 ms) : 17691, 18041
. : milestone, 17866,
section candidate
no_agent (17.867 ms) : 17689, 18045
. : milestone, 17867,
appsec (18.397 ms) : 18211, 18582
. : milestone, 18397,
code_origins (17.729 ms) : 17552, 17906
. : milestone, 17729,
iast (17.784 ms) : 17607, 17960
. : milestone, 17784,
profiling (18.625 ms) : 18437, 18813
. : milestone, 18625,
tracing (17.499 ms) : 17325, 17673
. : milestone, 17499,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.481 ms) : 2429, 2533
. : milestone, 2481,
iast (2.227 ms) : 2162, 2292
. : milestone, 2227,
iast_GLOBAL (2.279 ms) : 2213, 2345
. : milestone, 2279,
profiling (2.114 ms) : 2059, 2169
. : milestone, 2114,
tracing (2.059 ms) : 2008, 2111
. : milestone, 2059,
section candidate
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (2.486 ms) : 2433, 2538
. : milestone, 2486,
iast (2.235 ms) : 2169, 2300
. : milestone, 2235,
iast_GLOBAL (2.272 ms) : 2206, 2338
. : milestone, 2272,
profiling (2.087 ms) : 2033, 2142
. : milestone, 2087,
tracing (2.057 ms) : 2006, 2109
. : milestone, 2057,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~fd7396615b, baseline=1.57.0-SNAPSHOT~614cc721f6
dateFormat X
axisFormat %s
section baseline
no_agent (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
appsec (14.735 s) : 14735000, 14735000
. : milestone, 14735000,
iast (18.784 s) : 18784000, 18784000
. : milestone, 18784000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (14.826 s) : 14826000, 14826000
. : milestone, 14826000,
tracing (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
section candidate
no_agent (15.511 s) : 15511000, 15511000
. : milestone, 15511000,
appsec (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
iast (18.006 s) : 18006000, 18006000
. : milestone, 18006000,
iast_GLOBAL (18.108 s) : 18108000, 18108000
. : milestone, 18108000,
profiling (14.719 s) : 14719000, 14719000
. : milestone, 14719000,
tracing (14.682 s) : 14682000, 14682000
. : milestone, 14682000,
|
d926f7a to
6d05d9a
Compare
6fea068 to
c73df5f
Compare
This comment has been minimized.
This comment has been minimized.
ddb9b65 to
cf1db21
Compare
8e8f321 to
6b99c46
Compare
effa6c3 to
0f57d15
Compare
6b99c46 to
6f66fc2
Compare
7550227 to
b65cb5e
Compare
359af31 to
61689a5
Compare
6fd2957 to
31a1f96
Compare
61689a5 to
52aa2a3
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: Thanks for adding smoke tests
The app looks to crash at startup though 🤔
52aa2a3 to
40b9326
Compare
40b9326 to
fd73966
Compare
Thanks for the review. Yes, I forgot to remove the debugging configuration which I use locally to troubleshoot issues, should be fine by now 😄 |
What Does This Do
Adds smoke tests for the OpenFeature Java provider (PR)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]