Skip to content

Apply critical patch for ddprof dependency. #9920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply critical patch for ddprof dependency. #9920

wants to merge 1 commit into from

Conversation

@jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Nov 7, 2025 •
edited by atlassian bot
Loading

What Does This Do

Bump to version 1.34.1

Motivation

In version 1.34.0 of ddprof-java we have a critical concurrency bug which can lead to crashes under heavy load.
We need to apply the fix ASAP and then backport it to dd-trace-java patch release.

Additional Notes

Contributor Checklist

Jira ticket: PROF-12970

@jbachorik jbachorik added type: bug Bug report and fix comp: profiling Profiling labels Nov 7, 2025
@jbachorik jbachorik requested a review from zhengyu123 November 7, 2025 17:41
@jbachorik jbachorik marked this pull request as ready for review November 7, 2025 17:41
@jbachorik jbachorik requested a review from a team as a code owner November 7, 2025 17:41
@jbachorik jbachorik requested a review from mhlidd November 7, 2025 17:41
@jbachorik jbachorik marked this pull request as draft November 7, 2025 17:46
@jbachorik jbachorik marked this pull request as ready for review November 7, 2025 17:48
@jbachorik jbachorik enabled auto-merge (squash) November 7, 2025 17:52
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 7, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 62.18% (+2.55%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 89cfe4e | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/ddprof_1.34.1
git_commit_date 1762533227 1762537040
git_commit_sha 54da873 89cfe4e
release_version 1.56.0-SNAPSHOT~54da873ecc 1.56.0-SNAPSHOT~89cfe4e32e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762539634 1762539634
ci_job_id 1222955751 1222955751
ci_pipeline_id 81626962 81626962
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-3-wd6s9pf7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-3-wd6s9pf7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049225
Total [baseline] (10.847 s) : 0, 10847222
Agent [candidate] (1.047 s) : 0, 1047074
Total [candidate] (10.736 s) : 0, 10735725
section appsec
Agent [baseline] (1.219 s) : 0, 1218621
Total [baseline] (10.808 s) : 0, 10807648
Agent [candidate] (1.219 s) : 0, 1219272
Total [candidate] (10.865 s) : 0, 10865048
section iast
Agent [baseline] (1.187 s) : 0, 1186997
Total [baseline] (11.181 s) : 0, 11180820
Agent [candidate] (1.181 s) : 0, 1181038
Total [candidate] (11.205 s) : 0, 11205258
section profiling
Agent [baseline] (1.21 s) : 0, 1210428
Total [baseline] (10.959 s) : 0, 10959494
Agent [candidate] (1.192 s) : 0, 1192035
Total [candidate] (10.881 s) : 0, 10880846
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.219 s 169.396 ms (16.1%)
Agent iast 1.187 s 137.773 ms (13.1%)
Agent profiling 1.21 s 161.204 ms (15.4%)
Total tracing 10.847 s -
Total appsec 10.808 s -39.574 ms (-0.4%)
Total iast 11.181 s 333.598 ms (3.1%)
Total profiling 10.959 s 112.272 ms (1.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.219 s 172.198 ms (16.4%)
Agent iast 1.181 s 133.963 ms (12.8%)
Agent profiling 1.192 s 144.961 ms (13.8%)
Total tracing 10.736 s -
Total appsec 10.865 s 129.323 ms (1.2%)
Total iast 11.205 s 469.533 ms (4.4%)
Total profiling 10.881 s 145.121 ms (1.4%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (706.985 ms) : 0, 706985
BytebuddyAgent [candidate] (705.024 ms) : 0, 705024
GlobalTracer [baseline] (246.237 ms) : 0, 246237
GlobalTracer [candidate] (245.813 ms) : 0, 245813
AppSec [baseline] (32.487 ms) : 0, 32487
AppSec [candidate] (32.303 ms) : 0, 32303
Debugger [baseline] (6.419 ms) : 0, 6419
Debugger [candidate] (6.409 ms) : 0, 6409
Remote Config [baseline] (712.776 µs) : 0, 713
Remote Config [candidate] (704.731 µs) : 0, 705
Telemetry [baseline] (11.467 ms) : 0, 11467
Telemetry [candidate] (13.579 ms) : 0, 13579
Flare Poller [baseline] (8.696 ms) : 0, 8696
Flare Poller [candidate] (7.173 ms) : 0, 7173
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (727.61 ms) : 0, 727610
BytebuddyAgent [candidate] (728.083 ms) : 0, 728083
GlobalTracer [baseline] (236.294 ms) : 0, 236294
GlobalTracer [candidate] (237.345 ms) : 0, 237345
AppSec [baseline] (174.485 ms) : 0, 174485
AppSec [candidate] (173.853 ms) : 0, 173853
Debugger [baseline] (6.019 ms) : 0, 6019
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (662.14 µs) : 0, 662
Remote Config [candidate] (640.538 µs) : 0, 641
Telemetry [baseline] (8.581 ms) : 0, 8581
Telemetry [candidate] (8.409 ms) : 0, 8409
Flare Poller [baseline] (3.943 ms) : 0, 3943
Flare Poller [candidate] (4.016 ms) : 0, 4016
IAST [baseline] (24.798 ms) : 0, 24798
IAST [candidate] (24.786 ms) : 0, 24786
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (834.789 ms) : 0, 834789
BytebuddyAgent [candidate] (829.63 ms) : 0, 829630
GlobalTracer [baseline] (235.707 ms) : 0, 235707
GlobalTracer [candidate] (235.022 ms) : 0, 235022
AppSec [baseline] (28.657 ms) : 0, 28657
AppSec [candidate] (26.958 ms) : 0, 26958
Debugger [baseline] (5.942 ms) : 0, 5942
Debugger [candidate] (5.962 ms) : 0, 5962
Remote Config [baseline] (593.495 µs) : 0, 593
Remote Config [candidate] (588.742 µs) : 0, 589
Telemetry [baseline] (8.343 ms) : 0, 8343
Telemetry [candidate] (8.307 ms) : 0, 8307
Flare Poller [baseline] (4.117 ms) : 0, 4117
Flare Poller [candidate] (4.094 ms) : 0, 4094
IAST [baseline] (32.516 ms) : 0, 32516
IAST [candidate] (34.201 ms) : 0, 34201
section profiling
ProfilingAgent [baseline] (112.564 ms) : 0, 112564
ProfilingAgent [candidate] (110.119 ms) : 0, 110119
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (740.516 ms) : 0, 740516
BytebuddyAgent [candidate] (729.17 ms) : 0, 729170
GlobalTracer [baseline] (224.307 ms) : 0, 224307
GlobalTracer [candidate] (221.732 ms) : 0, 221732
AppSec [baseline] (32.736 ms) : 0, 32736
AppSec [candidate] (32.04 ms) : 0, 32040
Debugger [baseline] (8.502 ms) : 0, 8502
Debugger [candidate] (9.925 ms) : 0, 9925
Remote Config [baseline] (1.462 ms) : 0, 1462
Remote Config [candidate] (674.712 µs) : 0, 675
Telemetry [baseline] (14.081 ms) : 0, 14081
Telemetry [candidate] (13.046 ms) : 0, 13046
Flare Poller [baseline] (4.192 ms) : 0, 4192
Flare Poller [candidate] (4.139 ms) : 0, 4139
Profiling [baseline] (113.241 ms) : 0, 113241
Profiling [candidate] (110.776 ms) : 0, 110776
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050903
Total [baseline] (8.687 s) : 0, 8687276
Agent [candidate] (1.057 s) : 0, 1057171
Total [candidate] (8.623 s) : 0, 8623005
section iast
Agent [baseline] (1.179 s) : 0, 1179479
Total [baseline] (9.25 s) : 0, 9250202
Agent [candidate] (1.187 s) : 0, 1187473
Total [candidate] (9.272 s) : 0, 9271950
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.179 s 128.576 ms (12.2%)
Total tracing 8.687 s -
Total iast 9.25 s 562.926 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.187 s 130.302 ms (12.3%)
Total tracing 8.623 s -
Total iast 9.272 s 648.944 ms (7.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (707.685 ms) : 0, 707685
BytebuddyAgent [candidate] (711.568 ms) : 0, 711568
GlobalTracer [baseline] (246.389 ms) : 0, 246389
GlobalTracer [candidate] (248.183 ms) : 0, 248183
AppSec [baseline] (32.653 ms) : 0, 32653
AppSec [candidate] (32.798 ms) : 0, 32798
Debugger [baseline] (6.413 ms) : 0, 6413
Debugger [candidate] (6.522 ms) : 0, 6522
Remote Config [baseline] (712.331 µs) : 0, 712
Remote Config [candidate] (713.048 µs) : 0, 713
Telemetry [baseline] (13.593 ms) : 0, 13593
Telemetry [candidate] (14.466 ms) : 0, 14466
Flare Poller [baseline] (7.327 ms) : 0, 7327
Flare Poller [candidate] (6.606 ms) : 0, 6606
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (828.293 ms) : 0, 828293
BytebuddyAgent [candidate] (835.873 ms) : 0, 835873
GlobalTracer [baseline] (234.772 ms) : 0, 234772
GlobalTracer [candidate] (235.239 ms) : 0, 235239
IAST [baseline] (32.207 ms) : 0, 32207
IAST [candidate] (33.193 ms) : 0, 33193
AppSec [baseline] (28.823 ms) : 0, 28823
AppSec [candidate] (27.811 ms) : 0, 27811
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (6.042 ms) : 0, 6042
Remote Config [baseline] (593.37 µs) : 0, 593
Remote Config [candidate] (596.019 µs) : 0, 596
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (8.321 ms) : 0, 8321
Flare Poller [baseline] (4.116 ms) : 0, 4116
Flare Poller [candidate] (4.13 ms) : 0, 4130
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/ddprof_1.34.1
git_commit_date 1762533227 1762537040
git_commit_sha 54da873 89cfe4e
release_version 1.56.0-SNAPSHOT~54da873ecc 1.56.0-SNAPSHOT~89cfe4e32e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762540132 1762540132
ci_job_id 1222955754 1222955754
ci_pipeline_id 81626962 81626962
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-koaetnrf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-koaetnrf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast:high_load better
[-244.989µs; -157.993µs] or [-7.353%; -4.742%]		 unstable
[-69.657op/s; +242.719op/s] or [-5.070%; +17.668%]		 3.130ms 1460.344op/s 3.332ms 1373.812op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.539 ms) : 18345, 18733
.   : milestone, 18539,
appsec (18.791 ms) : 18603, 18980
.   : milestone, 18791,
code_origins (17.891 ms) : 17716, 18066
.   : milestone, 17891,
iast (17.887 ms) : 17707, 18066
.   : milestone, 17887,
profiling (18.445 ms) : 18259, 18632
.   : milestone, 18445,
tracing (17.565 ms) : 17389, 17741
.   : milestone, 17565,
section candidate
no_agent (18.07 ms) : 17883, 18258
.   : milestone, 18070,
appsec (18.784 ms) : 18590, 18978
.   : milestone, 18784,
code_origins (17.714 ms) : 17537, 17891
.   : milestone, 17714,
iast (17.807 ms) : 17631, 17984
.   : milestone, 17807,
profiling (18.449 ms) : 18259, 18638
.   : milestone, 18449,
tracing (17.549 ms) : 17377, 17721
.   : milestone, 17549,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.539 ms [18.345 ms, 18.733 ms] -
appsec 18.791 ms [18.603 ms, 18.98 ms] 252.646 µs (1.4%)
code_origins 17.891 ms [17.716 ms, 18.066 ms] -648.061 µs (-3.5%)
iast 17.887 ms [17.707 ms, 18.066 ms] -651.952 µs (-3.5%)
profiling 18.445 ms [18.259 ms, 18.632 ms] -93.636 µs (-0.5%)
tracing 17.565 ms [17.389 ms, 17.741 ms] -973.645 µs (-5.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.07 ms [17.883 ms, 18.258 ms] -
appsec 18.784 ms [18.59 ms, 18.978 ms] 713.383 µs (3.9%)
code_origins 17.714 ms [17.537 ms, 17.891 ms] -356.183 µs (-2.0%)
iast 17.807 ms [17.631 ms, 17.984 ms] -263.353 µs (-1.5%)
profiling 18.449 ms [18.259 ms, 18.638 ms] 378.192 µs (2.1%)
tracing 17.549 ms [17.377 ms, 17.721 ms] -521.647 µs (-2.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.211 ms) : 1199, 1223
.   : milestone, 1211,
iast (3.332 ms) : 3288, 3376
.   : milestone, 3332,
iast_FULL (5.893 ms) : 5835, 5952
.   : milestone, 5893,
iast_GLOBAL (3.663 ms) : 3603, 3724
.   : milestone, 3663,
profiling (1.965 ms) : 1947, 1982
.   : milestone, 1965,
tracing (1.803 ms) : 1788, 1818
.   : milestone, 1803,
section candidate
no_agent (1.193 ms) : 1182, 1205
.   : milestone, 1193,
iast (3.13 ms) : 3094, 3167
.   : milestone, 3130,
iast_FULL (5.776 ms) : 5718, 5834
.   : milestone, 5776,
iast_GLOBAL (3.615 ms) : 3561, 3668
.   : milestone, 3615,
profiling (1.964 ms) : 1947, 1980
.   : milestone, 1964,
tracing (1.808 ms) : 1793, 1824
.   : milestone, 1808,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.211 ms [1.199 ms, 1.223 ms] -
iast 3.332 ms [3.288 ms, 3.376 ms] 2.121 ms (175.2%)
iast_FULL 5.893 ms [5.835 ms, 5.952 ms] 4.683 ms (386.8%)
iast_GLOBAL 3.663 ms [3.603 ms, 3.724 ms] 2.453 ms (202.6%)
profiling 1.965 ms [1.947 ms, 1.982 ms] 753.799 µs (62.3%)
tracing 1.803 ms [1.788 ms, 1.818 ms] 592.125 µs (48.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.193 ms [1.182 ms, 1.205 ms] -
iast 3.13 ms [3.094 ms, 3.167 ms] 1.937 ms (162.3%)
iast_FULL 5.776 ms [5.718 ms, 5.834 ms] 4.582 ms (384.0%)
iast_GLOBAL 3.615 ms [3.561 ms, 3.668 ms] 2.421 ms (202.9%)
profiling 1.964 ms [1.947 ms, 1.98 ms] 770.134 µs (64.5%)
tracing 1.808 ms [1.793 ms, 1.824 ms] 615.031 µs (51.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/ddprof_1.34.1
git_commit_date 1762533227 1762537040
git_commit_sha 54da873 89cfe4e
release_version 1.56.0-SNAPSHOT~54da873ecc 1.56.0-SNAPSHOT~89cfe4e32e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1762539775 1762539775
ci_job_id 1222955756 1222955756
ci_pipeline_id 81626962 81626962
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-3-fkq1aodd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-3-fkq1aodd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.522 s) : 15522000, 15522000
.   : milestone, 15522000,
appsec (14.833 s) : 14833000, 14833000
.   : milestone, 14833000,
iast (18.62 s) : 18620000, 18620000
.   : milestone, 18620000,
iast_GLOBAL (17.765 s) : 17765000, 17765000
.   : milestone, 17765000,
profiling (15.087 s) : 15087000, 15087000
.   : milestone, 15087000,
tracing (14.637 s) : 14637000, 14637000
.   : milestone, 14637000,
section candidate
no_agent (15.545 s) : 15545000, 15545000
.   : milestone, 15545000,
appsec (14.745 s) : 14745000, 14745000
.   : milestone, 14745000,
iast (18.569 s) : 18569000, 18569000
.   : milestone, 18569000,
iast_GLOBAL (18.181 s) : 18181000, 18181000
.   : milestone, 18181000,
profiling (15.416 s) : 15416000, 15416000
.   : milestone, 15416000,
tracing (14.911 s) : 14911000, 14911000
.   : milestone, 14911000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.522 s [15.522 s, 15.522 s] -
appsec 14.833 s [14.833 s, 14.833 s] -689.0 ms (-4.4%)
iast 18.62 s [18.62 s, 18.62 s] 3.098 s (20.0%)
iast_GLOBAL 17.765 s [17.765 s, 17.765 s] 2.243 s (14.5%)
profiling 15.087 s [15.087 s, 15.087 s] -435.0 ms (-2.8%)
tracing 14.637 s [14.637 s, 14.637 s] -885.0 ms (-5.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.545 s [15.545 s, 15.545 s] -
appsec 14.745 s [14.745 s, 14.745 s] -800.0 ms (-5.1%)
iast 18.569 s [18.569 s, 18.569 s] 3.024 s (19.5%)
iast_GLOBAL 18.181 s [18.181 s, 18.181 s] 2.636 s (17.0%)
profiling 15.416 s [15.416 s, 15.416 s] -129.0 ms (-0.8%)
tracing 14.911 s [14.911 s, 14.911 s] -634.0 ms (-4.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~89cfe4e32e, baseline=1.56.0-SNAPSHOT~54da873ecc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (3.635 ms) : 3419, 3852
.   : milestone, 3635,
iast (2.21 ms) : 2147, 2274
.   : milestone, 2210,
iast_GLOBAL (2.253 ms) : 2189, 2318
.   : milestone, 2253,
profiling (2.483 ms) : 2316, 2650
.   : milestone, 2483,
tracing (2.042 ms) : 1992, 2092
.   : milestone, 2042,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (3.702 ms) : 3482, 3921
.   : milestone, 3702,
iast (2.204 ms) : 2140, 2267
.   : milestone, 2204,
iast_GLOBAL (2.25 ms) : 2185, 2314
.   : milestone, 2250,
profiling (2.068 ms) : 2015, 2120
.   : milestone, 2068,
tracing (2.019 ms) : 1969, 2068
.   : milestone, 2019,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.466 ms, 1.489 ms] -
appsec 3.635 ms [3.419 ms, 3.852 ms] 2.158 ms (146.0%)
iast 2.21 ms [2.147 ms, 2.274 ms] 732.749 µs (49.6%)
iast_GLOBAL 2.253 ms [2.189 ms, 2.318 ms] 775.735 µs (52.5%)
profiling 2.483 ms [2.316 ms, 2.65 ms] 1.005 ms (68.0%)
tracing 2.042 ms [1.992 ms, 2.092 ms] 564.255 µs (38.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 3.702 ms [3.482 ms, 3.921 ms] 2.229 ms (151.3%)
iast 2.204 ms [2.14 ms, 2.267 ms] 730.438 µs (49.6%)
iast_GLOBAL 2.25 ms [2.185 ms, 2.314 ms] 776.451 µs (52.7%)
profiling 2.068 ms [2.015 ms, 2.12 ms] 594.357 µs (40.3%)
tracing 2.019 ms [1.969 ms, 2.068 ms] 545.417 µs (37.0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

@zhengyu123 zhengyu123 zhengyu123 approved these changes

@mhlidd mhlidd Awaiting requested review from mhlidd mhlidd is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: profiling Profiling type: bug Bug report and fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbachorik @amarziali @zhengyu123