fix JDBC's SQLCommenter not taking into account semicolons #9915

na-ji · 2025-11-07T13:32:06Z

Motivation

After adding the new always append comment feature in #9798, a customer found a bug that was present in our SQL Commenter since a long time. Basically, JDBC always split queries to send to the DB on the semicolon. If a comment is after a semicolon, JDBC will still split the queries, and return multiple ResultSet. This provoked exceptions like this one:

org.postgresql.util.PSQLException: Multiple ResultSets were returned by
the query

What Does This Do

The SQL Commenter now correctly handles queries that ends with a semicolon. Instead of injecting the comment at the end, it will inject the comment before the semicolon.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: SDBM-2100

After adding the new always append comment feature in #9798, a customer found a bug that was present in our SQL Commenter since a long time. Basically, JDBC always split queries to send to the DB on the semicolon. If a comment is after a semicolon, JDBC will still split the queries, and return multiple ResultSet. This provoked exceptions like this one: ``` org.postgresql.util.PSQLException: Multiple ResultSets were returned by the query ``` SDBM-2100

datadog-datadog-prod-us1 · 2025-11-07T13:50:59Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 73.62% (+13.96%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: b9bd6fb | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-11-07T14:23:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/SDBM-2100-fix-SQL-append
git_commit_date	1762465633	1762522125
git_commit_sha	`434b694`	`b9bd6fb`
release_version	1.56.0-SNAPSHOT~434b694acb	1.56.0-SNAPSHOT~b9bd6fb8ef

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762524193	1762524193
ci_job_id	1222150063	1222150063
ci_pipeline_id	81584134	81584134
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-6l4rpzp8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-6l4rpzp8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049417
Total [baseline] (10.81 s) : 0, 10809537
Agent [candidate] (1.056 s) : 0, 1056239
Total [candidate] (10.885 s) : 0, 10885324
section appsec
Agent [baseline] (1.232 s) : 0, 1231657
Total [baseline] (10.945 s) : 0, 10945077
Agent [candidate] (1.224 s) : 0, 1224491
Total [candidate] (10.822 s) : 0, 10822158
section iast
Agent [baseline] (1.18 s) : 0, 1179513
Total [baseline] (11.134 s) : 0, 11133716
Agent [candidate] (1.178 s) : 0, 1177801
Total [candidate] (11.146 s) : 0, 11145519
section profiling
Agent [baseline] (1.192 s) : 0, 1191766
Total [baseline] (10.886 s) : 0, 10886138
Agent [candidate] (1.203 s) : 0, 1203008
Total [candidate] (10.961 s) : 0, 10960904

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.232 s	182.24 ms (17.4%)
Agent	iast	1.18 s	130.096 ms (12.4%)
Agent	profiling	1.192 s	142.349 ms (13.6%)
Total	tracing	10.81 s	-
Total	appsec	10.945 s	135.54 ms (1.3%)
Total	iast	11.134 s	324.178 ms (3.0%)
Total	profiling	10.886 s	76.601 ms (0.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	appsec	1.224 s	168.252 ms (15.9%)
Agent	iast	1.178 s	121.563 ms (11.5%)
Agent	profiling	1.203 s	146.77 ms (13.9%)
Total	tracing	10.885 s	-
Total	appsec	10.822 s	-63.166 ms (-0.6%)
Total	iast	11.146 s	260.195 ms (2.4%)
Total	profiling	10.961 s	75.58 ms (0.7%)

gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (706.138 ms) : 0, 706138
BytebuddyAgent [candidate] (711.007 ms) : 0, 711007
GlobalTracer [baseline] (246.23 ms) : 0, 246230
GlobalTracer [candidate] (247.905 ms) : 0, 247905
AppSec [baseline] (32.461 ms) : 0, 32461
AppSec [candidate] (32.747 ms) : 0, 32747
Debugger [baseline] (6.437 ms) : 0, 6437
Debugger [candidate] (6.469 ms) : 0, 6469
Remote Config [baseline] (714.24 µs) : 0, 714
Remote Config [candidate] (721.123 µs) : 0, 721
Telemetry [baseline] (14.596 ms) : 0, 14596
Telemetry [candidate] (12.414 ms) : 0, 12414
Flare Poller [baseline] (6.628 ms) : 0, 6628
Flare Poller [candidate] (8.679 ms) : 0, 8679
section appsec
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (734.993 ms) : 0, 734993
BytebuddyAgent [candidate] (731.443 ms) : 0, 731443
GlobalTracer [baseline] (238.743 ms) : 0, 238743
GlobalTracer [candidate] (237.997 ms) : 0, 237997
AppSec [baseline] (176.6 ms) : 0, 176600
AppSec [candidate] (174.75 ms) : 0, 174750
Debugger [baseline] (6.123 ms) : 0, 6123
Debugger [candidate] (5.994 ms) : 0, 5994
Remote Config [baseline] (669.016 µs) : 0, 669
Remote Config [candidate] (652.394 µs) : 0, 652
Telemetry [baseline] (8.733 ms) : 0, 8733
Telemetry [candidate] (8.473 ms) : 0, 8473
Flare Poller [baseline] (4.108 ms) : 0, 4108
Flare Poller [candidate] (3.966 ms) : 0, 3966
IAST [baseline] (25.153 ms) : 0, 25153
IAST [candidate] (24.887 ms) : 0, 24887
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (827.769 ms) : 0, 827769
BytebuddyAgent [candidate] (826.957 ms) : 0, 826957
GlobalTracer [baseline] (234.836 ms) : 0, 234836
GlobalTracer [candidate] (234.241 ms) : 0, 234241
AppSec [baseline] (29.703 ms) : 0, 29703
AppSec [candidate] (27.704 ms) : 0, 27704
Debugger [baseline] (6.055 ms) : 0, 6055
Debugger [candidate] (5.996 ms) : 0, 5996
Remote Config [baseline] (605.179 µs) : 0, 605
Remote Config [candidate] (599.043 µs) : 0, 599
Telemetry [baseline] (8.455 ms) : 0, 8455
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (4.226 ms) : 0, 4226
Flare Poller [candidate] (4.182 ms) : 0, 4182
IAST [baseline] (31.515 ms) : 0, 31515
IAST [candidate] (33.534 ms) : 0, 33534
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (728.226 ms) : 0, 728226
BytebuddyAgent [candidate] (734.662 ms) : 0, 734662
GlobalTracer [baseline] (221.375 ms) : 0, 221375
GlobalTracer [candidate] (223.175 ms) : 0, 223175
AppSec [baseline] (32.163 ms) : 0, 32163
AppSec [candidate] (32.371 ms) : 0, 32371
Debugger [baseline] (6.726 ms) : 0, 6726
Debugger [candidate] (7.523 ms) : 0, 7523
Remote Config [baseline] (682.301 µs) : 0, 682
Remote Config [candidate] (1.427 ms) : 0, 1427
Telemetry [baseline] (16.32 ms) : 0, 16320
Telemetry [candidate] (14.734 ms) : 0, 14734
Flare Poller [baseline] (4.127 ms) : 0, 4127
Flare Poller [candidate] (4.206 ms) : 0, 4206
ProfilingAgent [baseline] (111.038 ms) : 0, 111038
ProfilingAgent [candidate] (113.109 ms) : 0, 113109
Profiling [baseline] (111.689 ms) : 0, 111689
Profiling [candidate] (113.78 ms) : 0, 113780

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055480
Total [baseline] (8.692 s) : 0, 8691998
Agent [candidate] (1.048 s) : 0, 1047740
Total [candidate] (8.635 s) : 0, 8635434
section iast
Agent [baseline] (1.178 s) : 0, 1178397
Total [baseline] (9.326 s) : 0, 9325667
Agent [candidate] (1.179 s) : 0, 1179076
Total [candidate] (9.269 s) : 0, 9269004

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	iast	1.178 s	122.917 ms (11.6%)
Total	tracing	8.692 s	-
Total	iast	9.326 s	633.67 ms (7.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.179 s	131.336 ms (12.5%)
Total	tracing	8.635 s	-
Total	iast	9.269 s	633.57 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (710.507 ms) : 0, 710507
BytebuddyAgent [candidate] (704.641 ms) : 0, 704641
GlobalTracer [baseline] (247.186 ms) : 0, 247186
GlobalTracer [candidate] (245.981 ms) : 0, 245981
AppSec [baseline] (32.842 ms) : 0, 32842
AppSec [candidate] (32.585 ms) : 0, 32585
Debugger [baseline] (6.532 ms) : 0, 6532
Debugger [candidate] (6.414 ms) : 0, 6414
Remote Config [baseline] (715.068 µs) : 0, 715
Remote Config [candidate] (707.129 µs) : 0, 707
Telemetry [baseline] (12.462 ms) : 0, 12462
Telemetry [candidate] (14.093 ms) : 0, 14093
Flare Poller [baseline] (8.907 ms) : 0, 8907
Flare Poller [candidate] (7.273 ms) : 0, 7273
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (827.445 ms) : 0, 827445
BytebuddyAgent [candidate] (827.964 ms) : 0, 827964
GlobalTracer [baseline] (234.243 ms) : 0, 234243
GlobalTracer [candidate] (234.662 ms) : 0, 234662
AppSec [baseline] (26.845 ms) : 0, 26845
AppSec [candidate] (28.54 ms) : 0, 28540
Debugger [baseline] (5.988 ms) : 0, 5988
Debugger [candidate] (5.975 ms) : 0, 5975
Remote Config [baseline] (598.982 µs) : 0, 599
Remote Config [candidate] (601.226 µs) : 0, 601
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (8.408 ms) : 0, 8408
Flare Poller [baseline] (4.138 ms) : 0, 4138
Flare Poller [candidate] (4.1 ms) : 0, 4100
IAST [baseline] (34.684 ms) : 0, 34684
IAST [candidate] (32.636 ms) : 0, 32636

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/SDBM-2100-fix-SQL-append
git_commit_date	1762465633	1762522125
git_commit_sha	`434b694`	`b9bd6fb`
release_version	1.56.0-SNAPSHOT~434b694acb	1.56.0-SNAPSHOT~b9bd6fb8ef

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762524807	1762524807
ci_job_id	1222150066	1222150066
ci_pipeline_id	81584134	81584134
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-s91jpf6n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-s91jpf6n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+147.152µs; +272.318µs] or [+4.147%; +7.674%]	unstable [-196.363op/s; +55.176op/s] or [-15.203%; +4.272%]	3.759ms	1221.000op/s	3.549ms	1291.594op/s
scenario:load:insecure-bank:profiling:high_load	better [-102.352µs; -63.768µs] or [-4.928%; -3.070%]	unstable [-173.660op/s; +346.347op/s] or [-7.982%; +15.920%]	1.994ms	2261.906op/s	2.077ms	2175.562op/s
scenario:load:petclinic:appsec:high_load	better [-1010.337µs; -589.570µs] or [-5.231%; -3.053%]	unstable [-13.701op/s; +34.389op/s] or [-5.668%; +14.227%]	18.514ms	252.062op/s	19.314ms	241.719op/s
scenario:load:petclinic:tracing:high_load	better [-1192.842µs; -799.304µs] or [-6.371%; -4.269%]	unstable [-10.872op/s; +38.872op/s] or [-4.362%; +15.597%]	17.727ms	263.219op/s	18.724ms	249.219op/s
scenario:load:petclinic:no_agent:high_load	better [-819.445µs; -430.060µs] or [-4.565%; -2.396%]	unstable [-19.135op/s; +37.823op/s] or [-7.361%; +14.549%]	17.326ms	269.312op/s	17.951ms	259.969op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.291 ms) : 1279, 1304
.   : milestone, 1291,
iast (3.218 ms) : 3174, 3262
.   : milestone, 3218,
iast_FULL (5.7 ms) : 5644, 5756
.   : milestone, 5700,
iast_GLOBAL (3.549 ms) : 3492, 3605
.   : milestone, 3549,
profiling (2.077 ms) : 2059, 2095
.   : milestone, 2077,
tracing (1.811 ms) : 1796, 1826
.   : milestone, 1811,
section candidate
no_agent (1.285 ms) : 1271, 1298
.   : milestone, 1285,
iast (3.324 ms) : 3284, 3364
.   : milestone, 3324,
iast_FULL (5.814 ms) : 5755, 5874
.   : milestone, 5814,
iast_GLOBAL (3.759 ms) : 3699, 3818
.   : milestone, 3759,
profiling (1.994 ms) : 1976, 2011
.   : milestone, 1994,
tracing (1.786 ms) : 1771, 1800
.   : milestone, 1786,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.291 ms [1.279 ms, 1.304 ms]	-
iast	3.218 ms [3.174 ms, 3.262 ms]	1.926 ms (149.2%)
iast_FULL	5.7 ms [5.644 ms, 5.756 ms]	4.408 ms (341.4%)
iast_GLOBAL	3.549 ms [3.492 ms, 3.605 ms]	2.257 ms (174.8%)
profiling	2.077 ms [2.059 ms, 2.095 ms]	785.59 µs (60.8%)
tracing	1.811 ms [1.796 ms, 1.826 ms]	519.327 µs (40.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.285 ms [1.271 ms, 1.298 ms]	-
iast	3.324 ms [3.284 ms, 3.364 ms]	2.039 ms (158.7%)
iast_FULL	5.814 ms [5.755 ms, 5.874 ms]	4.53 ms (352.6%)
iast_GLOBAL	3.759 ms [3.699 ms, 3.818 ms]	2.474 ms (192.5%)
profiling	1.994 ms [1.976 ms, 2.011 ms]	709.167 µs (55.2%)
tracing	1.786 ms [1.771 ms, 1.8 ms]	501.114 µs (39.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.951 ms) : 17763, 18138
.   : milestone, 17951,
appsec (19.314 ms) : 19112, 19517
.   : milestone, 19314,
code_origins (17.68 ms) : 17502, 17857
.   : milestone, 17680,
iast (17.637 ms) : 17462, 17811
.   : milestone, 17637,
profiling (18.593 ms) : 18408, 18777
.   : milestone, 18593,
tracing (18.724 ms) : 18537, 18910
.   : milestone, 18724,
section candidate
no_agent (17.326 ms) : 17152, 17500
.   : milestone, 17326,
appsec (18.514 ms) : 18326, 18702
.   : milestone, 18514,
code_origins (18.081 ms) : 17900, 18262
.   : milestone, 18081,
iast (17.702 ms) : 17526, 17877
.   : milestone, 17702,
profiling (18.416 ms) : 18230, 18601
.   : milestone, 18416,
tracing (17.727 ms) : 17548, 17907
.   : milestone, 17727,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.951 ms [17.763 ms, 18.138 ms]	-
appsec	19.314 ms [19.112 ms, 19.517 ms]	1.363 ms (7.6%)
code_origins	17.68 ms [17.502 ms, 17.857 ms]	-271.223 µs (-1.5%)
iast	17.637 ms [17.462 ms, 17.811 ms]	-314.161 µs (-1.8%)
profiling	18.593 ms [18.408 ms, 18.777 ms]	641.645 µs (3.6%)
tracing	18.724 ms [18.537 ms, 18.91 ms]	772.628 µs (4.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.326 ms [17.152 ms, 17.5 ms]	-
appsec	18.514 ms [18.326 ms, 18.702 ms]	1.188 ms (6.9%)
code_origins	18.081 ms [17.9 ms, 18.262 ms]	754.731 µs (4.4%)
iast	17.702 ms [17.526 ms, 17.877 ms]	375.758 µs (2.2%)
profiling	18.416 ms [18.23 ms, 18.601 ms]	1.09 ms (6.3%)
tracing	17.727 ms [17.548 ms, 17.907 ms]	401.308 µs (2.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/SDBM-2100-fix-SQL-append
git_commit_date	1762465633	1762522125
git_commit_sha	`434b694`	`b9bd6fb`
release_version	1.56.0-SNAPSHOT~434b694acb	1.56.0-SNAPSHOT~b9bd6fb8ef

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1762524413	1762524413
ci_job_id	1222150069	1222150069
ci_pipeline_id	81584134	81584134
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-merkpeil 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-merkpeil 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.467 s) : 15467000, 15467000
.   : milestone, 15467000,
appsec (15.212 s) : 15212000, 15212000
.   : milestone, 15212000,
iast (18.66 s) : 18660000, 18660000
.   : milestone, 18660000,
iast_GLOBAL (17.772 s) : 17772000, 17772000
.   : milestone, 17772000,
profiling (15.634 s) : 15634000, 15634000
.   : milestone, 15634000,
tracing (14.533 s) : 14533000, 14533000
.   : milestone, 14533000,
section candidate
no_agent (15.5 s) : 15500000, 15500000
.   : milestone, 15500000,
appsec (15.351 s) : 15351000, 15351000
.   : milestone, 15351000,
iast (18.554 s) : 18554000, 18554000
.   : milestone, 18554000,
iast_GLOBAL (18.209 s) : 18209000, 18209000
.   : milestone, 18209000,
profiling (15.55 s) : 15550000, 15550000
.   : milestone, 15550000,
tracing (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.467 s [15.467 s, 15.467 s]	-
appsec	15.212 s [15.212 s, 15.212 s]	-255.0 ms (-1.6%)
iast	18.66 s [18.66 s, 18.66 s]	3.193 s (20.6%)
iast_GLOBAL	17.772 s [17.772 s, 17.772 s]	2.305 s (14.9%)
profiling	15.634 s [15.634 s, 15.634 s]	167.0 ms (1.1%)
tracing	14.533 s [14.533 s, 14.533 s]	-934.0 ms (-6.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.5 s [15.5 s, 15.5 s]	-
appsec	15.351 s [15.351 s, 15.351 s]	-149.0 ms (-1.0%)
iast	18.554 s [18.554 s, 18.554 s]	3.054 s (19.7%)
iast_GLOBAL	18.209 s [18.209 s, 18.209 s]	2.709 s (17.5%)
profiling	15.55 s [15.55 s, 15.55 s]	50.0 ms (0.3%)
tracing	14.922 s [14.922 s, 14.922 s]	-578.0 ms (-3.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~b9bd6fb8ef, baseline=1.56.0-SNAPSHOT~434b694acb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1496
.   : milestone, 1484,
appsec (2.521 ms) : 2467, 2575
.   : milestone, 2521,
iast (2.216 ms) : 2152, 2280
.   : milestone, 2216,
iast_GLOBAL (2.264 ms) : 2200, 2328
.   : milestone, 2264,
profiling (2.09 ms) : 2037, 2143
.   : milestone, 2090,
tracing (2.045 ms) : 1996, 2095
.   : milestone, 2045,
section candidate
no_agent (1.489 ms) : 1477, 1500
.   : milestone, 1489,
appsec (3.736 ms) : 3518, 3955
.   : milestone, 3736,
iast (2.232 ms) : 2167, 2297
.   : milestone, 2232,
iast_GLOBAL (2.252 ms) : 2188, 2316
.   : milestone, 2252,
profiling (2.088 ms) : 2035, 2141
.   : milestone, 2088,
tracing (2.053 ms) : 2003, 2103
.   : milestone, 2053,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.484 ms [1.472 ms, 1.496 ms]	-
appsec	2.521 ms [2.467 ms, 2.575 ms]	1.037 ms (69.9%)
iast	2.216 ms [2.152 ms, 2.28 ms]	731.817 µs (49.3%)
iast_GLOBAL	2.264 ms [2.2 ms, 2.328 ms]	779.977 µs (52.6%)
profiling	2.09 ms [2.037 ms, 2.143 ms]	606.315 µs (40.9%)
tracing	2.045 ms [1.996 ms, 2.095 ms]	561.283 µs (37.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.489 ms [1.477 ms, 1.5 ms]	-
appsec	3.736 ms [3.518 ms, 3.955 ms]	2.248 ms (151.0%)
iast	2.232 ms [2.167 ms, 2.297 ms]	743.297 µs (49.9%)
iast_GLOBAL	2.252 ms [2.188 ms, 2.316 ms]	763.088 µs (51.3%)
profiling	2.088 ms [2.035 ms, 2.141 ms]	599.231 µs (40.3%)
tracing	2.053 ms [2.003 ms, 2.103 ms]	564.397 µs (37.9%)

na-ji self-assigned this Nov 7, 2025

na-ji added type: bug Bug report and fix inst: jdbc JDBC instrumentation comp: database Database Monitoring labels Nov 7, 2025

na-ji marked this pull request as ready for review November 7, 2025 14:25

na-ji requested a review from a team as a code owner November 7, 2025 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix JDBC's SQLCommenter not taking into account semicolons #9915

fix JDBC's SQLCommenter not taking into account semicolons #9915

Uh oh!

na-ji commented Nov 7, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Nov 7, 2025

Uh oh!

pr-commenter bot commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix JDBC's SQLCommenter not taking into account semicolons #9915

Are you sure you want to change the base?

fix JDBC's SQLCommenter not taking into account semicolons #9915

Uh oh!

Conversation

na-ji commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

What Does This Do

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Nov 7, 2025

Uh oh!

pr-commenter bot commented Nov 7, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

na-ji commented Nov 7, 2025 •

edited

Loading