Skip to content

Fix npe on ConflatingMetricsAggregator when the resource is null #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

Fix npe on ConflatingMetricsAggregator when the resource is null #9909

merged 1 commit into from
Nov 10, 2025

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Nov 6, 2025

What Does This Do

Fixes:

java.lang.NullPointerException
  at metrics.ConflatingMetricsAggregator.publish(ConflatingMetricsAggregator.java:280)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner November 6, 2025 15:58
@amarziali amarziali requested a review from smola November 6, 2025 15:58
@amarziali amarziali added type: bug Bug report and fix comp: metrics Metrics tag: telemetry-error-reported Reported by error telemetry labels Nov 6, 2025
@amarziali amarziali requested a review from mcculls November 6, 2025 15:58
@amarziali amarziali enabled auto-merge (squash) November 6, 2025 15:58
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 6, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 63.29% (+3.68%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6f71652 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/npe
git_commit_date 1762435787 1762444581
git_commit_sha 19d774d 6f71652
release_version 1.56.0-SNAPSHOT~19d774d48c 1.56.0-SNAPSHOT~6f716528e6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762446305 1762446305
ci_job_id 1219988488 1219988488
ci_pipeline_id 81469943 81469943
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-415a3qel 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-415a3qel 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047240
Total [baseline] (8.639 s) : 0, 8638700
Agent [candidate] (1.046 s) : 0, 1046299
Total [candidate] (8.627 s) : 0, 8626676
section iast
Agent [baseline] (1.185 s) : 0, 1185214
Total [baseline] (9.301 s) : 0, 9301303
Agent [candidate] (1.187 s) : 0, 1186608
Total [candidate] (9.254 s) : 0, 9253549
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.185 s 137.973 ms (13.2%)
Total tracing 8.639 s -
Total iast 9.301 s 662.603 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.187 s 140.31 ms (13.4%)
Total tracing 8.627 s -
Total iast 9.254 s 626.873 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (704.866 ms) : 0, 704866
BytebuddyAgent [candidate] (704.379 ms) : 0, 704379
GlobalTracer [baseline] (245.955 ms) : 0, 245955
GlobalTracer [candidate] (245.587 ms) : 0, 245587
AppSec [baseline] (32.413 ms) : 0, 32413
AppSec [candidate] (32.443 ms) : 0, 32443
Debugger [baseline] (6.361 ms) : 0, 6361
Debugger [candidate] (6.328 ms) : 0, 6328
Remote Config [baseline] (712.717 µs) : 0, 713
Remote Config [candidate] (712.344 µs) : 0, 712
Telemetry [baseline] (14.363 ms) : 0, 14363
Telemetry [candidate] (13.571 ms) : 0, 13571
Flare Poller [baseline] (6.539 ms) : 0, 6539
Flare Poller [candidate] (7.157 ms) : 0, 7157
section iast
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (832.953 ms) : 0, 832953
BytebuddyAgent [candidate] (834.73 ms) : 0, 834730
GlobalTracer [baseline] (234.991 ms) : 0, 234991
GlobalTracer [candidate] (234.934 ms) : 0, 234934
IAST [baseline] (32.823 ms) : 0, 32823
IAST [candidate] (34.307 ms) : 0, 34307
AppSec [baseline] (28.877 ms) : 0, 28877
AppSec [candidate] (27.224 ms) : 0, 27224
Debugger [baseline] (6.063 ms) : 0, 6063
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (599.773 µs) : 0, 600
Remote Config [candidate] (600.172 µs) : 0, 600
Telemetry [baseline] (8.512 ms) : 0, 8512
Telemetry [candidate] (8.406 ms) : 0, 8406
Flare Poller [baseline] (4.158 ms) : 0, 4158
Flare Poller [candidate] (4.137 ms) : 0, 4137
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048920
Total [baseline] (10.804 s) : 0, 10804063
Agent [candidate] (1.045 s) : 0, 1044867
Total [candidate] (10.689 s) : 0, 10689264
section appsec
Agent [baseline] (1.221 s) : 0, 1220762
Total [baseline] (10.844 s) : 0, 10843637
Agent [candidate] (1.221 s) : 0, 1221385
Total [candidate] (10.921 s) : 0, 10921208
section iast
Agent [baseline] (1.191 s) : 0, 1191333
Total [baseline] (11.229 s) : 0, 11229140
Agent [candidate] (1.178 s) : 0, 1178298
Total [candidate] (11.193 s) : 0, 11192720
section profiling
Agent [baseline] (1.192 s) : 0, 1191930
Total [baseline] (10.837 s) : 0, 10836734
Agent [candidate] (1.194 s) : 0, 1193509
Total [candidate] (10.923 s) : 0, 10923392
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.221 s 171.842 ms (16.4%)
Agent iast 1.191 s 142.413 ms (13.6%)
Agent profiling 1.192 s 143.01 ms (13.6%)
Total tracing 10.804 s -
Total appsec 10.844 s 39.574 ms (0.4%)
Total iast 11.229 s 425.077 ms (3.9%)
Total profiling 10.837 s 32.671 ms (0.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.221 s 176.518 ms (16.9%)
Agent iast 1.178 s 133.43 ms (12.8%)
Agent profiling 1.194 s 148.641 ms (14.2%)
Total tracing 10.689 s -
Total appsec 10.921 s 231.944 ms (2.2%)
Total iast 11.193 s 503.456 ms (4.7%)
Total profiling 10.923 s 234.128 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (706.658 ms) : 0, 706658
BytebuddyAgent [candidate] (703.08 ms) : 0, 703080
GlobalTracer [baseline] (245.838 ms) : 0, 245838
GlobalTracer [candidate] (245.529 ms) : 0, 245529
AppSec [baseline] (32.411 ms) : 0, 32411
AppSec [candidate] (32.259 ms) : 0, 32259
Debugger [baseline] (6.379 ms) : 0, 6379
Debugger [candidate] (6.368 ms) : 0, 6368
Remote Config [baseline] (710.304 µs) : 0, 710
Remote Config [candidate] (707.075 µs) : 0, 707
Telemetry [baseline] (15.733 ms) : 0, 15733
Telemetry [candidate] (11.341 ms) : 0, 11341
Flare Poller [baseline] (5.052 ms) : 0, 5052
Flare Poller [candidate] (9.484 ms) : 0, 9484
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (729.073 ms) : 0, 729073
BytebuddyAgent [candidate] (729.13 ms) : 0, 729130
GlobalTracer [baseline] (237.226 ms) : 0, 237226
GlobalTracer [candidate] (237.439 ms) : 0, 237439
IAST [baseline] (24.832 ms) : 0, 24832
IAST [candidate] (24.875 ms) : 0, 24875
AppSec [baseline] (174.177 ms) : 0, 174177
AppSec [candidate] (174.468 ms) : 0, 174468
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (643.365 µs) : 0, 643
Remote Config [candidate] (648.163 µs) : 0, 648
Telemetry [baseline] (8.548 ms) : 0, 8548
Telemetry [candidate] (8.594 ms) : 0, 8594
Flare Poller [baseline] (4.02 ms) : 0, 4020
Flare Poller [candidate] (3.948 ms) : 0, 3948
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (837.409 ms) : 0, 837409
BytebuddyAgent [candidate] (827.739 ms) : 0, 827739
GlobalTracer [baseline] (236.538 ms) : 0, 236538
GlobalTracer [candidate] (234.477 ms) : 0, 234477
IAST [baseline] (32.681 ms) : 0, 32681
IAST [candidate] (30.529 ms) : 0, 30529
AppSec [baseline] (28.971 ms) : 0, 28971
AppSec [candidate] (30.308 ms) : 0, 30308
Debugger [baseline] (6.009 ms) : 0, 6009
Debugger [candidate] (5.981 ms) : 0, 5981
Remote Config [baseline] (608.007 µs) : 0, 608
Remote Config [candidate] (598.713 µs) : 0, 599
Telemetry [baseline] (8.524 ms) : 0, 8524
Telemetry [candidate] (8.396 ms) : 0, 8396
Flare Poller [baseline] (4.159 ms) : 0, 4159
Flare Poller [candidate] (4.142 ms) : 0, 4142
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (729.712 ms) : 0, 729712
BytebuddyAgent [candidate] (730.088 ms) : 0, 730088
GlobalTracer [baseline] (221.498 ms) : 0, 221498
GlobalTracer [candidate] (222.118 ms) : 0, 222118
AppSec [baseline] (32.068 ms) : 0, 32068
AppSec [candidate] (32.131 ms) : 0, 32131
Debugger [baseline] (8.901 ms) : 0, 8901
Debugger [candidate] (11.351 ms) : 0, 11351
Remote Config [baseline] (689.843 µs) : 0, 690
Remote Config [candidate] (691.717 µs) : 0, 692
Telemetry [baseline] (13.569 ms) : 0, 13569
Telemetry [candidate] (11.407 ms) : 0, 11407
Flare Poller [baseline] (4.136 ms) : 0, 4136
Flare Poller [candidate] (4.079 ms) : 0, 4079
ProfilingAgent [baseline] (110.139 ms) : 0, 110139
ProfilingAgent [candidate] (110.42 ms) : 0, 110420
Profiling [baseline] (110.795 ms) : 0, 110795
Profiling [candidate] (111.094 ms) : 0, 111094
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/npe
git_commit_date 1762435787 1762444581
git_commit_sha 19d774d 6f71652
release_version 1.56.0-SNAPSHOT~19d774d48c 1.56.0-SNAPSHOT~6f716528e6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762446888 1762446888
ci_job_id 1219988489 1219988489
ci_pipeline_id 81469943 81469943
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-bfcyx2zi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-bfcyx2zi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-92.645µs; -54.289µs] or [-4.494%; -2.633%]		 unstable
[-209.105op/s; +367.543op/s] or [-9.544%; +16.776%]		 1.988ms 2270.156op/s 2.062ms 2190.938op/s
scenario:load:insecure-bank:iast:high_load better
[-231.609µs; -138.532µs] or [-6.923%; -4.141%]		 unstable
[-91.591op/s; +247.779op/s] or [-6.690%; +18.099%]		 3.160ms 1447.125op/s 3.345ms 1369.031op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-257.549µs; -127.057µs] or [-4.274%; -2.109%]		 unstable
[-66.854op/s; +116.729op/s] or [-8.708%; +15.205%]		 5.833ms 792.656op/s 6.025ms 767.719op/s
scenario:load:petclinic:tracing:high_load better
[-2.374ms; -1.970ms] or [-12.012%; -9.967%]		 unstable
[+1.398op/s; +56.602op/s] or [+0.592%; +23.968%]		 17.595ms 265.156op/s 19.768ms 236.156op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c
    dateFormat X
    axisFormat %s
section baseline
no_agent (16.929 ms) : 16762, 17096
.   : milestone, 16929,
appsec (18.336 ms) : 18152, 18519
.   : milestone, 18336,
code_origins (17.681 ms) : 17504, 17858
.   : milestone, 17681,
iast (17.719 ms) : 17543, 17895
.   : milestone, 17719,
profiling (18.245 ms) : 18064, 18427
.   : milestone, 18245,
tracing (19.768 ms) : 19568, 19968
.   : milestone, 19768,
section candidate
no_agent (17.156 ms) : 16983, 17329
.   : milestone, 17156,
appsec (18.442 ms) : 18255, 18628
.   : milestone, 18442,
code_origins (17.45 ms) : 17278, 17622
.   : milestone, 17450,
iast (17.742 ms) : 17566, 17919
.   : milestone, 17742,
profiling (18.573 ms) : 18387, 18759
.   : milestone, 18573,
tracing (17.595 ms) : 17421, 17770
.   : milestone, 17595,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 16.929 ms [16.762 ms, 17.096 ms] -
appsec 18.336 ms [18.152 ms, 18.519 ms] 1.407 ms (8.3%)
code_origins 17.681 ms [17.504 ms, 17.858 ms] 751.767 µs (4.4%)
iast 17.719 ms [17.543 ms, 17.895 ms] 789.627 µs (4.7%)
profiling 18.245 ms [18.064 ms, 18.427 ms] 1.316 ms (7.8%)
tracing 19.768 ms [19.568 ms, 19.968 ms] 2.838 ms (16.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.156 ms [16.983 ms, 17.329 ms] -
appsec 18.442 ms [18.255 ms, 18.628 ms] 1.286 ms (7.5%)
code_origins 17.45 ms [17.278 ms, 17.622 ms] 294.128 µs (1.7%)
iast 17.742 ms [17.566 ms, 17.919 ms] 586.451 µs (3.4%)
profiling 18.573 ms [18.387 ms, 18.759 ms] 1.417 ms (8.3%)
tracing 17.595 ms [17.421 ms, 17.77 ms] 439.214 µs (2.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.19 ms) : 1179, 1202
.   : milestone, 1190,
iast (3.345 ms) : 3298, 3393
.   : milestone, 3345,
iast_FULL (6.025 ms) : 5964, 6087
.   : milestone, 6025,
iast_GLOBAL (3.613 ms) : 3562, 3664
.   : milestone, 3613,
profiling (2.062 ms) : 2043, 2080
.   : milestone, 2062,
tracing (1.785 ms) : 1771, 1800
.   : milestone, 1785,
section candidate
no_agent (1.198 ms) : 1186, 1209
.   : milestone, 1198,
iast (3.16 ms) : 3122, 3199
.   : milestone, 3160,
iast_FULL (5.833 ms) : 5774, 5893
.   : milestone, 5833,
iast_GLOBAL (3.642 ms) : 3573, 3712
.   : milestone, 3642,
profiling (1.988 ms) : 1971, 2005
.   : milestone, 1988,
tracing (1.757 ms) : 1743, 1772
.   : milestone, 1757,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.19 ms [1.179 ms, 1.202 ms] -
iast 3.345 ms [3.298 ms, 3.393 ms] 2.155 ms (181.0%)
iast_FULL 6.025 ms [5.964 ms, 6.087 ms] 4.835 ms (406.2%)
iast_GLOBAL 3.613 ms [3.562 ms, 3.664 ms] 2.423 ms (203.5%)
profiling 2.062 ms [2.043 ms, 2.08 ms] 871.19 µs (73.2%)
tracing 1.785 ms [1.771 ms, 1.8 ms] 594.95 µs (50.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.198 ms [1.186 ms, 1.209 ms] -
iast 3.16 ms [3.122 ms, 3.199 ms] 1.963 ms (163.9%)
iast_FULL 5.833 ms [5.774 ms, 5.893 ms] 4.635 ms (387.0%)
iast_GLOBAL 3.642 ms [3.573 ms, 3.712 ms] 2.445 ms (204.1%)
profiling 1.988 ms [1.971 ms, 2.005 ms] 790.413 µs (66.0%)
tracing 1.757 ms [1.743 ms, 1.772 ms] 559.636 µs (46.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/npe
git_commit_date 1762435787 1762444581
git_commit_sha 19d774d 6f71652
release_version 1.56.0-SNAPSHOT~19d774d48c 1.56.0-SNAPSHOT~6f716528e6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1762446554 1762446554
ci_job_id 1219988490 1219988490
ci_pipeline_id 81469943 81469943
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-v68q2awt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-v68q2awt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
appsec (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
iast (18.392 s) : 18392000, 18392000
.   : milestone, 18392000,
iast_GLOBAL (18.093 s) : 18093000, 18093000
.   : milestone, 18093000,
profiling (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
tracing (14.872 s) : 14872000, 14872000
.   : milestone, 14872000,
section candidate
no_agent (15.29 s) : 15290000, 15290000
.   : milestone, 15290000,
appsec (14.837 s) : 14837000, 14837000
.   : milestone, 14837000,
iast (18.582 s) : 18582000, 18582000
.   : milestone, 18582000,
iast_GLOBAL (18.149 s) : 18149000, 18149000
.   : milestone, 18149000,
profiling (15.379 s) : 15379000, 15379000
.   : milestone, 15379000,
tracing (14.852 s) : 14852000, 14852000
.   : milestone, 14852000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.939 s [14.939 s, 14.939 s] -
appsec 15.242 s [15.242 s, 15.242 s] 303.0 ms (2.0%)
iast 18.392 s [18.392 s, 18.392 s] 3.453 s (23.1%)
iast_GLOBAL 18.093 s [18.093 s, 18.093 s] 3.154 s (21.1%)
profiling 15.178 s [15.178 s, 15.178 s] 239.0 ms (1.6%)
tracing 14.872 s [14.872 s, 14.872 s] -67.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.29 s [15.29 s, 15.29 s] -
appsec 14.837 s [14.837 s, 14.837 s] -453.0 ms (-3.0%)
iast 18.582 s [18.582 s, 18.582 s] 3.292 s (21.5%)
iast_GLOBAL 18.149 s [18.149 s, 18.149 s] 2.859 s (18.7%)
profiling 15.379 s [15.379 s, 15.379 s] 89.0 ms (0.6%)
tracing 14.852 s [14.852 s, 14.852 s] -438.0 ms (-2.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~6f716528e6, baseline=1.56.0-SNAPSHOT~19d774d48c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.736 ms) : 3518, 3954
.   : milestone, 3736,
iast (2.225 ms) : 2162, 2289
.   : milestone, 2225,
iast_GLOBAL (2.27 ms) : 2206, 2334
.   : milestone, 2270,
profiling (2.074 ms) : 2022, 2125
.   : milestone, 2074,
tracing (2.035 ms) : 1986, 2085
.   : milestone, 2035,
section candidate
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (3.738 ms) : 3519, 3956
.   : milestone, 3738,
iast (2.229 ms) : 2165, 2293
.   : milestone, 2229,
iast_GLOBAL (2.269 ms) : 2204, 2333
.   : milestone, 2269,
profiling (2.507 ms) : 2338, 2676
.   : milestone, 2507,
tracing (2.037 ms) : 1987, 2086
.   : milestone, 2037,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 3.736 ms [3.518 ms, 3.954 ms] 2.257 ms (152.6%)
iast 2.225 ms [2.162 ms, 2.289 ms] 746.112 µs (50.4%)
iast_GLOBAL 2.27 ms [2.206 ms, 2.334 ms] 790.862 µs (53.5%)
profiling 2.074 ms [2.022 ms, 2.125 ms] 594.446 µs (40.2%)
tracing 2.035 ms [1.986 ms, 2.085 ms] 556.323 µs (37.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 3.738 ms [3.519 ms, 3.956 ms] 2.256 ms (152.4%)
iast 2.229 ms [2.165 ms, 2.293 ms] 747.806 µs (50.5%)
iast_GLOBAL 2.269 ms [2.204 ms, 2.333 ms] 787.681 µs (53.2%)
profiling 2.507 ms [2.338 ms, 2.676 ms] 1.026 ms (69.2%)
tracing 2.037 ms [1.987 ms, 2.086 ms] 555.481 µs (37.5%)

bric3
bric3 approved these changes Nov 10, 2025
View reviewed changes
...race-core/src/test/groovy/datadog/trace/common/metrics/ConflatingMetricAggregatorTest.groovy
latchTriggered
1 * writer.startBucket(1, _, _)
1 * writer.add(new MetricKey(
null,
Copy link
Contributor

@bric3 bric3 Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

Suggested change
null,
null, // resource name

@amarziali amarziali merged commit 4fb1b2e into master Nov 10, 2025
544 of 547 checks passed
@amarziali amarziali deleted the andrea.marziali/npe branch November 10, 2025 10:45
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 10, 2025
jandro996 pushed a commit that referenced this pull request Nov 10, 2025
@amarziali @jandro996
Fix npe on ConflatingMetricsAggregator when the resource is null (#9909)
44bab01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

@mcculls mcculls Awaiting requested review from mcculls

Assignees

No one assigned

Labels

comp: metrics Metrics tag: telemetry-error-reported Reported by error telemetry type: bug Bug report and fix

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @bric3