-
Notifications
You must be signed in to change notification settings - Fork 315
Add process tags to agent statsd client #9904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| if (null != constantTags && constantTags.length > 0) { | ||
| tagMapping = new TagCombiner(constantTags); | ||
| final List<String> processTags = ProcessTags.getTagsAsStringList(); | ||
| final int processTagSize = processTags != null ? processTags.size() : 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raphaelgavache I did not filter right now the process tags meaning that we send all of them systematically. It should be ok but in case it represents an issue, please let me know and we'll craft a whitelist
|
🎯 Code Coverage 🔗 Commit SHA: 8482aff | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 11 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049713
Total [baseline] (10.805 s) : 0, 10805064
Agent [candidate] (1.051 s) : 0, 1050699
Total [candidate] (10.758 s) : 0, 10758433
section appsec
Agent [baseline] (1.223 s) : 0, 1222963
Total [baseline] (10.832 s) : 0, 10831994
Agent [candidate] (1.225 s) : 0, 1224530
Total [candidate] (10.891 s) : 0, 10890592
section iast
Agent [baseline] (1.182 s) : 0, 1181566
Total [baseline] (11.148 s) : 0, 11147910
Agent [candidate] (1.189 s) : 0, 1189043
Total [candidate] (11.198 s) : 0, 11198396
section profiling
Agent [baseline] (1.191 s) : 0, 1191448
Total [baseline] (10.935 s) : 0, 10934627
Agent [candidate] (1.192 s) : 0, 1191600
Total [candidate] (10.877 s) : 0, 10876598
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (705.945 ms) : 0, 705945
BytebuddyAgent [candidate] (705.119 ms) : 0, 705119
GlobalTracer [baseline] (246.742 ms) : 0, 246742
GlobalTracer [candidate] (249.359 ms) : 0, 249359
AppSec [baseline] (32.591 ms) : 0, 32591
AppSec [candidate] (32.347 ms) : 0, 32347
Debugger [baseline] (6.42 ms) : 0, 6420
Debugger [candidate] (6.376 ms) : 0, 6376
Remote Config [baseline] (720.81 µs) : 0, 721
Remote Config [candidate] (678.604 µs) : 0, 679
Telemetry [baseline] (11.589 ms) : 0, 11589
Telemetry [candidate] (11.037 ms) : 0, 11037
Flare Poller [baseline] (9.539 ms) : 0, 9539
Flare Poller [candidate] (9.647 ms) : 0, 9647
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (729.983 ms) : 0, 729983
BytebuddyAgent [candidate] (729.356 ms) : 0, 729356
GlobalTracer [baseline] (237.981 ms) : 0, 237981
GlobalTracer [candidate] (241.092 ms) : 0, 241092
AppSec [baseline] (174.78 ms) : 0, 174780
AppSec [candidate] (174.237 ms) : 0, 174237
Debugger [baseline] (5.966 ms) : 0, 5966
Debugger [candidate] (6.066 ms) : 0, 6066
Remote Config [baseline] (646.01 µs) : 0, 646
Remote Config [candidate] (658.089 µs) : 0, 658
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (7.906 ms) : 0, 7906
Flare Poller [baseline] (3.991 ms) : 0, 3991
Flare Poller [candidate] (4.068 ms) : 0, 4068
IAST [baseline] (24.859 ms) : 0, 24859
IAST [candidate] (24.945 ms) : 0, 24945
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (829.717 ms) : 0, 829717
BytebuddyAgent [candidate] (833.876 ms) : 0, 833876
GlobalTracer [baseline] (235.201 ms) : 0, 235201
GlobalTracer [candidate] (238.556 ms) : 0, 238556
AppSec [baseline] (29.67 ms) : 0, 29670
AppSec [candidate] (30.589 ms) : 0, 30589
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.06 ms) : 0, 6060
Remote Config [baseline] (611.851 µs) : 0, 612
Remote Config [candidate] (610.913 µs) : 0, 611
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.044 ms) : 0, 8044
Flare Poller [baseline] (4.161 ms) : 0, 4161
Flare Poller [candidate] (4.162 ms) : 0, 4162
IAST [baseline] (31.655 ms) : 0, 31655
IAST [candidate] (30.861 ms) : 0, 30861
section profiling
ProfilingAgent [baseline] (110.369 ms) : 0, 110369
ProfilingAgent [candidate] (110.44 ms) : 0, 110440
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (728.653 ms) : 0, 728653
BytebuddyAgent [candidate] (728.974 ms) : 0, 728974
GlobalTracer [baseline] (221.85 ms) : 0, 221850
GlobalTracer [candidate] (221.939 ms) : 0, 221939
AppSec [baseline] (32.201 ms) : 0, 32201
AppSec [candidate] (32.188 ms) : 0, 32188
Debugger [baseline] (7.532 ms) : 0, 7532
Debugger [candidate] (9.862 ms) : 0, 9862
Remote Config [baseline] (1.493 ms) : 0, 1493
Remote Config [candidate] (684.876 µs) : 0, 685
Telemetry [baseline] (14.629 ms) : 0, 14629
Telemetry [candidate] (12.883 ms) : 0, 12883
Flare Poller [baseline] (4.138 ms) : 0, 4138
Flare Poller [candidate] (4.177 ms) : 0, 4177
Profiling [baseline] (111.027 ms) : 0, 111027
Profiling [candidate] (111.111 ms) : 0, 111111
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046208
Total [baseline] (8.615 s) : 0, 8614610
Agent [candidate] (1.057 s) : 0, 1056588
Total [candidate] (8.626 s) : 0, 8626055
section iast
Agent [baseline] (1.175 s) : 0, 1174623
Total [baseline] (9.244 s) : 0, 9244321
Agent [candidate] (1.178 s) : 0, 1177799
Total [candidate] (9.255 s) : 0, 9255322
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (703.315 ms) : 0, 703315
BytebuddyAgent [candidate] (709.253 ms) : 0, 709253
GlobalTracer [baseline] (246.053 ms) : 0, 246053
GlobalTracer [candidate] (251.033 ms) : 0, 251033
AppSec [baseline] (32.521 ms) : 0, 32521
AppSec [candidate] (32.627 ms) : 0, 32627
Debugger [baseline] (6.416 ms) : 0, 6416
Debugger [candidate] (6.404 ms) : 0, 6404
Remote Config [baseline] (723.968 µs) : 0, 724
Remote Config [candidate] (702.408 µs) : 0, 702
Telemetry [baseline] (13.734 ms) : 0, 13734
Telemetry [candidate] (13.087 ms) : 0, 13087
Flare Poller [baseline] (7.397 ms) : 0, 7397
Flare Poller [candidate] (7.158 ms) : 0, 7158
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (824.81 ms) : 0, 824810
BytebuddyAgent [candidate] (825.7 ms) : 0, 825700
GlobalTracer [baseline] (233.615 ms) : 0, 233615
GlobalTracer [candidate] (237.047 ms) : 0, 237047
IAST [baseline] (30.588 ms) : 0, 30588
IAST [candidate] (33.784 ms) : 0, 33784
AppSec [baseline] (30.376 ms) : 0, 30376
AppSec [candidate] (26.715 ms) : 0, 26715
Debugger [baseline] (6.027 ms) : 0, 6027
Debugger [candidate] (6.003 ms) : 0, 6003
Remote Config [baseline] (602.858 µs) : 0, 603
Remote Config [candidate] (604.991 µs) : 0, 605
Telemetry [baseline] (8.484 ms) : 0, 8484
Telemetry [candidate] (7.841 ms) : 0, 7841
Flare Poller [baseline] (4.093 ms) : 0, 4093
Flare Poller [candidate] (4.016 ms) : 0, 4016
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (1.208 ms) : 1196, 1220
. : milestone, 1208,
iast (3.303 ms) : 3251, 3354
. : milestone, 3303,
iast_FULL (5.609 ms) : 5553, 5666
. : milestone, 5609,
iast_GLOBAL (3.674 ms) : 3611, 3738
. : milestone, 3674,
profiling (2.327 ms) : 2305, 2349
. : milestone, 2327,
tracing (1.804 ms) : 1789, 1818
. : milestone, 1804,
section candidate
no_agent (1.193 ms) : 1181, 1204
. : milestone, 1193,
iast (3.267 ms) : 3229, 3305
. : milestone, 3267,
iast_FULL (5.831 ms) : 5772, 5889
. : milestone, 5831,
iast_GLOBAL (3.555 ms) : 3498, 3611
. : milestone, 3555,
profiling (1.962 ms) : 1946, 1978
. : milestone, 1962,
tracing (1.81 ms) : 1796, 1825
. : milestone, 1810,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (17.91 ms) : 17729, 18091
. : milestone, 17910,
appsec (18.805 ms) : 18614, 18997
. : milestone, 18805,
code_origins (17.78 ms) : 17601, 17958
. : milestone, 17780,
iast (17.61 ms) : 17434, 17787
. : milestone, 17610,
profiling (18.544 ms) : 18362, 18726
. : milestone, 18544,
tracing (18.548 ms) : 18358, 18737
. : milestone, 18548,
section candidate
no_agent (18.451 ms) : 18261, 18640
. : milestone, 18451,
appsec (18.597 ms) : 18408, 18785
. : milestone, 18597,
code_origins (17.679 ms) : 17502, 17856
. : milestone, 17679,
iast (17.821 ms) : 17645, 17996
. : milestone, 17821,
profiling (18.348 ms) : 18166, 18531
. : milestone, 18348,
tracing (17.428 ms) : 17254, 17602
. : milestone, 17428,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.703 ms) : 3485, 3921
. : milestone, 3703,
iast (2.223 ms) : 2159, 2286
. : milestone, 2223,
iast_GLOBAL (2.249 ms) : 2186, 2313
. : milestone, 2249,
profiling (2.089 ms) : 2036, 2142
. : milestone, 2089,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.636 ms) : 3422, 3850
. : milestone, 3636,
iast (2.218 ms) : 2154, 2281
. : milestone, 2218,
iast_GLOBAL (2.258 ms) : 2195, 2322
. : milestone, 2258,
profiling (2.076 ms) : 2024, 2129
. : milestone, 2076,
tracing (2.031 ms) : 1981, 2080
. : milestone, 2031,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~8482affe06, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
appsec (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
iast (18.635 s) : 18635000, 18635000
. : milestone, 18635000,
iast_GLOBAL (17.875 s) : 17875000, 17875000
. : milestone, 17875000,
profiling (15.553 s) : 15553000, 15553000
. : milestone, 15553000,
tracing (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
section candidate
no_agent (15.472 s) : 15472000, 15472000
. : milestone, 15472000,
appsec (15.459 s) : 15459000, 15459000
. : milestone, 15459000,
iast (18.28 s) : 18280000, 18280000
. : milestone, 18280000,
iast_GLOBAL (18.088 s) : 18088000, 18088000
. : milestone, 18088000,
profiling (15.246 s) : 15246000, 15246000
. : milestone, 15246000,
tracing (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
|
What Does This Do
Adds the process tags as constant tags to the statsd clients used by the tracer (i.e. jmxfetch)
Note: process tags may mutate since instrumentations can add some of them when the instrumentation kicks in. That can happen after the statsd client is created. This is a known limitation right now.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]