-
Notifications
You must be signed in to change notification settings - Fork 315
WIP: add trace agent backpressure #9882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 7d80c10 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027485
Total [baseline] (8.72 s) : 0, 8720339
Agent [candidate] (1.039 s) : 0, 1038881
Total [candidate] (8.694 s) : 0, 8693653
section iast
Agent [baseline] (1.168 s) : 0, 1167997
Total [baseline] (9.33 s) : 0, 9329912
Agent [candidate] (1.159 s) : 0, 1158606
Total [candidate] (9.36 s) : 0, 9360362
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (700.306 ms) : 0, 700306
BytebuddyAgent [candidate] (707.585 ms) : 0, 707585
GlobalTracer [baseline] (244.426 ms) : 0, 244426
GlobalTracer [candidate] (247.943 ms) : 0, 247943
AppSec [baseline] (32.24 ms) : 0, 32240
AppSec [candidate] (32.447 ms) : 0, 32447
Debugger [baseline] (6.384 ms) : 0, 6384
Debugger [candidate] (6.477 ms) : 0, 6477
Remote Config [baseline] (683.706 µs) : 0, 684
Remote Config [candidate] (686.961 µs) : 0, 687
Telemetry [baseline] (14.386 ms) : 0, 14386
Telemetry [candidate] (15.217 ms) : 0, 15217
Flare Poller [baseline] (6.517 ms) : 0, 6517
Flare Poller [candidate] (5.801 ms) : 0, 5801
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (829.838 ms) : 0, 829838
BytebuddyAgent [candidate] (821.286 ms) : 0, 821286
GlobalTracer [baseline] (234.703 ms) : 0, 234703
GlobalTracer [candidate] (236.09 ms) : 0, 236090
IAST [baseline] (33.489 ms) : 0, 33489
IAST [candidate] (32.197 ms) : 0, 32197
AppSec [baseline] (27.906 ms) : 0, 27906
AppSec [candidate] (27.079 ms) : 0, 27079
Debugger [baseline] (6.158 ms) : 0, 6158
Debugger [candidate] (6.161 ms) : 0, 6161
Remote Config [baseline] (602.308 µs) : 0, 602
Remote Config [candidate] (605.444 µs) : 0, 605
Telemetry [baseline] (8.346 ms) : 0, 8346
Telemetry [candidate] (8.357 ms) : 0, 8357
Flare Poller [baseline] (4.115 ms) : 0, 4115
Flare Poller [candidate] (4.225 ms) : 0, 4225
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1029815
Total [baseline] (10.752 s) : 0, 10752084
Agent [candidate] (1.03 s) : 0, 1030228
Total [candidate] (10.828 s) : 0, 10827596
section appsec
Agent [baseline] (1.211 s) : 0, 1211116
Total [baseline] (10.934 s) : 0, 10934289
Agent [candidate] (1.2 s) : 0, 1199872
Total [candidate] (10.788 s) : 0, 10788313
section iast
Agent [baseline] (1.162 s) : 0, 1161840
Total [baseline] (11.007 s) : 0, 11006890
Agent [candidate] (1.161 s) : 0, 1160688
Total [candidate] (11.121 s) : 0, 11121317
section profiling
Agent [baseline] (1.173 s) : 0, 1173404
Total [baseline] (10.981 s) : 0, 10980599
Agent [candidate] (1.187 s) : 0, 1186749
Total [candidate] (10.939 s) : 0, 10939418
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (702.277 ms) : 0, 702277
BytebuddyAgent [candidate] (701.402 ms) : 0, 701402
GlobalTracer [baseline] (244.52 ms) : 0, 244520
GlobalTracer [candidate] (245.503 ms) : 0, 245503
AppSec [baseline] (32.323 ms) : 0, 32323
AppSec [candidate] (32.521 ms) : 0, 32521
Debugger [baseline] (6.379 ms) : 0, 6379
Debugger [candidate] (7.18 ms) : 0, 7180
Remote Config [baseline] (687.394 µs) : 0, 687
Remote Config [candidate] (689.819 µs) : 0, 690
Telemetry [baseline] (12.82 ms) : 0, 12820
Telemetry [candidate] (14.606 ms) : 0, 14606
Flare Poller [baseline] (6.708 ms) : 0, 6708
Flare Poller [candidate] (5.701 ms) : 0, 5701
section appsec
crashtracking [baseline] (1.516 ms) : 0, 1516
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (732.112 ms) : 0, 732112
BytebuddyAgent [candidate] (724.763 ms) : 0, 724763
GlobalTracer [baseline] (237.579 ms) : 0, 237579
GlobalTracer [candidate] (236.671 ms) : 0, 236671
IAST [baseline] (25.287 ms) : 0, 25287
IAST [candidate] (24.886 ms) : 0, 24886
AppSec [baseline] (174.304 ms) : 0, 174304
AppSec [candidate] (172.2 ms) : 0, 172200
Debugger [baseline] (5.921 ms) : 0, 5921
Debugger [candidate] (5.881 ms) : 0, 5881
Remote Config [baseline] (649.449 µs) : 0, 649
Remote Config [candidate] (613.814 µs) : 0, 614
Telemetry [baseline] (8.463 ms) : 0, 8463
Telemetry [candidate] (8.337 ms) : 0, 8337
Flare Poller [baseline] (3.948 ms) : 0, 3948
Flare Poller [candidate] (3.945 ms) : 0, 3945
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (824.536 ms) : 0, 824536
BytebuddyAgent [candidate] (823.345 ms) : 0, 823345
GlobalTracer [baseline] (233.898 ms) : 0, 233898
GlobalTracer [candidate] (238.806 ms) : 0, 238806
IAST [baseline] (34.456 ms) : 0, 34456
IAST [candidate] (30.482 ms) : 0, 30482
AppSec [baseline] (27.018 ms) : 0, 27018
AppSec [candidate] (26.298 ms) : 0, 26298
Debugger [baseline] (6.102 ms) : 0, 6102
Debugger [candidate] (6.099 ms) : 0, 6099
Remote Config [baseline] (602.224 µs) : 0, 602
Remote Config [candidate] (595.652 µs) : 0, 596
Telemetry [baseline] (8.343 ms) : 0, 8343
Telemetry [candidate] (8.274 ms) : 0, 8274
Flare Poller [baseline] (4.155 ms) : 0, 4155
Flare Poller [candidate] (4.179 ms) : 0, 4179
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (725.856 ms) : 0, 725856
BytebuddyAgent [candidate] (735.09 ms) : 0, 735090
GlobalTracer [baseline] (220.11 ms) : 0, 220110
GlobalTracer [candidate] (222.942 ms) : 0, 222942
AppSec [baseline] (32.193 ms) : 0, 32193
AppSec [candidate] (34.007 ms) : 0, 34007
Debugger [baseline] (13.204 ms) : 0, 13204
Debugger [candidate] (10.056 ms) : 0, 10056
Remote Config [baseline] (1.439 ms) : 0, 1439
Remote Config [candidate] (698.054 µs) : 0, 698
Telemetry [baseline] (9.082 ms) : 0, 9082
Telemetry [candidate] (11.401 ms) : 0, 11401
Flare Poller [baseline] (4.135 ms) : 0, 4135
Flare Poller [candidate] (4.176 ms) : 0, 4176
ProfilingAgent [baseline] (110.307 ms) : 0, 110307
ProfilingAgent [candidate] (110.654 ms) : 0, 110654
Profiling [baseline] (110.95 ms) : 0, 110950
Profiling [candidate] (111.334 ms) : 0, 111334
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (18.008 ms) : 17824, 18192
. : milestone, 18008,
appsec (19.427 ms) : 19229, 19625
. : milestone, 19427,
code_origins (17.862 ms) : 17684, 18040
. : milestone, 17862,
iast (19.657 ms) : 19460, 19854
. : milestone, 19657,
profiling (19.526 ms) : 19331, 19721
. : milestone, 19526,
tracing (19.663 ms) : 19464, 19861
. : milestone, 19663,
section candidate
no_agent (17.066 ms) : 16898, 17234
. : milestone, 17066,
appsec (18.361 ms) : 18171, 18550
. : milestone, 18361,
code_origins (19.767 ms) : 19568, 19966
. : milestone, 19767,
iast (18.712 ms) : 18523, 18900
. : milestone, 18712,
profiling (19.264 ms) : 19067, 19460
. : milestone, 19264,
tracing (19.033 ms) : 18838, 19227
. : milestone, 19033,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1173, 1196
. : milestone, 1185,
iast (3.278 ms) : 3231, 3324
. : milestone, 3278,
iast_FULL (6.035 ms) : 5975, 6095
. : milestone, 6035,
iast_GLOBAL (3.765 ms) : 3715, 3814
. : milestone, 3765,
profiling (1.976 ms) : 1959, 1993
. : milestone, 1976,
tracing (1.809 ms) : 1794, 1824
. : milestone, 1809,
section candidate
no_agent (1.197 ms) : 1186, 1209
. : milestone, 1197,
iast (3.17 ms) : 3125, 3215
. : milestone, 3170,
iast_FULL (5.921 ms) : 5861, 5982
. : milestone, 5921,
iast_GLOBAL (3.516 ms) : 3465, 3566
. : milestone, 3516,
profiling (1.948 ms) : 1931, 1964
. : milestone, 1948,
tracing (1.834 ms) : 1817, 1850
. : milestone, 1834,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
appsec (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
iast (18.373 s) : 18373000, 18373000
. : milestone, 18373000,
iast_GLOBAL (18.143 s) : 18143000, 18143000
. : milestone, 18143000,
profiling (15.5 s) : 15500000, 15500000
. : milestone, 15500000,
tracing (15.135 s) : 15135000, 15135000
. : milestone, 15135000,
section candidate
no_agent (15.304 s) : 15304000, 15304000
. : milestone, 15304000,
appsec (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
iast (18.36 s) : 18360000, 18360000
. : milestone, 18360000,
iast_GLOBAL (18.339 s) : 18339000, 18339000
. : milestone, 18339000,
profiling (15.727 s) : 15727000, 15727000
. : milestone, 15727000,
tracing (15.251 s) : 15251000, 15251000
. : milestone, 15251000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~7d80c1002d, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.679 ms) : 3465, 3892
. : milestone, 3679,
iast (2.229 ms) : 2166, 2292
. : milestone, 2229,
iast_GLOBAL (2.281 ms) : 2216, 2346
. : milestone, 2281,
profiling (2.062 ms) : 2011, 2113
. : milestone, 2062,
tracing (2.048 ms) : 1999, 2098
. : milestone, 2048,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.726 ms) : 3507, 3945
. : milestone, 3726,
iast (2.219 ms) : 2155, 2283
. : milestone, 2219,
iast_GLOBAL (2.278 ms) : 2214, 2343
. : milestone, 2278,
profiling (2.523 ms) : 2349, 2696
. : milestone, 2523,
tracing (2.037 ms) : 1988, 2087
. : milestone, 2037,
|
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]