Skip to content

Prevent using v1/input endpoint for snapshots #9573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2025
Merged

Prevent using v1/input endpoint for snapshots #9573

merged 4 commits into from
Sep 22, 2025

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 19, 2025 •
edited by atlassian bot
Loading

What Does This Do

snapshots should always send to DEBUGGER track through v2/input or v1/diagnostics endpoints. v1/input is unredacted.
v1/diagnostics endpoint was introduced since DD agent 7.49

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-4522

@jpbempel jpbempel requested review from a team as code owners September 19, 2025 16:41
@jpbempel jpbempel requested review from shatzi and smola and removed request for a team September 19, 2025 16:41
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Sep 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added the type: enhancement Enhancements and improvements label Sep 19, 2025
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1758544356 1758544701
end_time 2025-09-22T12:33:57 2025-09-22T12:39:42
git_branch master jpbempel/no-v1-input-snapshot
git_commit_sha 6decf56 de58508
start_time 2025-09-22T12:32:37 2025-09-22T12:38:22
See matching parameters
Baseline Candidate
ci_job_id 1140692634 1140692634
ci_pipeline_id 77148762 77148762
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1758543820 1758543820

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-27.980µs; +37.325µs] or [-10.000%; +13.340%]		 unstable
[-37.805µs; +52.869µs] or [-11.776%; +16.469%]		 unstable
[-46.227µs; +63.583µs] or [-13.776%; +18.949%]		 unstable
[-164.587µs; +96.158µs] or [-16.729%; +9.774%]		 same
scenario:basic unsure
[-6.822µs; -1.623µs] or [-2.698%; -0.642%]		 same same unstable
[-96.498µs; +60.791µs] or [-13.307%; +8.383%]		 unstable
[-199.597op/s; +199.597op/s] or [-7.585%; +7.585%]
scenario:loop unsure
[-15.907µs; -8.346µs] or [-0.179%; -0.094%]		 unsure
[-23.674µs; -13.062µs] or [-0.264%; -0.146%]		 unsure
[-19.687µs; -8.861µs] or [-0.218%; -0.098%]		 same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (321.03 µs) : 292, 350
.   : milestone, 321,
basic (283.336 µs) : 276, 290
.   : milestone, 283,
loop (8.975 ms) : 8971, 8980
.   : milestone, 8975,
section candidate
noprobe (328.562 µs) : 275, 382
.   : milestone, 329,
basic (277.24 µs) : 271, 283
.   : milestone, 277,
loop (8.957 ms) : 8952, 8962
.   : milestone, 8957,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 321.03 µs [291.731 µs, 350.33 µs]
basic 283.336 µs [276.248 µs, 290.424 µs]
loop 8.975 ms [8.971 ms, 8.98 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 328.562 µs [275.017 µs, 382.107 µs]
basic 277.24 µs [271.299 µs, 283.18 µs]
loop 8.957 ms [8.952 ms, 8.962 ms]

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Sep 19, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.82% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f8929f0 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/no-v1-input-snapshot
git_commit_date 1758557987 1758562186
git_commit_sha 5e2a9e4 f8929f0
release_version 1.54.0-SNAPSHOT~5e2a9e4af6 1.54.0-SNAPSHOT~f8929f0df3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758564005 1758564005
ci_job_id 1141580034 1141580034
ci_pipeline_id 77193934 77193934
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ytpryvpv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ytpryvpv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020217
Total [baseline] (10.66 s) : 0, 10660481
Agent [candidate] (1.018 s) : 0, 1018273
Total [candidate] (10.664 s) : 0, 10663601
section appsec
Agent [baseline] (1.195 s) : 0, 1195158
Total [baseline] (11.083 s) : 0, 11082612
Agent [candidate] (1.204 s) : 0, 1203778
Total [candidate] (11.126 s) : 0, 11126241
section iast
Agent [baseline] (1.15 s) : 0, 1150311
Total [baseline] (11.129 s) : 0, 11128829
Agent [candidate] (1.153 s) : 0, 1153107
Total [candidate] (11.182 s) : 0, 11182063
section profiling
Agent [baseline] (1.178 s) : 0, 1177794
Total [baseline] (11.04 s) : 0, 11040497
Agent [candidate] (1.163 s) : 0, 1163496
Total [candidate] (11.071 s) : 0, 11070730
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.195 s 174.941 ms (17.1%)
Agent iast 1.15 s 130.094 ms (12.8%)
Agent profiling 1.178 s 157.577 ms (15.4%)
Total tracing 10.66 s -
Total appsec 11.083 s 422.131 ms (4.0%)
Total iast 11.129 s 468.348 ms (4.4%)
Total profiling 11.04 s 380.016 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent appsec 1.204 s 185.505 ms (18.2%)
Agent iast 1.153 s 134.834 ms (13.2%)
Agent profiling 1.163 s 145.224 ms (14.3%)
Total tracing 10.664 s -
Total appsec 11.126 s 462.64 ms (4.3%)
Total iast 11.182 s 518.462 ms (4.9%)
Total profiling 11.071 s 407.13 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (687.495 ms) : 0, 687495
BytebuddyAgent [candidate] (686.22 ms) : 0, 686220
GlobalTracer [baseline] (257.826 ms) : 0, 257826
GlobalTracer [candidate] (258.238 ms) : 0, 258238
AppSec [baseline] (31.726 ms) : 0, 31726
AppSec [candidate] (31.633 ms) : 0, 31633
Debugger [baseline] (6.364 ms) : 0, 6364
Debugger [candidate] (6.337 ms) : 0, 6337
Remote Config [baseline] (689.734 µs) : 0, 690
Remote Config [candidate] (681.29 µs) : 0, 681
Telemetry [baseline] (13.538 ms) : 0, 13538
Telemetry [candidate] (12.634 ms) : 0, 12634
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (710.255 ms) : 0, 710255
BytebuddyAgent [candidate] (715.261 ms) : 0, 715261
GlobalTracer [baseline] (249.644 ms) : 0, 249644
GlobalTracer [candidate] (252.733 ms) : 0, 252733
IAST [baseline] (25.115 ms) : 0, 25115
IAST [candidate] (25.01 ms) : 0, 25010
AppSec [baseline] (172.405 ms) : 0, 172405
AppSec [candidate] (172.177 ms) : 0, 172177
Debugger [baseline] (6.077 ms) : 0, 6077
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (617.953 µs) : 0, 618
Remote Config [candidate] (615.855 µs) : 0, 616
Telemetry [baseline] (8.444 ms) : 0, 8444
Telemetry [candidate] (9.187 ms) : 0, 9187
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (806.407 ms) : 0, 806407
BytebuddyAgent [candidate] (806.947 ms) : 0, 806947
GlobalTracer [baseline] (247.595 ms) : 0, 247595
GlobalTracer [candidate] (249.504 ms) : 0, 249504
IAST [baseline] (30.906 ms) : 0, 30906
IAST [candidate] (33.611 ms) : 0, 33611
AppSec [baseline] (27.904 ms) : 0, 27904
AppSec [candidate] (25.664 ms) : 0, 25664
Debugger [baseline] (6.149 ms) : 0, 6149
Debugger [candidate] (6.194 ms) : 0, 6194
Remote Config [baseline] (606.05 µs) : 0, 606
Remote Config [candidate] (602.524 µs) : 0, 603
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (8.181 ms) : 0, 8181
section profiling
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (727.764 ms) : 0, 727764
BytebuddyAgent [candidate] (718.583 ms) : 0, 718583
GlobalTracer [baseline] (237.799 ms) : 0, 237799
GlobalTracer [candidate] (236.054 ms) : 0, 236054
AppSec [baseline] (31.589 ms) : 0, 31589
AppSec [candidate] (31.065 ms) : 0, 31065
Debugger [baseline] (7.395 ms) : 0, 7395
Debugger [candidate] (6.474 ms) : 0, 6474
Remote Config [baseline] (737.931 µs) : 0, 738
Remote Config [candidate] (706.484 µs) : 0, 706
Telemetry [baseline] (16.085 ms) : 0, 16085
Telemetry [candidate] (16.571 ms) : 0, 16571
ProfilingAgent [baseline] (103.131 ms) : 0, 103131
ProfilingAgent [candidate] (101.489 ms) : 0, 101489
Profiling [baseline] (103.725 ms) : 0, 103725
Profiling [candidate] (102.086 ms) : 0, 102086
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020262
Total [baseline] (8.696 s) : 0, 8695568
Agent [candidate] (1.017 s) : 0, 1017075
Total [candidate] (8.67 s) : 0, 8669780
section iast
Agent [baseline] (1.152 s) : 0, 1152248
Total [baseline] (9.32 s) : 0, 9320282
Agent [candidate] (1.16 s) : 0, 1159845
Total [candidate] (9.351 s) : 0, 9350542
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent iast 1.152 s 131.986 ms (12.9%)
Total tracing 8.696 s -
Total iast 9.32 s 624.713 ms (7.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.017 s -
Agent iast 1.16 s 142.77 ms (14.0%)
Total tracing 8.67 s -
Total iast 9.351 s 680.762 ms (7.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (687.436 ms) : 0, 687436
BytebuddyAgent [candidate] (685.71 ms) : 0, 685710
GlobalTracer [baseline] (257.441 ms) : 0, 257441
GlobalTracer [candidate] (259.631 ms) : 0, 259631
AppSec [baseline] (31.857 ms) : 0, 31857
AppSec [candidate] (31.74 ms) : 0, 31740
Debugger [baseline] (6.361 ms) : 0, 6361
Debugger [candidate] (6.34 ms) : 0, 6340
Remote Config [baseline] (680.417 µs) : 0, 680
Remote Config [candidate] (686.391 µs) : 0, 686
Telemetry [baseline] (14.015 ms) : 0, 14015
Telemetry [candidate] (10.409 ms) : 0, 10409
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (807.072 ms) : 0, 807072
BytebuddyAgent [candidate] (812.505 ms) : 0, 812505
GlobalTracer [baseline] (248.253 ms) : 0, 248253
GlobalTracer [candidate] (250.364 ms) : 0, 250364
IAST [baseline] (29.427 ms) : 0, 29427
IAST [candidate] (29.391 ms) : 0, 29391
AppSec [baseline] (30.058 ms) : 0, 30058
AppSec [candidate] (30.029 ms) : 0, 30029
Debugger [baseline] (6.144 ms) : 0, 6144
Debugger [candidate] (6.097 ms) : 0, 6097
Remote Config [baseline] (604.671 µs) : 0, 605
Remote Config [candidate] (607.792 µs) : 0, 608
Telemetry [baseline] (8.306 ms) : 0, 8306
Telemetry [candidate] (8.278 ms) : 0, 8278
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/no-v1-input-snapshot
git_commit_date 1758557987 1758562186
git_commit_sha 5e2a9e4 f8929f0
release_version 1.54.0-SNAPSHOT~5e2a9e4af6 1.54.0-SNAPSHOT~f8929f0df3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758563662 1758563662
ci_job_id 1141580035 1141580035
ci_pipeline_id 77193934 77193934
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-kf2zea6m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-kf2zea6m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-708.472µs; -400.421µs] or [-7.790%; -4.403%]		 unstable
[-30.637op/s; +96.262op/s] or [-6.004%; +18.865%]		 8.540ms 543.094op/s 9.094ms 510.281op/s
scenario:load:petclinic:profiling:high_load better
[-2.506ms; -1.570ms] or [-5.086%; -3.186%]		 unstable
[-3.309op/s; +11.534op/s] or [-3.483%; +12.142%]		 47.234ms 99.100op/s 49.272ms 94.987op/s
scenario:load:petclinic:code_origins:high_load better
[-2.774ms; -1.956ms] or [-5.984%; -4.218%]		 unstable
[-2.141op/s; +12.966op/s] or [-2.121%; +12.844%]		 43.993ms 106.362op/s 46.358ms 100.950op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.355 ms) : 4300, 4411
.   : milestone, 4355,
iast (10.025 ms) : 9855, 10195
.   : milestone, 10025,
iast_FULL (14.866 ms) : 14567, 15164
.   : milestone, 14866,
iast_GLOBAL (10.902 ms) : 10707, 11096
.   : milestone, 10902,
profiling (9.094 ms) : 8949, 9239
.   : milestone, 9094,
tracing (7.557 ms) : 7435, 7679
.   : milestone, 7557,
section candidate
no_agent (4.362 ms) : 4313, 4412
.   : milestone, 4362,
iast (10.141 ms) : 9967, 10316
.   : milestone, 10141,
iast_FULL (14.996 ms) : 14698, 15294
.   : milestone, 14996,
iast_GLOBAL (10.965 ms) : 10769, 11161
.   : milestone, 10965,
profiling (8.54 ms) : 8399, 8681
.   : milestone, 8540,
tracing (7.812 ms) : 7701, 7924
.   : milestone, 7812,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.355 ms [4.3 ms, 4.411 ms] -
iast 10.025 ms [9.855 ms, 10.195 ms] 5.67 ms (130.2%)
iast_FULL 14.866 ms [14.567 ms, 15.164 ms] 10.51 ms (241.3%)
iast_GLOBAL 10.902 ms [10.707 ms, 11.096 ms] 6.546 ms (150.3%)
profiling 9.094 ms [8.949 ms, 9.239 ms] 4.739 ms (108.8%)
tracing 7.557 ms [7.435 ms, 7.679 ms] 3.202 ms (73.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.362 ms [4.313 ms, 4.412 ms] -
iast 10.141 ms [9.967 ms, 10.316 ms] 5.779 ms (132.5%)
iast_FULL 14.996 ms [14.698 ms, 15.294 ms] 10.634 ms (243.8%)
iast_GLOBAL 10.965 ms [10.769 ms, 11.161 ms] 6.603 ms (151.4%)
profiling 8.54 ms [8.399 ms, 8.681 ms] 4.177 ms (95.8%)
tracing 7.812 ms [7.701 ms, 7.924 ms] 3.45 ms (79.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.857 ms) : 36560, 37153
.   : milestone, 36857,
appsec (48.729 ms) : 48301, 49157
.   : milestone, 48729,
code_origins (46.358 ms) : 45977, 46739
.   : milestone, 46358,
iast (44.851 ms) : 44454, 45248
.   : milestone, 44851,
profiling (49.272 ms) : 48834, 49710
.   : milestone, 49272,
tracing (43.934 ms) : 43549, 44320
.   : milestone, 43934,
section candidate
no_agent (37.789 ms) : 37483, 38094
.   : milestone, 37789,
appsec (48.598 ms) : 48157, 49039
.   : milestone, 48598,
code_origins (43.993 ms) : 43614, 44373
.   : milestone, 43993,
iast (44.02 ms) : 43640, 44401
.   : milestone, 44020,
profiling (47.234 ms) : 46802, 47666
.   : milestone, 47234,
tracing (45.088 ms) : 44697, 45478
.   : milestone, 45088,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.857 ms [36.56 ms, 37.153 ms] -
appsec 48.729 ms [48.301 ms, 49.157 ms] 11.873 ms (32.2%)
code_origins 46.358 ms [45.977 ms, 46.739 ms] 9.502 ms (25.8%)
iast 44.851 ms [44.454 ms, 45.248 ms] 7.995 ms (21.7%)
profiling 49.272 ms [48.834 ms, 49.71 ms] 12.416 ms (33.7%)
tracing 43.934 ms [43.549 ms, 44.32 ms] 7.078 ms (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.789 ms [37.483 ms, 38.094 ms] -
appsec 48.598 ms [48.157 ms, 49.039 ms] 10.81 ms (28.6%)
code_origins 43.993 ms [43.614 ms, 44.373 ms] 6.205 ms (16.4%)
iast 44.02 ms [43.64 ms, 44.401 ms] 6.232 ms (16.5%)
profiling 47.234 ms [46.802 ms, 47.666 ms] 9.446 ms (25.0%)
tracing 45.088 ms [44.697 ms, 45.478 ms] 7.299 ms (19.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/no-v1-input-snapshot
git_commit_date 1758557987 1758562186
git_commit_sha 5e2a9e4 f8929f0
release_version 1.54.0-SNAPSHOT~5e2a9e4af6 1.54.0-SNAPSHOT~f8929f0df3
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1758564240 1758564240
ci_job_id 1141580036 1141580036
ci_pipeline_id 77193934 77193934
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-2rrruimw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-2rrruimw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.865 s) : 14865000, 14865000
.   : milestone, 14865000,
appsec (15.26 s) : 15260000, 15260000
.   : milestone, 15260000,
iast (18.383 s) : 18383000, 18383000
.   : milestone, 18383000,
iast_GLOBAL (18.371 s) : 18371000, 18371000
.   : milestone, 18371000,
profiling (15.424 s) : 15424000, 15424000
.   : milestone, 15424000,
tracing (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
section candidate
no_agent (14.895 s) : 14895000, 14895000
.   : milestone, 14895000,
appsec (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
iast (18.6 s) : 18600000, 18600000
.   : milestone, 18600000,
iast_GLOBAL (17.823 s) : 17823000, 17823000
.   : milestone, 17823000,
profiling (15.508 s) : 15508000, 15508000
.   : milestone, 15508000,
tracing (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.865 s [14.865 s, 14.865 s] -
appsec 15.26 s [15.26 s, 15.26 s] 395.0 ms (2.7%)
iast 18.383 s [18.383 s, 18.383 s] 3.518 s (23.7%)
iast_GLOBAL 18.371 s [18.371 s, 18.371 s] 3.506 s (23.6%)
profiling 15.424 s [15.424 s, 15.424 s] 559.0 ms (3.8%)
tracing 15.178 s [15.178 s, 15.178 s] 313.0 ms (2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.895 s [14.895 s, 14.895 s] -
appsec 14.98 s [14.98 s, 14.98 s] 85.0 ms (0.6%)
iast 18.6 s [18.6 s, 18.6 s] 3.705 s (24.9%)
iast_GLOBAL 17.823 s [17.823 s, 17.823 s] 2.928 s (19.7%)
profiling 15.508 s [15.508 s, 15.508 s] 613.0 ms (4.1%)
tracing 15.138 s [15.138 s, 15.138 s] 243.0 ms (1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~f8929f0df3, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.485 ms) : 1474, 1497
.   : milestone, 1485,
appsec (3.741 ms) : 3522, 3960
.   : milestone, 3741,
iast (2.223 ms) : 2160, 2285
.   : milestone, 2223,
iast_GLOBAL (2.25 ms) : 2187, 2313
.   : milestone, 2250,
profiling (2.064 ms) : 2014, 2115
.   : milestone, 2064,
tracing (2.037 ms) : 1988, 2086
.   : milestone, 2037,
section candidate
no_agent (1.486 ms) : 1474, 1497
.   : milestone, 1486,
appsec (3.714 ms) : 3492, 3936
.   : milestone, 3714,
iast (2.216 ms) : 2153, 2279
.   : milestone, 2216,
iast_GLOBAL (2.257 ms) : 2195, 2320
.   : milestone, 2257,
profiling (2.08 ms) : 2028, 2132
.   : milestone, 2080,
tracing (2.038 ms) : 1989, 2087
.   : milestone, 2038,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.485 ms [1.474 ms, 1.497 ms] -
appsec 3.741 ms [3.522 ms, 3.96 ms] 2.256 ms (151.9%)
iast 2.223 ms [2.16 ms, 2.285 ms] 737.412 µs (49.7%)
iast_GLOBAL 2.25 ms [2.187 ms, 2.313 ms] 765.114 µs (51.5%)
profiling 2.064 ms [2.014 ms, 2.115 ms] 579.005 µs (39.0%)
tracing 2.037 ms [1.988 ms, 2.086 ms] 551.865 µs (37.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.486 ms [1.474 ms, 1.497 ms] -
appsec 3.714 ms [3.492 ms, 3.936 ms] 2.229 ms (150.0%)
iast 2.216 ms [2.153 ms, 2.279 ms] 730.765 µs (49.2%)
iast_GLOBAL 2.257 ms [2.195 ms, 2.32 ms] 771.708 µs (51.9%)
profiling 2.08 ms [2.028 ms, 2.132 ms] 594.334 µs (40.0%)
tracing 2.038 ms [1.989 ms, 2.087 ms] 552.673 µs (37.2%)

@jpbempel
Prevent using v1/input endpoint for snapshots
eac689d 
snapshots should always send to DEBUGGER track through v2/input or
v1/diagnostics endpoints. v1/input is unredacted.
v1/diagnostics endpoint was introduced since DD agent 7.49
@jpbempel
fix tests
9fab460
@jpbempel jpbempel force-pushed the jpbempel/no-v1-input-snapshot branch from 3c857de to 9fab460 Compare September 22, 2025 08:41
@jpbempel jpbempel merged commit abac8af into master Sep 22, 2025
552 checks passed
@jpbempel jpbempel deleted the jpbempel/no-v1-input-snapshot branch September 22, 2025 18:36
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement Enhancements and improvements
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi