-
Notifications
You must be signed in to change notification settings - Fork 312
fix slo warnings #9570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix slo warnings #9570
Conversation
🎯 Code Coverage 🔗 Commit SHA: cfb3286 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022615
Total [baseline] (10.693 s) : 0, 10693336
Agent [candidate] (1.037 s) : 0, 1036586
Total [candidate] (10.753 s) : 0, 10752595
section appsec
Agent [baseline] (1.198 s) : 0, 1197685
Total [baseline] (11.063 s) : 0, 11062666
Agent [candidate] (1.201 s) : 0, 1200582
Total [candidate] (11.051 s) : 0, 11050627
section iast
Agent [baseline] (1.151 s) : 0, 1151499
Total [baseline] (11.024 s) : 0, 11024165
Agent [candidate] (1.158 s) : 0, 1157552
Total [candidate] (11.071 s) : 0, 11070570
section profiling
Agent [baseline] (1.165 s) : 0, 1165350
Total [baseline] (11.056 s) : 0, 11055608
Agent [candidate] (1.165 s) : 0, 1165155
Total [candidate] (10.988 s) : 0, 10988436
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (689.629 ms) : 0, 689629
BytebuddyAgent [candidate] (696.491 ms) : 0, 696491
GlobalTracer [baseline] (258.677 ms) : 0, 258677
GlobalTracer [candidate] (262.292 ms) : 0, 262292
AppSec [baseline] (31.601 ms) : 0, 31601
AppSec [candidate] (32.228 ms) : 0, 32228
Debugger [baseline] (6.319 ms) : 0, 6319
Debugger [candidate] (6.429 ms) : 0, 6429
Remote Config [baseline] (680.352 µs) : 0, 680
Remote Config [candidate] (695.382 µs) : 0, 695
Telemetry [baseline] (13.138 ms) : 0, 13138
Telemetry [candidate] (15.78 ms) : 0, 15780
section appsec
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (711.298 ms) : 0, 711298
BytebuddyAgent [candidate] (711.65 ms) : 0, 711650
GlobalTracer [baseline] (251.387 ms) : 0, 251387
GlobalTracer [candidate] (252.727 ms) : 0, 252727
AppSec [baseline] (170.869 ms) : 0, 170869
AppSec [candidate] (173.346 ms) : 0, 173346
Debugger [baseline] (6.076 ms) : 0, 6076
Debugger [candidate] (6.082 ms) : 0, 6082
Remote Config [baseline] (623.44 µs) : 0, 623
Remote Config [candidate] (629.1 µs) : 0, 629
Telemetry [baseline] (9.825 ms) : 0, 9825
Telemetry [candidate] (8.4 ms) : 0, 8400
IAST [baseline] (25.067 ms) : 0, 25067
IAST [candidate] (25.225 ms) : 0, 25225
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (806.64 ms) : 0, 806640
BytebuddyAgent [candidate] (811.152 ms) : 0, 811152
GlobalTracer [baseline] (248.981 ms) : 0, 248981
GlobalTracer [candidate] (250.262 ms) : 0, 250262
AppSec [baseline] (29.568 ms) : 0, 29568
AppSec [candidate] (27.937 ms) : 0, 27937
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (6.101 ms) : 0, 6101
Remote Config [baseline] (588.905 µs) : 0, 589
Remote Config [candidate] (598.551 µs) : 0, 599
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.178 ms) : 0, 8178
IAST [baseline] (29.11 ms) : 0, 29110
IAST [candidate] (30.835 ms) : 0, 30835
section profiling
ProfilingAgent [baseline] (101.742 ms) : 0, 101742
ProfilingAgent [candidate] (101.388 ms) : 0, 101388
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (720.129 ms) : 0, 720129
BytebuddyAgent [candidate] (719.178 ms) : 0, 719178
GlobalTracer [baseline] (236.068 ms) : 0, 236068
GlobalTracer [candidate] (237.308 ms) : 0, 237308
AppSec [baseline] (31.129 ms) : 0, 31129
AppSec [candidate] (31.162 ms) : 0, 31162
Debugger [baseline] (6.497 ms) : 0, 6497
Debugger [candidate] (6.526 ms) : 0, 6526
Remote Config [baseline] (694.951 µs) : 0, 695
Remote Config [candidate] (699.97 µs) : 0, 700
Telemetry [baseline] (16.55 ms) : 0, 16550
Telemetry [candidate] (16.442 ms) : 0, 16442
Profiling [baseline] (102.337 ms) : 0, 102337
Profiling [candidate] (101.985 ms) : 0, 101985
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022094
Total [baseline] (8.657 s) : 0, 8656822
Agent [candidate] (1.02 s) : 0, 1019996
Total [candidate] (8.66 s) : 0, 8660479
section iast
Agent [baseline] (1.156 s) : 0, 1156488
Total [baseline] (9.359 s) : 0, 9358676
Agent [candidate] (1.154 s) : 0, 1154229
Total [candidate] (9.385 s) : 0, 9384628
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (689.281 ms) : 0, 689281
BytebuddyAgent [candidate] (686.113 ms) : 0, 686113
GlobalTracer [baseline] (258.996 ms) : 0, 258996
GlobalTracer [candidate] (258.693 ms) : 0, 258693
AppSec [baseline] (31.732 ms) : 0, 31732
AppSec [candidate] (31.578 ms) : 0, 31578
Debugger [baseline] (6.349 ms) : 0, 6349
Debugger [candidate] (6.326 ms) : 0, 6326
Remote Config [baseline] (683.659 µs) : 0, 684
Remote Config [candidate] (681.029 µs) : 0, 681
Telemetry [baseline] (12.65 ms) : 0, 12650
Telemetry [candidate] (14.158 ms) : 0, 14158
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (811.528 ms) : 0, 811528
BytebuddyAgent [candidate] (808.715 ms) : 0, 808715
GlobalTracer [baseline] (248.727 ms) : 0, 248727
GlobalTracer [candidate] (249.458 ms) : 0, 249458
AppSec [baseline] (29.746 ms) : 0, 29746
AppSec [candidate] (28.868 ms) : 0, 28868
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.075 ms) : 0, 6075
Remote Config [baseline] (593.931 µs) : 0, 594
Remote Config [candidate] (590.551 µs) : 0, 591
Telemetry [baseline] (8.194 ms) : 0, 8194
Telemetry [candidate] (8.117 ms) : 0, 8117
IAST [baseline] (29.084 ms) : 0, 29084
IAST [candidate] (29.977 ms) : 0, 29977
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 5 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section baseline
no_agent (4.277 ms) : 4229, 4324
. : milestone, 4277,
iast (9.889 ms) : 9724, 10055
. : milestone, 9889,
iast_FULL (14.401 ms) : 14116, 14686
. : milestone, 14401,
iast_GLOBAL (10.596 ms) : 10407, 10786
. : milestone, 10596,
profiling (9.023 ms) : 8881, 9165
. : milestone, 9023,
tracing (7.907 ms) : 7784, 8029
. : milestone, 7907,
section candidate
no_agent (4.386 ms) : 4336, 4436
. : milestone, 4386,
iast (10.255 ms) : 10099, 10411
. : milestone, 10255,
iast_FULL (15.471 ms) : 15196, 15747
. : milestone, 15471,
iast_GLOBAL (10.83 ms) : 10658, 11001
. : milestone, 10830,
profiling (9.557 ms) : 9420, 9694
. : milestone, 9557,
tracing (8.332 ms) : 8221, 8442
. : milestone, 8332,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section baseline
no_agent (37.472 ms) : 37160, 37783
. : milestone, 37472,
appsec (47.533 ms) : 47135, 47931
. : milestone, 47533,
code_origins (46.243 ms) : 45844, 46642
. : milestone, 46243,
iast (44.327 ms) : 43942, 44712
. : milestone, 44327,
profiling (50.479 ms) : 50002, 50956
. : milestone, 50479,
tracing (46.82 ms) : 46413, 47227
. : milestone, 46820,
section candidate
no_agent (36.742 ms) : 36443, 37042
. : milestone, 36742,
appsec (48.318 ms) : 47896, 48741
. : milestone, 48318,
code_origins (48.506 ms) : 48101, 48910
. : milestone, 48506,
iast (46.32 ms) : 45931, 46708
. : milestone, 46320,
profiling (50.405 ms) : 49952, 50858
. : milestone, 50405,
tracing (44.128 ms) : 43758, 44498
. : milestone, 44128,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.716 ms) : 3498, 3935
. : milestone, 3716,
iast (2.18 ms) : 2118, 2242
. : milestone, 2180,
iast_GLOBAL (2.243 ms) : 2181, 2306
. : milestone, 2243,
profiling (2.068 ms) : 2017, 2120
. : milestone, 2068,
tracing (2.021 ms) : 1972, 2069
. : milestone, 2021,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.715 ms) : 3498, 3933
. : milestone, 3715,
iast (2.198 ms) : 2136, 2261
. : milestone, 2198,
iast_GLOBAL (2.235 ms) : 2172, 2298
. : milestone, 2235,
profiling (2.066 ms) : 2013, 2118
. : milestone, 2066,
tracing (2.021 ms) : 1972, 2069
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~cfb3286950, baseline=1.54.0-SNAPSHOT~56fa28c56e
dateFormat X
axisFormat %s
section baseline
no_agent (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
appsec (15.27 s) : 15270000, 15270000
. : milestone, 15270000,
iast (18.996 s) : 18996000, 18996000
. : milestone, 18996000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (15.27 s) : 15270000, 15270000
. : milestone, 15270000,
tracing (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
section candidate
no_agent (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
appsec (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
iast (18.629 s) : 18629000, 18629000
. : milestone, 18629000,
iast_GLOBAL (18.163 s) : 18163000, 18163000
. : milestone, 18163000,
profiling (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
tracing (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
|
5365c9f
to
eac5933
Compare
final class Aggregator implements Runnable { | ||
|
||
private static final long DEFAULT_SLEEP_MILLIS = 10; | ||
private static final long DEFAULT_SLEEP_MILLIS = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious how value of 1
was selected?
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]