-
Notifications
You must be signed in to change notification settings - Fork 312
Adding supported-configurations.json file #9563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
🎯 Code Coverage 🔗 Commit SHA: e78fb9e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025921
Total [baseline] (8.712 s) : 0, 8711977
Agent [candidate] (1.019 s) : 0, 1019469
Total [candidate] (8.603 s) : 0, 8602653
section iast
Agent [baseline] (1.159 s) : 0, 1159098
Total [baseline] (9.366 s) : 0, 9365758
Agent [candidate] (1.157 s) : 0, 1157343
Total [candidate] (9.378 s) : 0, 9377672
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (692.093 ms) : 0, 692093
BytebuddyAgent [candidate] (687.877 ms) : 0, 687877
GlobalTracer [baseline] (259.407 ms) : 0, 259407
GlobalTracer [candidate] (257.273 ms) : 0, 257273
AppSec [baseline] (31.982 ms) : 0, 31982
AppSec [candidate] (31.586 ms) : 0, 31586
Debugger [baseline] (6.358 ms) : 0, 6358
Debugger [candidate] (6.332 ms) : 0, 6332
Remote Config [baseline] (686.235 µs) : 0, 686
Remote Config [candidate] (685.381 µs) : 0, 685
Telemetry [baseline] (12.864 ms) : 0, 12864
Telemetry [candidate] (13.323 ms) : 0, 13323
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (812.715 ms) : 0, 812715
BytebuddyAgent [candidate] (812.84 ms) : 0, 812840
GlobalTracer [baseline] (248.846 ms) : 0, 248846
GlobalTracer [candidate] (248.258 ms) : 0, 248258
AppSec [baseline] (29.373 ms) : 0, 29373
AppSec [candidate] (29.738 ms) : 0, 29738
Debugger [baseline] (6.247 ms) : 0, 6247
Debugger [candidate] (6.102 ms) : 0, 6102
Remote Config [baseline] (626.44 µs) : 0, 626
Remote Config [candidate] (598.933 µs) : 0, 599
Telemetry [baseline] (8.49 ms) : 0, 8490
Telemetry [candidate] (8.171 ms) : 0, 8171
IAST [baseline] (30.293 ms) : 0, 30293
IAST [candidate] (29.166 ms) : 0, 29166
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019369
Total [baseline] (10.733 s) : 0, 10732818
Agent [candidate] (1.02 s) : 0, 1019938
Total [candidate] (10.656 s) : 0, 10655720
section appsec
Agent [baseline] (1.205 s) : 0, 1204544
Total [baseline] (10.962 s) : 0, 10961597
Agent [candidate] (1.198 s) : 0, 1198184
Total [candidate] (10.903 s) : 0, 10903400
section iast
Agent [baseline] (1.152 s) : 0, 1152344
Total [baseline] (11.103 s) : 0, 11103458
Agent [candidate] (1.152 s) : 0, 1151915
Total [candidate] (11.083 s) : 0, 11082837
section profiling
Agent [baseline] (1.168 s) : 0, 1167526
Total [baseline] (11.096 s) : 0, 11095614
Agent [candidate] (1.16 s) : 0, 1160214
Total [candidate] (11.013 s) : 0, 11013303
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (687.336 ms) : 0, 687336
BytebuddyAgent [candidate] (687.307 ms) : 0, 687307
GlobalTracer [baseline] (257.375 ms) : 0, 257375
GlobalTracer [candidate] (257.421 ms) : 0, 257421
AppSec [baseline] (31.739 ms) : 0, 31739
AppSec [candidate] (31.595 ms) : 0, 31595
Debugger [baseline] (6.351 ms) : 0, 6351
Debugger [candidate] (6.323 ms) : 0, 6323
Remote Config [baseline] (693.794 µs) : 0, 694
Remote Config [candidate] (670.369 µs) : 0, 670
Telemetry [baseline] (13.351 ms) : 0, 13351
Telemetry [candidate] (14.127 ms) : 0, 14127
section appsec
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (717.03 ms) : 0, 717030
BytebuddyAgent [candidate] (713.414 ms) : 0, 713414
GlobalTracer [baseline] (251.401 ms) : 0, 251401
GlobalTracer [candidate] (249.789 ms) : 0, 249789
AppSec [baseline] (171.569 ms) : 0, 171569
AppSec [candidate] (172.424 ms) : 0, 172424
Debugger [baseline] (6.073 ms) : 0, 6073
Debugger [candidate] (5.999 ms) : 0, 5999
Remote Config [baseline] (602.841 µs) : 0, 603
Remote Config [candidate] (610.271 µs) : 0, 610
Telemetry [baseline] (9.95 ms) : 0, 9950
Telemetry [candidate] (8.404 ms) : 0, 8404
IAST [baseline] (25.164 ms) : 0, 25164
IAST [candidate] (24.961 ms) : 0, 24961
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (807.996 ms) : 0, 807996
BytebuddyAgent [candidate] (807.789 ms) : 0, 807789
GlobalTracer [baseline] (247.839 ms) : 0, 247839
GlobalTracer [candidate] (247.652 ms) : 0, 247652
AppSec [baseline] (29.692 ms) : 0, 29692
AppSec [candidate] (29.838 ms) : 0, 29838
Debugger [baseline] (6.117 ms) : 0, 6117
Debugger [candidate] (6.136 ms) : 0, 6136
Remote Config [baseline] (594.874 µs) : 0, 595
Remote Config [candidate] (588.072 µs) : 0, 588
Telemetry [baseline] (8.323 ms) : 0, 8323
Telemetry [candidate] (8.196 ms) : 0, 8196
IAST [baseline] (29.33 ms) : 0, 29330
IAST [candidate] (29.281 ms) : 0, 29281
section profiling
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (721.214 ms) : 0, 721214
BytebuddyAgent [candidate] (717.583 ms) : 0, 717583
GlobalTracer [baseline] (235.878 ms) : 0, 235878
GlobalTracer [candidate] (234.392 ms) : 0, 234392
AppSec [baseline] (31.338 ms) : 0, 31338
AppSec [candidate] (31.087 ms) : 0, 31087
Debugger [baseline] (6.542 ms) : 0, 6542
Debugger [candidate] (6.477 ms) : 0, 6477
Remote Config [baseline] (716.583 µs) : 0, 717
Remote Config [candidate] (710.88 µs) : 0, 711
Telemetry [baseline] (16.692 ms) : 0, 16692
Telemetry [candidate] (16.437 ms) : 0, 16437
ProfilingAgent [baseline] (102.637 ms) : 0, 102637
ProfilingAgent [candidate] (101.123 ms) : 0, 101123
Profiling [baseline] (103.232 ms) : 0, 103232
Profiling [candidate] (101.75 ms) : 0, 101750
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section baseline
no_agent (4.493 ms) : 4442, 4544
. : milestone, 4493,
iast (9.521 ms) : 9362, 9679
. : milestone, 9521,
iast_FULL (14.083 ms) : 13808, 14358
. : milestone, 14083,
iast_GLOBAL (11.085 ms) : 10870, 11301
. : milestone, 11085,
profiling (9.253 ms) : 9083, 9422
. : milestone, 9253,
tracing (7.863 ms) : 7751, 7976
. : milestone, 7863,
section candidate
no_agent (4.54 ms) : 4488, 4592
. : milestone, 4540,
iast (9.473 ms) : 9315, 9630
. : milestone, 9473,
iast_FULL (14.299 ms) : 14012, 14585
. : milestone, 14299,
iast_GLOBAL (10.628 ms) : 10438, 10818
. : milestone, 10628,
profiling (9.097 ms) : 8947, 9247
. : milestone, 9097,
tracing (7.759 ms) : 7648, 7869
. : milestone, 7759,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section baseline
no_agent (36.591 ms) : 36293, 36890
. : milestone, 36591,
appsec (51.875 ms) : 51416, 52334
. : milestone, 51875,
code_origins (44.002 ms) : 43631, 44372
. : milestone, 44002,
iast (46.039 ms) : 45633, 46445
. : milestone, 46039,
profiling (50.455 ms) : 50008, 50901
. : milestone, 50455,
tracing (44.087 ms) : 43706, 44468
. : milestone, 44087,
section candidate
no_agent (36.915 ms) : 36608, 37221
. : milestone, 36915,
appsec (48.018 ms) : 47604, 48432
. : milestone, 48018,
code_origins (44.728 ms) : 44348, 45109
. : milestone, 44728,
iast (45.981 ms) : 45581, 46381
. : milestone, 45981,
profiling (47.306 ms) : 46868, 47743
. : milestone, 47306,
tracing (45.385 ms) : 44982, 45789
. : milestone, 45385,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section baseline
no_agent (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
appsec (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
iast (18.421 s) : 18421000, 18421000
. : milestone, 18421000,
iast_GLOBAL (18.019 s) : 18019000, 18019000
. : milestone, 18019000,
profiling (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
tracing (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
section candidate
no_agent (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
appsec (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
iast (18.33 s) : 18330000, 18330000
. : milestone, 18330000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
. : milestone, 17830000,
profiling (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
tracing (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e78fb9eeb4, baseline=1.54.0-SNAPSHOT~5e2a9e4af6
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.718 ms) : 3499, 3937
. : milestone, 3718,
iast (2.205 ms) : 2142, 2268
. : milestone, 2205,
iast_GLOBAL (2.265 ms) : 2201, 2328
. : milestone, 2265,
profiling (2.082 ms) : 2029, 2135
. : milestone, 2082,
tracing (2.044 ms) : 1994, 2093
. : milestone, 2044,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.643 ms) : 3430, 3856
. : milestone, 3643,
iast (2.21 ms) : 2147, 2273
. : milestone, 2210,
iast_GLOBAL (2.26 ms) : 2197, 2324
. : milestone, 2260,
profiling (2.074 ms) : 2023, 2125
. : milestone, 2074,
tracing (2.04 ms) : 1991, 2090
. : milestone, 2040,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ question: If adding the config metadata into Java resources default location requires some extra gradle setup, why not put such file into the /metadata
folder?
Its usage is not strictly defined but for now, it welcomes extra data needed for the project, and for now is limited to SSI / OCI / Injector.
But as you only use the JSON file from the project build plugin, the JSON config metadata should fit nicely with the injector metadata. WDYT?
This is great actually. It also prevents the file from being added to the shadow jars, so I don't need to do extra work to restrict it manually :) |
What Does This Do
This PR adds the supported-configurations file that will be used in #9539 for Config Inversion. The file documents all supported environment variables in the tracer, as well as aliases and deprecations. This PR also excludes the json file from the shadow jar.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]