Prepare for JEP 500 #9557
Draft
Prepare for JEP 500 #9557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎯 Code Coverage 🔗 Commit SHA: 5ad4f5e | Docs | Was this helpful? Give us feedback! |
PerfectSlayer
force-pushed
the
bbujon/jep500
branch
from
d2219bc to
5c24855
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063084
Total [baseline] (10.762 s) : 0, 10762083
Agent [candidate] (1.063 s) : 0, 1062562
Total [candidate] (10.722 s) : 0, 10722117
section appsec
Agent [baseline] (1.237 s) : 0, 1237268
Total [baseline] (11.059 s) : 0, 11058951
Agent [candidate] (1.236 s) : 0, 1236141
Total [candidate] (11.173 s) : 0, 11172725
section iast
Agent [baseline] (1.193 s) : 0, 1193338
Total [baseline] (11.109 s) : 0, 11109324
Agent [candidate] (1.192 s) : 0, 1191837
Total [candidate] (11.127 s) : 0, 11127084
section profiling
Agent [baseline] (1.209 s) : 0, 1209122
Total [baseline] (10.872 s) : 0, 10871556
Agent [candidate] (1.218 s) : 0, 1218252
Total [candidate] (10.986 s) : 0, 10986105
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (733.593 ms) : 0, 733593
BytebuddyAgent [candidate] (732.927 ms) : 0, 732927
GlobalTracer [baseline] (253.002 ms) : 0, 253002
GlobalTracer [candidate] (253.034 ms) : 0, 253034
AppSec [baseline] (30.642 ms) : 0, 30642
AppSec [candidate] (30.668 ms) : 0, 30668
Debugger [baseline] (6.395 ms) : 0, 6395
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (703.518 µs) : 0, 704
Remote Config [candidate] (698.111 µs) : 0, 698
Telemetry [baseline] (16.164 ms) : 0, 16164
Telemetry [candidate] (16.256 ms) : 0, 16256
section appsec
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (757.339 ms) : 0, 757339
BytebuddyAgent [candidate] (756.566 ms) : 0, 756566
GlobalTracer [baseline] (246.383 ms) : 0, 246383
GlobalTracer [candidate] (246.126 ms) : 0, 246126
AppSec [baseline] (171.848 ms) : 0, 171848
AppSec [candidate] (171.869 ms) : 0, 171869
Debugger [baseline] (5.967 ms) : 0, 5967
Debugger [candidate] (5.981 ms) : 0, 5981
Remote Config [baseline] (621.098 µs) : 0, 621
Remote Config [candidate] (628.112 µs) : 0, 628
Telemetry [baseline] (8.533 ms) : 0, 8533
Telemetry [candidate] (8.565 ms) : 0, 8565
IAST [baseline] (23.857 ms) : 0, 23857
IAST [candidate] (23.676 ms) : 0, 23676
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (854.177 ms) : 0, 854177
BytebuddyAgent [candidate] (852.863 ms) : 0, 852863
GlobalTracer [baseline] (246.532 ms) : 0, 246532
GlobalTracer [candidate] (245.704 ms) : 0, 245704
AppSec [baseline] (25.49 ms) : 0, 25490
AppSec [candidate] (26.388 ms) : 0, 26388
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.022 ms) : 0, 6022
Remote Config [baseline] (605.091 µs) : 0, 605
Remote Config [candidate] (592.174 µs) : 0, 592
Telemetry [baseline] (8.229 ms) : 0, 8229
Telemetry [candidate] (8.205 ms) : 0, 8205
IAST [baseline] (29.795 ms) : 0, 29795
IAST [candidate] (29.425 ms) : 0, 29425
section profiling
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (760.916 ms) : 0, 760916
BytebuddyAgent [candidate] (766.723 ms) : 0, 766723
GlobalTracer [baseline] (232.547 ms) : 0, 232547
GlobalTracer [candidate] (234.668 ms) : 0, 234668
AppSec [baseline] (32.735 ms) : 0, 32735
AppSec [candidate] (30.688 ms) : 0, 30688
Debugger [baseline] (10.619 ms) : 0, 10619
Debugger [candidate] (12.329 ms) : 0, 12329
Remote Config [baseline] (2.316 ms) : 0, 2316
Remote Config [candidate] (729.696 µs) : 0, 730
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (11.167 ms) : 0, 11167
ProfilingAgent [baseline] (108.603 ms) : 0, 108603
ProfilingAgent [candidate] (108.77 ms) : 0, 108770
Profiling [baseline] (109.227 ms) : 0, 109227
Profiling [candidate] (109.415 ms) : 0, 109415
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076971
Total [baseline] (8.727 s) : 0, 8727156
Agent [candidate] (1.064 s) : 0, 1064023
Total [candidate] (8.655 s) : 0, 8654568
section iast
Agent [baseline] (1.19 s) : 0, 1190498
Total [baseline] (9.321 s) : 0, 9320957
Agent [candidate] (1.188 s) : 0, 1188096
Total [candidate] (9.332 s) : 0, 9331754
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (743.085 ms) : 0, 743085
BytebuddyAgent [candidate] (733.421 ms) : 0, 733421
GlobalTracer [baseline] (256.184 ms) : 0, 256184
GlobalTracer [candidate] (253.857 ms) : 0, 253857
AppSec [baseline] (31.224 ms) : 0, 31224
AppSec [candidate] (30.76 ms) : 0, 30760
Debugger [baseline] (6.511 ms) : 0, 6511
Debugger [candidate] (6.471 ms) : 0, 6471
Remote Config [baseline] (717.43 µs) : 0, 717
Remote Config [candidate] (700.324 µs) : 0, 700
Telemetry [baseline] (16.503 ms) : 0, 16503
Telemetry [candidate] (16.395 ms) : 0, 16395
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (851.802 ms) : 0, 851802
BytebuddyAgent [candidate] (850.38 ms) : 0, 850380
GlobalTracer [baseline] (247.6 ms) : 0, 247600
GlobalTracer [candidate] (246.439 ms) : 0, 246439
AppSec [baseline] (25.532 ms) : 0, 25532
AppSec [candidate] (24.625 ms) : 0, 24625
Debugger [baseline] (6.086 ms) : 0, 6086
Debugger [candidate] (6.075 ms) : 0, 6075
Remote Config [baseline] (597.698 µs) : 0, 598
Remote Config [candidate] (592.426 µs) : 0, 592
Telemetry [baseline] (8.265 ms) : 0, 8265
Telemetry [candidate] (8.239 ms) : 0, 8239
IAST [baseline] (28.145 ms) : 0, 28145
IAST [candidate] (29.39 ms) : 0, 29390
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (37.853 ms) : 37552, 38155
. : milestone, 37853,
appsec (51.375 ms) : 50923, 51828
. : milestone, 51375,
code_origins (46.561 ms) : 46167, 46954
. : milestone, 46561,
iast (44.223 ms) : 43846, 44599
. : milestone, 44223,
profiling (49.547 ms) : 49075, 50018
. : milestone, 49547,
tracing (45.432 ms) : 45052, 45813
. : milestone, 45432,
section candidate
no_agent (36.745 ms) : 36450, 37041
. : milestone, 36745,
appsec (49.11 ms) : 48687, 49533
. : milestone, 49110,
code_origins (46.452 ms) : 46034, 46870
. : milestone, 46452,
iast (44.669 ms) : 44284, 45055
. : milestone, 44669,
profiling (48.752 ms) : 48296, 49208
. : milestone, 48752,
tracing (45.502 ms) : 45118, 45885
. : milestone, 45502,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (4.445 ms) : 4394, 4495
. : milestone, 4445,
iast (9.594 ms) : 9424, 9763
. : milestone, 9594,
iast_FULL (14.127 ms) : 13842, 14412
. : milestone, 14127,
iast_GLOBAL (10.452 ms) : 10271, 10634
. : milestone, 10452,
profiling (9.018 ms) : 8877, 9160
. : milestone, 9018,
tracing (7.813 ms) : 7694, 7931
. : milestone, 7813,
section candidate
no_agent (4.419 ms) : 4369, 4469
. : milestone, 4419,
iast (9.369 ms) : 9217, 9520
. : milestone, 9369,
iast_FULL (14.162 ms) : 13880, 14444
. : milestone, 14162,
iast_GLOBAL (10.489 ms) : 10301, 10677
. : milestone, 10489,
profiling (8.713 ms) : 8578, 8848
. : milestone, 8713,
tracing (7.728 ms) : 7620, 7836
. : milestone, 7728,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.764 ms) : 3544, 3983
. : milestone, 3764,
iast (2.209 ms) : 2146, 2272
. : milestone, 2209,
iast_GLOBAL (2.252 ms) : 2189, 2316
. : milestone, 2252,
profiling (2.081 ms) : 2029, 2133
. : milestone, 2081,
tracing (2.036 ms) : 1986, 2085
. : milestone, 2036,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.67 ms) : 3456, 3885
. : milestone, 3670,
iast (2.216 ms) : 2153, 2280
. : milestone, 2216,
iast_GLOBAL (2.249 ms) : 2186, 2313
. : milestone, 2249,
profiling (2.499 ms) : 2331, 2667
. : milestone, 2499,
tracing (2.037 ms) : 1987, 2086
. : milestone, 2037,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~5ad4f5ee26, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (15.619 s) : 15619000, 15619000
. : milestone, 15619000,
appsec (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
iast (18.123 s) : 18123000, 18123000
. : milestone, 18123000,
iast_GLOBAL (18.053 s) : 18053000, 18053000
. : milestone, 18053000,
profiling (15.412 s) : 15412000, 15412000
. : milestone, 15412000,
tracing (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
section candidate
no_agent (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
appsec (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
iast (18.733 s) : 18733000, 18733000
. : milestone, 18733000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
. : milestone, 17899000,
profiling (15.36 s) : 15360000, 15360000
. : milestone, 15360000,
tracing (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
|
PerfectSlayer
force-pushed
the
bbujon/jep500
branch
from
5c24855 to
d906b86
Compare
PerfectSlayer
force-pushed
the
bbujon/jep500
branch
from
d906b86 to
5ad4f5e
Compare
PerfectSlayer
added
the
tag: no release notes
PerfectSlayer
requested review from
nikita-tkachenko-datadog,
smola and
manuel-alvarez-alvarez
|
Will we be forbidding |
bric3
reviewed
Sep 18, 2025
Comment on lines
+34
to
+43
| java.lang.reflect.Field#set(java.lang.Object,java.lang.Object) | ||
| java.lang.reflect.Field#setBoolean(java.lang.Object,boolean) | ||
| java.lang.reflect.Field#setByte(java.lang.Object,byte) | ||
| java.lang.reflect.Field#setChar(java.lang.Object,char) | ||
| java.lang.reflect.Field#setShort(java.lang.Object,short) | ||
| java.lang.reflect.Field#setInt(java.lang.Object,int) | ||
| java.lang.reflect.Field#setLong(java.lang.Object,long) | ||
| java.lang.reflect.Field#setFloat(java.lang.Object,float) | ||
| java.lang.reflect.Field#setDouble(java.lang.Object,double) | ||
| java.lang.invoke.MethodHandles.Lookup#unreflectSetter(java.lang.reflect.Field) |
There was a problem hiding this comment.
question: Doesn't that affect other cases where the field is not final ?
In which case the comments near SuppressForbidden should be more precise, i.e. the field is public ?
There was a problem hiding this comment.
Doesn't that affect other cases where the field is not final ?
No it won't. You're right, I will update the message to add more context and precision.
I will also review the current usage to document wether it is called on a final field or not.
In which case the comments near SuppressForbidden should be more precise, i.e. the field is public ?
It is not much about field visibility (private, packaged, protected, public) but more about field immutability (final or not) but I will add more context 👍
There was a problem hiding this comment.
In which case the comments near SuppressForbidden should be more precise, i.e. the field is public ?
I have been played by my brain, I meant final not "public".
|
We won't. Quick quote from my doc about the topic:
|
|
Going back to draft to carefully evaluate and document each calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR prepares for the "Prepare to Make Final Mean Final" changes where mutating final field will be forbidden.
Motivation
Adding forbidden API should avoid using this API in the future, decreasing the migration work.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]