Refactored `AssertJ`, `Hamcrest` and `Google.Truth` to `Junit5.Assertions`. #9556

AlexeyKuznetsov-DD · 2025-09-18T00:53:23Z

What Does This Do

Refactors test assertions from AssertJ, Hamcrest and Google.Truth to JUnit5.Assertions.

Motivation

Nearly all tests already use JUnit5 or Spock assertions.
Only a handful of classes relied on AssertJ, Hamcrest and Google.Truth.
Consolidating on fewer assertion libraries simplifies the codebase and reduces maintenance overhead.
For context: JUnit5 assertions are used in 5,000+ places, while others combined appear in fewer than 150-200.

Pros & Cons

Pros

Unified and consistent style across the codebase.
No need for contributors to learn multiple assertion frameworks.
Fewer libraries to support and update; JUnit5 is required regardless.
Easier onboarding for new developers who only need to know JUnit5.
Reduces risk of mixing assertion styles in the same test, which can hurt readability.

Cons

JUnit5 assertions are less feature-rich than AssertJ.
Complex assertion scenarios may require adding helper functions.
Migration effort may introduce minor noise in diffs (less meaningful changes).
Potential loss of fluent/chainable assertion style, which some find more readable.

Additional Notes

AssertJ remains as a runtime-only dependency for kafka-clients-0.11 tests, where it is still required.

pr-commenter · 2025-09-18T00:57:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/refactor-assertj-to-junit
git_commit_date	1758553476	1758553890
git_commit_sha	`28bb458`	`bdc0d0a`
release_version	1.54.0-SNAPSHOT~28bb458edd	1.54.0-SNAPSHOT~bdc0d0a897

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1758555692	1758555692
ci_job_id	1141197983	1141197983
ci_pipeline_id	77174877	77174877
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-vtcihk7y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-vtcihk7y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019528
Total [baseline] (10.801 s) : 0, 10800770
Agent [candidate] (1.027 s) : 0, 1027275
Total [candidate] (10.722 s) : 0, 10721930
section appsec
Agent [baseline] (1.188 s) : 0, 1188145
Total [baseline] (11.043 s) : 0, 11043348
Agent [candidate] (1.202 s) : 0, 1202354
Total [candidate] (11.024 s) : 0, 11024380
section iast
Agent [baseline] (1.152 s) : 0, 1152040
Total [baseline] (11.049 s) : 0, 11048660
Agent [candidate] (1.153 s) : 0, 1153329
Total [candidate] (11.024 s) : 0, 11023699
section profiling
Agent [baseline] (1.165 s) : 0, 1165059
Total [baseline] (11.063 s) : 0, 11062959
Agent [candidate] (1.161 s) : 0, 1161342
Total [candidate] (10.999 s) : 0, 10998639

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	appsec	1.188 s	168.617 ms (16.5%)
Agent	iast	1.152 s	132.512 ms (13.0%)
Agent	profiling	1.165 s	145.531 ms (14.3%)
Total	tracing	10.801 s	-
Total	appsec	11.043 s	242.578 ms (2.2%)
Total	iast	11.049 s	247.89 ms (2.3%)
Total	profiling	11.063 s	262.189 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.027 s	-
Agent	appsec	1.202 s	175.079 ms (17.0%)
Agent	iast	1.153 s	126.054 ms (12.3%)
Agent	profiling	1.161 s	134.067 ms (13.1%)
Total	tracing	10.722 s	-
Total	appsec	11.024 s	302.45 ms (2.8%)
Total	iast	11.024 s	301.77 ms (2.8%)
Total	profiling	10.999 s	276.709 ms (2.6%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (685.179 ms) : 0, 685179
BytebuddyAgent [candidate] (691.173 ms) : 0, 691173
GlobalTracer [baseline] (258.899 ms) : 0, 258899
GlobalTracer [candidate] (260.206 ms) : 0, 260206
AppSec [baseline] (31.844 ms) : 0, 31844
AppSec [candidate] (31.932 ms) : 0, 31932
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.397 ms) : 0, 6397
Remote Config [baseline] (678.061 µs) : 0, 678
Remote Config [candidate] (685.387 µs) : 0, 685
Telemetry [baseline] (14.07 ms) : 0, 14070
Telemetry [candidate] (14.298 ms) : 0, 14298
section appsec
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (705.428 ms) : 0, 705428
BytebuddyAgent [candidate] (715.221 ms) : 0, 715221
GlobalTracer [baseline] (248.935 ms) : 0, 248935
GlobalTracer [candidate] (251.737 ms) : 0, 251737
IAST [baseline] (24.845 ms) : 0, 24845
IAST [candidate] (25.079 ms) : 0, 25079
AppSec [baseline] (171.598 ms) : 0, 171598
AppSec [candidate] (170.525 ms) : 0, 170525
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (625.505 µs) : 0, 626
Remote Config [candidate] (612.029 µs) : 0, 612
Telemetry [baseline] (8.329 ms) : 0, 8329
Telemetry [candidate] (10.535 ms) : 0, 10535
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (807.179 ms) : 0, 807179
BytebuddyAgent [candidate] (808.055 ms) : 0, 808055
GlobalTracer [baseline] (248.815 ms) : 0, 248815
GlobalTracer [candidate] (249.341 ms) : 0, 249341
IAST [baseline] (28.909 ms) : 0, 28909
IAST [candidate] (31.603 ms) : 0, 31603
AppSec [baseline] (29.845 ms) : 0, 29845
AppSec [candidate] (27.097 ms) : 0, 27097
Debugger [baseline] (6.094 ms) : 0, 6094
Debugger [candidate] (6.11 ms) : 0, 6110
Remote Config [baseline] (617.455 µs) : 0, 617
Remote Config [candidate] (593.485 µs) : 0, 593
Telemetry [baseline] (8.133 ms) : 0, 8133
Telemetry [candidate] (8.164 ms) : 0, 8164
section profiling
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (718.959 ms) : 0, 718959
BytebuddyAgent [candidate] (717.161 ms) : 0, 717161
GlobalTracer [baseline] (237.02 ms) : 0, 237020
GlobalTracer [candidate] (235.846 ms) : 0, 235846
AppSec [baseline] (31.412 ms) : 0, 31412
AppSec [candidate] (31.186 ms) : 0, 31186
Debugger [baseline] (6.551 ms) : 0, 6551
Debugger [candidate] (6.48 ms) : 0, 6480
Remote Config [baseline] (694.707 µs) : 0, 695
Remote Config [candidate] (713.017 µs) : 0, 713
Telemetry [baseline] (16.307 ms) : 0, 16307
Telemetry [candidate] (15.829 ms) : 0, 15829
ProfilingAgent [baseline] (101.691 ms) : 0, 101691
ProfilingAgent [candidate] (101.89 ms) : 0, 101890
Profiling [baseline] (102.291 ms) : 0, 102291
Profiling [candidate] (102.483 ms) : 0, 102483

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1024890
Total [baseline] (8.663 s) : 0, 8662886
Agent [candidate] (1.03 s) : 0, 1029604
Total [candidate] (8.67 s) : 0, 8670245
section iast
Agent [baseline] (1.158 s) : 0, 1158008
Total [baseline] (9.36 s) : 0, 9359726
Agent [candidate] (1.157 s) : 0, 1156877
Total [candidate] (9.326 s) : 0, 9326255

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.025 s	-
Agent	iast	1.158 s	133.118 ms (13.0%)
Total	tracing	8.663 s	-
Total	iast	9.36 s	696.84 ms (8.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.03 s	-
Agent	iast	1.157 s	127.273 ms (12.4%)
Total	tracing	8.67 s	-
Total	iast	9.326 s	656.01 ms (7.6%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (691.734 ms) : 0, 691734
BytebuddyAgent [candidate] (693.301 ms) : 0, 693301
GlobalTracer [baseline] (258.798 ms) : 0, 258798
GlobalTracer [candidate] (261.606 ms) : 0, 261606
AppSec [baseline] (31.676 ms) : 0, 31676
AppSec [candidate] (32.235 ms) : 0, 32235
Debugger [baseline] (6.339 ms) : 0, 6339
Debugger [candidate] (6.429 ms) : 0, 6429
Remote Config [baseline] (705.612 µs) : 0, 706
Remote Config [candidate] (697.757 µs) : 0, 698
Telemetry [baseline] (13.152 ms) : 0, 13152
Telemetry [candidate] (12.789 ms) : 0, 12789
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (811.649 ms) : 0, 811649
BytebuddyAgent [candidate] (811.29 ms) : 0, 811290
GlobalTracer [baseline] (250.007 ms) : 0, 250007
GlobalTracer [candidate] (249.452 ms) : 0, 249452
IAST [baseline] (30.114 ms) : 0, 30114
IAST [candidate] (29.973 ms) : 0, 29973
AppSec [baseline] (28.104 ms) : 0, 28104
AppSec [candidate] (28.893 ms) : 0, 28893
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (596.819 µs) : 0, 597
Remote Config [candidate] (599.111 µs) : 0, 599
Telemetry [baseline] (8.981 ms) : 0, 8981
Telemetry [candidate] (8.191 ms) : 0, 8191

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/refactor-assertj-to-junit
git_commit_date	1758553476	1758553890
git_commit_sha	`28bb458`	`bdc0d0a`
release_version	1.54.0-SNAPSHOT~28bb458edd	1.54.0-SNAPSHOT~bdc0d0a897

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1758555270	1758555270
ci_job_id	1141197984	1141197984
ci_pipeline_id	77174877	77174877
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-yebmqsow 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-yebmqsow 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.604 ms) : 37292, 37915
.   : milestone, 37604,
appsec (48.826 ms) : 48401, 49251
.   : milestone, 48826,
code_origins (45.213 ms) : 44812, 45614
.   : milestone, 45213,
iast (45.851 ms) : 45437, 46266
.   : milestone, 45851,
profiling (49.905 ms) : 49433, 50377
.   : milestone, 49905,
tracing (45.208 ms) : 44798, 45618
.   : milestone, 45208,
section candidate
no_agent (37.502 ms) : 37203, 37801
.   : milestone, 37502,
appsec (49.375 ms) : 48944, 49806
.   : milestone, 49375,
code_origins (45.9 ms) : 45513, 46287
.   : milestone, 45900,
iast (46.633 ms) : 46229, 47037
.   : milestone, 46633,
profiling (49.661 ms) : 49216, 50106
.   : milestone, 49661,
tracing (44.281 ms) : 43891, 44671
.   : milestone, 44281,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.604 ms [37.292 ms, 37.915 ms]	-
appsec	48.826 ms [48.401 ms, 49.251 ms]	11.223 ms (29.8%)
code_origins	45.213 ms [44.812 ms, 45.614 ms]	7.609 ms (20.2%)
iast	45.851 ms [45.437 ms, 46.266 ms]	8.248 ms (21.9%)
profiling	49.905 ms [49.433 ms, 50.377 ms]	12.301 ms (32.7%)
tracing	45.208 ms [44.798 ms, 45.618 ms]	7.604 ms (20.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.502 ms [37.203 ms, 37.801 ms]	-
appsec	49.375 ms [48.944 ms, 49.806 ms]	11.873 ms (31.7%)
code_origins	45.9 ms [45.513 ms, 46.287 ms]	8.398 ms (22.4%)
iast	46.633 ms [46.229 ms, 47.037 ms]	9.131 ms (24.3%)
profiling	49.661 ms [49.216 ms, 50.106 ms]	12.16 ms (32.4%)
tracing	44.281 ms [43.891 ms, 44.671 ms]	6.779 ms (18.1%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.285 ms) : 4237, 4333
.   : milestone, 4285,
iast (9.633 ms) : 9475, 9791
.   : milestone, 9633,
iast_FULL (14.782 ms) : 14486, 15079
.   : milestone, 14782,
iast_GLOBAL (10.98 ms) : 10784, 11175
.   : milestone, 10980,
profiling (9.012 ms) : 8858, 9165
.   : milestone, 9012,
tracing (7.759 ms) : 7649, 7868
.   : milestone, 7759,
section candidate
no_agent (4.161 ms) : 4112, 4210
.   : milestone, 4161,
iast (9.395 ms) : 9240, 9550
.   : milestone, 9395,
iast_FULL (14.621 ms) : 14325, 14917
.   : milestone, 14621,
iast_GLOBAL (10.897 ms) : 10703, 11091
.   : milestone, 10897,
profiling (9.047 ms) : 8905, 9190
.   : milestone, 9047,
tracing (7.697 ms) : 7582, 7811
.   : milestone, 7697,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.285 ms [4.237 ms, 4.333 ms]	-
iast	9.633 ms [9.475 ms, 9.791 ms]	5.348 ms (124.8%)
iast_FULL	14.782 ms [14.486 ms, 15.079 ms]	10.498 ms (245.0%)
iast_GLOBAL	10.98 ms [10.784 ms, 11.175 ms]	6.695 ms (156.2%)
profiling	9.012 ms [8.858 ms, 9.165 ms]	4.727 ms (110.3%)
tracing	7.759 ms [7.649 ms, 7.868 ms]	3.474 ms (81.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.161 ms [4.112 ms, 4.21 ms]	-
iast	9.395 ms [9.24 ms, 9.55 ms]	5.234 ms (125.8%)
iast_FULL	14.621 ms [14.325 ms, 14.917 ms]	10.46 ms (251.4%)
iast_GLOBAL	10.897 ms [10.703 ms, 11.091 ms]	6.736 ms (161.9%)
profiling	9.047 ms [8.905 ms, 9.19 ms]	4.886 ms (117.4%)
tracing	7.697 ms [7.582 ms, 7.811 ms]	3.536 ms (85.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/refactor-assertj-to-junit
git_commit_date	1758553476	1758553890
git_commit_sha	`28bb458`	`bdc0d0a`
release_version	1.54.0-SNAPSHOT~28bb458edd	1.54.0-SNAPSHOT~bdc0d0a897

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1758555877	1758555877
ci_job_id	1141197985	1141197985
ci_pipeline_id	77174877	77174877
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-ff0u245o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-ff0u245o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
appsec (15.103 s) : 15103000, 15103000
.   : milestone, 15103000,
iast (18.654 s) : 18654000, 18654000
.   : milestone, 18654000,
iast_GLOBAL (18.19 s) : 18190000, 18190000
.   : milestone, 18190000,
profiling (15.425 s) : 15425000, 15425000
.   : milestone, 15425000,
tracing (15.08 s) : 15080000, 15080000
.   : milestone, 15080000,
section candidate
no_agent (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
appsec (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
iast (18.409 s) : 18409000, 18409000
.   : milestone, 18409000,
iast_GLOBAL (18.174 s) : 18174000, 18174000
.   : milestone, 18174000,
profiling (15.551 s) : 15551000, 15551000
.   : milestone, 15551000,
tracing (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.997 s [14.997 s, 14.997 s]	-
appsec	15.103 s [15.103 s, 15.103 s]	106.0 ms (0.7%)
iast	18.654 s [18.654 s, 18.654 s]	3.657 s (24.4%)
iast_GLOBAL	18.19 s [18.19 s, 18.19 s]	3.193 s (21.3%)
profiling	15.425 s [15.425 s, 15.425 s]	428.0 ms (2.9%)
tracing	15.08 s [15.08 s, 15.08 s]	83.0 ms (0.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.922 s [14.922 s, 14.922 s]	-
appsec	15.022 s [15.022 s, 15.022 s]	100.0 ms (0.7%)
iast	18.409 s [18.409 s, 18.409 s]	3.487 s (23.4%)
iast_GLOBAL	18.174 s [18.174 s, 18.174 s]	3.252 s (21.8%)
profiling	15.551 s [15.551 s, 15.551 s]	629.0 ms (4.2%)
tracing	15.054 s [15.054 s, 15.054 s]	132.0 ms (0.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~bdc0d0a897, baseline=1.54.0-SNAPSHOT~28bb458edd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (3.736 ms) : 3517, 3956
.   : milestone, 3736,
iast (2.209 ms) : 2146, 2272
.   : milestone, 2209,
iast_GLOBAL (2.253 ms) : 2189, 2316
.   : milestone, 2253,
profiling (2.055 ms) : 2004, 2106
.   : milestone, 2055,
tracing (2.034 ms) : 1985, 2084
.   : milestone, 2034,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (3.727 ms) : 3506, 3949
.   : milestone, 3727,
iast (2.215 ms) : 2151, 2278
.   : milestone, 2215,
iast_GLOBAL (2.267 ms) : 2203, 2330
.   : milestone, 2267,
profiling (2.062 ms) : 2011, 2113
.   : milestone, 2062,
tracing (2.044 ms) : 1994, 2094
.   : milestone, 2044,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	3.736 ms [3.517 ms, 3.956 ms]	2.258 ms (152.8%)
iast	2.209 ms [2.146 ms, 2.272 ms]	730.529 µs (49.4%)
iast_GLOBAL	2.253 ms [2.189 ms, 2.316 ms]	774.381 µs (52.4%)
profiling	2.055 ms [2.004 ms, 2.106 ms]	576.968 µs (39.0%)
tracing	2.034 ms [1.985 ms, 2.084 ms]	556.263 µs (37.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.471 ms, 1.494 ms]	-
appsec	3.727 ms [3.506 ms, 3.949 ms]	2.245 ms (151.5%)
iast	2.215 ms [2.151 ms, 2.278 ms]	732.438 µs (49.4%)
iast_GLOBAL	2.267 ms [2.203 ms, 2.33 ms]	784.312 µs (52.9%)
profiling	2.062 ms [2.011 ms, 2.113 ms]	579.789 µs (39.1%)
tracing	2.044 ms [1.994 ms, 2.094 ms]	562.128 µs (37.9%)

datadog-datadog-prod-us1 · 2025-09-18T02:42:10Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.84% (-0.01%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: bdc0d0a | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-18T02:54:33Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/refactor-assertj-to-junit
git_commit_date	1758553476	1758553890
git_commit_sha	`28bb458`	`bdc0d0a`

See matching parameters

	Baseline	Candidate
ci_job_date	1758554921	1758554921
ci_job_id	1141197988	1141197988
ci_pipeline_id	77174877	77174877
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	unsure [-78328.087op/s; -16686.483op/s] or [-4.290%; -0.914%]
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2025-09-18T03:10:46Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/refactor-assertj-to-junit
git_commit_date	1758553476	1758553890
git_commit_sha	`28bb458`	`bdc0d0a`

See matching parameters

	Baseline	Candidate
ci_job_date	1758554947	1758554947
ci_job_id	1141197989	1141197989
ci_pipeline_id	77174877	77174877
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

PerfectSlayer

Interesting changes! Thanks for cleaning up the code base 🤝
(commenting only as it's still a draft)

bric3

This is an opinion, but I don't see the value to remove AssertJ assertions. This library is generally better equiped than Junit (Jupiter) assertions, and it very readable.
I cannot speak for google truth, but this seems a bit redundant wih AssertJ.

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt

utils/test-utils/src/main/java/datadog/trace/test/util/AssertionsUtils.java

AlexeyKuznetsov-DD · 2025-09-18T14:12:51Z

Interesting changes! Thanks for cleaning up the code base 🤝 (commenting only as it's still a draft)

Yep, just added to PR description my motivation and Pros & Cons.

AlexeyKuznetsov-DD · 2025-09-18T14:16:44Z

This is an opinion, but I don't see the value to remove AssertJ assertions. This library is generally better equiped than Junit (Jupiter) assertions, and it very readable. I cannot speak for google truth, but this seems a bit redundant wih AssertJ.

Probably yes, maybe I will get rid only of Truth and keep AssertJ, I'm still experimenting.

bric3 · 2025-09-18T15:12:46Z

I'm still experimenting.

My 2cts would be to convert the Junit one to assertj. While that's no small task, I believe there are some automated tools for that.

...mentation/maven-3.2.1/src/test/java/datadog/trace/instrumentation/maven3/MavenUtilsTest.java

ygree

Nice! Thanks for cleaning this up!

telemetry/src/test/java/datadog/telemetry/dependency/DependencyServiceTests.java

...mentation/maven-3.2.1/src/test/java/datadog/trace/instrumentation/maven3/MavenUtilsTest.java

sarahchen6

Nice, thanks!

# Conflicts: # dd-java-agent/instrumentation/kafka/kafka-connect-0.11/build.gradle

AlexeyKuznetsov-DD added 2 commits September 17, 2025 16:28

Refactor AssertJ to JUnit5.Assertions for unification.

122cec8

Fixed runtime dependency.

92f4914

AlexeyKuznetsov-DD self-assigned this Sep 18, 2025

AlexeyKuznetsov-DD added comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring labels Sep 18, 2025

Removed Truth.

cbd6282

PerfectSlayer reviewed Sep 18, 2025

View reviewed changes

bric3 approved these changes Sep 18, 2025

View reviewed changes

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt Outdated Show resolved Hide resolved

utils/test-utils/src/main/java/datadog/trace/test/util/AssertionsUtils.java Show resolved Hide resolved

Minor fixes.

cf30ba9

AlexeyKuznetsov-DD marked this pull request as ready for review September 18, 2025 15:15

AlexeyKuznetsov-DD requested review from a team as code owners September 18, 2025 15:15

AlexeyKuznetsov-DD requested a review from smola September 18, 2025 15:15

AlexeyKuznetsov-DD added 2 commits September 18, 2025 11:16

Merge branch 'master' into alexeyk/refactor-assertj-to-junit

b5dace5

Refactored Hamcrest to JUnit5.

aa58532

AlexeyKuznetsov-DD requested review from a team as code owners September 18, 2025 17:18

AlexeyKuznetsov-DD requested review from daniel-mohedano and sezen-datadog and removed request for a team September 18, 2025 17:18

AlexeyKuznetsov-DD requested a review from dougqh September 18, 2025 17:19

AlexeyKuznetsov-DD changed the title ~~Refactored AssertJ and Google.Truth to Junit5.Assertions.~~ Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. Sep 18, 2025

ygree reviewed Sep 18, 2025

View reviewed changes

...mentation/maven-3.2.1/src/test/java/datadog/trace/instrumentation/maven3/MavenUtilsTest.java Show resolved Hide resolved

ygree approved these changes Sep 18, 2025

View reviewed changes

Merge branch 'master' into alexeyk/refactor-assertj-to-junit

b336490

AlexeyKuznetsov-DD requested review from nikita-tkachenko-datadog and sarahchen6 September 18, 2025 19:27

sarahchen6 reviewed Sep 18, 2025

View reviewed changes

telemetry/src/test/java/datadog/telemetry/dependency/DependencyServiceTests.java Show resolved Hide resolved

Fixed review comments.

85aaa2c

AlexeyKuznetsov-DD requested review from sarahchen6 and PerfectSlayer September 18, 2025 20:02

sarahchen6 reviewed Sep 18, 2025

View reviewed changes

...mentation/maven-3.2.1/src/test/java/datadog/trace/instrumentation/maven3/MavenUtilsTest.java Show resolved Hide resolved

sarahchen6 approved these changes Sep 18, 2025

View reviewed changes

AlexeyKuznetsov-DD added 6 commits September 18, 2025 16:11

Fixed review comments.

3551d25

Merged with master.

6ce59b9

WIP.

8621a78

Merge branch 'master' into alexeyk/refactor-assertj-to-junit

c82ab71

# Conflicts: # dd-java-agent/instrumentation/kafka/kafka-connect-0.11/build.gradle

Fixed test.

3175f44

Merge branch 'master' into alexeyk/refactor-assertj-to-junit

bdc0d0a

AlexeyKuznetsov-DD merged commit cbe8eb4 into master Sep 22, 2025
547 checks passed

AlexeyKuznetsov-DD deleted the alexeyk/refactor-assertj-to-junit branch September 22, 2025 16:16

github-actions bot added this to the 1.54.0 milestone Sep 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactored `AssertJ`, `Hamcrest` and `Google.Truth` to `Junit5.Assertions`. #9556

Refactored `AssertJ`, `Hamcrest` and `Google.Truth` to `Junit5.Assertions`. #9556

AlexeyKuznetsov-DD commented Sep 18, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 18, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

bric3 left a comment

Uh oh!

Uh oh!

Uh oh!

AlexeyKuznetsov-DD commented Sep 18, 2025

Uh oh!

AlexeyKuznetsov-DD commented Sep 18, 2025

Uh oh!

bric3 commented Sep 18, 2025

Uh oh!

Uh oh!

ygree left a comment

Uh oh!

Uh oh!

Uh oh!

sarahchen6 left a comment

Uh oh!

Uh oh!

Uh oh!

Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. #9556

Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. #9556

Conversation

AlexeyKuznetsov-DD commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Pros & Cons

Additional Notes

Uh oh!

pr-commenter bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 18, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kafka / producer-benchmark

Parameters

Summary

Uh oh!

pr-commenter bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kafka / consumer-benchmark

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlexeyKuznetsov-DD commented Sep 18, 2025

Uh oh!

AlexeyKuznetsov-DD commented Sep 18, 2025

Uh oh!

bric3 commented Sep 18, 2025

Uh oh!

Uh oh!

ygree left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Refactored `AssertJ`, `Hamcrest` and `Google.Truth` to `Junit5.Assertions`. #9556

Refactored `AssertJ`, `Hamcrest` and `Google.Truth` to `Junit5.Assertions`. #9556

AlexeyKuznetsov-DD commented Sep 18, 2025 •

edited

Loading

pr-commenter bot commented Sep 18, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Sep 18, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Sep 18, 2025 •

edited

Loading

pr-commenter bot commented Sep 18, 2025 •

edited

Loading