Update CODEOWNERS #8830
Merged
Update CODEOWNERS #8830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
added
the
tag: no release notes
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~f5b1789403, baseline=1.50.0-SNAPSHOT~9eafda94cf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1036641
Total [baseline] (8.697 s) : 0, 8696924
Agent [candidate] (1.02 s) : 0, 1019657
Total [candidate] (8.636 s) : 0, 8635539
section iast
Agent [baseline] (1.154 s) : 0, 1153944
Total [baseline] (9.233 s) : 0, 9233298
Agent [candidate] (1.151 s) : 0, 1151367
Total [candidate] (9.207 s) : 0, 9207137
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.149 s) : 0, 1148796
Total [baseline] (9.198 s) : 0, 9198317
Agent [candidate] (1.147 s) : 0, 1147230
Total [candidate] (9.176 s) : 0, 9175949
section iast_TELEMETRY_OFF
Agent [baseline] (1.151 s) : 0, 1151312
Total [baseline] (9.295 s) : 0, 9294624
Agent [candidate] (1.145 s) : 0, 1145359
Total [candidate] (9.243 s) : 0, 9242629
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~f5b1789403, baseline=1.50.0-SNAPSHOT~9eafda94cf
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.367 ms) : 0, 693367
BytebuddyAgent [candidate] (682.368 ms) : 0, 682368
GlobalTracer [baseline] (243.578 ms) : 0, 243578
GlobalTracer [candidate] (240.175 ms) : 0, 240175
AppSec [baseline] (56.075 ms) : 0, 56075
AppSec [candidate] (54.199 ms) : 0, 54199
Debugger [baseline] (8.371 ms) : 0, 8371
Debugger [candidate] (6.851 ms) : 0, 6851
Remote Config [baseline] (707.436 µs) : 0, 707
Remote Config [candidate] (704.224 µs) : 0, 704
Telemetry [baseline] (10.65 ms) : 0, 10650
Telemetry [candidate] (11.768 ms) : 0, 11768
section iast
BytebuddyAgent [baseline] (806.482 ms) : 0, 806482
BytebuddyAgent [candidate] (803.45 ms) : 0, 803450
GlobalTracer [baseline] (231.2 ms) : 0, 231200
GlobalTracer [candidate] (231.463 ms) : 0, 231463
AppSec [baseline] (49.001 ms) : 0, 49001
AppSec [candidate] (48.604 ms) : 0, 48604
Debugger [baseline] (5.838 ms) : 0, 5838
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (586.238 µs) : 0, 586
Remote Config [candidate] (601.326 µs) : 0, 601
Telemetry [baseline] (7.839 ms) : 0, 7839
Telemetry [candidate] (7.905 ms) : 0, 7905
IAST [baseline] (29.443 ms) : 0, 29443
IAST [candidate] (29.849 ms) : 0, 29849
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.234 ms) : 0, 801234
BytebuddyAgent [candidate] (800.105 ms) : 0, 800105
GlobalTracer [baseline] (230.823 ms) : 0, 230823
GlobalTracer [candidate] (230.536 ms) : 0, 230536
AppSec [baseline] (52.66 ms) : 0, 52660
AppSec [candidate] (48.581 ms) : 0, 48581
Debugger [baseline] (5.886 ms) : 0, 5886
Debugger [candidate] (5.911 ms) : 0, 5911
Remote Config [baseline] (602.442 µs) : 0, 602
Remote Config [candidate] (599.279 µs) : 0, 599
Telemetry [baseline] (7.914 ms) : 0, 7914
Telemetry [candidate] (7.955 ms) : 0, 7955
IAST [baseline] (26.086 ms) : 0, 26086
IAST [candidate] (30.059 ms) : 0, 30059
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.503 ms) : 0, 803503
BytebuddyAgent [candidate] (798.73 ms) : 0, 798730
GlobalTracer [baseline] (231.403 ms) : 0, 231403
GlobalTracer [candidate] (230.846 ms) : 0, 230846
AppSec [baseline] (53.64 ms) : 0, 53640
AppSec [candidate] (55.725 ms) : 0, 55725
Debugger [baseline] (6.015 ms) : 0, 6015
Debugger [candidate] (5.901 ms) : 0, 5901
Remote Config [baseline] (601.211 µs) : 0, 601
Remote Config [candidate] (593.233 µs) : 0, 593
Telemetry [baseline] (7.847 ms) : 0, 7847
Telemetry [candidate] (7.705 ms) : 0, 7705
IAST [baseline] (24.678 ms) : 0, 24678
IAST [candidate] (22.31 ms) : 0, 22310
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~f5b1789403, baseline=1.50.0-SNAPSHOT~9eafda94cf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022157
Total [baseline] (10.411 s) : 0, 10410760
Agent [candidate] (1.021 s) : 0, 1021278
Total [candidate] (10.543 s) : 0, 10543349
section appsec
Agent [baseline] (1.164 s) : 0, 1164244
Total [baseline] (10.697 s) : 0, 10696851
Agent [candidate] (1.161 s) : 0, 1160880
Total [candidate] (10.682 s) : 0, 10681657
section iast
Agent [baseline] (1.157 s) : 0, 1157072
Total [baseline] (10.857 s) : 0, 10857020
Agent [candidate] (1.147 s) : 0, 1146667
Total [candidate] (10.881 s) : 0, 10881393
section profiling
Agent [baseline] (1.274 s) : 0, 1274248
Total [baseline] (10.858 s) : 0, 10858303
Agent [candidate] (1.295 s) : 0, 1295195
Total [candidate] (10.783 s) : 0, 10783227
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~f5b1789403, baseline=1.50.0-SNAPSHOT~9eafda94cf
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.19 ms) : 0, 684190
BytebuddyAgent [candidate] (684.008 ms) : 0, 684008
GlobalTracer [baseline] (240.811 ms) : 0, 240811
GlobalTracer [candidate] (240.562 ms) : 0, 240562
AppSec [baseline] (54.473 ms) : 0, 54473
AppSec [candidate] (54.38 ms) : 0, 54380
Debugger [baseline] (8.348 ms) : 0, 8348
Debugger [candidate] (6.118 ms) : 0, 6118
Remote Config [baseline] (715.784 µs) : 0, 716
Remote Config [candidate] (700.14 µs) : 0, 700
Telemetry [baseline] (10.02 ms) : 0, 10020
Telemetry [candidate] (11.866 ms) : 0, 11866
section appsec
BytebuddyAgent [baseline] (702.549 ms) : 0, 702549
BytebuddyAgent [candidate] (700.362 ms) : 0, 700362
GlobalTracer [baseline] (237.202 ms) : 0, 237202
GlobalTracer [candidate] (236.553 ms) : 0, 236553
AppSec [baseline] (175.679 ms) : 0, 175679
AppSec [candidate] (175.347 ms) : 0, 175347
Debugger [baseline] (5.972 ms) : 0, 5972
Debugger [candidate] (5.917 ms) : 0, 5917
Remote Config [baseline] (628.796 µs) : 0, 629
Remote Config [candidate] (629.287 µs) : 0, 629
Telemetry [baseline] (7.802 ms) : 0, 7802
Telemetry [candidate] (7.729 ms) : 0, 7729
IAST [baseline] (21.765 ms) : 0, 21765
IAST [candidate] (21.544 ms) : 0, 21544
section iast
BytebuddyAgent [baseline] (807.877 ms) : 0, 807877
BytebuddyAgent [candidate] (800.13 ms) : 0, 800130
GlobalTracer [baseline] (232.002 ms) : 0, 232002
GlobalTracer [candidate] (230.291 ms) : 0, 230291
AppSec [baseline] (50.631 ms) : 0, 50631
AppSec [candidate] (47.742 ms) : 0, 47742
Debugger [baseline] (5.915 ms) : 0, 5915
Debugger [candidate] (5.921 ms) : 0, 5921
Remote Config [baseline] (617.643 µs) : 0, 618
Remote Config [candidate] (589.197 µs) : 0, 589
Telemetry [baseline] (7.898 ms) : 0, 7898
Telemetry [candidate] (7.874 ms) : 0, 7874
IAST [baseline] (28.53 ms) : 0, 28530
IAST [candidate] (30.665 ms) : 0, 30665
section profiling
ProfilingAgent [baseline] (102.293 ms) : 0, 102293
ProfilingAgent [candidate] (104.328 ms) : 0, 104328
BytebuddyAgent [baseline] (671.527 ms) : 0, 671527
BytebuddyAgent [candidate] (684.904 ms) : 0, 684904
GlobalTracer [baseline] (373.24 ms) : 0, 373240
GlobalTracer [candidate] (376.873 ms) : 0, 376873
AppSec [baseline] (61.518 ms) : 0, 61518
AppSec [candidate] (62.342 ms) : 0, 62342
Debugger [baseline] (6.314 ms) : 0, 6314
Debugger [candidate] (6.319 ms) : 0, 6319
Remote Config [baseline] (655.532 µs) : 0, 656
Remote Config [candidate] (664.666 µs) : 0, 665
Telemetry [baseline] (8.119 ms) : 0, 8119
Telemetry [candidate] (8.327 ms) : 0, 8327
Profiling [baseline] (102.318 ms) : 0, 102318
Profiling [candidate] (104.353 ms) : 0, 104353
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~f5b1789403, baseline=1.50.0-SNAPSHOT~9eafda94cf
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1380
. : milestone, 1361,
appsec (1.733 ms) : 1709, 1757
. : milestone, 1733,
appsec_no_iast (1.737 ms) : 1714, 1759
. : milestone, 1737,
code_origins (1.689 ms) : 1662, 1716
. : milestone, 1689,
iast (1.515 ms) : 1491, 1540
. : milestone, 1515,
profiling (1.507 ms) : 1484, 1530
. : milestone, 1507,
tracing (1.493 ms) : 1467, 1518
. : milestone, 1493,
section candidate
no_agent (1.366 ms) : 1347, 1386
. : milestone, 1366,
appsec (1.723 ms) : 1699, 1747
. : milestone, 1723,
appsec_no_iast (1.722 ms) : 1699, 1746
. : milestone, 1722,
code_origins (1.698 ms) : 1671, 1725
. : milestone, 1698,
iast (1.515 ms) : 1491, 1539
. : milestone, 1515,
profiling (1.556 ms) : 1531, 1582
. : milestone, 1556,
tracing (1.5 ms) : 1475, 1524
. : milestone, 1500,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~f5b1789403, baseline=1.50.0-SNAPSHOT~9eafda94cf
dateFormat X
axisFormat %s
section baseline
no_agent (399.876 µs) : 380, 420
. : milestone, 400,
iast (521.834 µs) : 500, 544
. : milestone, 522,
iast_FULL (746.827 µs) : 723, 771
. : milestone, 747,
iast_GLOBAL (579.266 µs) : 557, 602
. : milestone, 579,
iast_HARDCODED_SECRET_DISABLED (534.216 µs) : 511, 557
. : milestone, 534,
iast_INACTIVE (469.261 µs) : 448, 490
. : milestone, 469,
iast_TELEMETRY_OFF (518.807 µs) : 495, 543
. : milestone, 519,
tracing (462.802 µs) : 441, 485
. : milestone, 463,
section candidate
no_agent (395.581 µs) : 375, 416
. : milestone, 396,
iast (519.647 µs) : 498, 541
. : milestone, 520,
iast_FULL (735.038 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (571.538 µs) : 550, 594
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (520.979 µs) : 498, 544
. : milestone, 521,
iast_INACTIVE (464.22 µs) : 442, 487
. : milestone, 464,
iast_TELEMETRY_OFF (508.638 µs) : 486, 532
. : milestone, 509,
tracing (465.168 µs) : 443, 487
. : milestone, 465,
Dacapo |
mcculls
approved these changes
May 15, 2025
sarahchen6
reviewed
May 15, 2025
sarahchen6
reviewed
May 15, 2025
sarahchen6
reviewed
May 15, 2025
| /dd-trace-core/src/test/groovy/datadog/trace/core/datastreams @DataDog/data-streams-monitoring | ||
| /internal-api/src/main/java/datadog/trace/api/datastreams @DataDog/data-streams-monitoring | ||
| /internal-api/src/test/groovy/datadog/trace/api/datastreams @DataDog/data-streams-monitoring | ||
| **/datastreams/ @DataDog/data-streams-monitoring |
There was a problem hiding this comment.
would this line cover lines 93-97? 👀 as in, maybe we can remove lines 93-97?
There was a problem hiding this comment.
I'm a little indecisive about it. I would rather only have (exact) full path rather than the wildcard rules.
But overall, I feel like the CODEOWNERS file will be poorly maintained so we will end up using the wildcard rules anyway 🤷
sarahchen6
approved these changes
May 15, 2025
There was a problem hiding this comment.
As is, we may need to adjust this line to add a / at the front of the file paths we include in XML files (or remove the beginning / from the paths in this file?). The CircleCI scripts may also change though with the Gitlab transition... unsure how codeowners are interpreted from XML files in Gitlab so that we get codeowner data such as here.
Otherwise, looks great, thanks!!
I aded them for consistency. For example:
Would you like to give it a try and see what are the result, or would you prefer it make such change right now as part of this PR? |
I see, thanks for the clarification!
I think the PR is good as is. I can follow up afterwards with a change to the script if we end up losing codeowner data :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR updates the CODEOWNERS files and add a reminder to keep it up-to-date in the PR contributor checklist.
Motivation
Introduction of apm-lang-plat-java team and review of the apm-java team
Additional Notes
Any improvement is welcome 🤝
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-502