Skip to content

Migrating all HttpClient Instrumentations to Inject Full Context #8826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Migrating all HttpClient Instrumentations to Inject Full Context #8826

wants to merge 12 commits into from

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented May 14, 2025 •
edited
Loading

What Does This Do

Migrates all Http Client Instrumentations to inject full context through the use of Context.current() rather than only injecting span contexts. This also leads to support of W3C Baggage injection for all Http Client instrumentations.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/migrate_http_client_instrumentations
git_commit_date 1747640407 1747641854
git_commit_sha 45c7667 ad0c438
release_version 1.50.0-SNAPSHOT~45c7667bff 1.50.0-SNAPSHOT~ad0c438cbd
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747644153 1747644153
ci_job_id 943240249 943240249
ci_pipeline_id 65444064 65444064
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-qba76gvb-project-304-concurrent-0-xmnuzuum 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-qba76gvb-project-304-concurrent-0-xmnuzuum 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021434
Total [baseline] (8.723 s) : 0, 8723059
Agent [candidate] (1.018 s) : 0, 1017987
Total [candidate] (8.674 s) : 0, 8674382
section iast
Agent [baseline] (1.151 s) : 0, 1150846
Total [baseline] (9.225 s) : 0, 9225498
Agent [candidate] (1.149 s) : 0, 1149428
Total [candidate] (9.294 s) : 0, 9293753
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.153 s) : 0, 1152912
Total [baseline] (9.278 s) : 0, 9277592
Agent [candidate] (1.157 s) : 0, 1156965
Total [candidate] (9.251 s) : 0, 9251326
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1146223
Total [baseline] (9.229 s) : 0, 9229229
Agent [candidate] (1.146 s) : 0, 1146251
Total [candidate] (9.284 s) : 0, 9284387
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent iast 1.151 s 129.412 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.153 s 131.478 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.146 s 124.789 ms (12.2%)
Total tracing 8.723 s -
Total iast 9.225 s 502.438 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.278 s 554.532 ms (6.4%)
Total iast_TELEMETRY_OFF 9.229 s 506.169 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent iast 1.149 s 131.441 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.157 s 138.978 ms (13.7%)
Agent iast_TELEMETRY_OFF 1.146 s 128.264 ms (12.6%)
Total tracing 8.674 s -
Total iast 9.294 s 619.372 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.251 s 576.945 ms (6.7%)
Total iast_TELEMETRY_OFF 9.284 s 610.005 ms (7.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.114 ms) : 0, 682114
BytebuddyAgent [candidate] (680.517 ms) : 0, 680517
GlobalTracer [baseline] (240.809 ms) : 0, 240809
GlobalTracer [candidate] (239.162 ms) : 0, 239162
AppSec [baseline] (55.35 ms) : 0, 55350
AppSec [candidate] (55.192 ms) : 0, 55192
Debugger [baseline] (8.425 ms) : 0, 8425
Debugger [candidate] (8.378 ms) : 0, 8378
Remote Config [baseline] (692.714 µs) : 0, 693
Remote Config [candidate] (695.88 µs) : 0, 696
Telemetry [baseline] (10.53 ms) : 0, 10530
Telemetry [candidate] (10.574 ms) : 0, 10574
section iast
BytebuddyAgent [baseline] (802.937 ms) : 0, 802937
BytebuddyAgent [candidate] (802.185 ms) : 0, 802185
GlobalTracer [baseline] (231.124 ms) : 0, 231124
GlobalTracer [candidate] (230.439 ms) : 0, 230439
IAST [baseline] (26.884 ms) : 0, 26884
IAST [candidate] (29.896 ms) : 0, 29896
AppSec [baseline] (51.32 ms) : 0, 51320
AppSec [candidate] (48.922 ms) : 0, 48922
Debugger [baseline] (5.907 ms) : 0, 5907
Debugger [candidate] (5.909 ms) : 0, 5909
Remote Config [baseline] (585.564 µs) : 0, 586
Remote Config [candidate] (628.581 µs) : 0, 629
Telemetry [baseline] (7.821 ms) : 0, 7821
Telemetry [candidate] (7.936 ms) : 0, 7936
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.784 ms) : 0, 803784
BytebuddyAgent [candidate] (807.379 ms) : 0, 807379
GlobalTracer [baseline] (231.873 ms) : 0, 231873
GlobalTracer [candidate] (231.893 ms) : 0, 231893
IAST [baseline] (28.312 ms) : 0, 28312
IAST [candidate] (29.766 ms) : 0, 29766
AppSec [baseline] (50.867 ms) : 0, 50867
AppSec [candidate] (49.794 ms) : 0, 49794
Debugger [baseline] (5.935 ms) : 0, 5935
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (592.504 µs) : 0, 593
Remote Config [candidate] (604.81 µs) : 0, 605
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (7.958 ms) : 0, 7958
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.363 ms) : 0, 799363
BytebuddyAgent [candidate] (799.117 ms) : 0, 799117
GlobalTracer [baseline] (230.575 ms) : 0, 230575
GlobalTracer [candidate] (231.219 ms) : 0, 231219
IAST [baseline] (23.074 ms) : 0, 23074
IAST [candidate] (23.12 ms) : 0, 23120
AppSec [baseline] (55.41 ms) : 0, 55410
AppSec [candidate] (54.883 ms) : 0, 54883
Debugger [baseline] (5.942 ms) : 0, 5942
Debugger [candidate] (5.984 ms) : 0, 5984
Remote Config [baseline] (592.684 µs) : 0, 593
Remote Config [candidate] (596.163 µs) : 0, 596
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (7.778 ms) : 0, 7778
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020371
Total [baseline] (10.538 s) : 0, 10537922
Agent [candidate] (1.028 s) : 0, 1027603
Total [candidate] (10.507 s) : 0, 10506886
section appsec
Agent [baseline] (1.162 s) : 0, 1162411
Total [baseline] (10.673 s) : 0, 10672884
Agent [candidate] (1.16 s) : 0, 1160466
Total [candidate] (10.711 s) : 0, 10711330
section iast
Agent [baseline] (1.16 s) : 0, 1159919
Total [baseline] (10.939 s) : 0, 10938545
Agent [candidate] (1.154 s) : 0, 1154128
Total [candidate] (10.952 s) : 0, 10951965
section profiling
Agent [baseline] (1.293 s) : 0, 1293227
Total [baseline] (10.971 s) : 0, 10970879
Agent [candidate] (1.295 s) : 0, 1294713
Total [candidate] (10.99 s) : 0, 10989950
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.162 s 142.039 ms (13.9%)
Agent iast 1.16 s 139.548 ms (13.7%)
Agent profiling 1.293 s 272.856 ms (26.7%)
Total tracing 10.538 s -
Total appsec 10.673 s 134.962 ms (1.3%)
Total iast 10.939 s 400.623 ms (3.8%)
Total profiling 10.971 s 432.957 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.028 s -
Agent appsec 1.16 s 132.863 ms (12.9%)
Agent iast 1.154 s 126.525 ms (12.3%)
Agent profiling 1.295 s 267.11 ms (26.0%)
Total tracing 10.507 s -
Total appsec 10.711 s 204.444 ms (1.9%)
Total iast 10.952 s 445.079 ms (4.2%)
Total profiling 10.99 s 483.064 ms (4.6%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.066 ms) : 0, 683066
BytebuddyAgent [candidate] (687.977 ms) : 0, 687977
GlobalTracer [baseline] (240.558 ms) : 0, 240558
GlobalTracer [candidate] (241.949 ms) : 0, 241949
AppSec [baseline] (54.394 ms) : 0, 54394
AppSec [candidate] (55.001 ms) : 0, 55001
Debugger [baseline] (8.344 ms) : 0, 8344
Debugger [candidate] (9.779 ms) : 0, 9779
Remote Config [baseline] (696.259 µs) : 0, 696
Remote Config [candidate] (712.819 µs) : 0, 713
Telemetry [baseline] (9.806 ms) : 0, 9806
Telemetry [candidate] (8.451 ms) : 0, 8451
section appsec
BytebuddyAgent [baseline] (701.039 ms) : 0, 701039
BytebuddyAgent [candidate] (699.906 ms) : 0, 699906
GlobalTracer [baseline] (237.074 ms) : 0, 237074
GlobalTracer [candidate] (236.99 ms) : 0, 236990
AppSec [baseline] (175.567 ms) : 0, 175567
AppSec [candidate] (175.317 ms) : 0, 175317
Debugger [baseline] (5.934 ms) : 0, 5934
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (620.032 µs) : 0, 620
Remote Config [candidate] (616.81 µs) : 0, 617
Telemetry [baseline] (7.748 ms) : 0, 7748
Telemetry [candidate] (7.379 ms) : 0, 7379
IAST [baseline] (21.795 ms) : 0, 21795
IAST [candidate] (21.673 ms) : 0, 21673
section iast
BytebuddyAgent [baseline] (810.457 ms) : 0, 810457
BytebuddyAgent [candidate] (806.563 ms) : 0, 806563
GlobalTracer [baseline] (232.481 ms) : 0, 232481
GlobalTracer [candidate] (230.686 ms) : 0, 230686
AppSec [baseline] (49.811 ms) : 0, 49811
AppSec [candidate] (51.921 ms) : 0, 51921
Debugger [baseline] (5.941 ms) : 0, 5941
Debugger [candidate] (5.92 ms) : 0, 5920
Remote Config [baseline] (596.171 µs) : 0, 596
Remote Config [candidate] (582.325 µs) : 0, 582
Telemetry [baseline] (7.942 ms) : 0, 7942
Telemetry [candidate] (7.933 ms) : 0, 7933
IAST [baseline] (29.223 ms) : 0, 29223
IAST [candidate] (26.949 ms) : 0, 26949
section profiling
ProfilingAgent [baseline] (104.902 ms) : 0, 104902
ProfilingAgent [candidate] (103.638 ms) : 0, 103638
BytebuddyAgent [baseline] (680.914 ms) : 0, 680914
BytebuddyAgent [candidate] (683.332 ms) : 0, 683332
GlobalTracer [baseline] (378.274 ms) : 0, 378274
GlobalTracer [candidate] (378.847 ms) : 0, 378847
AppSec [baseline] (62.598 ms) : 0, 62598
AppSec [candidate] (62.29 ms) : 0, 62290
Debugger [baseline] (6.362 ms) : 0, 6362
Debugger [candidate] (6.318 ms) : 0, 6318
Remote Config [baseline] (679.628 µs) : 0, 680
Remote Config [candidate] (652.537 µs) : 0, 653
Telemetry [baseline] (8.344 ms) : 0, 8344
Telemetry [candidate] (8.258 ms) : 0, 8258
Profiling [baseline] (104.927 ms) : 0, 104927
Profiling [candidate] (103.663 ms) : 0, 103663
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-19T08:14:42 2025-05-19T08:22:28
git_branch master mhlidd/migrate_http_client_instrumentations
git_commit_date 1747640407 1747641854
git_commit_sha 45c7667 ad0c438
release_version 1.50.0-SNAPSHOT~45c7667bff 1.50.0-SNAPSHOT~ad0c438cbd
start_time 2025-05-19T08:14:27 2025-05-19T08:22:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747643347 1747643347
ci_job_id 943240250 943240250
ci_pipeline_id 65444064 65444064
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-qba76gvb-project-304-concurrent-1-weas13p3 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-qba76gvb-project-304-concurrent-1-weas13p3 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.731 ms) : 1709, 1754
.   : milestone, 1731,
appsec_no_iast (1.737 ms) : 1714, 1760
.   : milestone, 1737,
code_origins (1.698 ms) : 1669, 1726
.   : milestone, 1698,
iast (1.52 ms) : 1496, 1544
.   : milestone, 1520,
profiling (1.566 ms) : 1541, 1590
.   : milestone, 1566,
tracing (1.476 ms) : 1451, 1501
.   : milestone, 1476,
section candidate
no_agent (1.38 ms) : 1359, 1401
.   : milestone, 1380,
appsec (1.735 ms) : 1711, 1758
.   : milestone, 1735,
appsec_no_iast (1.734 ms) : 1710, 1758
.   : milestone, 1734,
code_origins (1.676 ms) : 1649, 1703
.   : milestone, 1676,
iast (1.523 ms) : 1498, 1548
.   : milestone, 1523,
profiling (1.548 ms) : 1523, 1572
.   : milestone, 1548,
tracing (1.498 ms) : 1473, 1523
.   : milestone, 1498,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.374 ms] -
appsec 1.731 ms [1.709 ms, 1.754 ms] 376.621 µs (27.8%)
appsec_no_iast 1.737 ms [1.714 ms, 1.76 ms] 382.262 µs (28.2%)
code_origins 1.698 ms [1.669 ms, 1.726 ms] 343.102 µs (25.3%)
iast 1.52 ms [1.496 ms, 1.544 ms] 165.202 µs (12.2%)
profiling 1.566 ms [1.541 ms, 1.59 ms] 210.927 µs (15.6%)
tracing 1.476 ms [1.451 ms, 1.501 ms] 121.595 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.38 ms [1.359 ms, 1.401 ms] -
appsec 1.735 ms [1.711 ms, 1.758 ms] 354.702 µs (25.7%)
appsec_no_iast 1.734 ms [1.71 ms, 1.758 ms] 354.179 µs (25.7%)
code_origins 1.676 ms [1.649 ms, 1.703 ms] 296.27 µs (21.5%)
iast 1.523 ms [1.498 ms, 1.548 ms] 142.889 µs (10.4%)
profiling 1.548 ms [1.523 ms, 1.572 ms] 167.624 µs (12.1%)
tracing 1.498 ms [1.473 ms, 1.523 ms] 117.714 µs (8.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.146 µs) : 361, 403
.   : milestone, 382,
iast (516.477 µs) : 495, 538
.   : milestone, 516,
iast_FULL (744.94 µs) : 723, 767
.   : milestone, 745,
iast_GLOBAL (563.594 µs) : 542, 585
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (515.819 µs) : 493, 538
.   : milestone, 516,
iast_INACTIVE (466.493 µs) : 444, 489
.   : milestone, 466,
iast_TELEMETRY_OFF (511.414 µs) : 489, 534
.   : milestone, 511,
tracing (464.041 µs) : 442, 486
.   : milestone, 464,
section candidate
no_agent (379.382 µs) : 359, 399
.   : milestone, 379,
iast (522.17 µs) : 500, 544
.   : milestone, 522,
iast_FULL (744.052 µs) : 722, 766
.   : milestone, 744,
iast_GLOBAL (579.029 µs) : 556, 602
.   : milestone, 579,
iast_HARDCODED_SECRET_DISABLED (527.254 µs) : 504, 551
.   : milestone, 527,
iast_INACTIVE (470.288 µs) : 448, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (514.575 µs) : 492, 538
.   : milestone, 515,
tracing (468.994 µs) : 446, 492
.   : milestone, 469,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.146 µs [360.858 µs, 403.434 µs] -
iast 516.477 µs [494.697 µs, 538.257 µs] 134.331 µs (35.2%)
iast_FULL 744.94 µs [723.199 µs, 766.681 µs] 362.794 µs (94.9%)
iast_GLOBAL 563.594 µs [541.912 µs, 585.276 µs] 181.448 µs (47.5%)
iast_HARDCODED_SECRET_DISABLED 515.819 µs [493.243 µs, 538.395 µs] 133.673 µs (35.0%)
iast_INACTIVE 466.493 µs [444.423 µs, 488.563 µs] 84.347 µs (22.1%)
iast_TELEMETRY_OFF 511.414 µs [488.546 µs, 534.283 µs] 129.268 µs (33.8%)
tracing 464.041 µs [441.96 µs, 486.121 µs] 81.894 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.382 µs [359.493 µs, 399.272 µs] -
iast 522.17 µs [500.372 µs, 543.967 µs] 142.788 µs (37.6%)
iast_FULL 744.052 µs [722.031 µs, 766.074 µs] 364.67 µs (96.1%)
iast_GLOBAL 579.029 µs [556.259 µs, 601.8 µs] 199.647 µs (52.6%)
iast_HARDCODED_SECRET_DISABLED 527.254 µs [503.814 µs, 550.694 µs] 147.872 µs (39.0%)
iast_INACTIVE 470.288 µs [448.016 µs, 492.56 µs] 90.906 µs (24.0%)
iast_TELEMETRY_OFF 514.575 µs [491.643 µs, 537.508 µs] 135.193 µs (35.6%)
tracing 468.994 µs [445.858 µs, 492.129 µs] 89.611 µs (23.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/migrate_http_client_instrumentations
git_commit_date 1747640407 1747641854
git_commit_sha 45c7667 ad0c438
release_version 1.50.0-SNAPSHOT~45c7667bff 1.50.0-SNAPSHOT~ad0c438cbd
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1747643858 1747643858
ci_job_id 943240251 943240251
ci_pipeline_id 65444064 65444064
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-eswuofc8-project-304-concurrent-0-s95ogtc8 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-eswuofc8-project-304-concurrent-0-s95ogtc8 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (2.421 ms) : 2371, 2471
.   : milestone, 2421,
iast (2.191 ms) : 2129, 2254
.   : milestone, 2191,
iast_GLOBAL (2.242 ms) : 2179, 2304
.   : milestone, 2242,
profiling (2.51 ms) : 2272, 2747
.   : milestone, 2510,
tracing (2.019 ms) : 1970, 2067
.   : milestone, 2019,
section candidate
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (2.414 ms) : 2365, 2464
.   : milestone, 2414,
iast (2.201 ms) : 2138, 2263
.   : milestone, 2201,
iast_GLOBAL (2.234 ms) : 2171, 2296
.   : milestone, 2234,
profiling (2.05 ms) : 1999, 2101
.   : milestone, 2050,
tracing (2.013 ms) : 1965, 2061
.   : milestone, 2013,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 2.421 ms [2.371 ms, 2.471 ms] 941.554 µs (63.6%)
iast 2.191 ms [2.129 ms, 2.254 ms] 712.086 µs (48.1%)
iast_GLOBAL 2.242 ms [2.179 ms, 2.304 ms] 762.259 µs (51.5%)
profiling 2.51 ms [2.272 ms, 2.747 ms] 1.031 ms (69.7%)
tracing 2.019 ms [1.97 ms, 2.067 ms] 539.244 µs (36.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 2.414 ms [2.365 ms, 2.464 ms] 933.101 µs (63.0%)
iast 2.201 ms [2.138 ms, 2.263 ms] 719.193 µs (48.6%)
iast_GLOBAL 2.234 ms [2.171 ms, 2.296 ms] 752.591 µs (50.8%)
profiling 2.05 ms [1.999 ms, 2.101 ms] 568.666 µs (38.4%)
tracing 2.013 ms [1.965 ms, 2.061 ms] 531.673 µs (35.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ad0c438cbd, baseline=1.50.0-SNAPSHOT~45c7667bff
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.485 s) : 15485000, 15485000
.   : milestone, 15485000,
appsec (14.91 s) : 14910000, 14910000
.   : milestone, 14910000,
iast (18.214 s) : 18214000, 18214000
.   : milestone, 18214000,
iast_GLOBAL (18.25 s) : 18250000, 18250000
.   : milestone, 18250000,
profiling (14.817 s) : 14817000, 14817000
.   : milestone, 14817000,
tracing (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
section candidate
no_agent (15.273 s) : 15273000, 15273000
.   : milestone, 15273000,
appsec (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
iast (18.766 s) : 18766000, 18766000
.   : milestone, 18766000,
iast_GLOBAL (18.044 s) : 18044000, 18044000
.   : milestone, 18044000,
profiling (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,
tracing (14.864 s) : 14864000, 14864000
.   : milestone, 14864000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.485 s [15.485 s, 15.485 s] -
appsec 14.91 s [14.91 s, 14.91 s] -575.0 ms (-3.7%)
iast 18.214 s [18.214 s, 18.214 s] 2.729 s (17.6%)
iast_GLOBAL 18.25 s [18.25 s, 18.25 s] 2.765 s (17.9%)
profiling 14.817 s [14.817 s, 14.817 s] -668.0 ms (-4.3%)
tracing 15.003 s [15.003 s, 15.003 s] -482.0 ms (-3.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.273 s [15.273 s, 15.273 s] -
appsec 15.032 s [15.032 s, 15.032 s] -241.0 ms (-1.6%)
iast 18.766 s [18.766 s, 18.766 s] 3.493 s (22.9%)
iast_GLOBAL 18.044 s [18.044 s, 18.044 s] 2.771 s (18.1%)
profiling 15.054 s [15.054 s, 15.054 s] -219.0 ms (-1.4%)
tracing 14.864 s [14.864 s, 14.864 s] -409.0 ms (-2.7%)

@mhlidd mhlidd changed the title adding support for Akka Migrating all HttpClient Instrumentations to utilize Context.current() during injection May 15, 2025
@mhlidd mhlidd marked this pull request as ready for review May 15, 2025 04:17
@mhlidd mhlidd requested a review from a team as a code owner May 15, 2025 04:17
@PerfectSlayer PerfectSlayer self-requested a review May 15, 2025 05:56
PerfectSlayer
PerfectSlayer approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

@PerfectSlayer
Copy link
Contributor

I would recommend using a "meaningful" title for the PR if it is not hidden from the release notes.
Like : "Support full context injection for HTTP clients" and add some context in the PR description, especially about "now the W3C baggage will be injected by HTTP clients".

@mhlidd mhlidd changed the title Migrating all HttpClient Instrumentations to utilize Context.current() during injection Migrating all HttpClient Instrumentations to Inject Full Context May 15, 2025
@mhlidd mhlidd requested a review from a team as a code owner May 19, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
comp: context propagation Trace context propagation type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhlidd @PerfectSlayer @amarziali