-
Notifications
You must be signed in to change notification settings - Fork 303
Implement attempt to fix v3 and v4 and bump capability version #8824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
daniel-mohedano
wants to merge
3
commits into
master
Choose a base branch
from
daniel.mohedano/attempt-to-fix-v3-v4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 18 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1033710
Total [baseline] (10.516 s) : 0, 10515976
Agent [candidate] (1.021 s) : 0, 1020840
Total [candidate] (10.514 s) : 0, 10514173
section appsec
Agent [baseline] (1.159 s) : 0, 1158831
Total [baseline] (10.703 s) : 0, 10703108
Agent [candidate] (1.162 s) : 0, 1161792
Total [candidate] (10.705 s) : 0, 10704702
section iast
Agent [baseline] (1.15 s) : 0, 1150006
Total [baseline] (10.887 s) : 0, 10886893
Agent [candidate] (1.155 s) : 0, 1154738
Total [candidate] (10.912 s) : 0, 10911939
section profiling
Agent [baseline] (1.287 s) : 0, 1286775
Total [baseline] (10.854 s) : 0, 10853710
Agent [candidate] (1.29 s) : 0, 1290398
Total [candidate] (10.847 s) : 0, 10846763
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.166 ms) : 0, 692166
BytebuddyAgent [candidate] (681.645 ms) : 0, 681645
GlobalTracer [baseline] (242.957 ms) : 0, 242957
GlobalTracer [candidate] (240.226 ms) : 0, 240226
AppSec [baseline] (55.759 ms) : 0, 55759
AppSec [candidate] (55.179 ms) : 0, 55179
Debugger [baseline] (8.41 ms) : 0, 8410
Debugger [candidate] (9.803 ms) : 0, 9803
Remote Config [baseline] (717.276 µs) : 0, 717
Remote Config [candidate] (692.165 µs) : 0, 692
Telemetry [baseline] (9.969 ms) : 0, 9969
Telemetry [candidate] (9.801 ms) : 0, 9801
section appsec
BytebuddyAgent [baseline] (698.987 ms) : 0, 698987
BytebuddyAgent [candidate] (700.54 ms) : 0, 700540
GlobalTracer [baseline] (236.421 ms) : 0, 236421
GlobalTracer [candidate] (236.92 ms) : 0, 236920
IAST [baseline] (21.445 ms) : 0, 21445
IAST [candidate] (21.681 ms) : 0, 21681
AppSec [baseline] (175.371 ms) : 0, 175371
AppSec [candidate] (175.048 ms) : 0, 175048
Debugger [baseline] (5.919 ms) : 0, 5919
Debugger [candidate] (6.283 ms) : 0, 6283
Remote Config [baseline] (609.83 µs) : 0, 610
Remote Config [candidate] (622.222 µs) : 0, 622
Telemetry [baseline] (7.318 ms) : 0, 7318
Telemetry [candidate] (8.065 ms) : 0, 8065
section iast
BytebuddyAgent [baseline] (802.675 ms) : 0, 802675
BytebuddyAgent [candidate] (806.055 ms) : 0, 806055
GlobalTracer [baseline] (230.879 ms) : 0, 230879
GlobalTracer [candidate] (231.731 ms) : 0, 231731
IAST [baseline] (28.405 ms) : 0, 28405
IAST [candidate] (30.074 ms) : 0, 30074
AppSec [baseline] (50.241 ms) : 0, 50241
AppSec [candidate] (48.781 ms) : 0, 48781
Debugger [baseline] (5.871 ms) : 0, 5871
Debugger [candidate] (5.917 ms) : 0, 5917
Remote Config [baseline] (585.232 µs) : 0, 585
Remote Config [candidate] (663.415 µs) : 0, 663
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (7.942 ms) : 0, 7942
section profiling
BytebuddyAgent [baseline] (678.053 ms) : 0, 678053
BytebuddyAgent [candidate] (679.519 ms) : 0, 679519
GlobalTracer [baseline] (376.303 ms) : 0, 376303
GlobalTracer [candidate] (377.614 ms) : 0, 377614
AppSec [baseline] (62.219 ms) : 0, 62219
AppSec [candidate] (62.634 ms) : 0, 62634
Debugger [baseline] (6.279 ms) : 0, 6279
Debugger [candidate] (6.354 ms) : 0, 6354
Remote Config [baseline] (659.603 µs) : 0, 660
Remote Config [candidate] (665.717 µs) : 0, 666
Telemetry [baseline] (8.204 ms) : 0, 8204
Telemetry [candidate] (8.325 ms) : 0, 8325
ProfilingAgent [baseline] (104.023 ms) : 0, 104023
ProfilingAgent [candidate] (104.039 ms) : 0, 104039
Profiling [baseline] (104.048 ms) : 0, 104048
Profiling [candidate] (104.062 ms) : 0, 104062
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031961
Total [baseline] (8.677 s) : 0, 8677190
Agent [candidate] (1.017 s) : 0, 1017108
Total [candidate] (8.65 s) : 0, 8650481
section iast
Agent [baseline] (1.147 s) : 0, 1146901
Total [baseline] (9.211 s) : 0, 9210579
Agent [candidate] (1.146 s) : 0, 1146454
Total [candidate] (9.218 s) : 0, 9218201
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1147668
Total [baseline] (9.242 s) : 0, 9242378
Agent [candidate] (1.149 s) : 0, 1148923
Total [candidate] (9.223 s) : 0, 9222865
section iast_TELEMETRY_OFF
Agent [baseline] (1.147 s) : 0, 1147293
Total [baseline] (9.22 s) : 0, 9219870
Agent [candidate] (1.144 s) : 0, 1143844
Total [candidate] (9.267 s) : 0, 9266598
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.312 ms) : 0, 690312
BytebuddyAgent [candidate] (680.792 ms) : 0, 680792
GlobalTracer [baseline] (243.184 ms) : 0, 243184
GlobalTracer [candidate] (239.556 ms) : 0, 239556
AppSec [baseline] (55.649 ms) : 0, 55649
AppSec [candidate] (55.747 ms) : 0, 55747
Debugger [baseline] (8.422 ms) : 0, 8422
Debugger [candidate] (6.959 ms) : 0, 6959
Remote Config [baseline] (716.524 µs) : 0, 717
Remote Config [candidate] (712.478 µs) : 0, 712
Telemetry [baseline] (9.857 ms) : 0, 9857
Telemetry [candidate] (9.802 ms) : 0, 9802
section iast
BytebuddyAgent [baseline] (800.859 ms) : 0, 800859
BytebuddyAgent [candidate] (799.755 ms) : 0, 799755
GlobalTracer [baseline] (229.748 ms) : 0, 229748
GlobalTracer [candidate] (230.32 ms) : 0, 230320
IAST [baseline] (28.236 ms) : 0, 28236
IAST [candidate] (28.313 ms) : 0, 28313
AppSec [baseline] (49.431 ms) : 0, 49431
AppSec [candidate] (50.319 ms) : 0, 50319
Debugger [baseline] (5.895 ms) : 0, 5895
Debugger [candidate] (5.864 ms) : 0, 5864
Remote Config [baseline] (599.312 µs) : 0, 599
Remote Config [candidate] (590.705 µs) : 0, 591
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (7.833 ms) : 0, 7833
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.887 ms) : 0, 800887
BytebuddyAgent [candidate] (801.374 ms) : 0, 801374
GlobalTracer [baseline] (230.515 ms) : 0, 230515
GlobalTracer [candidate] (230.471 ms) : 0, 230471
IAST [baseline] (28.298 ms) : 0, 28298
IAST [candidate] (26.684 ms) : 0, 26684
AppSec [baseline] (50.078 ms) : 0, 50078
AppSec [candidate] (52.295 ms) : 0, 52295
Debugger [baseline] (5.86 ms) : 0, 5860
Debugger [candidate] (5.952 ms) : 0, 5952
Remote Config [baseline] (604.858 µs) : 0, 605
Remote Config [candidate] (609.564 µs) : 0, 610
Telemetry [baseline] (7.886 ms) : 0, 7886
Telemetry [candidate] (8.001 ms) : 0, 8001
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.26 ms) : 0, 801260
BytebuddyAgent [candidate] (797.514 ms) : 0, 797514
GlobalTracer [baseline] (230.4 ms) : 0, 230400
GlobalTracer [candidate] (230.583 ms) : 0, 230583
IAST [baseline] (24.392 ms) : 0, 24392
IAST [candidate] (23.774 ms) : 0, 23774
AppSec [baseline] (53.378 ms) : 0, 53378
AppSec [candidate] (54.048 ms) : 0, 54048
Debugger [baseline] (5.955 ms) : 0, 5955
Debugger [candidate] (5.948 ms) : 0, 5948
Remote Config [baseline] (600.816 µs) : 0, 601
Remote Config [candidate] (604.656 µs) : 0, 605
Telemetry [baseline] (7.738 ms) : 0, 7738
Telemetry [candidate] (7.849 ms) : 0, 7849
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (379.577 µs) : 359, 400
. : milestone, 380,
iast (522.564 µs) : 501, 545
. : milestone, 523,
iast_FULL (733.948 µs) : 712, 756
. : milestone, 734,
iast_GLOBAL (582.119 µs) : 559, 605
. : milestone, 582,
iast_HARDCODED_SECRET_DISABLED (514.765 µs) : 492, 538
. : milestone, 515,
iast_INACTIVE (468.031 µs) : 445, 491
. : milestone, 468,
iast_TELEMETRY_OFF (522.28 µs) : 499, 546
. : milestone, 522,
tracing (463.935 µs) : 442, 486
. : milestone, 464,
section candidate
no_agent (381.041 µs) : 361, 401
. : milestone, 381,
iast (518.471 µs) : 497, 540
. : milestone, 518,
iast_FULL (741.344 µs) : 720, 763
. : milestone, 741,
iast_GLOBAL (563.689 µs) : 542, 586
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (519.301 µs) : 496, 543
. : milestone, 519,
iast_INACTIVE (473.028 µs) : 450, 496
. : milestone, 473,
iast_TELEMETRY_OFF (513.681 µs) : 490, 537
. : milestone, 514,
tracing (465.52 µs) : 443, 488
. : milestone, 466,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1379
. : milestone, 1359,
appsec (1.75 ms) : 1726, 1774
. : milestone, 1750,
appsec_no_iast (1.737 ms) : 1713, 1760
. : milestone, 1737,
code_origins (1.684 ms) : 1658, 1710
. : milestone, 1684,
iast (1.518 ms) : 1494, 1541
. : milestone, 1518,
profiling (1.518 ms) : 1494, 1542
. : milestone, 1518,
tracing (1.492 ms) : 1468, 1516
. : milestone, 1492,
section candidate
no_agent (1.356 ms) : 1336, 1376
. : milestone, 1356,
appsec (1.726 ms) : 1702, 1749
. : milestone, 1726,
appsec_no_iast (1.733 ms) : 1710, 1756
. : milestone, 1733,
code_origins (1.673 ms) : 1646, 1701
. : milestone, 1673,
iast (1.533 ms) : 1509, 1556
. : milestone, 1533,
profiling (1.51 ms) : 1486, 1534
. : milestone, 1510,
tracing (1.497 ms) : 1473, 1522
. : milestone, 1497,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (15.598 s) : 15598000, 15598000
. : milestone, 15598000,
appsec (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
iast (18.225 s) : 18225000, 18225000
. : milestone, 18225000,
iast_GLOBAL (18.368 s) : 18368000, 18368000
. : milestone, 18368000,
profiling (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
tracing (15.021 s) : 15021000, 15021000
. : milestone, 15021000,
section candidate
no_agent (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
appsec (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
iast (18.969 s) : 18969000, 18969000
. : milestone, 18969000,
iast_GLOBAL (18.168 s) : 18168000, 18168000
. : milestone, 18168000,
profiling (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
tracing (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~bde6edeb40, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (2.425 ms) : 2376, 2475
. : milestone, 2425,
iast (2.198 ms) : 2136, 2260
. : milestone, 2198,
iast_GLOBAL (2.239 ms) : 2177, 2301
. : milestone, 2239,
profiling (2.066 ms) : 2015, 2117
. : milestone, 2066,
tracing (2.037 ms) : 1989, 2086
. : milestone, 2037,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.419 ms) : 2369, 2469
. : milestone, 2419,
iast (2.199 ms) : 2137, 2261
. : milestone, 2199,
iast_GLOBAL (2.24 ms) : 2177, 2302
. : milestone, 2240,
profiling (2.494 ms) : 2260, 2727
. : milestone, 2494,
tracing (2.014 ms) : 1966, 2061
. : milestone, 2014,
|
nikita-tkachenko-datadog
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Implements versions 3 and 4 of attempt to fix, with the following changes:
@test.test_management.attempt_to_fix_passed
will also now be tagged withfalse
as value when an attempt to fix test doesn't pass all retries2
to4
"attempt_to_fix_passed": "false"
on failed attempt to fix attemptsContributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1964 [SDTEST-1986]