Skip to content

Improve inferred gateway span design #8801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PerfectSlayer
Copy link
Contributor

Move their context and propagator into tracing/api. Refactor tests
Simplify context element
Fix propagator

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Move their context and propagator into tracing/api.
Refactor tests
Simplify context element
Fix propagator
Move propagator to dd-trace-core
@pr-commenter
Copy link

pr-commenter bot commented May 12, 2025

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-12T10:07:15 2025-05-12T10:14:59
git_branch master bbujon/gateway-inferred-span
git_commit_date 1747042167 1747043877
git_commit_sha e5785f7 276f07a
release_version 1.50.0-SNAPSHOT~e5785f7306 1.50.0-SNAPSHOT~276f07a332
start_time 2025-05-12T10:07:00 2025-05-12T10:14:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747045297 1747045297
ci_job_id 933093709 933093709
ci_pipeline_id 64761720 64761720
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-psrqmy6d-project-304-concurrent-0-9oh2exwy 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-psrqmy6d-project-304-concurrent-0-9oh2exwy 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~276f07a332, baseline=1.50.0-SNAPSHOT~e5785f7306
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.983 µs) : 359, 397
.   : milestone, 378,
iast (522.2 µs) : 499, 545
.   : milestone, 522,
iast_FULL (734.448 µs) : 711, 758
.   : milestone, 734,
iast_GLOBAL (556.935 µs) : 535, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (523.527 µs) : 501, 546
.   : milestone, 524,
iast_INACTIVE (464.11 µs) : 441, 487
.   : milestone, 464,
iast_TELEMETRY_OFF (501.682 µs) : 478, 525
.   : milestone, 502,
tracing (461.51 µs) : 439, 484
.   : milestone, 462,
section candidate
no_agent (382.969 µs) : 363, 403
.   : milestone, 383,
iast (511.167 µs) : 489, 533
.   : milestone, 511,
iast_FULL (729.748 µs) : 708, 752
.   : milestone, 730,
iast_GLOBAL (558.488 µs) : 536, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (522.57 µs) : 499, 546
.   : milestone, 523,
iast_INACTIVE (467.661 µs) : 445, 491
.   : milestone, 468,
iast_TELEMETRY_OFF (510.161 µs) : 487, 533
.   : milestone, 510,
tracing (458.538 µs) : 436, 481
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.983 µs [358.548 µs, 397.418 µs] -
iast 522.2 µs [499.447 µs, 544.953 µs] 144.217 µs (38.2%)
iast_FULL 734.448 µs [711.362 µs, 757.533 µs] 356.465 µs (94.3%)
iast_GLOBAL 556.935 µs [535.121 µs, 578.748 µs] 178.952 µs (47.3%)
iast_HARDCODED_SECRET_DISABLED 523.527 µs [500.592 µs, 546.461 µs] 145.544 µs (38.5%)
iast_INACTIVE 464.11 µs [441.404 µs, 486.816 µs] 86.127 µs (22.8%)
iast_TELEMETRY_OFF 501.682 µs [478.236 µs, 525.128 µs] 123.7 µs (32.7%)
tracing 461.51 µs [439.183 µs, 483.838 µs] 83.527 µs (22.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.969 µs [362.926 µs, 403.012 µs] -
iast 511.167 µs [489.4 µs, 532.934 µs] 128.198 µs (33.5%)
iast_FULL 729.748 µs [707.908 µs, 751.588 µs] 346.779 µs (90.6%)
iast_GLOBAL 558.488 µs [536.35 µs, 580.626 µs] 175.519 µs (45.8%)
iast_HARDCODED_SECRET_DISABLED 522.57 µs [499.338 µs, 545.801 µs] 139.601 µs (36.5%)
iast_INACTIVE 467.661 µs [444.633 µs, 490.688 µs] 84.692 µs (22.1%)
iast_TELEMETRY_OFF 510.161 µs [487.382 µs, 532.941 µs] 127.193 µs (33.2%)
tracing 458.538 µs [436.255 µs, 480.82 µs] 75.569 µs (19.7%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~276f07a332, baseline=1.50.0-SNAPSHOT~e5785f7306
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1379
.   : milestone, 1359,
appsec (1.741 ms) : 1718, 1764
.   : milestone, 1741,
appsec_no_iast (1.721 ms) : 1697, 1744
.   : milestone, 1721,
code_origins (1.659 ms) : 1632, 1686
.   : milestone, 1659,
iast (1.494 ms) : 1470, 1518
.   : milestone, 1494,
profiling (1.563 ms) : 1538, 1588
.   : milestone, 1563,
tracing (1.511 ms) : 1487, 1535
.   : milestone, 1511,
section candidate
no_agent (1.367 ms) : 1347, 1386
.   : milestone, 1367,
appsec (1.72 ms) : 1696, 1745
.   : milestone, 1720,
appsec_no_iast (1.727 ms) : 1704, 1750
.   : milestone, 1727,
code_origins (1.669 ms) : 1642, 1696
.   : milestone, 1669,
iast (1.506 ms) : 1482, 1531
.   : milestone, 1506,
profiling (1.565 ms) : 1541, 1589
.   : milestone, 1565,
tracing (1.49 ms) : 1466, 1515
.   : milestone, 1490,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.379 ms] -
appsec 1.741 ms [1.718 ms, 1.764 ms] 381.769 µs (28.1%)
appsec_no_iast 1.721 ms [1.697 ms, 1.744 ms] 361.136 µs (26.6%)
code_origins 1.659 ms [1.632 ms, 1.686 ms] 299.849 µs (22.1%)
iast 1.494 ms [1.47 ms, 1.518 ms] 134.367 µs (9.9%)
profiling 1.563 ms [1.538 ms, 1.588 ms] 203.461 µs (15.0%)
tracing 1.511 ms [1.487 ms, 1.535 ms] 151.783 µs (11.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.367 ms [1.347 ms, 1.386 ms] -
appsec 1.72 ms [1.696 ms, 1.745 ms] 353.736 µs (25.9%)
appsec_no_iast 1.727 ms [1.704 ms, 1.75 ms] 360.24 µs (26.4%)
code_origins 1.669 ms [1.642 ms, 1.696 ms] 302.413 µs (22.1%)
iast 1.506 ms [1.482 ms, 1.531 ms] 139.773 µs (10.2%)
profiling 1.565 ms [1.541 ms, 1.589 ms] 198.183 µs (14.5%)
tracing 1.49 ms [1.466 ms, 1.515 ms] 123.479 µs (9.0%)

Dacapo

@PerfectSlayer PerfectSlayer changed the title Fix inferred gateway span design Improve inferred gateway span design May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant