-
Notifications
You must be signed in to change notification settings - Fork 303
Improve inferred gateway span design #8801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PerfectSlayer
wants to merge
2
commits into
master
Choose a base branch
from
bbujon/gateway-inferred-span
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move their context and propagator into tracing/api. Refactor tests Simplify context element Fix propagator
Move propagator to dd-trace-core
BenchmarksStartupLoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~276f07a332, baseline=1.50.0-SNAPSHOT~e5785f7306
dateFormat X
axisFormat %s
section baseline
no_agent (377.983 µs) : 359, 397
. : milestone, 378,
iast (522.2 µs) : 499, 545
. : milestone, 522,
iast_FULL (734.448 µs) : 711, 758
. : milestone, 734,
iast_GLOBAL (556.935 µs) : 535, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (523.527 µs) : 501, 546
. : milestone, 524,
iast_INACTIVE (464.11 µs) : 441, 487
. : milestone, 464,
iast_TELEMETRY_OFF (501.682 µs) : 478, 525
. : milestone, 502,
tracing (461.51 µs) : 439, 484
. : milestone, 462,
section candidate
no_agent (382.969 µs) : 363, 403
. : milestone, 383,
iast (511.167 µs) : 489, 533
. : milestone, 511,
iast_FULL (729.748 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (558.488 µs) : 536, 581
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (522.57 µs) : 499, 546
. : milestone, 523,
iast_INACTIVE (467.661 µs) : 445, 491
. : milestone, 468,
iast_TELEMETRY_OFF (510.161 µs) : 487, 533
. : milestone, 510,
tracing (458.538 µs) : 436, 481
. : milestone, 459,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~276f07a332, baseline=1.50.0-SNAPSHOT~e5785f7306
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1379
. : milestone, 1359,
appsec (1.741 ms) : 1718, 1764
. : milestone, 1741,
appsec_no_iast (1.721 ms) : 1697, 1744
. : milestone, 1721,
code_origins (1.659 ms) : 1632, 1686
. : milestone, 1659,
iast (1.494 ms) : 1470, 1518
. : milestone, 1494,
profiling (1.563 ms) : 1538, 1588
. : milestone, 1563,
tracing (1.511 ms) : 1487, 1535
. : milestone, 1511,
section candidate
no_agent (1.367 ms) : 1347, 1386
. : milestone, 1367,
appsec (1.72 ms) : 1696, 1745
. : milestone, 1720,
appsec_no_iast (1.727 ms) : 1704, 1750
. : milestone, 1727,
code_origins (1.669 ms) : 1642, 1696
. : milestone, 1669,
iast (1.506 ms) : 1482, 1531
. : milestone, 1506,
profiling (1.565 ms) : 1541, 1589
. : milestone, 1565,
tracing (1.49 ms) : 1466, 1515
. : milestone, 1490,
Dacapo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move their context and propagator into tracing/api. Refactor tests
Simplify context element
Fix propagator
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]