-
Notifications
You must be signed in to change notification settings - Fork 303
The Stable Config migration from snakeyaml to the snakeyaml engine to support GraalVM Native #8790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 17 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021024
Total [baseline] (8.652 s) : 0, 8652238
Agent [candidate] (1.018 s) : 0, 1018034
Total [candidate] (8.65 s) : 0, 8649930
section iast
Agent [baseline] (1.154 s) : 0, 1154302
Total [baseline] (9.219 s) : 0, 9219118
Agent [candidate] (1.15 s) : 0, 1149784
Total [candidate] (9.245 s) : 0, 9244772
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.151 s) : 0, 1150993
Total [baseline] (9.212 s) : 0, 9211737
Agent [candidate] (1.158 s) : 0, 1157983
Total [candidate] (9.221 s) : 0, 9221003
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1151952
Total [baseline] (9.232 s) : 0, 9232393
Agent [candidate] (1.143 s) : 0, 1143448
Total [candidate] (9.19 s) : 0, 9190082
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.351 ms) : 0, 684351
BytebuddyAgent [candidate] (679.754 ms) : 0, 679754
GlobalTracer [baseline] (240.468 ms) : 0, 240468
GlobalTracer [candidate] (239.288 ms) : 0, 239288
AppSec [baseline] (55.188 ms) : 0, 55188
AppSec [candidate] (55.135 ms) : 0, 55135
Debugger [baseline] (7.683 ms) : 0, 7683
Debugger [candidate] (9.126 ms) : 0, 9126
Remote Config [baseline] (707.84 µs) : 0, 708
Remote Config [candidate] (696.259 µs) : 0, 696
Telemetry [baseline] (9.095 ms) : 0, 9095
Telemetry [candidate] (10.487 ms) : 0, 10487
section iast
BytebuddyAgent [baseline] (804.741 ms) : 0, 804741
BytebuddyAgent [candidate] (802.138 ms) : 0, 802138
GlobalTracer [baseline] (231.894 ms) : 0, 231894
GlobalTracer [candidate] (230.786 ms) : 0, 230786
IAST [baseline] (26.235 ms) : 0, 26235
IAST [candidate] (30.272 ms) : 0, 30272
AppSec [baseline] (53.391 ms) : 0, 53391
AppSec [candidate] (48.571 ms) : 0, 48571
Debugger [baseline] (5.907 ms) : 0, 5907
Debugger [candidate] (5.902 ms) : 0, 5902
Remote Config [baseline] (627.555 µs) : 0, 628
Remote Config [candidate] (594.102 µs) : 0, 594
Telemetry [baseline] (7.9 ms) : 0, 7900
Telemetry [candidate] (7.927 ms) : 0, 7927
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.378 ms) : 0, 803378
BytebuddyAgent [candidate] (809.38 ms) : 0, 809380
GlobalTracer [baseline] (230.871 ms) : 0, 230871
GlobalTracer [candidate] (232.284 ms) : 0, 232284
IAST [baseline] (28.44 ms) : 0, 28440
IAST [candidate] (25.956 ms) : 0, 25956
AppSec [baseline] (50.428 ms) : 0, 50428
AppSec [candidate] (49.978 ms) : 0, 49978
Debugger [baseline] (5.875 ms) : 0, 5875
Debugger [candidate] (5.86 ms) : 0, 5860
Remote Config [baseline] (607.334 µs) : 0, 607
Remote Config [candidate] (601.442 µs) : 0, 601
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (7.863 ms) : 0, 7863
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.167 ms) : 0, 804167
BytebuddyAgent [candidate] (797.056 ms) : 0, 797056
GlobalTracer [baseline] (231.26 ms) : 0, 231260
GlobalTracer [candidate] (230.509 ms) : 0, 230509
IAST [baseline] (23.313 ms) : 0, 23313
IAST [candidate] (23.888 ms) : 0, 23888
AppSec [baseline] (55.243 ms) : 0, 55243
AppSec [candidate] (54.16 ms) : 0, 54160
Debugger [baseline] (6.012 ms) : 0, 6012
Debugger [candidate] (5.967 ms) : 0, 5967
Remote Config [baseline] (612.93 µs) : 0, 613
Remote Config [candidate] (605.409 µs) : 0, 605
Telemetry [baseline] (7.752 ms) : 0, 7752
Telemetry [candidate] (7.793 ms) : 0, 7793
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026354
Total [baseline] (10.448 s) : 0, 10448028
Agent [candidate] (1.018 s) : 0, 1018472
Total [candidate] (10.507 s) : 0, 10507187
section appsec
Agent [baseline] (1.162 s) : 0, 1162343
Total [baseline] (10.68 s) : 0, 10680149
Agent [candidate] (1.167 s) : 0, 1167356
Total [candidate] (10.727 s) : 0, 10727270
section iast
Agent [baseline] (1.15 s) : 0, 1150024
Total [baseline] (10.907 s) : 0, 10906665
Agent [candidate] (1.151 s) : 0, 1151117
Total [candidate] (10.879 s) : 0, 10879010
section profiling
Agent [baseline] (1.281 s) : 0, 1281375
Total [baseline] (10.768 s) : 0, 10768269
Agent [candidate] (1.291 s) : 0, 1290638
Total [candidate] (10.878 s) : 0, 10877584
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.772 ms) : 0, 687772
BytebuddyAgent [candidate] (682.547 ms) : 0, 682547
GlobalTracer [baseline] (241.792 ms) : 0, 241792
GlobalTracer [candidate] (239.661 ms) : 0, 239661
AppSec [baseline] (54.779 ms) : 0, 54779
AppSec [candidate] (55.157 ms) : 0, 55157
Debugger [baseline] (6.917 ms) : 0, 6917
Debugger [candidate] (6.176 ms) : 0, 6176
Remote Config [baseline] (706.053 µs) : 0, 706
Remote Config [candidate] (732.211 µs) : 0, 732
Telemetry [baseline] (10.686 ms) : 0, 10686
Telemetry [candidate] (10.66 ms) : 0, 10660
section appsec
BytebuddyAgent [baseline] (701.868 ms) : 0, 701868
BytebuddyAgent [candidate] (704.843 ms) : 0, 704843
GlobalTracer [baseline] (236.244 ms) : 0, 236244
GlobalTracer [candidate] (237.864 ms) : 0, 237864
IAST [baseline] (21.638 ms) : 0, 21638
IAST [candidate] (21.693 ms) : 0, 21693
AppSec [baseline] (175.052 ms) : 0, 175052
AppSec [candidate] (176.074 ms) : 0, 176074
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (5.95 ms) : 0, 5950
Remote Config [baseline] (628.808 µs) : 0, 629
Remote Config [candidate] (628.902 µs) : 0, 629
Telemetry [baseline] (8.142 ms) : 0, 8142
Telemetry [candidate] (7.427 ms) : 0, 7427
section iast
BytebuddyAgent [baseline] (802.803 ms) : 0, 802803
BytebuddyAgent [candidate] (803.766 ms) : 0, 803766
GlobalTracer [baseline] (230.953 ms) : 0, 230953
GlobalTracer [candidate] (231.081 ms) : 0, 231081
IAST [baseline] (27.473 ms) : 0, 27473
IAST [candidate] (24.267 ms) : 0, 24267
AppSec [baseline] (50.199 ms) : 0, 50199
AppSec [candidate] (50.989 ms) : 0, 50989
Debugger [baseline] (5.866 ms) : 0, 5866
Debugger [candidate] (5.895 ms) : 0, 5895
Remote Config [baseline] (589.087 µs) : 0, 589
Remote Config [candidate] (581.512 µs) : 0, 582
Telemetry [baseline] (7.842 ms) : 0, 7842
Telemetry [candidate] (7.851 ms) : 0, 7851
section profiling
BytebuddyAgent [baseline] (675.903 ms) : 0, 675903
BytebuddyAgent [candidate] (679.287 ms) : 0, 679287
GlobalTracer [baseline] (374.857 ms) : 0, 374857
GlobalTracer [candidate] (378.804 ms) : 0, 378804
AppSec [baseline] (61.603 ms) : 0, 61603
AppSec [candidate] (62.266 ms) : 0, 62266
Debugger [baseline] (6.278 ms) : 0, 6278
Debugger [candidate] (6.362 ms) : 0, 6362
Remote Config [baseline] (730.301 µs) : 0, 730
Remote Config [candidate] (669.127 µs) : 0, 669
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (8.298 ms) : 0, 8298
ProfilingAgent [baseline] (102.789 ms) : 0, 102789
ProfilingAgent [candidate] (103.779 ms) : 0, 103779
Profiling [baseline] (102.813 ms) : 0, 102813
Profiling [candidate] (103.803 ms) : 0, 103803
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1336, 1375
. : milestone, 1356,
appsec (1.74 ms) : 1717, 1764
. : milestone, 1740,
appsec_no_iast (1.723 ms) : 1700, 1746
. : milestone, 1723,
code_origins (1.676 ms) : 1650, 1703
. : milestone, 1676,
iast (1.535 ms) : 1511, 1559
. : milestone, 1535,
profiling (1.533 ms) : 1509, 1556
. : milestone, 1533,
tracing (1.505 ms) : 1481, 1530
. : milestone, 1505,
section candidate
no_agent (1.373 ms) : 1354, 1392
. : milestone, 1373,
appsec (1.755 ms) : 1731, 1779
. : milestone, 1755,
appsec_no_iast (1.723 ms) : 1700, 1745
. : milestone, 1723,
code_origins (1.671 ms) : 1644, 1697
. : milestone, 1671,
iast (1.521 ms) : 1496, 1545
. : milestone, 1521,
profiling (1.521 ms) : 1498, 1544
. : milestone, 1521,
tracing (1.472 ms) : 1447, 1497
. : milestone, 1472,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section baseline
no_agent (383.432 µs) : 362, 405
. : milestone, 383,
iast (522.135 µs) : 499, 545
. : milestone, 522,
iast_FULL (734.786 µs) : 713, 756
. : milestone, 735,
iast_GLOBAL (561.498 µs) : 540, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (530.11 µs) : 508, 553
. : milestone, 530,
iast_INACTIVE (467.251 µs) : 445, 489
. : milestone, 467,
iast_TELEMETRY_OFF (514.631 µs) : 491, 538
. : milestone, 515,
tracing (465.592 µs) : 443, 488
. : milestone, 466,
section candidate
no_agent (385.199 µs) : 365, 405
. : milestone, 385,
iast (522.492 µs) : 499, 546
. : milestone, 522,
iast_FULL (739.17 µs) : 717, 761
. : milestone, 739,
iast_GLOBAL (564.323 µs) : 543, 586
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (528.985 µs) : 507, 551
. : milestone, 529,
iast_INACTIVE (468.538 µs) : 446, 491
. : milestone, 469,
iast_TELEMETRY_OFF (511.858 µs) : 488, 536
. : milestone, 512,
tracing (459.457 µs) : 437, 482
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.396 ms) : 2346, 2445
. : milestone, 2396,
iast (2.184 ms) : 2122, 2246
. : milestone, 2184,
iast_GLOBAL (2.219 ms) : 2157, 2281
. : milestone, 2219,
profiling (2.057 ms) : 2006, 2108
. : milestone, 2057,
tracing (2.022 ms) : 1973, 2070
. : milestone, 2022,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.394 ms) : 2345, 2444
. : milestone, 2394,
iast (2.183 ms) : 2120, 2245
. : milestone, 2183,
iast_GLOBAL (2.223 ms) : 2161, 2286
. : milestone, 2223,
profiling (2.513 ms) : 2328, 2698
. : milestone, 2513,
tracing (2.003 ms) : 1954, 2051
. : milestone, 2003,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ec92feec74, baseline=1.50.0-SNAPSHOT~a33e422137
dateFormat X
axisFormat %s
section baseline
no_agent (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
appsec (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
iast (18.535 s) : 18535000, 18535000
. : milestone, 18535000,
iast_GLOBAL (17.9 s) : 17900000, 17900000
. : milestone, 17900000,
profiling (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
tracing (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
section candidate
no_agent (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
appsec (15.164 s) : 15164000, 15164000
. : milestone, 15164000,
iast (18.656 s) : 18656000, 18656000
. : milestone, 18656000,
iast_GLOBAL (18.042 s) : 18042000, 18042000
. : milestone, 18042000,
profiling (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
tracing (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
|
39a540b
to
a4deaea
Compare
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
What Does This Do
Migrates the yaml component from snakeyaml to snakeyaml-engine, which is currently only used in the stable config.
Motivation
The main motivation is GraalVM Native compatibility. The original snakeyaml supports java bean de/serialization from/to yaml which doesn't work with GraalVM Native builds.
Additional Notes
Without this, it would cause the GraalVM Native Build error:
whenever stable config parsing occurs, such as when
/etc/datadog-agent/application_monitoring.yaml
exists.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]