Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AttachableWrapper aspect from scopes #8647

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Remove AttachableWrapper aspect from scopes #8647

merged 1 commit into from
Apr 2, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 31, 2025 •
edited by jira bot
Loading

Motivation

With the switch to use the internal Context API to manage OpenTelemetry contexts, we no longer need to attach state to scopes. In the majority of cases the scope wrapper is only accessed once when activating a span or context. The other cases are deprecated calls to check the active scope, where the returned scope wrapper is short-lived and cheap to recreate.

Contributor Checklist

Jira ticket: APMAPI-960

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 31, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-AttachableWrapper
git_commit_date 1743528797 1743530160
git_commit_sha d8de104 017f6c5
release_version 1.48.0-SNAPSHOT~d8de1044d6 1.48.0-SNAPSHOT~017f6c5c04
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743533647 1743533647
ci_job_id 875573142 875573142
ci_pipeline_id 60697229 60697229
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pjtrxvqe-project-304-concurrent-0-igw3eofs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pjtrxvqe-project-304-concurrent-0-igw3eofs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054476
Total [baseline] (10.515 s) : 0, 10515188
Agent [candidate] (1.053 s) : 0, 1053489
Total [candidate] (10.482 s) : 0, 10482272
section appsec
Agent [baseline] (1.196 s) : 0, 1195513
Total [baseline] (10.75 s) : 0, 10749726
Agent [candidate] (1.197 s) : 0, 1196612
Total [candidate] (10.779 s) : 0, 10779379
section iast
Agent [baseline] (1.18 s) : 0, 1179650
Total [baseline] (11.046 s) : 0, 11045576
Agent [candidate] (1.19 s) : 0, 1189503
Total [candidate] (11.032 s) : 0, 11031893
section profiling
Agent [baseline] (1.284 s) : 0, 1284186
Total [baseline] (10.891 s) : 0, 10890749
Agent [candidate] (1.278 s) : 0, 1278231
Total [candidate] (10.855 s) : 0, 10855213
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.196 s 141.037 ms (13.4%)
Agent iast 1.18 s 125.174 ms (11.9%)
Agent profiling 1.284 s 229.71 ms (21.8%)
Total tracing 10.515 s -
Total appsec 10.75 s 234.538 ms (2.2%)
Total iast 11.046 s 530.388 ms (5.0%)
Total profiling 10.891 s 375.56 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.197 s 143.123 ms (13.6%)
Agent iast 1.19 s 136.015 ms (12.9%)
Agent profiling 1.278 s 224.742 ms (21.3%)
Total tracing 10.482 s -
Total appsec 10.779 s 297.107 ms (2.8%)
Total iast 11.032 s 549.621 ms (5.2%)
Total profiling 10.855 s 372.941 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.073 ms) : 0, 718073
BytebuddyAgent [candidate] (717.6 ms) : 0, 717600
GlobalTracer [baseline] (239.852 ms) : 0, 239852
GlobalTracer [candidate] (239.159 ms) : 0, 239159
AppSec [baseline] (55.143 ms) : 0, 55143
AppSec [candidate] (54.537 ms) : 0, 54537
Debugger [baseline] (5.208 ms) : 0, 5208
Debugger [candidate] (4.434 ms) : 0, 4434
Remote Config [baseline] (690.333 µs) : 0, 690
Remote Config [candidate] (690.753 µs) : 0, 691
Telemetry [baseline] (15.048 ms) : 0, 15048
Telemetry [candidate] (16.622 ms) : 0, 16622
section appsec
BytebuddyAgent [baseline] (738.48 ms) : 0, 738480
BytebuddyAgent [candidate] (738.693 ms) : 0, 738693
GlobalTracer [baseline] (236.468 ms) : 0, 236468
GlobalTracer [candidate] (237.056 ms) : 0, 237056
AppSec [baseline] (176.172 ms) : 0, 176172
AppSec [candidate] (176.364 ms) : 0, 176364
Debugger [baseline] (4.291 ms) : 0, 4291
Debugger [candidate] (4.305 ms) : 0, 4305
Remote Config [baseline] (650.59 µs) : 0, 651
Remote Config [candidate] (644.483 µs) : 0, 644
Telemetry [baseline] (8.209 ms) : 0, 8209
Telemetry [candidate] (8.232 ms) : 0, 8232
IAST [baseline] (21.646 ms) : 0, 21646
IAST [candidate] (21.646 ms) : 0, 21646
section iast
BytebuddyAgent [baseline] (837.017 ms) : 0, 837017
BytebuddyAgent [candidate] (844.951 ms) : 0, 844951
GlobalTracer [baseline] (229.897 ms) : 0, 229897
GlobalTracer [candidate] (231.383 ms) : 0, 231383
AppSec [baseline] (56.246 ms) : 0, 56246
AppSec [candidate] (56.151 ms) : 0, 56151
Debugger [baseline] (4.08 ms) : 0, 4080
Debugger [candidate] (4.142 ms) : 0, 4142
Remote Config [baseline] (598.516 µs) : 0, 599
Remote Config [candidate] (610.817 µs) : 0, 611
Telemetry [baseline] (8.75 ms) : 0, 8750
Telemetry [candidate] (8.797 ms) : 0, 8797
IAST [baseline] (22.629 ms) : 0, 22629
IAST [candidate] (22.927 ms) : 0, 22927
section profiling
ProfilingAgent [baseline] (103.16 ms) : 0, 103160
ProfilingAgent [candidate] (103.132 ms) : 0, 103132
BytebuddyAgent [baseline] (716.133 ms) : 0, 716133
BytebuddyAgent [candidate] (711.559 ms) : 0, 711559
GlobalTracer [baseline] (349.961 ms) : 0, 349961
GlobalTracer [candidate] (350.498 ms) : 0, 350498
AppSec [baseline] (54.736 ms) : 0, 54736
AppSec [candidate] (53.434 ms) : 0, 53434
Debugger [baseline] (4.346 ms) : 0, 4346
Debugger [candidate] (4.294 ms) : 0, 4294
Remote Config [baseline] (699.814 µs) : 0, 700
Remote Config [candidate] (697.708 µs) : 0, 698
Telemetry [baseline] (9.127 ms) : 0, 9127
Telemetry [candidate] (9.01 ms) : 0, 9010
Profiling [baseline] (103.185 ms) : 0, 103185
Profiling [candidate] (103.157 ms) : 0, 103157
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060038
Total [baseline] (8.696 s) : 0, 8695808
Agent [candidate] (1.054 s) : 0, 1053617
Total [candidate] (8.697 s) : 0, 8697060
section iast
Agent [baseline] (1.181 s) : 0, 1181272
Total [baseline] (9.29 s) : 0, 9289820
Agent [candidate] (1.18 s) : 0, 1179595
Total [candidate] (9.243 s) : 0, 9242623
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1180431
Total [baseline] (9.194 s) : 0, 9194063
Agent [candidate] (1.181 s) : 0, 1181158
Total [candidate] (9.235 s) : 0, 9235002
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176132
Total [baseline] (9.311 s) : 0, 9311283
Agent [candidate] (1.189 s) : 0, 1188670
Total [candidate] (9.262 s) : 0, 9261524
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.181 s 121.234 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.18 s 120.393 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.176 s 116.094 ms (11.0%)
Total tracing 8.696 s -
Total iast 9.29 s 594.012 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.194 s 498.254 ms (5.7%)
Total iast_TELEMETRY_OFF 9.311 s 615.474 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.18 s 125.978 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 127.541 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.189 s 135.053 ms (12.8%)
Total tracing 8.697 s -
Total iast 9.243 s 545.563 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.235 s 537.941 ms (6.2%)
Total iast_TELEMETRY_OFF 9.262 s 564.464 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.22 ms) : 0, 725220
BytebuddyAgent [candidate] (720.066 ms) : 0, 720066
GlobalTracer [baseline] (241.488 ms) : 0, 241488
GlobalTracer [candidate] (239.861 ms) : 0, 239861
AppSec [baseline] (54.649 ms) : 0, 54649
AppSec [candidate] (55.145 ms) : 0, 55145
Debugger [baseline] (4.456 ms) : 0, 4456
Debugger [candidate] (4.462 ms) : 0, 4462
Remote Config [baseline] (703.909 µs) : 0, 704
Remote Config [candidate] (690.028 µs) : 0, 690
Telemetry [baseline] (12.877 ms) : 0, 12877
Telemetry [candidate] (12.796 ms) : 0, 12796
section iast
BytebuddyAgent [baseline] (838.398 ms) : 0, 838398
BytebuddyAgent [candidate] (837.126 ms) : 0, 837126
GlobalTracer [baseline] (229.84 ms) : 0, 229840
GlobalTracer [candidate] (229.684 ms) : 0, 229684
IAST [baseline] (22.729 ms) : 0, 22729
IAST [candidate] (22.685 ms) : 0, 22685
AppSec [baseline] (56.241 ms) : 0, 56241
AppSec [candidate] (55.907 ms) : 0, 55907
Debugger [baseline] (4.183 ms) : 0, 4183
Debugger [candidate] (4.202 ms) : 0, 4202
Remote Config [baseline] (611.615 µs) : 0, 612
Remote Config [candidate] (629.703 µs) : 0, 630
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.884 ms) : 0, 8884
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.635 ms) : 0, 837635
BytebuddyAgent [candidate] (838.444 ms) : 0, 838444
GlobalTracer [baseline] (229.629 ms) : 0, 229629
GlobalTracer [candidate] (230.048 ms) : 0, 230048
IAST [baseline] (22.876 ms) : 0, 22876
IAST [candidate] (22.748 ms) : 0, 22748
AppSec [baseline] (56.284 ms) : 0, 56284
AppSec [candidate] (55.881 ms) : 0, 55881
Debugger [baseline] (4.179 ms) : 0, 4179
Debugger [candidate] (4.13 ms) : 0, 4130
Remote Config [baseline] (623.189 µs) : 0, 623
Remote Config [candidate] (609.876 µs) : 0, 610
Telemetry [baseline] (8.775 ms) : 0, 8775
Telemetry [candidate] (8.801 ms) : 0, 8801
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.766 ms) : 0, 833766
BytebuddyAgent [candidate] (845.75 ms) : 0, 845750
GlobalTracer [baseline] (230.046 ms) : 0, 230046
GlobalTracer [candidate] (230.255 ms) : 0, 230255
IAST [baseline] (22.324 ms) : 0, 22324
IAST [candidate] (22.611 ms) : 0, 22611
AppSec [baseline] (55.973 ms) : 0, 55973
AppSec [candidate] (56.024 ms) : 0, 56024
Debugger [baseline] (4.157 ms) : 0, 4157
Debugger [candidate] (4.127 ms) : 0, 4127
Remote Config [baseline] (613.083 µs) : 0, 613
Remote Config [candidate] (614.555 µs) : 0, 615
Telemetry [baseline] (8.748 ms) : 0, 8748
Telemetry [candidate] (8.68 ms) : 0, 8680
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-01T18:26:26 2025-04-01T18:34:11
git_branch master mcculls/remove-AttachableWrapper
git_commit_date 1743528797 1743530160
git_commit_sha d8de104 017f6c5
release_version 1.48.0-SNAPSHOT~d8de1044d6 1.48.0-SNAPSHOT~017f6c5c04
start_time 2025-04-01T18:26:12 2025-04-01T18:33:57
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743532849 1743532849
ci_job_id 875573145 875573145
ci_pipeline_id 60697229 60697229
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pjtrxvqe-project-304-concurrent-1-jw17uwbc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pjtrxvqe-project-304-concurrent-1-jw17uwbc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1384
.   : milestone, 1364,
appsec (1.744 ms) : 1720, 1768
.   : milestone, 1744,
appsec_no_iast (1.723 ms) : 1698, 1748
.   : milestone, 1723,
code_origins (1.71 ms) : 1684, 1736
.   : milestone, 1710,
iast (1.523 ms) : 1498, 1548
.   : milestone, 1523,
profiling (1.5 ms) : 1476, 1523
.   : milestone, 1500,
tracing (1.496 ms) : 1472, 1521
.   : milestone, 1496,
section candidate
no_agent (1.373 ms) : 1353, 1393
.   : milestone, 1373,
appsec (1.72 ms) : 1697, 1744
.   : milestone, 1720,
appsec_no_iast (1.748 ms) : 1723, 1772
.   : milestone, 1748,
code_origins (1.684 ms) : 1658, 1710
.   : milestone, 1684,
iast (1.508 ms) : 1484, 1533
.   : milestone, 1508,
profiling (1.509 ms) : 1485, 1532
.   : milestone, 1509,
tracing (1.511 ms) : 1487, 1536
.   : milestone, 1511,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.345 ms, 1.384 ms] -
appsec 1.744 ms [1.72 ms, 1.768 ms] 379.842 µs (27.8%)
appsec_no_iast 1.723 ms [1.698 ms, 1.748 ms] 358.858 µs (26.3%)
code_origins 1.71 ms [1.684 ms, 1.736 ms] 346.244 µs (25.4%)
iast 1.523 ms [1.498 ms, 1.548 ms] 159.009 µs (11.7%)
profiling 1.5 ms [1.476 ms, 1.523 ms] 135.436 µs (9.9%)
tracing 1.496 ms [1.472 ms, 1.521 ms] 132.222 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.373 ms [1.353 ms, 1.393 ms] -
appsec 1.72 ms [1.697 ms, 1.744 ms] 347.764 µs (25.3%)
appsec_no_iast 1.748 ms [1.723 ms, 1.772 ms] 375.124 µs (27.3%)
code_origins 1.684 ms [1.658 ms, 1.71 ms] 311.227 µs (22.7%)
iast 1.508 ms [1.484 ms, 1.533 ms] 135.691 µs (9.9%)
profiling 1.509 ms [1.485 ms, 1.532 ms] 135.95 µs (9.9%)
tracing 1.511 ms [1.487 ms, 1.536 ms] 138.784 µs (10.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (390.879 µs) : 371, 411
.   : milestone, 391,
iast (513.547 µs) : 492, 535
.   : milestone, 514,
iast_FULL (731.036 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (563.234 µs) : 542, 585
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (515.787 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (466.68 µs) : 445, 488
.   : milestone, 467,
iast_TELEMETRY_OFF (510.046 µs) : 488, 532
.   : milestone, 510,
tracing (466.706 µs) : 446, 488
.   : milestone, 467,
section candidate
no_agent (386.88 µs) : 365, 409
.   : milestone, 387,
iast (518.541 µs) : 496, 541
.   : milestone, 519,
iast_FULL (739.693 µs) : 718, 761
.   : milestone, 740,
iast_GLOBAL (564.492 µs) : 542, 587
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (516.008 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (468.232 µs) : 447, 489
.   : milestone, 468,
iast_TELEMETRY_OFF (508.498 µs) : 487, 530
.   : milestone, 508,
tracing (469.314 µs) : 448, 491
.   : milestone, 469,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 390.879 µs [371.046 µs, 410.712 µs] -
iast 513.547 µs [491.803 µs, 535.292 µs] 122.668 µs (31.4%)
iast_FULL 731.036 µs [709.027 µs, 753.045 µs] 340.157 µs (87.0%)
iast_GLOBAL 563.234 µs [541.715 µs, 584.754 µs] 172.355 µs (44.1%)
iast_HARDCODED_SECRET_DISABLED 515.787 µs [493.613 µs, 537.962 µs] 124.908 µs (32.0%)
iast_INACTIVE 466.68 µs [445.384 µs, 487.975 µs] 75.801 µs (19.4%)
iast_TELEMETRY_OFF 510.046 µs [487.838 µs, 532.254 µs] 119.167 µs (30.5%)
tracing 466.706 µs [445.685 µs, 487.726 µs] 75.827 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 386.88 µs [365.078 µs, 408.681 µs] -
iast 518.541 µs [496.492 µs, 540.59 µs] 131.661 µs (34.0%)
iast_FULL 739.693 µs [717.898 µs, 761.489 µs] 352.814 µs (91.2%)
iast_GLOBAL 564.492 µs [542.132 µs, 586.853 µs] 177.613 µs (45.9%)
iast_HARDCODED_SECRET_DISABLED 516.008 µs [494.244 µs, 537.772 µs] 129.128 µs (33.4%)
iast_INACTIVE 468.232 µs [447.1 µs, 489.364 µs] 81.352 µs (21.0%)
iast_TELEMETRY_OFF 508.498 µs [486.933 µs, 530.064 µs] 121.618 µs (31.4%)
tracing 469.314 µs [447.935 µs, 490.692 µs] 82.434 µs (21.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-AttachableWrapper
git_commit_date 1743528797 1743530160
git_commit_sha d8de104 017f6c5
release_version 1.48.0-SNAPSHOT~d8de1044d6 1.48.0-SNAPSHOT~017f6c5c04
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1743533347 1743533347
ci_job_id 875573147 875573147
ci_pipeline_id 60697229 60697229
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pjtrxvqe-project-304-concurrent-2-4uonh46a 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pjtrxvqe-project-304-concurrent-2-4uonh46a 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1481
.   : milestone, 1470,
appsec (2.366 ms) : 2320, 2413
.   : milestone, 2366,
iast (2.148 ms) : 2089, 2207
.   : milestone, 2148,
iast_GLOBAL (2.191 ms) : 2131, 2250
.   : milestone, 2191,
profiling (2.025 ms) : 1977, 2074
.   : milestone, 2025,
tracing (1.982 ms) : 1936, 2028
.   : milestone, 1982,
section candidate
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.362 ms) : 2315, 2408
.   : milestone, 2362,
iast (2.152 ms) : 2093, 2211
.   : milestone, 2152,
iast_GLOBAL (2.196 ms) : 2137, 2255
.   : milestone, 2196,
profiling (2.0 ms) : 1953, 2048
.   : milestone, 2000,
tracing (1.972 ms) : 1927, 2017
.   : milestone, 1972,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.481 ms] -
appsec 2.366 ms [2.32 ms, 2.413 ms] 896.462 µs (61.0%)
iast 2.148 ms [2.089 ms, 2.207 ms] 678.045 µs (46.1%)
iast_GLOBAL 2.191 ms [2.131 ms, 2.25 ms] 720.618 µs (49.0%)
profiling 2.025 ms [1.977 ms, 2.074 ms] 555.117 µs (37.8%)
tracing 1.982 ms [1.936 ms, 2.028 ms] 511.734 µs (34.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.362 ms [2.315 ms, 2.408 ms] 892.347 µs (60.7%)
iast 2.152 ms [2.093 ms, 2.211 ms] 682.888 µs (46.5%)
iast_GLOBAL 2.196 ms [2.137 ms, 2.255 ms] 726.475 µs (49.4%)
profiling 2.0 ms [1.953 ms, 2.048 ms] 531.208 µs (36.2%)
tracing 1.972 ms [1.927 ms, 2.017 ms] 502.984 µs (34.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~017f6c5c04, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.334 s) : 15334000, 15334000
.   : milestone, 15334000,
appsec (14.618 s) : 14618000, 14618000
.   : milestone, 14618000,
iast (19.001 s) : 19001000, 19001000
.   : milestone, 19001000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
.   : milestone, 18077000,
profiling (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
tracing (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
section candidate
no_agent (14.881 s) : 14881000, 14881000
.   : milestone, 14881000,
appsec (14.933 s) : 14933000, 14933000
.   : milestone, 14933000,
iast (18.487 s) : 18487000, 18487000
.   : milestone, 18487000,
iast_GLOBAL (18.244 s) : 18244000, 18244000
.   : milestone, 18244000,
profiling (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
tracing (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.334 s [15.334 s, 15.334 s] -
appsec 14.618 s [14.618 s, 14.618 s] -716.0 ms (-4.7%)
iast 19.001 s [19.001 s, 19.001 s] 3.667 s (23.9%)
iast_GLOBAL 18.077 s [18.077 s, 18.077 s] 2.743 s (17.9%)
profiling 14.995 s [14.995 s, 14.995 s] -339.0 ms (-2.2%)
tracing 15.047 s [15.047 s, 15.047 s] -287.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.881 s [14.881 s, 14.881 s] -
appsec 14.933 s [14.933 s, 14.933 s] 52.0 ms (0.3%)
iast 18.487 s [18.487 s, 18.487 s] 3.606 s (24.2%)
iast_GLOBAL 18.244 s [18.244 s, 18.244 s] 3.363 s (22.6%)
profiling 15.235 s [15.235 s, 15.235 s] 354.0 ms (2.4%)
tracing 15.072 s [15.072 s, 15.072 s] 191.0 ms (1.3%)

@mcculls mcculls force-pushed the mcculls/remove-activeScope-method branch from c4cb2e9 to 760506a Compare April 1, 2025 17:40
@mcculls mcculls force-pushed the mcculls/remove-AttachableWrapper branch from ccb5be3 to 80bbe40 Compare April 1, 2025 17:41
@mcculls mcculls changed the base branch from mcculls/remove-activeScope-method to master April 1, 2025 17:42
@mcculls mcculls marked this pull request as ready for review April 1, 2025 17:42
@mcculls mcculls requested review from a team as code owners April 1, 2025 17:42
@mcculls mcculls requested review from smola and amarziali April 1, 2025 17:42
@mcculls
Remove AttachableWrapper aspect from scopes (#8534)
017f6c5 
In the majority of cases the scope wrapper will only be accessed once when
activating a span or context. The other cases are deprecated calls to check
the active scope, where the returned scope wrapper is short-lived and cheap
to recreate.
@mcculls mcculls force-pushed the mcculls/remove-AttachableWrapper branch from 80bbe40 to 017f6c5 Compare April 1, 2025 17:56
@mcculls mcculls merged commit 6d3edeb into master Apr 2, 2025
252 checks passed
@mcculls mcculls deleted the mcculls/remove-AttachableWrapper branch April 2, 2025 09:34
@github-actions github-actions bot added this to the 1.48.0 milestone Apr 2, 2025
@mcculls mcculls changed the title Remove AttachableWrapper aspect from scopes (#8534) Remove AttachableWrapper aspect from scopes Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali