Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused activeScope method #8646

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Remove unused activeScope method #8646

merged 1 commit into from
Apr 2, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 31, 2025

Motivation

With the switch to use the internal Context API to manage OpenTelemetry contexts, the activeScope method is no longer used in the codebase and can be removed.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 31, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-activeScope-method
git_commit_date 1743528797 1743529218
git_commit_sha d8de104 760506a
release_version 1.48.0-SNAPSHOT~d8de1044d6 1.48.0-SNAPSHOT~760506ae43
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743532225 1743532225
ci_job_id 875535673 875535673
ci_pipeline_id 60694604 60694604
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-x-j3wh1g-project-304-concurrent-2-lidtfw84 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-x-j3wh1g-project-304-concurrent-2-lidtfw84 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058473
Total [baseline] (8.709 s) : 0, 8709021
Agent [candidate] (1.059 s) : 0, 1059366
Total [candidate] (8.715 s) : 0, 8714644
section iast
Agent [baseline] (1.183 s) : 0, 1183227
Total [baseline] (9.33 s) : 0, 9330102
Agent [candidate] (1.187 s) : 0, 1187157
Total [candidate] (9.256 s) : 0, 9256418
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1189711
Total [baseline] (9.235 s) : 0, 9235436
Agent [candidate] (1.181 s) : 0, 1180720
Total [candidate] (9.243 s) : 0, 9243123
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177974
Total [baseline] (9.283 s) : 0, 9283157
Agent [candidate] (1.178 s) : 0, 1177865
Total [candidate] (9.312 s) : 0, 9312226
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.183 s 124.754 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.19 s 131.238 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.178 s 119.501 ms (11.3%)
Total tracing 8.709 s -
Total iast 9.33 s 621.081 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.235 s 526.414 ms (6.0%)
Total iast_TELEMETRY_OFF 9.283 s 574.136 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.187 s 127.791 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 121.355 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.178 s 118.499 ms (11.2%)
Total tracing 8.715 s -
Total iast 9.256 s 541.774 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.243 s 528.479 ms (6.1%)
Total iast_TELEMETRY_OFF 9.312 s 597.582 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.397 ms) : 0, 722397
BytebuddyAgent [candidate] (722.999 ms) : 0, 722999
GlobalTracer [baseline] (241.648 ms) : 0, 241648
GlobalTracer [candidate] (241.116 ms) : 0, 241116
AppSec [baseline] (56.287 ms) : 0, 56287
AppSec [candidate] (55.851 ms) : 0, 55851
Debugger [baseline] (4.48 ms) : 0, 4480
Debugger [candidate] (4.467 ms) : 0, 4467
Remote Config [baseline] (705.902 µs) : 0, 706
Remote Config [candidate] (692.038 µs) : 0, 692
Telemetry [baseline] (12.264 ms) : 0, 12264
Telemetry [candidate] (13.565 ms) : 0, 13565
section iast
BytebuddyAgent [baseline] (840.992 ms) : 0, 840992
BytebuddyAgent [candidate] (844.196 ms) : 0, 844196
GlobalTracer [baseline] (229.713 ms) : 0, 229713
GlobalTracer [candidate] (230.076 ms) : 0, 230076
IAST [baseline] (22.589 ms) : 0, 22589
IAST [candidate] (22.677 ms) : 0, 22677
AppSec [baseline] (55.803 ms) : 0, 55803
AppSec [candidate] (56.002 ms) : 0, 56002
Debugger [baseline] (4.116 ms) : 0, 4116
Debugger [candidate] (4.195 ms) : 0, 4195
Remote Config [baseline] (612.787 µs) : 0, 613
Remote Config [candidate] (642.965 µs) : 0, 643
Telemetry [baseline] (8.856 ms) : 0, 8856
Telemetry [candidate] (8.77 ms) : 0, 8770
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (845.204 ms) : 0, 845204
BytebuddyAgent [candidate] (838.256 ms) : 0, 838256
GlobalTracer [baseline] (231.005 ms) : 0, 231005
GlobalTracer [candidate] (230.204 ms) : 0, 230204
IAST [baseline] (23.045 ms) : 0, 23045
IAST [candidate] (22.743 ms) : 0, 22743
AppSec [baseline] (56.222 ms) : 0, 56222
AppSec [candidate] (55.565 ms) : 0, 55565
Debugger [baseline] (4.197 ms) : 0, 4197
Debugger [candidate] (4.118 ms) : 0, 4118
Remote Config [baseline] (618.043 µs) : 0, 618
Remote Config [candidate] (619.176 µs) : 0, 619
Telemetry [baseline] (8.829 ms) : 0, 8829
Telemetry [candidate] (8.76 ms) : 0, 8760
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.613 ms) : 0, 835613
BytebuddyAgent [candidate] (836.117 ms) : 0, 836117
GlobalTracer [baseline] (230.329 ms) : 0, 230329
GlobalTracer [candidate] (229.961 ms) : 0, 229961
IAST [baseline] (22.442 ms) : 0, 22442
IAST [candidate] (22.229 ms) : 0, 22229
AppSec [baseline] (55.74 ms) : 0, 55740
AppSec [candidate] (55.693 ms) : 0, 55693
Debugger [baseline] (4.159 ms) : 0, 4159
Debugger [candidate] (4.122 ms) : 0, 4122
Remote Config [baseline] (616.897 µs) : 0, 617
Remote Config [candidate] (609.037 µs) : 0, 609
Telemetry [baseline] (8.684 ms) : 0, 8684
Telemetry [candidate] (8.663 ms) : 0, 8663
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056445
Total [baseline] (10.548 s) : 0, 10548454
Agent [candidate] (1.055 s) : 0, 1054641
Total [candidate] (10.539 s) : 0, 10538689
section appsec
Agent [baseline] (1.201 s) : 0, 1200894
Total [baseline] (10.796 s) : 0, 10795533
Agent [candidate] (1.202 s) : 0, 1202164
Total [candidate] (10.817 s) : 0, 10817107
section iast
Agent [baseline] (1.199 s) : 0, 1199467
Total [baseline] (11.084 s) : 0, 11083608
Agent [candidate] (1.181 s) : 0, 1180656
Total [candidate] (11.156 s) : 0, 11155800
section profiling
Agent [baseline] (1.278 s) : 0, 1278397
Total [baseline] (11.012 s) : 0, 11012258
Agent [candidate] (1.276 s) : 0, 1275629
Total [candidate] (10.925 s) : 0, 10925467
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.201 s 144.449 ms (13.7%)
Agent iast 1.199 s 143.022 ms (13.5%)
Agent profiling 1.278 s 221.952 ms (21.0%)
Total tracing 10.548 s -
Total appsec 10.796 s 247.079 ms (2.3%)
Total iast 11.084 s 535.154 ms (5.1%)
Total profiling 11.012 s 463.804 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.202 s 147.523 ms (14.0%)
Agent iast 1.181 s 126.015 ms (11.9%)
Agent profiling 1.276 s 220.988 ms (21.0%)
Total tracing 10.539 s -
Total appsec 10.817 s 278.418 ms (2.6%)
Total iast 11.156 s 617.111 ms (5.9%)
Total profiling 10.925 s 386.777 ms (3.7%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.281 ms) : 0, 720281
BytebuddyAgent [candidate] (719.975 ms) : 0, 719975
GlobalTracer [baseline] (240.232 ms) : 0, 240232
GlobalTracer [candidate] (240.603 ms) : 0, 240603
AppSec [baseline] (54.87 ms) : 0, 54870
AppSec [candidate] (54.757 ms) : 0, 54757
Debugger [baseline] (5.136 ms) : 0, 5136
Debugger [candidate] (4.443 ms) : 0, 4443
Remote Config [baseline] (691.837 µs) : 0, 692
Remote Config [candidate] (693.419 µs) : 0, 693
Telemetry [baseline] (14.722 ms) : 0, 14722
Telemetry [candidate] (13.66 ms) : 0, 13660
section appsec
BytebuddyAgent [baseline] (742.182 ms) : 0, 742182
BytebuddyAgent [candidate] (742.947 ms) : 0, 742947
GlobalTracer [baseline] (237.538 ms) : 0, 237538
GlobalTracer [candidate] (237.67 ms) : 0, 237670
IAST [baseline] (21.461 ms) : 0, 21461
IAST [candidate] (21.674 ms) : 0, 21674
AppSec [baseline] (176.303 ms) : 0, 176303
AppSec [candidate] (175.769 ms) : 0, 175769
Debugger [baseline] (4.282 ms) : 0, 4282
Debugger [candidate] (4.312 ms) : 0, 4312
Remote Config [baseline] (640.938 µs) : 0, 641
Remote Config [candidate] (640.467 µs) : 0, 640
Telemetry [baseline] (8.598 ms) : 0, 8598
Telemetry [candidate] (9.375 ms) : 0, 9375
section iast
BytebuddyAgent [baseline] (853.184 ms) : 0, 853184
BytebuddyAgent [candidate] (838.018 ms) : 0, 838018
GlobalTracer [baseline] (232.169 ms) : 0, 232169
GlobalTracer [candidate] (230.234 ms) : 0, 230234
IAST [baseline] (23.043 ms) : 0, 23043
IAST [candidate] (22.674 ms) : 0, 22674
AppSec [baseline] (56.595 ms) : 0, 56595
AppSec [candidate] (55.805 ms) : 0, 55805
Debugger [baseline] (4.217 ms) : 0, 4217
Debugger [candidate] (4.112 ms) : 0, 4112
Remote Config [baseline] (623.236 µs) : 0, 623
Remote Config [candidate] (616.413 µs) : 0, 616
Telemetry [baseline] (8.931 ms) : 0, 8931
Telemetry [candidate] (8.756 ms) : 0, 8756
section profiling
BytebuddyAgent [baseline] (712.571 ms) : 0, 712571
BytebuddyAgent [candidate] (710.945 ms) : 0, 710945
GlobalTracer [baseline] (349.729 ms) : 0, 349729
GlobalTracer [candidate] (349.352 ms) : 0, 349352
AppSec [baseline] (54.208 ms) : 0, 54208
AppSec [candidate] (53.091 ms) : 0, 53091
Debugger [baseline] (4.274 ms) : 0, 4274
Debugger [candidate] (4.259 ms) : 0, 4259
Remote Config [baseline] (695.958 µs) : 0, 696
Remote Config [candidate] (691.035 µs) : 0, 691
Telemetry [baseline] (8.902 ms) : 0, 8902
Telemetry [candidate] (8.943 ms) : 0, 8943
ProfilingAgent [baseline] (102.296 ms) : 0, 102296
ProfilingAgent [candidate] (102.664 ms) : 0, 102664
Profiling [baseline] (102.322 ms) : 0, 102322
Profiling [candidate] (102.69 ms) : 0, 102690
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-01T18:00:22 2025-04-01T18:08:07
git_branch master mcculls/remove-activeScope-method
git_commit_date 1743528797 1743529218
git_commit_sha d8de104 760506a
release_version 1.48.0-SNAPSHOT~d8de1044d6 1.48.0-SNAPSHOT~760506ae43
start_time 2025-04-01T18:00:08 2025-04-01T18:07:53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743531286 1743531286
ci_job_id 875535674 875535674
ci_pipeline_id 60694604 60694604
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-1ywhvvpj-project-304-concurrent-1-32ysr8ja 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-1ywhvvpj-project-304-concurrent-1-32ysr8ja 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.765 µs) : 360, 399
.   : milestone, 380,
iast (513.433 µs) : 492, 535
.   : milestone, 513,
iast_FULL (734.459 µs) : 712, 757
.   : milestone, 734,
iast_GLOBAL (551.607 µs) : 530, 573
.   : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (516.783 µs) : 495, 539
.   : milestone, 517,
iast_INACTIVE (468.258 µs) : 447, 490
.   : milestone, 468,
iast_TELEMETRY_OFF (504.634 µs) : 482, 527
.   : milestone, 505,
tracing (464.436 µs) : 443, 486
.   : milestone, 464,
section candidate
no_agent (384.71 µs) : 364, 406
.   : milestone, 385,
iast (513.255 µs) : 491, 535
.   : milestone, 513,
iast_FULL (735.206 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (554.477 µs) : 533, 576
.   : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (516.952 µs) : 495, 539
.   : milestone, 517,
iast_INACTIVE (461.183 µs) : 439, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (502.399 µs) : 480, 524
.   : milestone, 502,
tracing (458.212 µs) : 438, 479
.   : milestone, 458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.765 µs [360.278 µs, 399.251 µs] -
iast 513.433 µs [491.783 µs, 535.083 µs] 133.669 µs (35.2%)
iast_FULL 734.459 µs [712.37 µs, 756.549 µs] 354.695 µs (93.4%)
iast_GLOBAL 551.607 µs [529.846 µs, 573.367 µs] 171.842 µs (45.2%)
iast_HARDCODED_SECRET_DISABLED 516.783 µs [494.564 µs, 539.002 µs] 137.019 µs (36.1%)
iast_INACTIVE 468.258 µs [446.568 µs, 489.948 µs] 88.494 µs (23.3%)
iast_TELEMETRY_OFF 504.634 µs [482.323 µs, 526.945 µs] 124.869 µs (32.9%)
tracing 464.436 µs [443.18 µs, 485.693 µs] 84.672 µs (22.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.71 µs [363.718 µs, 405.701 µs] -
iast 513.255 µs [491.237 µs, 535.273 µs] 128.546 µs (33.4%)
iast_FULL 735.206 µs [713.333 µs, 757.08 µs] 350.497 µs (91.1%)
iast_GLOBAL 554.477 µs [532.879 µs, 576.076 µs] 169.768 µs (44.1%)
iast_HARDCODED_SECRET_DISABLED 516.952 µs [494.932 µs, 538.973 µs] 132.243 µs (34.4%)
iast_INACTIVE 461.183 µs [439.497 µs, 482.87 µs] 76.474 µs (19.9%)
iast_TELEMETRY_OFF 502.399 µs [480.459 µs, 524.339 µs] 117.689 µs (30.6%)
tracing 458.212 µs [437.63 µs, 478.795 µs] 73.503 µs (19.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.373 ms) : 1354, 1393
.   : milestone, 1373,
appsec (1.741 ms) : 1716, 1765
.   : milestone, 1741,
appsec_no_iast (1.747 ms) : 1723, 1771
.   : milestone, 1747,
code_origins (1.681 ms) : 1655, 1707
.   : milestone, 1681,
iast (1.504 ms) : 1479, 1529
.   : milestone, 1504,
profiling (1.538 ms) : 1515, 1561
.   : milestone, 1538,
tracing (1.484 ms) : 1458, 1510
.   : milestone, 1484,
section candidate
no_agent (1.353 ms) : 1333, 1373
.   : milestone, 1353,
appsec (1.739 ms) : 1715, 1762
.   : milestone, 1739,
appsec_no_iast (1.732 ms) : 1707, 1757
.   : milestone, 1732,
code_origins (1.695 ms) : 1669, 1721
.   : milestone, 1695,
iast (1.505 ms) : 1480, 1530
.   : milestone, 1505,
profiling (1.558 ms) : 1534, 1582
.   : milestone, 1558,
tracing (1.503 ms) : 1478, 1527
.   : milestone, 1503,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.373 ms [1.354 ms, 1.393 ms] -
appsec 1.741 ms [1.716 ms, 1.765 ms] 367.613 µs (26.8%)
appsec_no_iast 1.747 ms [1.723 ms, 1.771 ms] 374.25 µs (27.3%)
code_origins 1.681 ms [1.655 ms, 1.707 ms] 308.055 µs (22.4%)
iast 1.504 ms [1.479 ms, 1.529 ms] 130.874 µs (9.5%)
profiling 1.538 ms [1.515 ms, 1.561 ms] 164.748 µs (12.0%)
tracing 1.484 ms [1.458 ms, 1.51 ms] 110.701 µs (8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.373 ms] -
appsec 1.739 ms [1.715 ms, 1.762 ms] 385.487 µs (28.5%)
appsec_no_iast 1.732 ms [1.707 ms, 1.757 ms] 379.212 µs (28.0%)
code_origins 1.695 ms [1.669 ms, 1.721 ms] 341.992 µs (25.3%)
iast 1.505 ms [1.48 ms, 1.53 ms] 151.888 µs (11.2%)
profiling 1.558 ms [1.534 ms, 1.582 ms] 205.083 µs (15.2%)
tracing 1.503 ms [1.478 ms, 1.527 ms] 149.654 µs (11.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-activeScope-method
git_commit_date 1743528797 1743529218
git_commit_sha d8de104 760506a
release_version 1.48.0-SNAPSHOT~d8de1044d6 1.48.0-SNAPSHOT~760506ae43
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1743531793 1743531793
ci_job_id 875535675 875535675
ci_pipeline_id 60694604 60694604
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-1ywhvvpj-project-304-concurrent-2-94ltl46j 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-1ywhvvpj-project-304-concurrent-2-94ltl46j 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.375 ms) : 2329, 2422
.   : milestone, 2375,
iast (2.168 ms) : 2109, 2228
.   : milestone, 2168,
iast_GLOBAL (2.192 ms) : 2133, 2251
.   : milestone, 2192,
profiling (2.006 ms) : 1959, 2053
.   : milestone, 2006,
tracing (1.99 ms) : 1944, 2035
.   : milestone, 1990,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.366 ms) : 2320, 2413
.   : milestone, 2366,
iast (2.15 ms) : 2091, 2209
.   : milestone, 2150,
iast_GLOBAL (2.202 ms) : 2142, 2261
.   : milestone, 2202,
profiling (2.023 ms) : 1975, 2071
.   : milestone, 2023,
tracing (1.978 ms) : 1933, 2023
.   : milestone, 1978,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.375 ms [2.329 ms, 2.422 ms] 903.654 µs (61.4%)
iast 2.168 ms [2.109 ms, 2.228 ms] 696.54 µs (47.3%)
iast_GLOBAL 2.192 ms [2.133 ms, 2.251 ms] 720.299 µs (48.9%)
profiling 2.006 ms [1.959 ms, 2.053 ms] 534.548 µs (36.3%)
tracing 1.99 ms [1.944 ms, 2.035 ms] 518.162 µs (35.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.366 ms [2.32 ms, 2.413 ms] 899.64 µs (61.3%)
iast 2.15 ms [2.091 ms, 2.209 ms] 683.605 µs (46.6%)
iast_GLOBAL 2.202 ms [2.142 ms, 2.261 ms] 734.708 µs (50.1%)
profiling 2.023 ms [1.975 ms, 2.071 ms] 556.27 µs (37.9%)
tracing 1.978 ms [1.933 ms, 2.023 ms] 511.282 µs (34.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~760506ae43, baseline=1.48.0-SNAPSHOT~d8de1044d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.903 s) : 14903000, 14903000
.   : milestone, 14903000,
appsec (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,
iast (18.673 s) : 18673000, 18673000
.   : milestone, 18673000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
.   : milestone, 17998000,
profiling (15.684 s) : 15684000, 15684000
.   : milestone, 15684000,
tracing (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
section candidate
no_agent (15.5 s) : 15500000, 15500000
.   : milestone, 15500000,
appsec (14.785 s) : 14785000, 14785000
.   : milestone, 14785000,
iast (18.823 s) : 18823000, 18823000
.   : milestone, 18823000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
.   : milestone, 17961000,
profiling (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
tracing (15.102 s) : 15102000, 15102000
.   : milestone, 15102000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.903 s [14.903 s, 14.903 s] -
appsec 14.912 s [14.912 s, 14.912 s] 9.0 ms (0.1%)
iast 18.673 s [18.673 s, 18.673 s] 3.77 s (25.3%)
iast_GLOBAL 17.998 s [17.998 s, 17.998 s] 3.095 s (20.8%)
profiling 15.684 s [15.684 s, 15.684 s] 781.0 ms (5.2%)
tracing 15.027 s [15.027 s, 15.027 s] 124.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.5 s [15.5 s, 15.5 s] -
appsec 14.785 s [14.785 s, 14.785 s] -715.0 ms (-4.6%)
iast 18.823 s [18.823 s, 18.823 s] 3.323 s (21.4%)
iast_GLOBAL 17.961 s [17.961 s, 17.961 s] 2.461 s (15.9%)
profiling 15.136 s [15.136 s, 15.136 s] -364.0 ms (-2.3%)
tracing 15.102 s [15.102 s, 15.102 s] -398.0 ms (-2.6%)

@mcculls mcculls force-pushed the mcculls/migrate-otel-shim-to-context branch from c2c2dff to d56c702 Compare March 31, 2025 15:15
Base automatically changed from mcculls/migrate-otel-shim-to-context to master April 1, 2025 17:33
@mcculls mcculls force-pushed the mcculls/remove-activeScope-method branch from c4cb2e9 to 760506a Compare April 1, 2025 17:40
@mcculls mcculls marked this pull request as ready for review April 1, 2025 17:42
@mcculls mcculls requested a review from a team as a code owner April 1, 2025 17:42
@mcculls mcculls requested review from ygree and amarziali April 1, 2025 17:42
amarziali
amarziali approved these changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mcculls mcculls changed the title Remove unused activeScope method (#8531) Remove unused activeScope method Apr 2, 2025
@mcculls mcculls merged commit a1a175c into master Apr 2, 2025
254 checks passed
@mcculls mcculls deleted the mcculls/remove-activeScope-method branch April 2, 2025 09:34
@github-actions github-actions bot added this to the 1.48.0 milestone Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali