Revert "Add avoid double instrumenting lambda non-streaming handlers." #8247

nhulston · 2025-01-17T21:30:20Z

Reverts #8073

This caused a tracing regression on Lambda (serverless) where AWS inferred spans were no longer being created.

Built and test manually; inferred spans now work on this branch:

github-actions · 2025-01-17T21:37:05Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

purple4reina · 2025-01-17T21:48:24Z

Here’s my assessment of what’s going on. The original PR was a collaboration between myself and
@amarziali.

There are two types of lambda functions in java: streaming and non-streaming. In the non-streaming case, the handler signature will be something like

  public APIGatewayV2HTTPResponse handleRequest(APIGatewayV2HTTPEvent event, Context context) {

While in the streaming case it’s always

  public void handleRequest(InputStream inputStream, OutputStream outputStream, Context context) throws IOException {

The problem we were seeing initially was that, due to using a single instrumentation class for both streaming and non-streaming, we were always getting null for the response payload in both cases.

The thing that was causing this is how aws implements these two handler types under the hood. The lambda runtime defines a special non-streaming handler, which has the signature of a streaming handler, but calls the customer’s non-streaming handler under the hood. This way, the non-streaming handlers are executed by the runtime the same as streaming handlers.

Our original version of the instrumentation for the non-streaming case wrapped both of these handlers, — the customer’s handler and the special runtime defined non-streaming converted to streaming handler — and unfortunately for us, the instrumentation on the streaming handler was firing first, thus preventing the instrumentation on the customer defined handler from executing.

The change that we’re reverting forced the instrumentation to ignore the special lambda runtime defined non-streaming converted to streaming handler.

purple4reina · 2025-01-17T21:50:48Z

FYI that reverting this change will put back into place a regression that has been present in the Datadog Lambda Java layer for some time.

The instrumentation was not properly wrapping the handler and so was always receiving null for the response payload, which is then sent to the extension for handling.

This meant that customers were unable to see their response payloads on their trace when DD_CAPTURE_LAMBDA_PAYLOAD=true. Without the response payload, we were also unable to determine the status code and thus were unable to set it as a span attribute.

pr-commenter · 2025-01-17T22:13:21Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	revert-8073-rey.abolofia/lambda-capture-response
git_commit_date	1737139405	1737155166
git_commit_sha	`0b239ae`	`356a1bd`
release_version	1.46.0-SNAPSHOT~0b239ae5cc	1.46.0-SNAPSHOT~356a1bd549

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737157682	1737157682
ci_job_id	771755727	771755727
ci_pipeline_id	53396468	53396468
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067724
Total [baseline] (10.612 s) : 0, 10611669
Agent [candidate] (1.054 s) : 0, 1053638
Total [candidate] (10.49 s) : 0, 10489868
section appsec
Agent [baseline] (1.19 s) : 0, 1189961
Total [baseline] (10.682 s) : 0, 10682182
Agent [candidate] (1.194 s) : 0, 1194340
Total [candidate] (10.733 s) : 0, 10732930
section iast
Agent [baseline] (1.182 s) : 0, 1182489
Total [baseline] (11.065 s) : 0, 11064934
Agent [candidate] (1.193 s) : 0, 1192925
Total [candidate] (11.01 s) : 0, 11010385
section profiling
Agent [baseline] (1.261 s) : 0, 1261134
Total [baseline] (10.876 s) : 0, 10875721
Agent [candidate] (1.252 s) : 0, 1252132
Total [candidate] (10.903 s) : 0, 10902785

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.068 s	-
Agent	appsec	1.19 s	122.237 ms (11.4%)
Agent	iast	1.182 s	114.765 ms (10.7%)
Agent	profiling	1.261 s	193.411 ms (18.1%)
Total	tracing	10.612 s	-
Total	appsec	10.682 s	70.513 ms (0.7%)
Total	iast	11.065 s	453.265 ms (4.3%)
Total	profiling	10.876 s	264.052 ms (2.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	appsec	1.194 s	140.702 ms (13.4%)
Agent	iast	1.193 s	139.287 ms (13.2%)
Agent	profiling	1.252 s	198.494 ms (18.8%)
Total	tracing	10.49 s	-
Total	appsec	10.733 s	243.062 ms (2.3%)
Total	iast	11.01 s	520.517 ms (5.0%)
Total	profiling	10.903 s	412.917 ms (3.9%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.823 ms) : 0, 723823
BytebuddyAgent [candidate] (713.292 ms) : 0, 713292
GlobalTracer [baseline] (257.663 ms) : 0, 257663
GlobalTracer [candidate] (255.789 ms) : 0, 255789
AppSec [baseline] (56.618 ms) : 0, 56618
AppSec [candidate] (55.721 ms) : 0, 55721
Remote Config [baseline] (739.965 µs) : 0, 740
Remote Config [candidate] (751.763 µs) : 0, 752
Telemetry [baseline] (13.718 ms) : 0, 13718
Telemetry [candidate] (13.062 ms) : 0, 13062
section appsec
BytebuddyAgent [baseline] (732.371 ms) : 0, 732371
BytebuddyAgent [candidate] (734.826 ms) : 0, 734826
GlobalTracer [baseline] (253.251 ms) : 0, 253251
GlobalTracer [candidate] (253.885 ms) : 0, 253885
AppSec [baseline] (170.753 ms) : 0, 170753
AppSec [candidate] (171.852 ms) : 0, 171852
IAST [baseline] (19.423 ms) : 0, 19423
IAST [candidate] (19.699 ms) : 0, 19699
Remote Config [baseline] (666.921 µs) : 0, 667
Remote Config [candidate] (675.685 µs) : 0, 676
Telemetry [baseline] (8.168 ms) : 0, 8168
Telemetry [candidate] (8.221 ms) : 0, 8221
section iast
BytebuddyAgent [baseline] (831.862 ms) : 0, 831862
BytebuddyAgent [candidate] (839.461 ms) : 0, 839461
GlobalTracer [baseline] (246.712 ms) : 0, 246712
GlobalTracer [candidate] (248.175 ms) : 0, 248175
AppSec [baseline] (58.112 ms) : 0, 58112
AppSec [candidate] (58.591 ms) : 0, 58591
IAST [baseline] (21.537 ms) : 0, 21537
IAST [candidate] (21.972 ms) : 0, 21972
Remote Config [baseline] (670.756 µs) : 0, 671
Remote Config [candidate] (677.0 µs) : 0, 677
Telemetry [baseline] (8.71 ms) : 0, 8710
Telemetry [candidate] (8.942 ms) : 0, 8942
section profiling
BytebuddyAgent [baseline] (707.18 ms) : 0, 707180
BytebuddyAgent [candidate] (702.567 ms) : 0, 702567
GlobalTracer [baseline] (351.338 ms) : 0, 351338
GlobalTracer [candidate] (349.586 ms) : 0, 349586
AppSec [baseline] (54.875 ms) : 0, 54875
AppSec [candidate] (53.7 ms) : 0, 53700
Remote Config [baseline] (705.374 µs) : 0, 705
Remote Config [candidate] (695.857 µs) : 0, 696
Telemetry [baseline] (8.824 ms) : 0, 8824
Telemetry [candidate] (8.788 ms) : 0, 8788
ProfilingAgent [baseline] (96.031 ms) : 0, 96031
ProfilingAgent [candidate] (94.946 ms) : 0, 94946
Profiling [baseline] (96.055 ms) : 0, 96055
Profiling [candidate] (94.969 ms) : 0, 94969

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059098
Total [baseline] (8.635 s) : 0, 8634610
Agent [candidate] (1.066 s) : 0, 1065620
Total [candidate] (8.639 s) : 0, 8639394
section iast
Agent [baseline] (1.185 s) : 0, 1185324
Total [baseline] (9.191 s) : 0, 9191080
Agent [candidate] (1.192 s) : 0, 1192496
Total [candidate] (9.23 s) : 0, 9229747
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1181562
Total [baseline] (9.173 s) : 0, 9172731
Agent [candidate] (1.182 s) : 0, 1182119
Total [candidate] (9.171 s) : 0, 9170524
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176774
Total [baseline] (9.187 s) : 0, 9186735
Agent [candidate] (1.18 s) : 0, 1180397
Total [candidate] (9.214 s) : 0, 9213675

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.059 s	-
Agent	iast	1.185 s	126.226 ms (11.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	122.464 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.177 s	117.677 ms (11.1%)
Total	tracing	8.635 s	-
Total	iast	9.191 s	556.47 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.173 s	538.121 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.187 s	552.124 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	iast	1.192 s	126.876 ms (11.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	116.499 ms (10.9%)
Agent	iast_TELEMETRY_OFF	1.18 s	114.777 ms (10.8%)
Total	tracing	8.639 s	-
Total	iast	9.23 s	590.354 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.171 s	531.13 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.214 s	574.281 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.977 ms) : 0, 715977
BytebuddyAgent [candidate] (723.158 ms) : 0, 723158
GlobalTracer [baseline] (257.396 ms) : 0, 257396
GlobalTracer [candidate] (257.838 ms) : 0, 257838
AppSec [baseline] (55.928 ms) : 0, 55928
AppSec [candidate] (55.939 ms) : 0, 55939
Remote Config [baseline] (740.075 µs) : 0, 740
Remote Config [candidate] (742.57 µs) : 0, 743
Telemetry [baseline] (14.045 ms) : 0, 14045
Telemetry [candidate] (12.714 ms) : 0, 12714
section iast
BytebuddyAgent [baseline] (833.867 ms) : 0, 833867
BytebuddyAgent [candidate] (839.023 ms) : 0, 839023
GlobalTracer [baseline] (246.936 ms) : 0, 246936
GlobalTracer [candidate] (248.339 ms) : 0, 248339
AppSec [baseline] (58.35 ms) : 0, 58350
AppSec [candidate] (58.598 ms) : 0, 58598
IAST [baseline] (21.591 ms) : 0, 21591
IAST [candidate] (21.691 ms) : 0, 21691
Remote Config [baseline] (669.881 µs) : 0, 670
Remote Config [candidate] (675.704 µs) : 0, 676
Telemetry [baseline] (8.916 ms) : 0, 8916
Telemetry [candidate] (8.923 ms) : 0, 8923
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.06 ms) : 0, 831060
BytebuddyAgent [candidate] (831.312 ms) : 0, 831312
GlobalTracer [baseline] (246.569 ms) : 0, 246569
GlobalTracer [candidate] (246.482 ms) : 0, 246482
AppSec [baseline] (58.05 ms) : 0, 58050
AppSec [candidate] (58.14 ms) : 0, 58140
IAST [baseline] (21.432 ms) : 0, 21432
IAST [candidate] (21.682 ms) : 0, 21682
Remote Config [baseline] (672.362 µs) : 0, 672
Remote Config [candidate] (675.831 µs) : 0, 676
Telemetry [baseline] (8.813 ms) : 0, 8813
Telemetry [candidate] (8.853 ms) : 0, 8853
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.423 ms) : 0, 827423
BytebuddyAgent [candidate] (830.062 ms) : 0, 830062
GlobalTracer [baseline] (246.165 ms) : 0, 246165
GlobalTracer [candidate] (247.044 ms) : 0, 247044
AppSec [baseline] (57.947 ms) : 0, 57947
AppSec [candidate] (57.959 ms) : 0, 57959
IAST [baseline] (20.906 ms) : 0, 20906
IAST [candidate] (20.926 ms) : 0, 20926
Remote Config [baseline] (668.788 µs) : 0, 669
Remote Config [candidate] (675.193 µs) : 0, 675
Telemetry [baseline] (8.71 ms) : 0, 8710
Telemetry [candidate] (8.696 ms) : 0, 8696

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-17T23:17:58	2025-01-17T23:25:01
git_branch	master	revert-8073-rey.abolofia/lambda-capture-response
git_commit_date	1737139405	1737155166
git_commit_sha	`0b239ae`	`356a1bd`
release_version	1.46.0-SNAPSHOT~0b239ae5cc	1.46.0-SNAPSHOT~356a1bd549
start_time	2025-01-17T23:17:44	2025-01-17T23:24:47

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737156661	1737156661
ci_job_id	771755728	771755728
ci_pipeline_id	53396468	53396468
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+75.465µs; +127.240µs] or [+5.118%; +8.630%]	unstable [-703.494op/s; +475.573op/s] or [-22.864%; +15.456%]	1.576ms	2962.963op/s	1.474ms	3076.923op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.363 ms) : 1344, 1383
.   : milestone, 1363,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.783 ms) : 1759, 1808
.   : milestone, 1783,
iast (1.509 ms) : 1484, 1534
.   : milestone, 1509,
profiling (1.474 ms) : 1451, 1498
.   : milestone, 1474,
tracing (1.5 ms) : 1476, 1525
.   : milestone, 1500,
section candidate
no_agent (1.372 ms) : 1352, 1391
.   : milestone, 1372,
appsec (1.757 ms) : 1733, 1781
.   : milestone, 1757,
appsec_no_iast (1.761 ms) : 1738, 1784
.   : milestone, 1761,
iast (1.519 ms) : 1494, 1543
.   : milestone, 1519,
profiling (1.576 ms) : 1551, 1601
.   : milestone, 1576,
tracing (1.494 ms) : 1470, 1518
.   : milestone, 1494,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.363 ms [1.344 ms, 1.383 ms]	-
appsec	1.732 ms [1.708 ms, 1.756 ms]	368.637 µs (27.0%)
appsec_no_iast	1.783 ms [1.759 ms, 1.808 ms]	419.75 µs (30.8%)
iast	1.509 ms [1.484 ms, 1.534 ms]	145.737 µs (10.7%)
profiling	1.474 ms [1.451 ms, 1.498 ms]	111.055 µs (8.1%)
tracing	1.5 ms [1.476 ms, 1.525 ms]	136.826 µs (10.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.372 ms [1.352 ms, 1.391 ms]	-
appsec	1.757 ms [1.733 ms, 1.781 ms]	385.522 µs (28.1%)
appsec_no_iast	1.761 ms [1.738 ms, 1.784 ms]	389.36 µs (28.4%)
iast	1.519 ms [1.494 ms, 1.543 ms]	147.307 µs (10.7%)
profiling	1.576 ms [1.551 ms, 1.601 ms]	204.144 µs (14.9%)
tracing	1.494 ms [1.47 ms, 1.518 ms]	122.503 µs (8.9%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.993 µs) : 351, 391
.   : milestone, 371,
iast (509.341 µs) : 487, 531
.   : milestone, 509,
iast_FULL (743.752 µs) : 722, 766
.   : milestone, 744,
iast_GLOBAL (558.274 µs) : 536, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (508.514 µs) : 486, 531
.   : milestone, 509,
iast_INACTIVE (462.835 µs) : 441, 485
.   : milestone, 463,
iast_TELEMETRY_OFF (491.384 µs) : 469, 513
.   : milestone, 491,
tracing (455.251 µs) : 434, 477
.   : milestone, 455,
section candidate
no_agent (375.251 µs) : 355, 395
.   : milestone, 375,
iast (509.396 µs) : 488, 531
.   : milestone, 509,
iast_FULL (738.155 µs) : 716, 760
.   : milestone, 738,
iast_GLOBAL (555.448 µs) : 533, 578
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (500.811 µs) : 479, 523
.   : milestone, 501,
iast_INACTIVE (461.536 µs) : 440, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (489.826 µs) : 468, 511
.   : milestone, 490,
tracing (451.842 µs) : 431, 473
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.993 µs [351.182 µs, 390.805 µs]	-
iast	509.341 µs [487.32 µs, 531.362 µs]	138.347 µs (37.3%)
iast_FULL	743.752 µs [721.582 µs, 765.922 µs]	372.759 µs (100.5%)
iast_GLOBAL	558.274 µs [535.772 µs, 580.777 µs]	187.281 µs (50.5%)
iast_HARDCODED_SECRET_DISABLED	508.514 µs [486.364 µs, 530.663 µs]	137.52 µs (37.1%)
iast_INACTIVE	462.835 µs [440.953 µs, 484.716 µs]	91.841 µs (24.8%)
iast_TELEMETRY_OFF	491.384 µs [469.435 µs, 513.333 µs]	120.391 µs (32.5%)
tracing	455.251 µs [433.901 µs, 476.602 µs]	84.258 µs (22.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.251 µs [355.355 µs, 395.147 µs]	-
iast	509.396 µs [487.553 µs, 531.239 µs]	134.145 µs (35.7%)
iast_FULL	738.155 µs [716.141 µs, 760.168 µs]	362.903 µs (96.7%)
iast_GLOBAL	555.448 µs [533.212 µs, 577.684 µs]	180.197 µs (48.0%)
iast_HARDCODED_SECRET_DISABLED	500.811 µs [479.049 µs, 522.573 µs]	125.56 µs (33.5%)
iast_INACTIVE	461.536 µs [439.791 µs, 483.28 µs]	86.284 µs (23.0%)
iast_TELEMETRY_OFF	489.826 µs [468.341 µs, 511.311 µs]	114.575 µs (30.5%)
tracing	451.842 µs [430.905 µs, 472.778 µs]	76.591 µs (20.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	revert-8073-rey.abolofia/lambda-capture-response
git_commit_date	1737139405	1737155166
git_commit_sha	`0b239ae`	`356a1bd`
release_version	1.46.0-SNAPSHOT~0b239ae5cc	1.46.0-SNAPSHOT~356a1bd549

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737157281	1737157281
ci_job_id	771755729	771755729
ci_pipeline_id	53396468	53396468
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.36 ms) : 2317, 2403
.   : milestone, 2360,
iast (2.1 ms) : 2046, 2155
.   : milestone, 2100,
iast_GLOBAL (2.153 ms) : 2098, 2208
.   : milestone, 2153,
profiling (1.973 ms) : 1929, 2017
.   : milestone, 1973,
tracing (1.962 ms) : 1919, 2004
.   : milestone, 1962,
section candidate
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.361 ms) : 2318, 2404
.   : milestone, 2361,
iast (2.096 ms) : 2042, 2150
.   : milestone, 2096,
iast_GLOBAL (2.156 ms) : 2101, 2211
.   : milestone, 2156,
profiling (2.0 ms) : 1955, 2044
.   : milestone, 2000,
tracing (1.951 ms) : 1909, 1993
.   : milestone, 1951,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	2.36 ms [2.317 ms, 2.403 ms]	888.487 µs (60.4%)
iast	2.1 ms [2.046 ms, 2.155 ms]	628.86 µs (42.7%)
iast_GLOBAL	2.153 ms [2.098 ms, 2.208 ms]	681.519 µs (46.3%)
profiling	1.973 ms [1.929 ms, 2.017 ms]	501.704 µs (34.1%)
tracing	1.962 ms [1.919 ms, 2.004 ms]	490.081 µs (33.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.361 ms [2.318 ms, 2.404 ms]	891.283 µs (60.7%)
iast	2.096 ms [2.042 ms, 2.15 ms]	626.724 µs (42.7%)
iast_GLOBAL	2.156 ms [2.101 ms, 2.211 ms]	686.974 µs (46.8%)
profiling	2.0 ms [1.955 ms, 2.044 ms]	530.222 µs (36.1%)
tracing	1.951 ms [1.909 ms, 1.993 ms]	482.023 µs (32.8%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~356a1bd549, baseline=1.46.0-SNAPSHOT~0b239ae5cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.416 s) : 15416000, 15416000
.   : milestone, 15416000,
appsec (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
iast (18.687 s) : 18687000, 18687000
.   : milestone, 18687000,
iast_GLOBAL (18.174 s) : 18174000, 18174000
.   : milestone, 18174000,
profiling (15.103 s) : 15103000, 15103000
.   : milestone, 15103000,
tracing (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
section candidate
no_agent (15.512 s) : 15512000, 15512000
.   : milestone, 15512000,
appsec (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
iast (18.852 s) : 18852000, 18852000
.   : milestone, 18852000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
.   : milestone, 17949000,
profiling (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
tracing (15.298 s) : 15298000, 15298000
.   : milestone, 15298000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.416 s [15.416 s, 15.416 s]	-
appsec	15.047 s [15.047 s, 15.047 s]	-369.0 ms (-2.4%)
iast	18.687 s [18.687 s, 18.687 s]	3.271 s (21.2%)
iast_GLOBAL	18.174 s [18.174 s, 18.174 s]	2.758 s (17.9%)
profiling	15.103 s [15.103 s, 15.103 s]	-313.0 ms (-2.0%)
tracing	14.995 s [14.995 s, 14.995 s]	-421.0 ms (-2.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.512 s [15.512 s, 15.512 s]	-
appsec	15.031 s [15.031 s, 15.031 s]	-481.0 ms (-3.1%)
iast	18.852 s [18.852 s, 18.852 s]	3.34 s (21.5%)
iast_GLOBAL	17.949 s [17.949 s, 17.949 s]	2.437 s (15.7%)
profiling	14.959 s [14.959 s, 14.959 s]	-553.0 ms (-3.6%)
tracing	15.298 s [15.298 s, 15.298 s]	-214.0 ms (-1.4%)

…#8073)" This reverts commit 82cd3f5.

purple4reina approved these changes Jan 17, 2025

View reviewed changes

nhulston marked this pull request as ready for review January 17, 2025 21:36

nhulston requested a review from a team as a code owner January 17, 2025 21:36

nhulston requested a review from manuel-alvarez-alvarez January 17, 2025 21:36

nhulston added tag: serverless Serverless support type: bug inst: aws sdk AWS SDK instrumentation labels Jan 17, 2025

nhulston force-pushed the revert-8073-rey.abolofia/lambda-capture-response branch from 78f10c6 to 13262f4 Compare January 17, 2025 22:12

nhulston enabled auto-merge (squash) January 17, 2025 22:22

Revert "Add avoid double instrumenting lambda non-streaming handlers. (…

356a1bd

…#8073)" This reverts commit 82cd3f5.

nhulston force-pushed the revert-8073-rey.abolofia/lambda-capture-response branch from e40cc3c to 356a1bd Compare January 17, 2025 23:06

mcculls approved these changes Jan 18, 2025

View reviewed changes

amarziali approved these changes Jan 20, 2025

View reviewed changes

amarziali added comp: api Tracer public API and removed comp: api Tracer public API labels Jan 20, 2025

nhulston merged commit 0767e3c into master Jan 20, 2025
173 of 174 checks passed

nhulston deleted the revert-8073-rey.abolofia/lambda-capture-response branch January 20, 2025 08:00

github-actions bot added this to the 1.46.0 milestone Jan 20, 2025

purple4reina mentioned this pull request Jan 21, 2025

Properly capture lambda payloads for all handler types. #8264

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Add avoid double instrumenting lambda non-streaming handlers." #8247

Revert "Add avoid double instrumenting lambda non-streaming handlers." #8247

nhulston commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

purple4reina commented Jan 17, 2025

purple4reina commented Jan 17, 2025

pr-commenter bot commented Jan 17, 2025 •

edited

Loading

Revert "Add avoid double instrumenting lambda non-streaming handlers." #8247

Revert "Add avoid double instrumenting lambda non-streaming handlers." #8247

Conversation

nhulston commented Jan 17, 2025 • edited Loading

github-actions bot commented Jan 17, 2025 • edited Loading

purple4reina commented Jan 17, 2025

purple4reina commented Jan 17, 2025

pr-commenter bot commented Jan 17, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

nhulston commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

pr-commenter bot commented Jan 17, 2025 •

edited

Loading