-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] improve setup of dev env on Windows #8180
Draft
lucaspimentel
wants to merge
10
commits into
master
Choose a base branch
from
lpimentel/improve-windows-devex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+353
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspimentel
force-pushed
the
lpimentel/improve-windows-devex
branch
from
January 10, 2025 23:43
edab42a
to
49b945c
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 2 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053039
Total [baseline] (10.447 s) : 0, 10446899
Agent [candidate] (1.056 s) : 0, 1055895
Total [candidate] (10.47 s) : 0, 10470374
section appsec
Agent [baseline] (1.189 s) : 0, 1188700
Total [baseline] (10.724 s) : 0, 10723815
Agent [candidate] (1.194 s) : 0, 1194112
Total [candidate] (10.747 s) : 0, 10746891
section iast
Agent [baseline] (1.192 s) : 0, 1191528
Total [baseline] (10.975 s) : 0, 10975005
Agent [candidate] (1.192 s) : 0, 1192375
Total [candidate] (11.033 s) : 0, 11033335
section profiling
Agent [baseline] (1.249 s) : 0, 1249346
Total [baseline] (10.856 s) : 0, 10855582
Agent [candidate] (1.263 s) : 0, 1262624
Total [candidate] (10.906 s) : 0, 10906126
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.171 ms) : 0, 713171
BytebuddyAgent [candidate] (713.592 ms) : 0, 713592
GlobalTracer [baseline] (255.344 ms) : 0, 255344
GlobalTracer [candidate] (255.629 ms) : 0, 255629
AppSec [baseline] (56.021 ms) : 0, 56021
AppSec [candidate] (55.889 ms) : 0, 55889
Remote Config [baseline] (729.359 µs) : 0, 729
Remote Config [candidate] (729.448 µs) : 0, 729
Telemetry [baseline] (12.809 ms) : 0, 12809
Telemetry [candidate] (15.057 ms) : 0, 15057
section appsec
BytebuddyAgent [baseline] (730.904 ms) : 0, 730904
BytebuddyAgent [candidate] (734.651 ms) : 0, 734651
GlobalTracer [baseline] (252.775 ms) : 0, 252775
GlobalTracer [candidate] (254.399 ms) : 0, 254399
AppSec [baseline] (171.499 ms) : 0, 171499
AppSec [candidate] (171.409 ms) : 0, 171409
Remote Config [baseline] (666.792 µs) : 0, 667
Remote Config [candidate] (675.121 µs) : 0, 675
Telemetry [baseline] (8.187 ms) : 0, 8187
Telemetry [candidate] (8.237 ms) : 0, 8237
IAST [baseline] (19.369 ms) : 0, 19369
IAST [candidate] (19.323 ms) : 0, 19323
section iast
BytebuddyAgent [baseline] (838.296 ms) : 0, 838296
BytebuddyAgent [candidate] (839.299 ms) : 0, 839299
GlobalTracer [baseline] (248.07 ms) : 0, 248070
GlobalTracer [candidate] (248.413 ms) : 0, 248413
AppSec [baseline] (58.642 ms) : 0, 58642
AppSec [candidate] (57.978 ms) : 0, 57978
Remote Config [baseline] (674.196 µs) : 0, 674
Remote Config [candidate] (676.794 µs) : 0, 677
Telemetry [baseline] (8.96 ms) : 0, 8960
Telemetry [candidate] (8.879 ms) : 0, 8879
IAST [baseline] (21.753 ms) : 0, 21753
IAST [candidate] (21.879 ms) : 0, 21879
section profiling
BytebuddyAgent [baseline] (700.468 ms) : 0, 700468
BytebuddyAgent [candidate] (708.253 ms) : 0, 708253
GlobalTracer [baseline] (348.174 ms) : 0, 348174
GlobalTracer [candidate] (352.124 ms) : 0, 352124
AppSec [baseline] (54.578 ms) : 0, 54578
AppSec [candidate] (54.106 ms) : 0, 54106
Remote Config [baseline] (707.034 µs) : 0, 707
Remote Config [candidate] (659.121 µs) : 0, 659
Telemetry [baseline] (8.794 ms) : 0, 8794
Telemetry [candidate] (8.986 ms) : 0, 8986
ProfilingAgent [baseline] (94.759 ms) : 0, 94759
ProfilingAgent [candidate] (96.213 ms) : 0, 96213
Profiling [baseline] (94.783 ms) : 0, 94783
Profiling [candidate] (96.237 ms) : 0, 96237
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063768
Total [baseline] (8.654 s) : 0, 8654106
Agent [candidate] (1.055 s) : 0, 1054630
Total [candidate] (8.624 s) : 0, 8624201
section iast
Agent [baseline] (1.183 s) : 0, 1182761
Total [baseline] (9.205 s) : 0, 9205447
Agent [candidate] (1.19 s) : 0, 1190364
Total [candidate] (9.204 s) : 0, 9204282
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1191560
Total [baseline] (9.2 s) : 0, 9200136
Agent [candidate] (1.18 s) : 0, 1180181
Total [candidate] (9.157 s) : 0, 9157488
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1189605
Total [baseline] (9.19 s) : 0, 9189968
Agent [candidate] (1.177 s) : 0, 1176502
Total [candidate] (9.205 s) : 0, 9205228
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.501 ms) : 0, 718501
BytebuddyAgent [candidate] (713.238 ms) : 0, 713238
GlobalTracer [baseline] (257.689 ms) : 0, 257689
GlobalTracer [candidate] (255.099 ms) : 0, 255099
AppSec [baseline] (56.828 ms) : 0, 56828
AppSec [candidate] (56.43 ms) : 0, 56430
Remote Config [baseline] (758.319 µs) : 0, 758
Remote Config [candidate] (714.017 µs) : 0, 714
Telemetry [baseline] (14.976 ms) : 0, 14976
Telemetry [candidate] (14.191 ms) : 0, 14191
section iast
BytebuddyAgent [baseline] (832.375 ms) : 0, 832375
BytebuddyAgent [candidate] (838.126 ms) : 0, 838126
GlobalTracer [baseline] (246.346 ms) : 0, 246346
GlobalTracer [candidate] (247.835 ms) : 0, 247835
AppSec [baseline] (58.06 ms) : 0, 58060
AppSec [candidate] (58.217 ms) : 0, 58217
Remote Config [baseline] (649.245 µs) : 0, 649
Remote Config [candidate] (682.015 µs) : 0, 682
Telemetry [baseline] (8.814 ms) : 0, 8814
Telemetry [candidate] (8.841 ms) : 0, 8841
IAST [baseline] (21.472 ms) : 0, 21472
IAST [candidate] (21.566 ms) : 0, 21566
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.826 ms) : 0, 837826
BytebuddyAgent [candidate] (829.859 ms) : 0, 829859
GlobalTracer [baseline] (248.061 ms) : 0, 248061
GlobalTracer [candidate] (246.547 ms) : 0, 246547
AppSec [baseline] (59.117 ms) : 0, 59117
AppSec [candidate] (57.998 ms) : 0, 57998
Remote Config [baseline] (693.062 µs) : 0, 693
Remote Config [candidate] (660.14 µs) : 0, 660
Telemetry [baseline] (8.968 ms) : 0, 8968
Telemetry [candidate] (8.73 ms) : 0, 8730
IAST [baseline] (21.795 ms) : 0, 21795
IAST [candidate] (21.333 ms) : 0, 21333
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.932 ms) : 0, 836932
BytebuddyAgent [candidate] (827.726 ms) : 0, 827726
GlobalTracer [baseline] (248.879 ms) : 0, 248879
GlobalTracer [candidate] (246.229 ms) : 0, 246229
AppSec [baseline] (58.085 ms) : 0, 58085
AppSec [candidate] (57.563 ms) : 0, 57563
Remote Config [baseline] (677.065 µs) : 0, 677
Remote Config [candidate] (650.721 µs) : 0, 651
Telemetry [baseline] (8.709 ms) : 0, 8709
Telemetry [candidate] (8.577 ms) : 0, 8577
IAST [baseline] (21.23 ms) : 0, 21230
IAST [candidate] (20.796 ms) : 0, 20796
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section baseline
no_agent (374.665 µs) : 354, 396
. : milestone, 375,
iast (504.136 µs) : 483, 526
. : milestone, 504,
iast_FULL (741.269 µs) : 720, 763
. : milestone, 741,
iast_GLOBAL (551.839 µs) : 530, 574
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (498.076 µs) : 477, 520
. : milestone, 498,
iast_INACTIVE (452.48 µs) : 431, 474
. : milestone, 452,
iast_TELEMETRY_OFF (493.092 µs) : 471, 515
. : milestone, 493,
tracing (451.666 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (375.349 µs) : 356, 395
. : milestone, 375,
iast (487.498 µs) : 466, 509
. : milestone, 487,
iast_FULL (649.495 µs) : 628, 671
. : milestone, 649,
iast_GLOBAL (522.475 µs) : 500, 545
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (489.566 µs) : 468, 511
. : milestone, 490,
iast_INACTIVE (453.412 µs) : 432, 475
. : milestone, 453,
iast_TELEMETRY_OFF (483.074 µs) : 461, 505
. : milestone, 483,
tracing (448.71 µs) : 428, 469
. : milestone, 449,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section baseline
no_agent (1.336 ms) : 1316, 1355
. : milestone, 1336,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.763 ms) : 1740, 1786
. : milestone, 1763,
iast (1.495 ms) : 1471, 1520
. : milestone, 1495,
profiling (1.503 ms) : 1477, 1528
. : milestone, 1503,
tracing (1.457 ms) : 1432, 1482
. : milestone, 1457,
section candidate
no_agent (1.351 ms) : 1331, 1370
. : milestone, 1351,
appsec (1.735 ms) : 1710, 1759
. : milestone, 1735,
appsec_no_iast (1.759 ms) : 1736, 1781
. : milestone, 1759,
iast (1.488 ms) : 1465, 1511
. : milestone, 1488,
profiling (1.503 ms) : 1479, 1527
. : milestone, 1503,
tracing (1.48 ms) : 1454, 1505
. : milestone, 1480,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section baseline
no_agent (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
appsec (15.014 s) : 15014000, 15014000
. : milestone, 15014000,
iast (18.794 s) : 18794000, 18794000
. : milestone, 18794000,
iast_GLOBAL (17.636 s) : 17636000, 17636000
. : milestone, 17636000,
profiling (15.159 s) : 15159000, 15159000
. : milestone, 15159000,
tracing (15.098 s) : 15098000, 15098000
. : milestone, 15098000,
section candidate
no_agent (14.913 s) : 14913000, 14913000
. : milestone, 14913000,
appsec (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
iast (18.759 s) : 18759000, 18759000
. : milestone, 18759000,
iast_GLOBAL (17.934 s) : 17934000, 17934000
. : milestone, 17934000,
profiling (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
tracing (15.142 s) : 15142000, 15142000
. : milestone, 15142000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~7d6b4ed6c8, baseline=1.46.0-SNAPSHOT~0b239ae5cc
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.369 ms) : 2326, 2412
. : milestone, 2369,
iast (2.111 ms) : 2056, 2165
. : milestone, 2111,
iast_GLOBAL (2.147 ms) : 2093, 2202
. : milestone, 2147,
profiling (1.976 ms) : 1932, 2020
. : milestone, 1976,
tracing (1.948 ms) : 1906, 1990
. : milestone, 1948,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.36 ms) : 2317, 2403
. : milestone, 2360,
iast (2.105 ms) : 2051, 2159
. : milestone, 2105,
iast_GLOBAL (2.145 ms) : 2090, 2199
. : milestone, 2145,
profiling (1.982 ms) : 1937, 2027
. : milestone, 1982,
tracing (1.944 ms) : 1902, 1986
. : milestone, 1944,
|
lucaspimentel
force-pushed
the
lpimentel/improve-windows-devex
branch
from
January 14, 2025 16:57
cb13e10
to
2cdf74c
Compare
lucaspimentel
force-pushed
the
lpimentel/improve-windows-devex
branch
from
January 14, 2025 16:57
2cdf74c
to
140b9b4
Compare
lucaspimentel
force-pushed
the
lpimentel/improve-windows-devex
branch
from
January 14, 2025 22:16
ba49891
to
81367a6
Compare
lucaspimentel
changed the title
[docs] improve windows devex
[docs] improve devex on Windows
Jan 15, 2025
lucaspimentel
commented
Jan 15, 2025
lucaspimentel
commented
Jan 15, 2025
lucaspimentel
commented
Jan 15, 2025
lucaspimentel
changed the title
[docs] improve devex on Windows
[docs] improve setup of dev env on Windows
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Try to improve the steps to set up the
dd-trace-java
development environment on Windows:setup.ps1
for quick check (same assetup.sh
)tooling/install-jdks-windows.ps1
to install required SDKs and environment variablesBUILDING.md
Motivation
I am working with
dd-trace-java
for the first time, and I have a Windows laptop, so I'm trying to cover some of the onboarding gaps for the next engineer 😅Additional Notes
These changes only cover docs and scripts to set up dev env on Windows. No code changes to the library itself. (i.e. tests required)
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]