Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HasMethodAdvice aspect to instrumentations, away from modules #8139

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Move HasMethodAdvice aspect to instrumentations, away from modules #8139

merged 3 commits into from
Jan 1, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Dec 31, 2024 •
edited
Loading

What Does This Do

Refactoring to help with the migration to instrumentation modules that group together related instrumentations, but do not themselves declare any type or method advice.

Additional Notes

Includes some related changes to also help migration to instrumentation modules:

  • Load 'AbcModule' definitions from the instrumentation class-loader so they can be unloaded after startup
  • Move postProcessor option to InstrumenterModule, so it can be shared across the grouped instrumentations

Contributor Checklist

Jira ticket: APMAPI-858

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Dec 31, 2024
@mcculls mcculls force-pushed the mcculls/move-hasmethodadvice-from-modules branch 2 times, most recently from 5a63053 to 61fb7f5 Compare December 31, 2024 14:53
@mcculls mcculls force-pushed the mcculls/move-hasmethodadvice-from-modules branch from 61fb7f5 to 14f1a38 Compare December 31, 2024 15:03
@mcculls mcculls marked this pull request as ready for review December 31, 2024 15:26
@mcculls mcculls requested review from a team as code owners December 31, 2024 15:26
@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/move-hasmethodadvice-from-modules
git_commit_date 1735656717 1735685615
git_commit_sha c99c2c2 37ad948
release_version 1.45.0-SNAPSHOT~c99c2c2042 1.45.0-SNAPSHOT~37ad948dba
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735688143 1735688143
ci_job_id 751838277 751838277
ci_pipeline_id 51960821 51960821
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050523
Total [baseline] (10.39 s) : 0, 10389530
Agent [candidate] (1.058 s) : 0, 1058440
Total [candidate] (10.434 s) : 0, 10433625
section appsec
Agent [baseline] (1.185 s) : 0, 1184964
Total [baseline] (10.749 s) : 0, 10749226
Agent [candidate] (1.189 s) : 0, 1189032
Total [candidate] (10.741 s) : 0, 10740513
section iast
Agent [baseline] (1.179 s) : 0, 1179210
Total [baseline] (11.017 s) : 0, 11017425
Agent [candidate] (1.183 s) : 0, 1182751
Total [candidate] (10.962 s) : 0, 10961531
section profiling
Agent [baseline] (1.282 s) : 0, 1281669
Total [baseline] (10.917 s) : 0, 10916512
Agent [candidate] (1.282 s) : 0, 1281761
Total [candidate] (10.89 s) : 0, 10890022
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.185 s 134.441 ms (12.8%)
Agent iast 1.179 s 128.687 ms (12.2%)
Agent profiling 1.282 s 231.146 ms (22.0%)
Total tracing 10.39 s -
Total appsec 10.749 s 359.695 ms (3.5%)
Total iast 11.017 s 627.895 ms (6.0%)
Total profiling 10.917 s 526.981 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.189 s 130.592 ms (12.3%)
Agent iast 1.183 s 124.311 ms (11.7%)
Agent profiling 1.282 s 223.321 ms (21.1%)
Total tracing 10.434 s -
Total appsec 10.741 s 306.888 ms (2.9%)
Total iast 10.962 s 527.907 ms (5.1%)
Total profiling 10.89 s 456.398 ms (4.4%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.272 ms) : 0, 711272
BytebuddyAgent [candidate] (717.483 ms) : 0, 717483
GlobalTracer [baseline] (256.098 ms) : 0, 256098
GlobalTracer [candidate] (258.282 ms) : 0, 258282
AppSec [baseline] (55.243 ms) : 0, 55243
AppSec [candidate] (55.534 ms) : 0, 55534
Remote Config [baseline] (717.687 µs) : 0, 718
Remote Config [candidate] (709.833 µs) : 0, 710
Telemetry [baseline] (12.158 ms) : 0, 12158
Telemetry [candidate] (11.311 ms) : 0, 11311
section appsec
BytebuddyAgent [baseline] (728.239 ms) : 0, 728239
BytebuddyAgent [candidate] (729.376 ms) : 0, 729376
GlobalTracer [baseline] (253.052 ms) : 0, 253052
GlobalTracer [candidate] (254.565 ms) : 0, 254565
AppSec [baseline] (170.285 ms) : 0, 170285
AppSec [candidate] (171.469 ms) : 0, 171469
Remote Config [baseline] (667.415 µs) : 0, 667
Remote Config [candidate] (666.998 µs) : 0, 667
Telemetry [baseline] (8.027 ms) : 0, 8027
Telemetry [candidate] (8.118 ms) : 0, 8118
IAST [baseline] (19.424 ms) : 0, 19424
IAST [candidate] (19.544 ms) : 0, 19544
section iast
BytebuddyAgent [baseline] (827.347 ms) : 0, 827347
BytebuddyAgent [candidate] (831.072 ms) : 0, 831072
GlobalTracer [baseline] (247.709 ms) : 0, 247709
GlobalTracer [candidate] (247.507 ms) : 0, 247507
AppSec [baseline] (58.278 ms) : 0, 58278
AppSec [candidate] (58.312 ms) : 0, 58312
Remote Config [baseline] (661.949 µs) : 0, 662
Remote Config [candidate] (652.788 µs) : 0, 653
Telemetry [baseline] (8.564 ms) : 0, 8564
Telemetry [candidate] (8.581 ms) : 0, 8581
IAST [baseline] (21.655 ms) : 0, 21655
IAST [candidate] (21.563 ms) : 0, 21563
section profiling
BytebuddyAgent [baseline] (705.535 ms) : 0, 705535
BytebuddyAgent [candidate] (706.492 ms) : 0, 706492
GlobalTracer [baseline] (373.649 ms) : 0, 373649
GlobalTracer [candidate] (373.643 ms) : 0, 373643
AppSec [baseline] (54.972 ms) : 0, 54972
AppSec [candidate] (54.22 ms) : 0, 54220
Remote Config [baseline] (737.242 µs) : 0, 737
Remote Config [candidate] (673.493 µs) : 0, 673
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (7.85 ms) : 0, 7850
ProfilingAgent [baseline] (97.105 ms) : 0, 97105
ProfilingAgent [candidate] (96.822 ms) : 0, 96822
Profiling [baseline] (97.13 ms) : 0, 97130
Profiling [candidate] (96.846 ms) : 0, 96846
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053852
Total [baseline] (8.615 s) : 0, 8614676
Agent [candidate] (1.053 s) : 0, 1052771
Total [candidate] (8.629 s) : 0, 8629308
section iast
Agent [baseline] (1.186 s) : 0, 1185961
Total [baseline] (9.205 s) : 0, 9204576
Agent [candidate] (1.18 s) : 0, 1179610
Total [candidate] (9.182 s) : 0, 9182073
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.188 s) : 0, 1188157
Total [baseline] (9.213 s) : 0, 9213270
Agent [candidate] (1.194 s) : 0, 1193598
Total [candidate] (9.195 s) : 0, 9194839
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175403
Total [baseline] (9.167 s) : 0, 9167002
Agent [candidate] (1.193 s) : 0, 1193320
Total [candidate] (9.192 s) : 0, 9192162
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.186 s 132.11 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.188 s 134.306 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.175 s 121.552 ms (11.5%)
Total tracing 8.615 s -
Total iast 9.205 s 589.9 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.213 s 598.594 ms (6.9%)
Total iast_TELEMETRY_OFF 9.167 s 552.327 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.18 s 126.839 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 140.827 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.193 s 140.549 ms (13.4%)
Total tracing 8.629 s -
Total iast 9.182 s 552.765 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.195 s 565.53 ms (6.6%)
Total iast_TELEMETRY_OFF 9.192 s 562.854 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.14 ms) : 0, 713140
BytebuddyAgent [candidate] (712.946 ms) : 0, 712946
GlobalTracer [baseline] (256.927 ms) : 0, 256927
GlobalTracer [candidate] (256.843 ms) : 0, 256843
AppSec [baseline] (55.147 ms) : 0, 55147
AppSec [candidate] (55.174 ms) : 0, 55174
Remote Config [baseline] (714.041 µs) : 0, 714
Remote Config [candidate] (708.558 µs) : 0, 709
Telemetry [baseline] (12.728 ms) : 0, 12728
Telemetry [candidate] (12.023 ms) : 0, 12023
section iast
BytebuddyAgent [baseline] (834.094 ms) : 0, 834094
BytebuddyAgent [candidate] (829.108 ms) : 0, 829108
GlobalTracer [baseline] (247.939 ms) : 0, 247939
GlobalTracer [candidate] (246.581 ms) : 0, 246581
AppSec [baseline] (58.081 ms) : 0, 58081
AppSec [candidate] (58.128 ms) : 0, 58128
Remote Config [baseline] (654.704 µs) : 0, 655
Remote Config [candidate] (656.113 µs) : 0, 656
Telemetry [baseline] (8.631 ms) : 0, 8631
Telemetry [candidate] (8.614 ms) : 0, 8614
IAST [baseline] (21.416 ms) : 0, 21416
IAST [candidate] (21.502 ms) : 0, 21502
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.492 ms) : 0, 834492
BytebuddyAgent [candidate] (839.714 ms) : 0, 839714
GlobalTracer [baseline] (248.545 ms) : 0, 248545
GlobalTracer [candidate] (248.799 ms) : 0, 248799
AppSec [baseline] (58.84 ms) : 0, 58840
AppSec [candidate] (58.481 ms) : 0, 58481
Remote Config [baseline] (661.139 µs) : 0, 661
Remote Config [candidate] (703.872 µs) : 0, 704
Telemetry [baseline] (8.715 ms) : 0, 8715
Telemetry [candidate] (8.753 ms) : 0, 8753
IAST [baseline] (21.699 ms) : 0, 21699
IAST [candidate] (21.867 ms) : 0, 21867
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (825.669 ms) : 0, 825669
BytebuddyAgent [candidate] (838.777 ms) : 0, 838777
GlobalTracer [baseline] (246.61 ms) : 0, 246610
GlobalTracer [candidate] (249.931 ms) : 0, 249931
AppSec [baseline] (57.995 ms) : 0, 57995
AppSec [candidate] (58.574 ms) : 0, 58574
Remote Config [baseline] (654.319 µs) : 0, 654
Remote Config [candidate] (676.53 µs) : 0, 677
Telemetry [baseline] (8.47 ms) : 0, 8470
Telemetry [candidate] (8.556 ms) : 0, 8556
IAST [baseline] (21.029 ms) : 0, 21029
IAST [candidate] (21.595 ms) : 0, 21595
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-31T23:06:02 2024-12-31T23:13:00
git_branch master mcculls/move-hasmethodadvice-from-modules
git_commit_date 1735656717 1735685615
git_commit_sha c99c2c2 37ad948
release_version 1.45.0-SNAPSHOT~c99c2c2042 1.45.0-SNAPSHOT~37ad948dba
start_time 2024-12-31T23:05:48 2024-12-31T23:12:47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735687135 1735687135
ci_job_id 751838278 751838278
ci_pipeline_id 51960821 51960821
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+38.775µs; +90.685µs] or [+2.597%; +6.075%]		 unstable
[-676.595op/s; +448.675op/s] or [-21.989%; +14.582%]		 1.558ms 2962.963op/s 1.493ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042
    dateFormat X
    axisFormat %s
section baseline
no_agent (385.554 µs) : 366, 405
.   : milestone, 386,
iast (491.864 µs) : 471, 513
.   : milestone, 492,
iast_FULL (660.187 µs) : 639, 682
.   : milestone, 660,
iast_GLOBAL (531.485 µs) : 509, 554
.   : milestone, 531,
iast_HARDCODED_SECRET_DISABLED (493.983 µs) : 473, 515
.   : milestone, 494,
iast_INACTIVE (454.297 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (496.257 µs) : 473, 519
.   : milestone, 496,
tracing (453.283 µs) : 432, 474
.   : milestone, 453,
section candidate
no_agent (373.6 µs) : 354, 394
.   : milestone, 374,
iast (490.008 µs) : 469, 511
.   : milestone, 490,
iast_FULL (653.225 µs) : 631, 675
.   : milestone, 653,
iast_GLOBAL (522.226 µs) : 501, 544
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (496.541 µs) : 475, 518
.   : milestone, 497,
iast_INACTIVE (456.965 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (483.052 µs) : 461, 505
.   : milestone, 483,
tracing (448.787 µs) : 428, 469
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.554 µs [365.757 µs, 405.35 µs] -
iast 491.864 µs [470.568 µs, 513.161 µs] 106.31 µs (27.6%)
iast_FULL 660.187 µs [638.517 µs, 681.857 µs] 274.633 µs (71.2%)
iast_GLOBAL 531.485 µs [508.807 µs, 554.162 µs] 145.931 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 493.983 µs [472.693 µs, 515.274 µs] 108.429 µs (28.1%)
iast_INACTIVE 454.297 µs [433.182 µs, 475.412 µs] 68.743 µs (17.8%)
iast_TELEMETRY_OFF 496.257 µs [473.396 µs, 519.117 µs] 110.703 µs (28.7%)
tracing 453.283 µs [432.294 µs, 474.271 µs] 67.729 µs (17.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.6 µs [353.533 µs, 393.668 µs] -
iast 490.008 µs [468.604 µs, 511.412 µs] 116.408 µs (31.2%)
iast_FULL 653.225 µs [631.444 µs, 675.005 µs] 279.624 µs (74.8%)
iast_GLOBAL 522.226 µs [500.742 µs, 543.71 µs] 148.626 µs (39.8%)
iast_HARDCODED_SECRET_DISABLED 496.541 µs [474.853 µs, 518.23 µs] 122.941 µs (32.9%)
iast_INACTIVE 456.965 µs [435.504 µs, 478.427 µs] 83.365 µs (22.3%)
iast_TELEMETRY_OFF 483.052 µs [461.269 µs, 504.835 µs] 109.452 µs (29.3%)
tracing 448.787 µs [428.342 µs, 469.232 µs] 75.187 µs (20.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.373 ms) : 1353, 1394
.   : milestone, 1373,
appsec (1.752 ms) : 1729, 1776
.   : milestone, 1752,
appsec_no_iast (1.777 ms) : 1750, 1804
.   : milestone, 1777,
iast (1.5 ms) : 1476, 1523
.   : milestone, 1500,
profiling (1.493 ms) : 1469, 1517
.   : milestone, 1493,
tracing (1.487 ms) : 1462, 1511
.   : milestone, 1487,
section candidate
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.745 ms) : 1721, 1769
.   : milestone, 1745,
appsec_no_iast (1.775 ms) : 1752, 1799
.   : milestone, 1775,
iast (1.509 ms) : 1487, 1532
.   : milestone, 1509,
profiling (1.558 ms) : 1533, 1582
.   : milestone, 1558,
tracing (1.496 ms) : 1472, 1520
.   : milestone, 1496,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.373 ms [1.353 ms, 1.394 ms] -
appsec 1.752 ms [1.729 ms, 1.776 ms] 379.011 µs (27.6%)
appsec_no_iast 1.777 ms [1.75 ms, 1.804 ms] 403.783 µs (29.4%)
iast 1.5 ms [1.476 ms, 1.523 ms] 126.439 µs (9.2%)
profiling 1.493 ms [1.469 ms, 1.517 ms] 119.443 µs (8.7%)
tracing 1.487 ms [1.462 ms, 1.511 ms] 113.239 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.374 ms] -
appsec 1.745 ms [1.721 ms, 1.769 ms] 390.313 µs (28.8%)
appsec_no_iast 1.775 ms [1.752 ms, 1.799 ms] 420.776 µs (31.1%)
iast 1.509 ms [1.487 ms, 1.532 ms] 154.69 µs (11.4%)
profiling 1.558 ms [1.533 ms, 1.582 ms] 202.876 µs (15.0%)
tracing 1.496 ms [1.472 ms, 1.52 ms] 141.493 µs (10.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/move-hasmethodadvice-from-modules
git_commit_date 1735656717 1735685615
git_commit_sha c99c2c2 37ad948
release_version 1.45.0-SNAPSHOT~c99c2c2042 1.45.0-SNAPSHOT~37ad948dba
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1735687722 1735687722
ci_job_id 751838279 751838279
ci_pipeline_id 51960821 51960821
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1494
.   : milestone, 1482,
appsec (2.366 ms) : 2324, 2407
.   : milestone, 2366,
iast (2.092 ms) : 2040, 2145
.   : milestone, 2092,
iast_GLOBAL (2.142 ms) : 2089, 2196
.   : milestone, 2142,
profiling (2.466 ms) : 2279, 2653
.   : milestone, 2466,
tracing (1.946 ms) : 1906, 1986
.   : milestone, 1946,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (2.358 ms) : 2316, 2400
.   : milestone, 2358,
iast (2.098 ms) : 2045, 2151
.   : milestone, 2098,
iast_GLOBAL (2.144 ms) : 2091, 2197
.   : milestone, 2144,
profiling (2.451 ms) : 2261, 2641
.   : milestone, 2451,
tracing (1.938 ms) : 1897, 1979
.   : milestone, 1938,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.494 ms] -
appsec 2.366 ms [2.324 ms, 2.407 ms] 883.548 µs (59.6%)
iast 2.092 ms [2.04 ms, 2.145 ms] 610.459 µs (41.2%)
iast_GLOBAL 2.142 ms [2.089 ms, 2.196 ms] 660.309 µs (44.6%)
profiling 2.466 ms [2.279 ms, 2.653 ms] 983.786 µs (66.4%)
tracing 1.946 ms [1.906 ms, 1.986 ms] 464.005 µs (31.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 2.358 ms [2.316 ms, 2.4 ms] 878.653 µs (59.4%)
iast 2.098 ms [2.045 ms, 2.151 ms] 618.909 µs (41.8%)
iast_GLOBAL 2.144 ms [2.091 ms, 2.197 ms] 664.794 µs (44.9%)
profiling 2.451 ms [2.261 ms, 2.641 ms] 971.684 µs (65.7%)
tracing 1.938 ms [1.897 ms, 1.979 ms] 458.845 µs (31.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~37ad948dba, baseline=1.45.0-SNAPSHOT~c99c2c2042
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.251 s) : 15251000, 15251000
.   : milestone, 15251000,
appsec (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
iast (18.96 s) : 18960000, 18960000
.   : milestone, 18960000,
iast_GLOBAL (17.858 s) : 17858000, 17858000
.   : milestone, 17858000,
profiling (15.679 s) : 15679000, 15679000
.   : milestone, 15679000,
tracing (14.797 s) : 14797000, 14797000
.   : milestone, 14797000,
section candidate
no_agent (15.272 s) : 15272000, 15272000
.   : milestone, 15272000,
appsec (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,
iast (18.82 s) : 18820000, 18820000
.   : milestone, 18820000,
iast_GLOBAL (17.645 s) : 17645000, 17645000
.   : milestone, 17645000,
profiling (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
tracing (14.897 s) : 14897000, 14897000
.   : milestone, 14897000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.251 s [15.251 s, 15.251 s] -
appsec 15.008 s [15.008 s, 15.008 s] -243.0 ms (-1.6%)
iast 18.96 s [18.96 s, 18.96 s] 3.709 s (24.3%)
iast_GLOBAL 17.858 s [17.858 s, 17.858 s] 2.607 s (17.1%)
profiling 15.679 s [15.679 s, 15.679 s] 428.0 ms (2.8%)
tracing 14.797 s [14.797 s, 14.797 s] -454.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.272 s [15.272 s, 15.272 s] -
appsec 15.054 s [15.054 s, 15.054 s] -218.0 ms (-1.4%)
iast 18.82 s [18.82 s, 18.82 s] 3.548 s (23.2%)
iast_GLOBAL 17.645 s [17.645 s, 17.645 s] 2.373 s (15.5%)
profiling 14.995 s [14.995 s, 14.995 s] -277.0 ms (-1.8%)
tracing 14.897 s [14.897 s, 14.897 s] -375.0 ms (-2.5%)

@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2024 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/move-hasmethodadvice-from-modules
git_commit_date 1735656717 1735685615
git_commit_sha c99c2c2 37ad948
See matching parameters
Baseline Candidate
ci_job_date 1735687006 1735687006
ci_job_id 751838281 751838281
ci_pipeline_id 51960821 51960821
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2024 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/move-hasmethodadvice-from-modules
git_commit_date 1735656717 1735685615
git_commit_sha c99c2c2 37ad948
See matching parameters
Baseline Candidate
ci_job_date 1735687053 1735687053
ci_job_id 751838282 751838282
ci_pipeline_id 51960821 51960821
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@mcculls mcculls force-pushed the mcculls/move-hasmethodadvice-from-modules branch from 37ad948 to 29cfc23 Compare January 1, 2025 01:22
@mcculls mcculls enabled auto-merge (squash) January 1, 2025 01:25
@mcculls mcculls merged commit e8df8a0 into master Jan 1, 2025
145 of 149 checks passed
@mcculls mcculls deleted the mcculls/move-hasmethodadvice-from-modules branch January 1, 2025 01:58
@github-actions github-actions bot added this to the 1.45.0 milestone Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

@juan-fernandez juan-fernandez Awaiting requested review from juan-fernandez juan-fernandez is a code owner automatically assigned from DataDog/ci-app-libraries-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.45.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali