Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multivalue multiline header extraction #8112

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Allow multivalue multiline header extraction #8112

wants to merge 9 commits into from

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Dec 18, 2024 •
edited
Loading

What Does This Do

The goal of this PR is to support multi-value multi-line HTTP header extraction. To do so, it

  • Updates the headers data struct from Map<String, String> to List<List<String>> to support multiple values with the same header. The doRequest method calls need to be updated as a result.
  • Changes the getRequestHeader and getResponseHeader methods in the client decorators for Apache and Grizzly to retrieve multiple header values instead of just the first.
  • Adds a class that extends HttpClientTest to test multiple values for the same header.

Motivation

Currently, HTTP protocol allows splitting the header into multiple lines per value. For example, header: value1, header: value2, header: value3. However, the Java tracer extracts only the first value of an http header and will oftentimes override the original header value when trying to set another value. This PR attempts to provide support from the tracer for multiple values under the same header.

Additional Notes

This is a cleaned up version of #7996.

Not all client decorators support multiple header values (e.g. jetty-client-9.1, spring-webflux-5, google-http-client, netty-4.1, and http-url-connection) because they use a .set method or map data structure somewhere that overrides header values when a new value with the same header name is introduced. Open to ideas on how to address this!

Contributor Checklist

Jira ticket: https://datadoghq.atlassian.net/browse/AIDM-273

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/allow-multiline-headers-take-2
git_commit_date 1734517793 1734549563
git_commit_sha a19f73a ec51de9
release_version 1.45.0-SNAPSHOT~a19f73a5ea 1.45.0-SNAPSHOT~ec51de9c4c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734552074 1734552074
ci_job_id 744554105 744554105
ci_pipeline_id 51489636 51489636
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093943
Total [baseline] (10.488 s) : 0, 10488182
Agent [candidate] (1.102 s) : 0, 1102468
Total [candidate] (10.512 s) : 0, 10512074
section appsec
Agent [baseline] (1.227 s) : 0, 1227043
Total [baseline] (10.684 s) : 0, 10684166
Agent [candidate] (1.227 s) : 0, 1227408
Total [candidate] (10.744 s) : 0, 10744036
section iast
Agent [baseline] (1.224 s) : 0, 1223932
Total [baseline] (11.006 s) : 0, 11005641
Agent [candidate] (1.223 s) : 0, 1223497
Total [candidate] (10.969 s) : 0, 10969100
section profiling
Agent [baseline] (1.323 s) : 0, 1323428
Total [baseline] (10.891 s) : 0, 10890967
Agent [candidate] (1.329 s) : 0, 1328614
Total [candidate] (10.94 s) : 0, 10939772
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.094 s -
Agent appsec 1.227 s 133.1 ms (12.2%)
Agent iast 1.224 s 129.989 ms (11.9%)
Agent profiling 1.323 s 229.484 ms (21.0%)
Total tracing 10.488 s -
Total appsec 10.684 s 195.984 ms (1.9%)
Total iast 11.006 s 517.458 ms (4.9%)
Total profiling 10.891 s 402.785 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.102 s -
Agent appsec 1.227 s 124.94 ms (11.3%)
Agent iast 1.223 s 121.029 ms (11.0%)
Agent profiling 1.329 s 226.146 ms (20.5%)
Total tracing 10.512 s -
Total appsec 10.744 s 231.962 ms (2.2%)
Total iast 10.969 s 457.026 ms (4.3%)
Total profiling 10.94 s 427.698 ms (4.1%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.363 ms) : 0, 697363
BytebuddyAgent [candidate] (701.7 ms) : 0, 701700
GlobalTracer [baseline] (316.738 ms) : 0, 316738
GlobalTracer [candidate] (319.983 ms) : 0, 319983
AppSec [baseline] (54.743 ms) : 0, 54743
AppSec [candidate] (55.379 ms) : 0, 55379
Remote Config [baseline] (658.729 µs) : 0, 659
Remote Config [candidate] (668.806 µs) : 0, 669
Telemetry [baseline] (10.692 ms) : 0, 10692
Telemetry [candidate] (10.857 ms) : 0, 10857
section appsec
BytebuddyAgent [baseline] (712.683 ms) : 0, 712683
BytebuddyAgent [candidate] (713.452 ms) : 0, 713452
GlobalTracer [baseline] (314.935 ms) : 0, 314935
GlobalTracer [candidate] (314.903 ms) : 0, 314903
AppSec [baseline] (167.821 ms) : 0, 167821
AppSec [candidate] (167.722 ms) : 0, 167722
IAST [baseline] (19.633 ms) : 0, 19633
IAST [candidate] (19.11 ms) : 0, 19110
Remote Config [baseline] (655.756 µs) : 0, 656
Remote Config [candidate] (654.11 µs) : 0, 654
Telemetry [baseline] (7.438 ms) : 0, 7438
Telemetry [candidate] (7.386 ms) : 0, 7386
section iast
BytebuddyAgent [baseline] (814.364 ms) : 0, 814364
BytebuddyAgent [candidate] (815.593 ms) : 0, 815593
GlobalTracer [baseline] (308.529 ms) : 0, 308529
GlobalTracer [candidate] (307.31 ms) : 0, 307310
AppSec [baseline] (56.419 ms) : 0, 56419
AppSec [candidate] (57.635 ms) : 0, 57635
IAST [baseline] (22.773 ms) : 0, 22773
IAST [candidate] (20.995 ms) : 0, 20995
Remote Config [baseline] (624.628 µs) : 0, 625
Remote Config [candidate] (636.186 µs) : 0, 636
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (7.54 ms) : 0, 7540
section profiling
BytebuddyAgent [baseline] (693.884 ms) : 0, 693884
BytebuddyAgent [candidate] (695.814 ms) : 0, 695814
GlobalTracer [baseline] (434.113 ms) : 0, 434113
GlobalTracer [candidate] (435.826 ms) : 0, 435826
AppSec [baseline] (53.696 ms) : 0, 53696
AppSec [candidate] (54.178 ms) : 0, 54178
Remote Config [baseline] (667.618 µs) : 0, 668
Remote Config [candidate] (678.52 µs) : 0, 679
Telemetry [baseline] (7.684 ms) : 0, 7684
Telemetry [candidate] (7.754 ms) : 0, 7754
ProfilingAgent [baseline] (93.936 ms) : 0, 93936
ProfilingAgent [candidate] (94.823 ms) : 0, 94823
Profiling [baseline] (93.96 ms) : 0, 93960
Profiling [candidate] (94.846 ms) : 0, 94846
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1099203
Total [baseline] (8.657 s) : 0, 8656587
Agent [candidate] (1.096 s) : 0, 1095502
Total [candidate] (8.657 s) : 0, 8656573
section iast
Agent [baseline] (1.221 s) : 0, 1221448
Total [baseline] (9.211 s) : 0, 9211447
Agent [candidate] (1.231 s) : 0, 1230728
Total [candidate] (9.209 s) : 0, 9209186
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.23 s) : 0, 1229975
Total [baseline] (9.174 s) : 0, 9173571
Agent [candidate] (1.233 s) : 0, 1233222
Total [candidate] (9.217 s) : 0, 9216936
section iast_TELEMETRY_OFF
Agent [baseline] (1.226 s) : 0, 1225541
Total [baseline] (9.235 s) : 0, 9235138
Agent [candidate] (1.218 s) : 0, 1217808
Total [candidate] (9.184 s) : 0, 9183962
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.099 s -
Agent iast 1.221 s 122.245 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.23 s 130.772 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.226 s 126.337 ms (11.5%)
Total tracing 8.657 s -
Total iast 9.211 s 554.86 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.174 s 516.984 ms (6.0%)
Total iast_TELEMETRY_OFF 9.235 s 578.55 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.096 s -
Agent iast 1.231 s 135.225 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.233 s 137.719 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.218 s 122.305 ms (11.2%)
Total tracing 8.657 s -
Total iast 9.209 s 552.613 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.217 s 560.363 ms (6.5%)
Total iast_TELEMETRY_OFF 9.184 s 527.39 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (700.186 ms) : 0, 700186
BytebuddyAgent [candidate] (696.899 ms) : 0, 696899
GlobalTracer [baseline] (319.406 ms) : 0, 319406
GlobalTracer [candidate] (317.992 ms) : 0, 317992
AppSec [baseline] (54.475 ms) : 0, 54475
AppSec [candidate] (54.853 ms) : 0, 54853
Remote Config [baseline] (660.653 µs) : 0, 661
Remote Config [candidate] (674.889 µs) : 0, 675
Telemetry [baseline] (10.688 ms) : 0, 10688
Telemetry [candidate] (11.298 ms) : 0, 11298
section iast
BytebuddyAgent [baseline] (814.87 ms) : 0, 814870
BytebuddyAgent [candidate] (821.328 ms) : 0, 821328
GlobalTracer [baseline] (306.257 ms) : 0, 306257
GlobalTracer [candidate] (308.547 ms) : 0, 308547
AppSec [baseline] (57.604 ms) : 0, 57604
AppSec [candidate] (57.844 ms) : 0, 57844
IAST [baseline] (20.906 ms) : 0, 20906
IAST [candidate] (21.009 ms) : 0, 21009
Remote Config [baseline] (605.799 µs) : 0, 606
Remote Config [candidate] (630.957 µs) : 0, 631
Telemetry [baseline] (7.435 ms) : 0, 7435
Telemetry [candidate] (7.469 ms) : 0, 7469
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (820.566 ms) : 0, 820566
BytebuddyAgent [candidate] (822.211 ms) : 0, 822211
GlobalTracer [baseline] (308.673 ms) : 0, 308673
GlobalTracer [candidate] (309.835 ms) : 0, 309835
AppSec [baseline] (56.821 ms) : 0, 56821
AppSec [candidate] (57.177 ms) : 0, 57177
IAST [baseline] (22.006 ms) : 0, 22006
IAST [candidate] (22.037 ms) : 0, 22037
Remote Config [baseline] (625.502 µs) : 0, 626
Remote Config [candidate] (616.701 µs) : 0, 617
Telemetry [baseline] (7.48 ms) : 0, 7480
Telemetry [candidate] (7.462 ms) : 0, 7462
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (816.93 ms) : 0, 816930
BytebuddyAgent [candidate] (810.973 ms) : 0, 810973
GlobalTracer [baseline] (307.577 ms) : 0, 307577
GlobalTracer [candidate] (306.245 ms) : 0, 306245
AppSec [baseline] (57.453 ms) : 0, 57453
AppSec [candidate] (57.28 ms) : 0, 57280
IAST [baseline] (21.712 ms) : 0, 21712
IAST [candidate] (21.516 ms) : 0, 21516
Remote Config [baseline] (607.351 µs) : 0, 607
Remote Config [candidate] (615.344 µs) : 0, 615
Telemetry [baseline] (7.434 ms) : 0, 7434
Telemetry [candidate] (7.402 ms) : 0, 7402
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-18T19:33:43 2024-12-18T19:40:42
git_branch master sarahchen6/allow-multiline-headers-take-2
git_commit_date 1734517793 1734549563
git_commit_sha a19f73a ec51de9
release_version 1.45.0-SNAPSHOT~a19f73a5ea 1.45.0-SNAPSHOT~ec51de9c4c
start_time 2024-12-18T19:33:29 2024-12-18T19:40:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734551196 1734551196
ci_job_id 744554106 744554106
ci_pipeline_id 51489636 51489636
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.328 µs) : 358, 397
.   : milestone, 377,
iast (496.619 µs) : 475, 519
.   : milestone, 497,
iast_FULL (657.266 µs) : 635, 679
.   : milestone, 657,
iast_GLOBAL (527.309 µs) : 506, 549
.   : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (487.73 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (457.838 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (481.244 µs) : 460, 503
.   : milestone, 481,
tracing (454.829 µs) : 433, 477
.   : milestone, 455,
section candidate
no_agent (379.664 µs) : 360, 400
.   : milestone, 380,
iast (488.3 µs) : 467, 510
.   : milestone, 488,
iast_FULL (655.926 µs) : 634, 678
.   : milestone, 656,
iast_GLOBAL (515.526 µs) : 494, 537
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (493.778 µs) : 472, 516
.   : milestone, 494,
iast_INACTIVE (457.718 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (482.355 µs) : 461, 504
.   : milestone, 482,
tracing (457.675 µs) : 436, 480
.   : milestone, 458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.328 µs [357.717 µs, 396.939 µs] -
iast 496.619 µs [474.501 µs, 518.736 µs] 119.291 µs (31.6%)
iast_FULL 657.266 µs [635.482 µs, 679.049 µs] 279.938 µs (74.2%)
iast_GLOBAL 527.309 µs [505.551 µs, 549.067 µs] 149.981 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED 487.73 µs [466.395 µs, 509.066 µs] 110.402 µs (29.3%)
iast_INACTIVE 457.838 µs [436.214 µs, 479.462 µs] 80.51 µs (21.3%)
iast_TELEMETRY_OFF 481.244 µs [459.933 µs, 502.555 µs] 103.916 µs (27.5%)
tracing 454.829 µs [432.911 µs, 476.746 µs] 77.501 µs (20.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.664 µs [359.782 µs, 399.546 µs] -
iast 488.3 µs [467.091 µs, 509.509 µs] 108.636 µs (28.6%)
iast_FULL 655.926 µs [634.249 µs, 677.603 µs] 276.261 µs (72.8%)
iast_GLOBAL 515.526 µs [494.339 µs, 536.713 µs] 135.862 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 493.778 µs [471.621 µs, 515.935 µs] 114.114 µs (30.1%)
iast_INACTIVE 457.718 µs [436.051 µs, 479.385 µs] 78.053 µs (20.6%)
iast_TELEMETRY_OFF 482.355 µs [460.852 µs, 503.858 µs] 102.691 µs (27.0%)
tracing 457.675 µs [435.516 µs, 479.833 µs] 78.011 µs (20.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1336, 1377
.   : milestone, 1357,
appsec (1.763 ms) : 1740, 1787
.   : milestone, 1763,
appsec_no_iast (1.762 ms) : 1737, 1787
.   : milestone, 1762,
iast (1.493 ms) : 1470, 1516
.   : milestone, 1493,
profiling (1.531 ms) : 1507, 1555
.   : milestone, 1531,
tracing (1.469 ms) : 1445, 1494
.   : milestone, 1469,
section candidate
no_agent (1.353 ms) : 1333, 1372
.   : milestone, 1353,
appsec (1.755 ms) : 1732, 1778
.   : milestone, 1755,
appsec_no_iast (1.789 ms) : 1765, 1814
.   : milestone, 1789,
iast (1.506 ms) : 1483, 1528
.   : milestone, 1506,
profiling (1.511 ms) : 1487, 1534
.   : milestone, 1511,
tracing (1.493 ms) : 1469, 1518
.   : milestone, 1493,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.336 ms, 1.377 ms] -
appsec 1.763 ms [1.74 ms, 1.787 ms] 406.553 µs (30.0%)
appsec_no_iast 1.762 ms [1.737 ms, 1.787 ms] 405.214 µs (29.9%)
iast 1.493 ms [1.47 ms, 1.516 ms] 136.398 µs (10.1%)
profiling 1.531 ms [1.507 ms, 1.555 ms] 174.258 µs (12.8%)
tracing 1.469 ms [1.445 ms, 1.494 ms] 112.486 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.372 ms] -
appsec 1.755 ms [1.732 ms, 1.778 ms] 402.269 µs (29.7%)
appsec_no_iast 1.789 ms [1.765 ms, 1.814 ms] 436.354 µs (32.3%)
iast 1.506 ms [1.483 ms, 1.528 ms] 153.109 µs (11.3%)
profiling 1.511 ms [1.487 ms, 1.534 ms] 158.205 µs (11.7%)
tracing 1.493 ms [1.469 ms, 1.518 ms] 140.738 µs (10.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/allow-multiline-headers-take-2
git_commit_date 1734517793 1734549563
git_commit_sha a19f73a ec51de9
release_version 1.45.0-SNAPSHOT~a19f73a5ea 1.45.0-SNAPSHOT~ec51de9c4c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1734551648 1734551648
ci_job_id 744554107 744554107
ci_pipeline_id 51489636 51489636
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.481 s) : 15481000, 15481000
.   : milestone, 15481000,
appsec (14.755 s) : 14755000, 14755000
.   : milestone, 14755000,
iast (18.747 s) : 18747000, 18747000
.   : milestone, 18747000,
iast_GLOBAL (17.797 s) : 17797000, 17797000
.   : milestone, 17797000,
profiling (15.499 s) : 15499000, 15499000
.   : milestone, 15499000,
tracing (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
section candidate
no_agent (14.864 s) : 14864000, 14864000
.   : milestone, 14864000,
appsec (14.777 s) : 14777000, 14777000
.   : milestone, 14777000,
iast (18.805 s) : 18805000, 18805000
.   : milestone, 18805000,
iast_GLOBAL (18.218 s) : 18218000, 18218000
.   : milestone, 18218000,
profiling (14.952 s) : 14952000, 14952000
.   : milestone, 14952000,
tracing (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.481 s [15.481 s, 15.481 s] -
appsec 14.755 s [14.755 s, 14.755 s] -726.0 ms (-4.7%)
iast 18.747 s [18.747 s, 18.747 s] 3.266 s (21.1%)
iast_GLOBAL 17.797 s [17.797 s, 17.797 s] 2.316 s (15.0%)
profiling 15.499 s [15.499 s, 15.499 s] 18.0 ms (0.1%)
tracing 14.998 s [14.998 s, 14.998 s] -483.0 ms (-3.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.864 s [14.864 s, 14.864 s] -
appsec 14.777 s [14.777 s, 14.777 s] -87.0 ms (-0.6%)
iast 18.805 s [18.805 s, 18.805 s] 3.941 s (26.5%)
iast_GLOBAL 18.218 s [18.218 s, 18.218 s] 3.354 s (22.6%)
profiling 14.952 s [14.952 s, 14.952 s] 88.0 ms (0.6%)
tracing 14.969 s [14.969 s, 14.969 s] 105.0 ms (0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~ec51de9c4c, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.37 ms) : 2328, 2413
.   : milestone, 2370,
iast (2.109 ms) : 2055, 2163
.   : milestone, 2109,
iast_GLOBAL (2.152 ms) : 2098, 2206
.   : milestone, 2152,
profiling (1.964 ms) : 1921, 2006
.   : milestone, 1964,
tracing (1.954 ms) : 1913, 1996
.   : milestone, 1954,
section candidate
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.382 ms) : 2338, 2425
.   : milestone, 2382,
iast (2.122 ms) : 2068, 2177
.   : milestone, 2122,
iast_GLOBAL (2.158 ms) : 2104, 2212
.   : milestone, 2158,
profiling (1.988 ms) : 1944, 2032
.   : milestone, 1988,
tracing (1.951 ms) : 1910, 1993
.   : milestone, 1951,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.37 ms [2.328 ms, 2.413 ms] 896.704 µs (60.9%)
iast 2.109 ms [2.055 ms, 2.163 ms] 635.343 µs (43.1%)
iast_GLOBAL 2.152 ms [2.098 ms, 2.206 ms] 678.539 µs (46.1%)
profiling 1.964 ms [1.921 ms, 2.006 ms] 490.391 µs (33.3%)
tracing 1.954 ms [1.913 ms, 1.996 ms] 480.776 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.382 ms [2.338 ms, 2.425 ms] 903.245 µs (61.1%)
iast 2.122 ms [2.068 ms, 2.177 ms] 643.941 µs (43.6%)
iast_GLOBAL 2.158 ms [2.104 ms, 2.212 ms] 679.809 µs (46.0%)
profiling 1.988 ms [1.944 ms, 2.032 ms] 509.634 µs (34.5%)
tracing 1.951 ms [1.91 ms, 1.993 ms] 473.061 µs (32.0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarahchen6