-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation for support ipv6 addresses in dd_agent_host #7984
Draft
mhlidd
wants to merge
4
commits into
master
Choose a base branch
from
mhlidd/support_ipv6_host_addresses
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 13 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091108
Total [baseline] (10.514 s) : 0, 10514167
Agent [candidate] (1.098 s) : 0, 1097547
Total [candidate] (10.441 s) : 0, 10440553
section appsec
Agent [baseline] (1.227 s) : 0, 1227205
Total [baseline] (10.772 s) : 0, 10771586
Agent [candidate] (1.223 s) : 0, 1222841
Total [candidate] (10.737 s) : 0, 10736540
section iast
Agent [baseline] (1.227 s) : 0, 1226511
Total [baseline] (11.027 s) : 0, 11026719
Agent [candidate] (1.222 s) : 0, 1221501
Total [candidate] (10.949 s) : 0, 10949344
section profiling
Agent [baseline] (1.325 s) : 0, 1325032
Total [baseline] (10.893 s) : 0, 10892878
Agent [candidate] (1.305 s) : 0, 1304511
Total [candidate] (10.804 s) : 0, 10804249
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.864 ms) : 0, 692864
BytebuddyAgent [candidate] (698.772 ms) : 0, 698772
GlobalTracer [baseline] (318.002 ms) : 0, 318002
GlobalTracer [candidate] (320.132 ms) : 0, 320132
AppSec [baseline] (55.088 ms) : 0, 55088
AppSec [candidate] (54.752 ms) : 0, 54752
Remote Config [baseline] (688.978 µs) : 0, 689
Remote Config [candidate] (696.259 µs) : 0, 696
Telemetry [baseline] (10.749 ms) : 0, 10749
Telemetry [candidate] (9.359 ms) : 0, 9359
section appsec
BytebuddyAgent [baseline] (712.821 ms) : 0, 712821
BytebuddyAgent [candidate] (709.692 ms) : 0, 709692
GlobalTracer [baseline] (314.777 ms) : 0, 314777
GlobalTracer [candidate] (314.821 ms) : 0, 314821
AppSec [baseline] (167.557 ms) : 0, 167557
AppSec [candidate] (164.173 ms) : 0, 164173
Remote Config [baseline] (647.915 µs) : 0, 648
Remote Config [candidate] (637.279 µs) : 0, 637
Telemetry [baseline] (8.218 ms) : 0, 8218
Telemetry [candidate] (10.001 ms) : 0, 10001
IAST [baseline] (18.91 ms) : 0, 18910
IAST [candidate] (19.589 ms) : 0, 19589
section iast
BytebuddyAgent [baseline] (817.205 ms) : 0, 817205
BytebuddyAgent [candidate] (812.081 ms) : 0, 812081
GlobalTracer [baseline] (308.243 ms) : 0, 308243
GlobalTracer [candidate] (308.229 ms) : 0, 308229
AppSec [baseline] (57.432 ms) : 0, 57432
AppSec [candidate] (57.466 ms) : 0, 57466
Remote Config [baseline] (650.184 µs) : 0, 650
Remote Config [candidate] (625.671 µs) : 0, 626
Telemetry [baseline] (7.526 ms) : 0, 7526
Telemetry [candidate] (7.509 ms) : 0, 7509
IAST [baseline] (21.656 ms) : 0, 21656
IAST [candidate] (21.768 ms) : 0, 21768
section profiling
BytebuddyAgent [baseline] (689.264 ms) : 0, 689264
BytebuddyAgent [candidate] (695.794 ms) : 0, 695794
GlobalTracer [baseline] (438.723 ms) : 0, 438723
GlobalTracer [candidate] (405.848 ms) : 0, 405848
AppSec [baseline] (54.348 ms) : 0, 54348
AppSec [candidate] (55.446 ms) : 0, 55446
Remote Config [baseline] (679.818 µs) : 0, 680
Remote Config [candidate] (681.068 µs) : 0, 681
Telemetry [baseline] (7.889 ms) : 0, 7889
Telemetry [candidate] (10.733 ms) : 0, 10733
ProfilingAgent [baseline] (95.019 ms) : 0, 95019
ProfilingAgent [candidate] (96.441 ms) : 0, 96441
Profiling [baseline] (95.043 ms) : 0, 95043
Profiling [candidate] (96.465 ms) : 0, 96465
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098902
Total [baseline] (8.75 s) : 0, 8750316
Agent [candidate] (1.091 s) : 0, 1090831
Total [candidate] (8.658 s) : 0, 8657994
section iast
Agent [baseline] (1.22 s) : 0, 1220170
Total [baseline] (9.22 s) : 0, 9219814
Agent [candidate] (1.224 s) : 0, 1223825
Total [candidate] (9.247 s) : 0, 9247050
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.219 s) : 0, 1218608
Total [baseline] (9.176 s) : 0, 9176163
Agent [candidate] (1.22 s) : 0, 1219755
Total [candidate] (9.217 s) : 0, 9216889
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1218255
Total [baseline] (9.214 s) : 0, 9213725
Agent [candidate] (1.219 s) : 0, 1219070
Total [candidate] (9.24 s) : 0, 9240132
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (699.433 ms) : 0, 699433
BytebuddyAgent [candidate] (693.205 ms) : 0, 693205
GlobalTracer [baseline] (320.968 ms) : 0, 320968
GlobalTracer [candidate] (317.815 ms) : 0, 317815
AppSec [baseline] (54.763 ms) : 0, 54763
AppSec [candidate] (54.695 ms) : 0, 54695
Remote Config [baseline] (685.671 µs) : 0, 686
Remote Config [candidate] (690.421 µs) : 0, 690
Telemetry [baseline] (9.225 ms) : 0, 9225
Telemetry [candidate] (10.667 ms) : 0, 10667
section iast
BytebuddyAgent [baseline] (812.17 ms) : 0, 812170
BytebuddyAgent [candidate] (814.077 ms) : 0, 814077
GlobalTracer [baseline] (307.062 ms) : 0, 307062
GlobalTracer [candidate] (308.565 ms) : 0, 308565
AppSec [baseline] (57.291 ms) : 0, 57291
AppSec [candidate] (56.443 ms) : 0, 56443
IAST [baseline] (21.687 ms) : 0, 21687
IAST [candidate] (22.712 ms) : 0, 22712
Remote Config [baseline] (633.917 µs) : 0, 634
Remote Config [candidate] (625.313 µs) : 0, 625
Telemetry [baseline] (7.526 ms) : 0, 7526
Telemetry [candidate] (7.526 ms) : 0, 7526
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (810.555 ms) : 0, 810555
BytebuddyAgent [candidate] (811.118 ms) : 0, 811118
GlobalTracer [baseline] (306.786 ms) : 0, 306786
GlobalTracer [candidate] (308.238 ms) : 0, 308238
AppSec [baseline] (57.579 ms) : 0, 57579
AppSec [candidate] (57.835 ms) : 0, 57835
IAST [baseline] (21.739 ms) : 0, 21739
IAST [candidate] (20.685 ms) : 0, 20685
Remote Config [baseline] (624.716 µs) : 0, 625
Remote Config [candidate] (608.917 µs) : 0, 609
Telemetry [baseline] (7.614 ms) : 0, 7614
Telemetry [candidate] (7.445 ms) : 0, 7445
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.561 ms) : 0, 810561
BytebuddyAgent [candidate] (808.512 ms) : 0, 808512
GlobalTracer [baseline] (307.671 ms) : 0, 307671
GlobalTracer [candidate] (309.316 ms) : 0, 309316
AppSec [baseline] (56.96 ms) : 0, 56960
AppSec [candidate] (56.444 ms) : 0, 56444
IAST [baseline] (21.161 ms) : 0, 21161
IAST [candidate] (22.034 ms) : 0, 22034
Remote Config [baseline] (644.935 µs) : 0, 645
Remote Config [candidate] (623.672 µs) : 0, 624
Telemetry [baseline] (7.469 ms) : 0, 7469
Telemetry [candidate] (8.309 ms) : 0, 8309
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section baseline
no_agent (373.945 µs) : 354, 393
. : milestone, 374,
iast (488.055 µs) : 466, 510
. : milestone, 488,
iast_FULL (642.061 µs) : 621, 663
. : milestone, 642,
iast_GLOBAL (510.131 µs) : 489, 531
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (481.533 µs) : 460, 503
. : milestone, 482,
iast_INACTIVE (446.108 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (473.553 µs) : 452, 495
. : milestone, 474,
tracing (450.405 µs) : 429, 471
. : milestone, 450,
section candidate
no_agent (371.658 µs) : 352, 392
. : milestone, 372,
iast (480.117 µs) : 459, 501
. : milestone, 480,
iast_FULL (654.016 µs) : 633, 675
. : milestone, 654,
iast_GLOBAL (513.24 µs) : 491, 535
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (483.674 µs) : 463, 505
. : milestone, 484,
iast_INACTIVE (437.128 µs) : 417, 458
. : milestone, 437,
iast_TELEMETRY_OFF (477.72 µs) : 456, 500
. : milestone, 478,
tracing (445.347 µs) : 424, 467
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1385
. : milestone, 1364,
appsec (1.732 ms) : 1708, 1757
. : milestone, 1732,
appsec_no_iast (1.734 ms) : 1709, 1759
. : milestone, 1734,
iast (1.51 ms) : 1487, 1532
. : milestone, 1510,
profiling (1.555 ms) : 1531, 1579
. : milestone, 1555,
tracing (1.48 ms) : 1456, 1505
. : milestone, 1480,
section candidate
no_agent (1.365 ms) : 1346, 1384
. : milestone, 1365,
appsec (1.743 ms) : 1719, 1768
. : milestone, 1743,
appsec_no_iast (1.72 ms) : 1695, 1745
. : milestone, 1720,
iast (1.486 ms) : 1463, 1509
. : milestone, 1486,
profiling (1.507 ms) : 1483, 1531
. : milestone, 1507,
tracing (1.493 ms) : 1469, 1517
. : milestone, 1493,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.335 ms) : 2294, 2377
. : milestone, 2335,
iast (2.074 ms) : 2022, 2126
. : milestone, 2074,
iast_GLOBAL (2.116 ms) : 2064, 2169
. : milestone, 2116,
profiling (1.969 ms) : 1926, 2012
. : milestone, 1969,
tracing (1.922 ms) : 1881, 1962
. : milestone, 1922,
section candidate
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.332 ms) : 2291, 2374
. : milestone, 2332,
iast (2.075 ms) : 2023, 2127
. : milestone, 2075,
iast_GLOBAL (2.123 ms) : 2071, 2175
. : milestone, 2123,
profiling (1.941 ms) : 1899, 1984
. : milestone, 1941,
tracing (1.922 ms) : 1882, 1962
. : milestone, 1922,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~b0690cd65f, baseline=1.44.0-SNAPSHOT~224dc1b6d9
dateFormat X
axisFormat %s
section baseline
no_agent (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
appsec (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
iast (18.821 s) : 18821000, 18821000
. : milestone, 18821000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
. : milestone, 18038000,
profiling (15.354 s) : 15354000, 15354000
. : milestone, 15354000,
tracing (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
section candidate
no_agent (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
appsec (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
iast (19.101 s) : 19101000, 19101000
. : milestone, 19101000,
iast_GLOBAL (17.887 s) : 17887000, 17887000
. : milestone, 17887000,
profiling (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
tracing (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
|
Relates to #7713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]