-
Notifications
You must be signed in to change notification settings - Fork 318
put custom tags into a single defined attribute #10004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pawel-big-lebowski
wants to merge
1
commit into
master
Choose a base branch
from
pawel.leszczynski/custom-tags-in-one-attribute
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
put custom tags into a single defined attribute #10004
pawel-big-lebowski
wants to merge
1
commit into
master
from
pawel.leszczynski/custom-tags-in-one-attribute
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6145838 to
c1d1604
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.108 s) : 0, 1108438
Total [baseline] (8.848 s) : 0, 8847963
Agent [candidate] (1.102 s) : 0, 1102262
Total [candidate] (8.847 s) : 0, 8846877
section iast
Agent [baseline] (1.24 s) : 0, 1240476
Total [baseline] (9.563 s) : 0, 9563165
Agent [candidate] (1.24 s) : 0, 1239545
Total [candidate] (9.537 s) : 0, 9537448
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (713.167 ms) : 0, 713167
BytebuddyAgent [candidate] (708.051 ms) : 0, 708051
GlobalTracer [baseline] (250.627 ms) : 0, 250627
GlobalTracer [candidate] (249.271 ms) : 0, 249271
AppSec [baseline] (32.427 ms) : 0, 32427
AppSec [candidate] (32.136 ms) : 0, 32136
Debugger [baseline] (63.394 ms) : 0, 63394
Debugger [candidate] (63.708 ms) : 0, 63708
Remote Config [baseline] (622.51 µs) : 0, 623
Remote Config [candidate] (642.66 µs) : 0, 643
Telemetry [baseline] (8.18 ms) : 0, 8180
Telemetry [candidate] (8.293 ms) : 0, 8293
Flare Poller [baseline] (3.682 ms) : 0, 3682
Flare Poller [candidate] (3.787 ms) : 0, 3787
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (832.727 ms) : 0, 832727
BytebuddyAgent [candidate] (832.714 ms) : 0, 832714
GlobalTracer [baseline] (238.178 ms) : 0, 238178
GlobalTracer [candidate] (237.504 ms) : 0, 237504
AppSec [baseline] (33.9 ms) : 0, 33900
AppSec [candidate] (32.188 ms) : 0, 32188
Debugger [baseline] (59.786 ms) : 0, 59786
Debugger [candidate] (60.136 ms) : 0, 60136
Remote Config [baseline] (554.632 µs) : 0, 555
Remote Config [candidate] (532.821 µs) : 0, 533
Telemetry [baseline] (7.651 ms) : 0, 7651
Telemetry [candidate] (7.611 ms) : 0, 7611
Flare Poller [baseline] (3.519 ms) : 0, 3519
Flare Poller [candidate] (3.441 ms) : 0, 3441
IAST [baseline] (27.756 ms) : 0, 27756
IAST [candidate] (29.103 ms) : 0, 29103
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.113 s) : 0, 1113098
Total [baseline] (10.912 s) : 0, 10911983
Agent [candidate] (1.1 s) : 0, 1100018
Total [candidate] (10.714 s) : 0, 10714223
section appsec
Agent [baseline] (1.283 s) : 0, 1282532
Total [baseline] (11.184 s) : 0, 11184202
Agent [candidate] (1.298 s) : 0, 1297945
Total [candidate] (11.255 s) : 0, 11255398
section iast
Agent [baseline] (1.24 s) : 0, 1240097
Total [baseline] (11.224 s) : 0, 11223813
Agent [candidate] (1.236 s) : 0, 1236305
Total [candidate] (11.218 s) : 0, 11217858
section profiling
Agent [baseline] (1.231 s) : 0, 1230796
Total [baseline] (11.075 s) : 0, 11075007
Agent [candidate] (1.244 s) : 0, 1244407
Total [candidate] (11.274 s) : 0, 11273811
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (714.937 ms) : 0, 714937
BytebuddyAgent [candidate] (707.26 ms) : 0, 707260
GlobalTracer [baseline] (251.795 ms) : 0, 251795
GlobalTracer [candidate] (248.068 ms) : 0, 248068
AppSec [baseline] (32.565 ms) : 0, 32565
AppSec [candidate] (32.005 ms) : 0, 32005
Debugger [baseline] (64.816 ms) : 0, 64816
Debugger [candidate] (63.762 ms) : 0, 63762
Remote Config [baseline] (636.745 µs) : 0, 637
Remote Config [candidate] (629.035 µs) : 0, 629
Telemetry [baseline] (8.308 ms) : 0, 8308
Telemetry [candidate] (8.292 ms) : 0, 8292
Flare Poller [baseline] (3.738 ms) : 0, 3738
Flare Poller [candidate] (3.724 ms) : 0, 3724
section appsec
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (732.012 ms) : 0, 732012
BytebuddyAgent [candidate] (741.61 ms) : 0, 741610
GlobalTracer [baseline] (240.661 ms) : 0, 240661
GlobalTracer [candidate] (243.229 ms) : 0, 243229
AppSec [baseline] (174.038 ms) : 0, 174038
AppSec [candidate] (175.373 ms) : 0, 175373
Debugger [baseline] (61.826 ms) : 0, 61826
Debugger [candidate] (62.646 ms) : 0, 62646
Remote Config [baseline] (657.124 µs) : 0, 657
Remote Config [candidate] (673.493 µs) : 0, 673
Telemetry [baseline] (8.22 ms) : 0, 8220
Telemetry [candidate] (8.406 ms) : 0, 8406
Flare Poller [baseline] (3.861 ms) : 0, 3861
Flare Poller [candidate] (3.944 ms) : 0, 3944
IAST [baseline] (24.863 ms) : 0, 24863
IAST [candidate] (25.264 ms) : 0, 25264
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (832.851 ms) : 0, 832851
BytebuddyAgent [candidate] (829.216 ms) : 0, 829216
GlobalTracer [baseline] (237.787 ms) : 0, 237787
GlobalTracer [candidate] (236.992 ms) : 0, 236992
AppSec [baseline] (31.199 ms) : 0, 31199
AppSec [candidate] (32.382 ms) : 0, 32382
Debugger [baseline] (60.52 ms) : 0, 60520
Debugger [candidate] (60.857 ms) : 0, 60857
Remote Config [baseline] (535.502 µs) : 0, 536
Remote Config [candidate] (607.571 µs) : 0, 608
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (7.606 ms) : 0, 7606
Flare Poller [baseline] (3.462 ms) : 0, 3462
Flare Poller [candidate] (3.469 ms) : 0, 3469
IAST [baseline] (29.794 ms) : 0, 29794
IAST [candidate] (28.984 ms) : 0, 28984
section profiling
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (732.994 ms) : 0, 732994
BytebuddyAgent [candidate] (741.128 ms) : 0, 741128
GlobalTracer [baseline] (222.215 ms) : 0, 222215
GlobalTracer [candidate] (225.138 ms) : 0, 225138
AppSec [baseline] (32.032 ms) : 0, 32032
AppSec [candidate] (32.862 ms) : 0, 32862
Debugger [baseline] (63.255 ms) : 0, 63255
Debugger [candidate] (63.733 ms) : 0, 63733
Remote Config [baseline] (652.392 µs) : 0, 652
Remote Config [candidate] (660.165 µs) : 0, 660
Telemetry [baseline] (7.979 ms) : 0, 7979
Telemetry [candidate] (8.001 ms) : 0, 8001
Flare Poller [baseline] (3.782 ms) : 0, 3782
Flare Poller [candidate] (3.757 ms) : 0, 3757
ProfilingAgent [baseline] (96.917 ms) : 0, 96917
ProfilingAgent [candidate] (97.582 ms) : 0, 97582
Profiling [baseline] (97.501 ms) : 0, 97501
Profiling [candidate] (98.173 ms) : 0, 98173
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (18.084 ms) : 17900, 18267
. : milestone, 18084,
appsec (18.765 ms) : 18579, 18952
. : milestone, 18765,
code_origins (17.744 ms) : 17569, 17919
. : milestone, 17744,
iast (17.842 ms) : 17662, 18023
. : milestone, 17842,
profiling (18.506 ms) : 18324, 18687
. : milestone, 18506,
tracing (17.628 ms) : 17451, 17805
. : milestone, 17628,
section candidate
no_agent (19.638 ms) : 19435, 19841
. : milestone, 19638,
appsec (18.726 ms) : 18538, 18915
. : milestone, 18726,
code_origins (17.943 ms) : 17765, 18121
. : milestone, 17943,
iast (18.021 ms) : 17841, 18200
. : milestone, 18021,
profiling (18.569 ms) : 18384, 18754
. : milestone, 18569,
tracing (17.657 ms) : 17482, 17832
. : milestone, 17657,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (1.218 ms) : 1206, 1230
. : milestone, 1218,
iast (3.27 ms) : 3223, 3317
. : milestone, 3270,
iast_FULL (5.855 ms) : 5797, 5914
. : milestone, 5855,
iast_GLOBAL (3.754 ms) : 3689, 3819
. : milestone, 3754,
profiling (1.937 ms) : 1920, 1954
. : milestone, 1937,
tracing (1.831 ms) : 1816, 1846
. : milestone, 1831,
section candidate
no_agent (1.216 ms) : 1204, 1228
. : milestone, 1216,
iast (3.311 ms) : 3269, 3353
. : milestone, 3311,
iast_FULL (5.822 ms) : 5763, 5880
. : milestone, 5822,
iast_GLOBAL (3.577 ms) : 3524, 3630
. : milestone, 3577,
profiling (2.14 ms) : 2121, 2159
. : milestone, 2140,
tracing (1.805 ms) : 1791, 1820
. : milestone, 1805,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (15.48 s) : 15480000, 15480000
. : milestone, 15480000,
appsec (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
iast (18.941 s) : 18941000, 18941000
. : milestone, 18941000,
iast_GLOBAL (17.806 s) : 17806000, 17806000
. : milestone, 17806000,
profiling (15.491 s) : 15491000, 15491000
. : milestone, 15491000,
tracing (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
section candidate
no_agent (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
appsec (14.776 s) : 14776000, 14776000
. : milestone, 14776000,
iast (18.361 s) : 18361000, 18361000
. : milestone, 18361000,
iast_GLOBAL (18.044 s) : 18044000, 18044000
. : milestone, 18044000,
profiling (15.243 s) : 15243000, 15243000
. : milestone, 15243000,
tracing (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~c1d1604353, baseline=1.56.0-SNAPSHOT~0614d7316c
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.47 ms) : 2418, 2522
. : milestone, 2470,
iast (2.217 ms) : 2152, 2281
. : milestone, 2217,
iast_GLOBAL (2.256 ms) : 2191, 2320
. : milestone, 2256,
profiling (2.07 ms) : 2017, 2124
. : milestone, 2070,
tracing (2.049 ms) : 1998, 2100
. : milestone, 2049,
section candidate
no_agent (1.475 ms) : 1464, 1486
. : milestone, 1475,
appsec (3.706 ms) : 3486, 3925
. : milestone, 3706,
iast (2.218 ms) : 2154, 2283
. : milestone, 2218,
iast_GLOBAL (2.26 ms) : 2195, 2325
. : milestone, 2260,
profiling (2.081 ms) : 2028, 2134
. : milestone, 2081,
tracing (2.04 ms) : 1989, 2091
. : milestone, 2040,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]