Skip to content

Conversation

@quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Dec 9, 2025

What does this PR do?

Revamp of @rarguelloF PR for v2: contrib/go.uber.org/zap: add basic integration

Makes the following changes:

  • Support 128-bit trace IDs
  • Update to use v2 instead of v1
  • Register package in packages.go

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@quinna-h quinna-h requested review from a team as code owners December 9, 2025 22:08
@quinna-h quinna-h marked this pull request as draft December 9, 2025 22:08
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.38%. Comparing base (1a6f881) to head (8d8be52).

Files with missing lines Patch % Lines
contrib/go.uber.org/zap/zap.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
ddtrace/tracer/option.go 85.20% <ø> (+0.59%) ⬆️
instrumentation/packages.go 9.23% <ø> (ø)
contrib/go.uber.org/zap/zap.go 89.47% <89.47%> (ø)

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 9, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: 8d8be52 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2025

Benchmarks

Benchmark execution time: 2025-12-10 19:23:22

Comparing candidate commit 8d8be52 in PR branch zap-integration-refactor with baseline commit 1a6f881 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

@quinna-h quinna-h changed the title Zap integration refactor Zap integration Dec 9, 2025
@quinna-h quinna-h changed the title Zap integration feat: add zap integration Dec 10, 2025
@quinna-h quinna-h marked this pull request as ready for review December 10, 2025 20:58
@quinna-h quinna-h requested a review from a team as a code owner December 10, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants