Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 5, 2025

What does this PR do?

Tracer migrates to using Config.profilerEndpoints instead of its own config.profilerEndpoints.

Motivation

https://datadoghq.atlassian.net/browse/APMAPI-1748

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@kakkoyun kakkoyun changed the title tracer: migrate profilerEndpoints chore(config/tracer): migrate profilerEndpoints Dec 5, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 5, 2025

Benchmarks

Benchmark execution time: 2025-12-11 18:18:14

Comparing candidate commit 11c53ff in PR branch mtoff/profilerEndpoints with baseline commit d274bc5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 5, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: 11c53ff | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@mtoffl01 mtoffl01 changed the base branch from main to mtoff/revamp-debug-api December 5, 2025 17:25
@mtoffl01 mtoffl01 marked this pull request as ready for review December 5, 2025 18:41
@mtoffl01 mtoffl01 requested review from a team as code owners December 5, 2025 18:41
@mtoffl01 mtoffl01 marked this pull request as draft December 8, 2025 16:06
Base automatically changed from mtoff/revamp-debug-api to main December 9, 2025 09:21
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.36%. Comparing base (560907d) to head (11c53ff).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/config/config.go 10.00% 9 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
ddtrace/tracer/log.go 86.51% <100.00%> (ø)
ddtrace/tracer/option.go 85.07% <100.00%> (+0.55%) ⬆️
ddtrace/tracer/telemetry.go 87.50% <100.00%> (ø)
ddtrace/tracer/tracer.go 86.40% <100.00%> (+0.19%) ⬆️
internal/config/config.go 47.57% <10.00%> (-10.08%) ⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtoffl01 mtoffl01 marked this pull request as ready for review December 9, 2025 16:49
@mtoffl01 mtoffl01 changed the title chore(config/tracer): migrate profilerEndpoints chore(config): migrate tracer.profilerEndpoints Dec 9, 2025
@mtoffl01 mtoffl01 enabled auto-merge (squash) December 10, 2025 22:20
@mtoffl01 mtoffl01 merged commit 7785375 into main Dec 12, 2025
265 of 269 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/profilerEndpoints branch December 12, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants