-
Notifications
You must be signed in to change notification settings - Fork 493
chore(config): migrate tracer.logStartup #4214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| OriginRemoteConfig Origin = "remote_config" | ||
| OriginLocalStableConfig Origin = "local_stable_config" | ||
| OriginManagedStableConfig Origin = "fleet_stable_config" | ||
| OriginCalculated Origin = "calculated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"calculated" is an established origin already used by other ddtrace libs such as dotnet, node and java. It essentially represents, "we determined the value of this config based on other factors; we 'calculated' it outselves"
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected * Fix with Cursor requires Datadog plugin ≥v2.17.0 🔗 Commit SHA: f4f16d7 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ceb8a0b to
8eb1f41
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
37fb44d to
f4f16d7
Compare

What does this PR do?
Tracer migrates to using
Config.logStartupinstead of its ownconfig.logStartup.Motivation
https://datadoghq.atlassian.net/browse/APMAPI-1748
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!