Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 5, 2025

What does this PR do?

Tracer migrates to using Config.logStartup instead of its own config.logStartup.

Motivation

https://datadoghq.atlassian.net/browse/APMAPI-1748

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

OriginRemoteConfig Origin = "remote_config"
OriginLocalStableConfig Origin = "local_stable_config"
OriginManagedStableConfig Origin = "fleet_stable_config"
OriginCalculated Origin = "calculated"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"calculated" is an established origin already used by other ddtrace libs such as dotnet, node and java. It essentially represents, "we determined the value of this config based on other factors; we 'calculated' it outselves"

@pr-commenter
Copy link

pr-commenter bot commented Dec 5, 2025

Benchmarks

Benchmark execution time: 2025-12-11 15:56:34

Comparing candidate commit f4f16d7 in PR branch mtoff/logstartup with baseline commit 0f78453 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 5, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: f4f16d7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@kakkoyun kakkoyun changed the title tracer: migrate logStartup chore(config/tracer): migrate logStartup Dec 5, 2025
@mtoffl01 mtoffl01 marked this pull request as ready for review December 5, 2025 18:37
@mtoffl01 mtoffl01 requested review from a team as code owners December 5, 2025 18:37
@mtoffl01 mtoffl01 force-pushed the mtoff/revamp-debug-api branch from ceb8a0b to 8eb1f41 Compare December 5, 2025 19:02
@mtoffl01 mtoffl01 changed the base branch from mtoff/revamp-debug-api to mtoff/config-origin December 5, 2025 19:10
@mtoffl01 mtoffl01 marked this pull request as draft December 5, 2025 19:15
Base automatically changed from mtoff/config-origin to main December 9, 2025 15:38
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.28%. Comparing base (bee04f0) to head (37fb44d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/config/config.go 9.09% 10 Missing ⚠️
ddtrace/tracer/option.go 16.66% 5 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
ddtrace/tracer/telemetry.go 87.50% <100.00%> (ø)
ddtrace/tracer/tracer.go 86.40% <100.00%> (+0.19%) ⬆️
ddtrace/tracer/option.go 85.16% <16.66%> (+0.57%) ⬆️
internal/config/config.go 62.82% <9.09%> (-21.67%) ⬇️

... and 80 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtoffl01 mtoffl01 marked this pull request as ready for review December 9, 2025 16:48
@mtoffl01 mtoffl01 changed the title chore(config/tracer): migrate logStartup chore(config): migrate tracer.logStartup Dec 9, 2025
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mtoffl01 mtoffl01 merged commit 69ec141 into main Dec 11, 2025
248 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/logstartup branch December 11, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants