-
Notifications
You must be signed in to change notification settings - Fork 484
chore: enable shuffle testing for contrib packages #4065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
felixge
wants to merge
2
commits into
main
Choose a base branch
from
felix.geisendoerfer/chore-enable-shuffle-testing-for-contrib-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: enable shuffle testing for contrib packages #4065
felixge
wants to merge
2
commits into
main
from
felix.geisendoerfer/chore-enable-shuffle-testing-for-contrib-packages
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2025-10-23 05:29:34 Comparing candidate commit 17096cf in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
ceddef6 to
722d24a
Compare
|
Fix the test failure below by removing global state from the
implementation.
```
$ go test -test.shuffle 1761195191840193457 ./contrib/log/slog/
--- FAIL: TestWrapHandler (0.03s)
--- FAIL: TestWrapHandler/testLogger (0.03s)
slog_test.go:103: {"time":"2025-10-23T07:14:27.195674+02:00","level":"INFO","msg":"this is an info log with tracing information","dd.trace_id":"2097471805985655682","dd.span_id":"2097471805985655682"}
slog_test.go:103:
Error Trace: /Users/felix.geisendoerfer/go/src/github.com/DataDog/dd-trace-go/contrib/log/slog/slog_test.go:42
/Users/felix.geisendoerfer/go/src/github.com/DataDog/dd-trace-go/contrib/log/slog/slog_test.go:103
/Users/felix.geisendoerfer/go/src/github.com/DataDog/dd-trace-go/contrib/log/slog/slog_test.go:149
Error: Not equal:
expected: "68f9b9b3000000001d1bb77ea22c0b82"
actual : "2097471805985655682"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-68f9b9b3000000001d1bb77ea22c0b82
+2097471805985655682
Test: TestWrapHandler/testLogger
Messages: trace id not found
slog_test.go:104: {"time":"2025-10-23T07:14:27.195681+02:00","level":"ERROR","msg":"this is an error log with tracing information","dd.trace_id":"2097471805985655682","dd.span_id":"2097471805985655682"}
slog_test.go:104:
Error Trace: /Users/felix.geisendoerfer/go/src/github.com/DataDog/dd-trace-go/contrib/log/slog/slog_test.go:42
/Users/felix.geisendoerfer/go/src/github.com/DataDog/dd-trace-go/contrib/log/slog/slog_test.go:104
/Users/felix.geisendoerfer/go/src/github.com/DataDog/dd-trace-go/contrib/log/slog/slog_test.go:149
Error: Not equal:
expected: "68f9b9b3000000001d1bb77ea22c0b82"
actual : "2097471805985655682"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-68f9b9b3000000001d1bb77ea22c0b82
+2097471805985655682
Test: TestWrapHandler/testLogger
Messages: trace id not found
slog_test.go:132: {"time":"2025-10-23T07:14:27.203777+02:00","level":"INFO","msg":"this is an info log with tracing information"}
slog_test.go:133: {"time":"2025-10-23T07:14:27.20378+02:00","level":"ERROR","msg":"this is an error log with tracing information"}
```
722d24a to
17096cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4061
PROF-12822
What does this PR do?
Motivation
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!