Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go1.24 support] bump golangcilint #3198

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

hannahkm
Copy link
Contributor

What does this PR do?

Bumps the version of golangci-lint being used to be the latest version.

Motivation

The earliest version of golangci-lint to support Go v1.24 is v1.64, whereas we were previously at v1.63. To prevent failures on the main branch, we should upgrade the linter.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@hannahkm hannahkm requested review from a team as code owners February 18, 2025 18:52
@hannahkm hannahkm enabled auto-merge (squash) February 18, 2025 18:55
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 18, 2025

Datadog Report

Branch report: hannahkm/bump-golangcilint-again
Commit report: 752256c
Test service: dd-trace-go

✅ 0 Failed, 5257 Passed, 73 Skipped, 2m 7.16s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 18, 2025

Benchmarks

Benchmark execution time: 2025-02-19 09:34:13

Comparing candidate commit c31e31f in PR branch hannahkm/bump-golangcilint-again with baseline commit dde8a0b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 1 unstable metrics.

@hannahkm hannahkm merged commit 804001d into main Feb 19, 2025
173 checks passed
@hannahkm hannahkm deleted the hannahkm/bump-golangcilint-again branch February 19, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants