Draft: .NET cluster id via reflection #7702

robcarlan-datadog · 2025-10-23T18:01:57Z

Summary of changes

Don't merge - just a simple POC of obtaining cluster id and ensuring that this flows through our system correctly. Need to implement this correctly with duck typing.

Reason for change

Implementation details

Test coverage

Other details

This reverts commit b272d08.

datadog-datadog-prod-us1 · 2025-10-23T18:32:34Z

⚠️ Tests

⚠️ Warnings

🧪 739 Tests failed

CategorizedCallTargetIntegrations from Datadog.Trace.ClrProfiler.IntegrationTests.CallTargetNativeTests (Datadog)
Expected exit code: 0, actual exit code: 134.
HandlesBatchProcessing from Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringKafkaTests (Datadog)
Results do not match.
Differences:
Received: DataStreamsMonitoringKafkaTests.HandlesBatchProcessing.received.txt
Verified: DataStreamsMonitoringKafkaTests.HandlesBatchProcessing.verified.txt
Compare Result:
  {
    Env: integration_tests,
    Service: Samples.DataStreams.Kafka,
    TracerVersion: <snip>,
    Lang: dotnet,
...
HandlesBatchProcessing from Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringKafkaTests (Datadog)
Results do not match.
Differences:
Received: DataStreamsMonitoringKafkaTests.HandlesBatchProcessing.received.txt
Verified: DataStreamsMonitoringKafkaTests.HandlesBatchProcessing.verified.txt
Compare Result:
  {
    Env: integration_tests,
    Service: Samples.DataStreams.Kafka,
    TracerVersion: <snip>,
    Lang: dotnet,
...
View all

ℹ️ Info

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f83a435 | Docs | Was this helpful? Give us feedback!}

dd-trace-dotnet-ci-bot · 2025-10-23T19:16:22Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (82ms)  : crit, 77, 87
     .   : crit, milestone, 82,
    master - mean (75ms)  : 74, 76
     .   : milestone, 75,

    section Baseline
    This PR (7702) - mean (81ms)  : 72, 89
     .   : milestone, 81,
    master - mean (71ms)  : 69, 73
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (1,121ms)  : 954, 1288
     .   : milestone, 1121,
    master - mean (1,069ms)  : 1007, 1131
     .   : milestone, 1069,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (112ms)  : 109, 114
     .   : milestone, 112,
    master - mean (112ms)  : 109, 114
     .   : milestone, 112,

    section Baseline
    This PR (7702) - mean (110ms)  : 106, 114
     .   : milestone, 110,
    master - mean (111ms)  : 108, 113
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (759ms)  : 727, 791
     .   : milestone, 759,
    master - mean (761ms)  : 735, 788
     .   : milestone, 761,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (99ms)  : 96, 102
     .   : milestone, 99,
    master - mean (103ms)  : 101, 105
     .   : milestone, 103,

    section Baseline
    This PR (7702) - mean (98ms)  : 96, 100
     .   : milestone, 98,
    master - mean (100ms)  : 96, 104
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (731ms)  : 672, 790
     .   : milestone, 731,
    master - mean (721ms)  : 681, 761
     .   : milestone, 721,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (98ms)  : 96, 100
     .   : milestone, 98,
    master - mean (98ms)  : 96, 101
     .   : milestone, 98,

    section Baseline
    This PR (7702) - mean (97ms)  : 95, 99
     .   : milestone, 97,
    master - mean (97ms)  : 94, 100
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (679ms)  : 656, 701
     .   : milestone, 679,
    master - mean (679ms)  : 664, 693
     .   : milestone, 679,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (197ms)  : 194, 199
     .   : milestone, 197,
    master - mean (197ms)  : 194, 200
     .   : milestone, 197,

    section Baseline
    This PR (7702) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (194ms)  : 190, 197
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (1,184ms)  : 1089, 1278
     .   : milestone, 1184,
    master - mean (1,166ms)  : 1111, 1220
     .   : milestone, 1166,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (278ms)  : 274, 281
     .   : milestone, 278,

    section Baseline
    This PR (7702) - mean (277ms)  : 269, 285
     .   : milestone, 277,
    master - mean (278ms)  : 273, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (946ms)  : 900, 991
     .   : milestone, 946,
    master - mean (947ms)  : 898, 996
     .   : milestone, 947,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (270ms)  : 266, 274
     .   : milestone, 270,
    master - mean (271ms)  : 268, 274
     .   : milestone, 271,

    section Baseline
    This PR (7702) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (272ms)  : 266, 278
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (927ms)  : 880, 975
     .   : milestone, 927,
    master - mean (935ms)  : 873, 996
     .   : milestone, 935,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7702) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (271ms)  : 266, 276
     .   : milestone, 271,

    section Baseline
    This PR (7702) - mean (272ms)  : 267, 276
     .   : milestone, 272,
    master - mean (269ms)  : 265, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7702) - mean (855ms)  : 828, 882
     .   : milestone, 855,
    master - mean (861ms)  : 836, 886
     .   : milestone, 861,

pr-commenter · 2025-10-23T19:28:02Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7702 compared to master:

2 benchmarks are slower, with geometric mean 1.667
5 benchmarks have fewer allocations
4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7702

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	5.68 KB	5.71 KB	33 B	0.58%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	10.6μs	57ns	317ns	0	0	0	5.51 KB
master	`StartStopWithChild`	netcoreapp3.1	14.5μs	74ns	331ns	0	0	0	5.68 KB
master	`StartStopWithChild`	net472	22.3μs	124ns	849ns	0.861	0.215	0	6.06 KB
#7702	`StartStopWithChild`	net6.0	10.6μs	57.7ns	311ns	0	0	0	5.51 KB
#7702	`StartStopWithChild`	netcoreapp3.1	13.7μs	67ns	268ns	0	0	0	5.71 KB
#7702	`StartStopWithChild`	net472	22.2μs	118ns	603ns	0.996	0.332	0.111	6.04 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7702

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.31 KB	3.35 KB	46 B	1.39%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	938μs	255ns	988ns	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.05ms	224ns	840ns	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.18ms	90.7ns	327ns	3.31 KB
#7702	`WriteAndFlushEnrichedTraces`	net6.0	928μs	178ns	665ns	2.71 KB
#7702	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.02ms	210ns	788ns	2.71 KB
#7702	`WriteAndFlushEnrichedTraces`	net472	1.19ms	106ns	410ns	3.35 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`AllCycleSimpleBody`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN	0 b
master	`AllCycleSimpleBody`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN	0 b
master	`AllCycleSimpleBody`	net472	N/A	N/A	N/A	NaN	NaN	NaN	0 b
master	`AllCycleMoreComplexBody`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN	0 b
master	`AllCycleMoreComplexBody`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN	0 b
master	`AllCycleMoreComplexBody`	net472	N/A	N/A	N/A	NaN	NaN	NaN	0 b
master	`ObjectExtractorSimpleBody`	net6.0	320ns	0.151ns	0.566ns	0	0	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	397ns	2.1ns	10.7ns	0	0	0	272 B
master	`ObjectExtractorSimpleBody`	net472	300ns	1.07ns	3.87ns	0.0446	0	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.46μs	6.85ns	26.5ns	0	0	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.9μs	1.36ns	5.25ns	0	0	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.71μs	2.98ns	10.7ns	0.572	0	0	3.8 KB
#7702	`AllCycleSimpleBody`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN	0 b
#7702	`AllCycleSimpleBody`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN	0 b
#7702	`AllCycleSimpleBody`	net472	N/A	N/A	N/A	NaN	NaN	NaN	0 b
#7702	`AllCycleMoreComplexBody`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN	0 b
#7702	`AllCycleMoreComplexBody`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN	0 b
#7702	`AllCycleMoreComplexBody`	net472	N/A	N/A	N/A	NaN	NaN	NaN	0 b
#7702	`ObjectExtractorSimpleBody`	net6.0	323ns	0.295ns	1.14ns	0	0	0	280 B
#7702	`ObjectExtractorSimpleBody`	netcoreapp3.1	396ns	2.2ns	12.9ns	0	0	0	272 B
#7702	`ObjectExtractorSimpleBody`	net472	304ns	0.0716ns	0.277ns	0.0444	0	0	281 B
#7702	`ObjectExtractorMoreComplexBody`	net6.0	6.36μs	30.7ns	130ns	0	0	0	3.78 KB
#7702	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.87μs	36.2ns	145ns	0	0	0	3.69 KB
#7702	`ObjectExtractorMoreComplexBody`	net472	6.78μs	2.33ns	8.72ns	0.577	0	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EncodeArgs`	net6.0	76.6μs	136ns	526ns	0	32.4 KB
master	`EncodeArgs`	netcoreapp3.1	96.7μs	277ns	1.07μs	0	32.4 KB
master	`EncodeArgs`	net472	109μs	13.9ns	53.7ns	4.91	32.51 KB
master	`EncodeLegacyArgs`	net6.0	142μs	50ns	194ns	0	2.15 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	199μs	273ns	1.06μs	0	2.14 KB
master	`EncodeLegacyArgs`	net472	262μs	150ns	579ns	0	2.16 KB
#7702	`EncodeArgs`	net6.0	76.5μs	119ns	462ns	0	32.4 KB
#7702	`EncodeArgs`	netcoreapp3.1	98.2μs	104ns	402ns	0	32.4 KB
#7702	`EncodeArgs`	net472	109μs	64.9ns	251ns	4.89	32.51 KB
#7702	`EncodeLegacyArgs`	net6.0	146μs	44.8ns	162ns	0	2.15 KB
#7702	`EncodeLegacyArgs`	netcoreapp3.1	198μs	125ns	483ns	0	2.15 KB
#7702	`EncodeLegacyArgs`	net472	262μs	67.5ns	261ns	0	2.16 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7702

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1	2.089	410,639.27	857,890.62

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`RunWafRealisticBenchmark`	net6.0	390μs	52.6ns	197ns	4.55 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	411μs	294ns	1.14μs	4.48 KB
master	`RunWafRealisticBenchmark`	net472	430μs	40.9ns	158ns	4.66 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	286μs	45.8ns	177ns	2.24 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	300μs	367ns	1.27μs	2.22 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	311μs	30.8ns	119ns	2.29 KB
#7702	`RunWafRealisticBenchmark`	net6.0	395μs	61.1ns	237ns	4.55 KB
#7702	`RunWafRealisticBenchmark`	netcoreapp3.1	856μs	2.37μs	8.53μs	4.48 KB
#7702	`RunWafRealisticBenchmark`	net472	429μs	53.1ns	206ns	4.66 KB
#7702	`RunWafRealisticBenchmarkWithAttack`	net6.0	286μs	40.4ns	146ns	2.24 KB
#7702	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	300μs	68.5ns	247ns	2.22 KB
#7702	`RunWafRealisticBenchmarkWithAttack`	net472	311μs	26.5ns	103ns	2.29 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	61.2μs	53.8ns	194ns	14.52 KB
master	`SendRequest`	netcoreapp3.1	72.1μs	70.3ns	272ns	17.42 KB
master	`SendRequest`	net472	0.00335ns	0.00152ns	0.00591ns	0 b
#7702	`SendRequest`	net6.0	61.4μs	293ns	1.24μs	14.52 KB
#7702	`SendRequest`	netcoreapp3.1	71.6μs	49.8ns	173ns	17.42 KB
#7702	`SendRequest`	net472	0.00144ns	0.00135ns	0.00522ns	0 b

Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #7702

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice‑net6.0	1.331	1,903,155.73	2,532,733.75

Fewer allocations 🎉 in #7702

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0	5 B	4 B	-1 B	-20.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1	28 B	0 b	-28 B	-100.00%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`OriginalCharSlice`	net6.0	1.89ms	5.47μs	20.5μs	0	640.01 KB
master	`OriginalCharSlice`	netcoreapp3.1	2.14ms	9.36μs	36.2μs	0	640 KB
master	`OriginalCharSlice`	net472	2.65ms	95.6ns	345ns	100	641.95 KB
master	`OptimizedCharSlice`	net6.0	1.37ms	109ns	406ns	0	4 B
master	`OptimizedCharSlice`	netcoreapp3.1	1.68ms	270ns	1.04μs	0	1 B
master	`OptimizedCharSlice`	net472	2.09ms	339ns	1.31μs	0	0 b
master	`OptimizedCharSliceWithPool`	net6.0	877μs	29.4ns	110ns	0	5 B
master	`OptimizedCharSliceWithPool`	netcoreapp3.1	854μs	158ns	613ns	0	28 B
master	`OptimizedCharSliceWithPool`	net472	1.13ms	65.9ns	247ns	0	0 b
#7702	`OriginalCharSlice`	net6.0	2.51ms	10.8μs	41.9μs	0	640.01 KB
#7702	`OriginalCharSlice`	netcoreapp3.1	2.09ms	3.26μs	12.2μs	0	640 KB
#7702	`OriginalCharSlice`	net472	2.64ms	115ns	446ns	100	641.95 KB
#7702	`OptimizedCharSlice`	net6.0	1.37ms	243ns	940ns	0	4 B
#7702	`OptimizedCharSlice`	netcoreapp3.1	1.76ms	525ns	2.03μs	0	1 B
#7702	`OptimizedCharSlice`	net472	1.9ms	361ns	1.4μs	0	0 b
#7702	`OptimizedCharSliceWithPool`	net6.0	800μs	63.8ns	247ns	0	4 B
#7702	`OptimizedCharSliceWithPool`	netcoreapp3.1	813μs	147ns	570ns	0	0 b
#7702	`OptimizedCharSliceWithPool`	net472	1.18ms	104ns	389ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7702

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	56.39 KB	55.77 KB	-615 B	-1.09%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	673μs	1.78μs	6.88μs	0	41.82 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	689μs	3.94μs	30.7μs	0	42.11 KB
master	`WriteAndFlushEnrichedTraces`	net472	873μs	3.13μs	11.7μs	8.33	56.39 KB
#7702	`WriteAndFlushEnrichedTraces`	net6.0	643μs	1.26μs	7.03μs	0	41.65 KB
#7702	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	755μs	3.69μs	14.8μs	0	41.91 KB
#7702	`WriteAndFlushEnrichedTraces`	net472	874μs	2.33μs	9.03μs	8.33	55.77 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.92μs	9.15ns	36.6ns	0	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.59μs	9.16ns	35.5ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.76μs	1.13ns	4.07ns	0.15	0.0137	987 B
#7702	`ExecuteNonQuery`	net6.0	1.84μs	9.01ns	37.1ns	0	0	1.02 KB
#7702	`ExecuteNonQuery`	netcoreapp3.1	2.75μs	3.26ns	12.6ns	0	0	1.02 KB
#7702	`ExecuteNonQuery`	net472	2.72μs	4.39ns	17ns	0.149	0.0135	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.71μs	8.98ns	44.9ns	0	1.03 KB
master	`CallElasticsearch`	netcoreapp3.1	2.18μs	10.7ns	47.8ns	0	1.03 KB
master	`CallElasticsearch`	net472	3.61μs	2.37ns	8.87ns	0.163	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.88μs	9.66ns	44.3ns	0	1.01 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.35μs	10.7ns	39.9ns	0	1.08 KB
master	`CallElasticsearchAsync`	net472	3.81μs	6.09ns	22.8ns	0.172	1.1 KB
#7702	`CallElasticsearch`	net6.0	1.74μs	8.86ns	38.6ns	0	1.03 KB
#7702	`CallElasticsearch`	netcoreapp3.1	2.19μs	10.1ns	39.3ns	0	1.03 KB
#7702	`CallElasticsearch`	net472	3.5μs	1.14ns	4.4ns	0.157	1.04 KB
#7702	`CallElasticsearchAsync`	net6.0	1.8μs	6.22ns	24.1ns	0	1.01 KB
#7702	`CallElasticsearchAsync`	netcoreapp3.1	2.42μs	10ns	38.9ns	0	1.08 KB
#7702	`CallElasticsearchAsync`	net472	3.63μs	4.27ns	16.6ns	0.163	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.88μs	8.1ns	31.4ns	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	2.49μs	7.29ns	28.2ns	0	952 B
master	`ExecuteAsync`	net472	2.7μs	0.916ns	3.43ns	0.135	915 B
#7702	`ExecuteAsync`	net6.0	1.91μs	1.2ns	4.16ns	0	952 B
#7702	`ExecuteAsync`	netcoreapp3.1	2.39μs	10.3ns	40ns	0	952 B
#7702	`ExecuteAsync`	net472	2.65μs	2.73ns	10.6ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	6.73μs	13.9ns	52.1ns	0	2.36 KB
master	`SendAsync`	netcoreapp3.1	8.74μs	22.2ns	86ns	0	2.9 KB
master	`SendAsync`	net472	12.6μs	10.2ns	39.7ns	0.5	3.18 KB
#7702	`SendAsync`	net6.0	6.89μs	15.7ns	58.7ns	0	2.36 KB
#7702	`SendAsync`	netcoreapp3.1	8.56μs	23.8ns	92.2ns	0	2.9 KB
#7702	`SendAsync`	net472	12.3μs	13.2ns	51.2ns	0.491	3.18 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7702

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	255.94 KB	276.76 KB	20.82 KB	8.14%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	42.68 KB	44.04 KB	1.36 KB	3.19%

Fewer allocations 🎉 in #7702

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	43.87 KB	43.54 KB	-336 B	-0.77%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	276.01 KB	259.5 KB	-16.5 KB	-5.98%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	45.2μs	256ns	1.72μs	43.87 KB
master	`StringConcatBenchmark`	netcoreapp3.1	48.5μs	246ns	1.48μs	42.68 KB
master	`StringConcatBenchmark`	net472	56.9μs	268ns	1.07μs	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	468μs	1.94μs	7μs	276.01 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	498μs	1.45μs	5.44μs	255.94 KB
master	`StringConcatAspectBenchmark`	net472	405μs	2.21μs	12.9μs	279.51 KB
#7702	`StringConcatBenchmark`	net6.0	41.2μs	193ns	747ns	43.54 KB
#7702	`StringConcatBenchmark`	netcoreapp3.1	46.6μs	134ns	463ns	44.04 KB
#7702	`StringConcatBenchmark`	net472	57.6μs	219ns	819ns	57.34 KB
#7702	`StringConcatAspectBenchmark`	net6.0	491μs	2.21μs	7.66μs	259.5 KB
#7702	`StringConcatAspectBenchmark`	netcoreapp3.1	523μs	1.65μs	5.71μs	276.76 KB
#7702	`StringConcatAspectBenchmark`	net472	407μs	2.09μs	10.3μs	278.53 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.58μs	13.7ns	66.9ns	0	1.7 KB
master	`EnrichedLog`	netcoreapp3.1	3.62μs	16.9ns	69.5ns	0	1.7 KB
master	`EnrichedLog`	net472	3.77μs	3.49ns	13.5ns	0.245	1.64 KB
#7702	`EnrichedLog`	net6.0	2.62μs	1.43ns	5.53ns	0	1.7 KB
#7702	`EnrichedLog`	netcoreapp3.1	3.69μs	18.3ns	77.6ns	0	1.7 KB
#7702	`EnrichedLog`	net472	3.95μs	5.65ns	21.9ns	0.256	1.64 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	123μs	109ns	391ns	4.31 KB
master	`EnrichedLog`	netcoreapp3.1	127μs	38.4ns	139ns	4.31 KB
master	`EnrichedLog`	net472	167μs	30ns	112ns	4.52 KB
#7702	`EnrichedLog`	net6.0	123μs	38.5ns	133ns	4.31 KB
#7702	`EnrichedLog`	netcoreapp3.1	129μs	597ns	2.31μs	4.31 KB
#7702	`EnrichedLog`	net472	168μs	31.9ns	124ns	4.52 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.9μs	9.14ns	35.4ns	0	2.26 KB
master	`EnrichedLog`	netcoreapp3.1	6.72μs	6.94ns	25ns	0	2.26 KB
master	`EnrichedLog`	net472	7.63μs	4.32ns	16.7ns	0.306	2.08 KB
#7702	`EnrichedLog`	net6.0	4.95μs	25.1ns	103ns	0	2.26 KB
#7702	`EnrichedLog`	netcoreapp3.1	6.7μs	20.1ns	72.3ns	0	2.26 KB
#7702	`EnrichedLog`	net472	8.03μs	12.5ns	48.5ns	0.323	2.08 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	2.02μs	9.35ns	33.7ns	0	1.2 KB
master	`SendReceive`	netcoreapp3.1	2.81μs	5.49ns	21.2ns	0	1.2 KB
master	`SendReceive`	net472	3.22μs	3.82ns	14.8ns	0.176	1.2 KB
#7702	`SendReceive`	net6.0	1.96μs	10.1ns	47.5ns	0	1.2 KB
#7702	`SendReceive`	netcoreapp3.1	2.67μs	13.9ns	66.6ns	0	1.2 KB
#7702	`SendReceive`	net472	3.1μs	5.13ns	19.9ns	0.184	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.31μs	4.48ns	16.8ns	0	1.58 KB
master	`EnrichedLog`	netcoreapp3.1	5.71μs	9.26ns	33.4ns	0	1.63 KB
master	`EnrichedLog`	net472	6.52μs	8.55ns	33.1ns	0.293	2.03 KB
#7702	`EnrichedLog`	net6.0	4.27μs	10.5ns	39.2ns	0	1.58 KB
#7702	`EnrichedLog`	netcoreapp3.1	5.55μs	12.7ns	47.7ns	0	1.63 KB
#7702	`EnrichedLog`	net472	6.65μs	11.4ns	44ns	0.297	2.03 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	789ns	3.9ns	17.5ns	0	576 B
master	`StartFinishSpan`	netcoreapp3.1	965ns	5.15ns	27.7ns	0	576 B
master	`StartFinishSpan`	net472	915ns	0.274ns	0.989ns	0.0917	578 B
master	`StartFinishScope`	net6.0	944ns	5.22ns	28.1ns	0	696 B
master	`StartFinishScope`	netcoreapp3.1	1.23μs	6.57ns	35.4ns	0	697 B
master	`StartFinishScope`	net472	1.14μs	0.122ns	0.474ns	0.103	658 B
#7702	`StartFinishSpan`	net6.0	768ns	1.96ns	7.58ns	0	576 B
#7702	`StartFinishSpan`	netcoreapp3.1	974ns	5.03ns	25.2ns	0	576 B
#7702	`StartFinishSpan`	net472	917ns	0.106ns	0.398ns	0.0873	578 B
#7702	`StartFinishScope`	net6.0	907ns	4.38ns	19.1ns	0	696 B
#7702	`StartFinishScope`	netcoreapp3.1	1.21μs	6.19ns	29.7ns	0	696 B
#7702	`StartFinishScope`	net472	1.14μs	0.205ns	0.795ns	0.103	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.07μs	5.57ns	26.7ns	0	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.44μs	5.16ns	20ns	0	696 B
master	`RunOnMethodBegin`	net472	1.43μs	0.533ns	2.07ns	0.1	658 B
#7702	`RunOnMethodBegin`	net6.0	1.04μs	5.61ns	30.2ns	0	696 B
#7702	`RunOnMethodBegin`	netcoreapp3.1	1.39μs	7.05ns	30.7ns	0	696 B
#7702	`RunOnMethodBegin`	net472	1.46μs	0.83ns	3.22ns	0.103	658 B

robcarlan-datadog added 14 commits October 17, 2025 16:14

WIP adding kafka cluster id pass 0

2cc66a6

add verbose logging to branch

12e1ae5

use GetCluster admin API call

4e3eefd

Merge branch 'master' into rob.carlan/kafka-cluster-id-tag

cac15ea

simple attempt to avoid infinite loop

8ea5880

log to console

529693e

Merge branch 'master' into rob.carlan/kafka-cluster-id-tag

f81899b

try new way of describe cluster

d460d8f

try static duck typing

0d11980

Merge branch 'master' into rob.carlan/kafka-cluster-id-tag

cbe909f

working via reflection

dea7110

simplify, remove reflection

b272d08

Revert "simplify, remove reflection"

656feb2

This reverts commit b272d08.

implement via Reflection

b5cadb6

attempt adding kafka_cluster_id to dsm checkpoints

f83a435

Uh oh!

Draft: .NET cluster id via reflection #7702

Are you sure you want to change the base?

Draft: .NET cluster id via reflection #7702

Uh oh!

Conversation

robcarlan-datadog commented Oct 23, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

dd-trace-dotnet-ci-bot bot commented Oct 23, 2025

Execution-Time Benchmarks Report ⏱️

Uh oh!

pr-commenter bot commented Oct 23, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

More allocations ⚠️ in #7702

Raw results

More allocations ⚠️ in #7702

Raw results

Raw results

Raw results

Slower ⚠️ in #7702

Raw results

Raw results

Slower ⚠️ in #7702

Fewer allocations 🎉 in #7702

Raw results

Fewer allocations 🎉 in #7702

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #7702

Fewer allocations 🎉 in #7702

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datadog-datadog-prod-us1 bot commented Oct 23, 2025 •

edited

Loading