Skip to content

Remove the ApiWebRequest transport in favor of the HttpClientRequest #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Remove the ApiWebRequest transport in favor of the HttpClientRequest #7684

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b51231f
Remove the ApiWebRequest transport in favor of the HttpClientRequest …
tonyredondo Oct 21, 2025
14ecaf3
fixes
tonyredondo Oct 21, 2025
e6a9bcc
changes
tonyredondo Oct 21, 2025
e1a70c0
fixes
tonyredondo Oct 21, 2025
f32ad90
fixes
tonyredondo Oct 22, 2025
02aa687
fix
tonyredondo Oct 22, 2025
0ac3712
Merge branch 'master' into tony/remove-api-web-request-transport
tonyredondo Oct 22, 2025
b1983d5
changes
tonyredondo Oct 23, 2025
a558abc
update snapshot
tonyredondo Oct 23, 2025
f054718
changes
tonyredondo Oct 24, 2025
6e71449
fixes
tonyredondo Oct 27, 2025
9a30527
Merge branch 'master' into tony/remove-api-web-request-transport
tonyredondo Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tracer/missing-nullability-files.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,6 @@ src/Datadog.Trace/Agent/TraceSamplers/ErrorSampler.cs
src/Datadog.Trace/Agent/TraceSamplers/ITraceChunkSampler.cs
src/Datadog.Trace/Agent/TraceSamplers/PrioritySampler.cs
src/Datadog.Trace/Agent/TraceSamplers/RareSampler.cs
src/Datadog.Trace/Agent/Transports/ApiWebRequest.cs
src/Datadog.Trace/Agent/Transports/ApiWebRequestFactory.cs
src/Datadog.Trace/Agent/Transports/HttpClientRequest.cs
src/Datadog.Trace/Agent/Transports/HttpClientRequestFactory.cs
src/Datadog.Trace/Agent/Transports/HttpStreamRequest.cs
Expand Down
1 change: 0 additions & 1 deletion tracer/src/Datadog.Trace.Trimming/build/Datadog.Trace.Trimming.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,6 @@
<type fullname="System.Net.Sockets.UnixDomainSocketEndPoint" />
</assembly>
<assembly fullname="System.Net.WebHeaderCollection">
<type fullname="System.Net.HttpRequestHeader" />
<type fullname="System.Net.WebHeaderCollection" />
</assembly>
<assembly fullname="System.Net.WebProxy">
Expand Down
5 changes: 0 additions & 5 deletions tracer/src/Datadog.Trace/Agent/AgentTransportStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,8 @@ public static IApiRequestFactory Get(
#endif
case TracesTransportType.Default:
default:
#if NETCOREAPP
Log.Information("Using " + nameof(HttpClientRequestFactory) + " for {ProductName} transport.", productName);
return new HttpClientRequestFactory(getBaseEndpoint(settings.AgentUri), defaultAgentHeaders, timeout: tcpTimeout);
#else
Log.Information("Using " + nameof(ApiWebRequestFactory) + " for {ProductName} transport.", productName);
return new ApiWebRequestFactory(getBaseEndpoint(settings.AgentUri), defaultAgentHeaders, timeout: tcpTimeout);
#endif
}
}
}
191 changes: 0 additions & 191 deletions tracer/src/Datadog.Trace/Agent/Transports/ApiWebRequest.cs
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions tracer/src/Datadog.Trace/Agent/Transports/ApiWebRequestFactory.cs
View file
Open in desktop

This file was deleted.

49 changes: 0 additions & 49 deletions tracer/src/Datadog.Trace/Agent/Transports/ApiWebResponse.cs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions tracer/src/Datadog.Trace/Agent/Transports/GzipCompressedContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

#nullable enable

#if NETCOREAPP
using System.IO;
using System.IO.Compression;
using System.Net;
Expand Down Expand Up @@ -47,5 +46,3 @@ protected override bool TryComputeLength(out long length)
return false;
}
}

#endif
3 changes: 0 additions & 3 deletions tracer/src/Datadog.Trace/Agent/Transports/HttpClientRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

#if NETCOREAPP
using System;
using System.IO;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Threading.Tasks;
using Datadog.Trace.AppSec;
using Datadog.Trace.HttpOverStreams;
using Datadog.Trace.Logging;

Expand Down Expand Up @@ -152,4 +150,3 @@ public async Task<IApiResponse> PostAsync(MultipartFormItem[] items, MultipartCo
}
}
}
#endif
2 changes: 0 additions & 2 deletions tracer/src/Datadog.Trace/Agent/Transports/HttpClientRequestFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

#if NETCOREAPP
using System;
using System.Collections.Generic;
using System.Net;
Expand Down Expand Up @@ -62,4 +61,3 @@ public void SetProxy(WebProxy proxy, NetworkCredential credential)
}
}
}
#endif
Loading
Loading