-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Package Versions Bump] Updating package versions #6486
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6486) - mean (69ms) : 66, 71
. : milestone, 69,
master - mean (69ms) : 64, 74
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6486) - mean (981ms) : 954, 1008
. : milestone, 981,
master - mean (972ms) : 951, 993
. : milestone, 972,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6486) - mean (108ms) : 106, 111
. : milestone, 108,
master - mean (107ms) : 104, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6486) - mean (681ms) : 668, 694
. : milestone, 681,
master - mean (674ms) : 659, 690
. : milestone, 674,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6486) - mean (91ms) : 89, 94
. : milestone, 91,
master - mean (90ms) : 89, 92
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (6486) - mean (634ms) : 615, 652
. : milestone, 634,
master - mean (632ms) : 614, 650
. : milestone, 632,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6486) - mean (194ms) : 187, 201
. : milestone, 194,
master - mean (195ms) : 188, 201
. : milestone, 195,
section CallTarget+Inlining+NGEN
This PR (6486) - mean (1,097ms) : 1068, 1126
. : milestone, 1097,
master - mean (1,098ms) : 1075, 1121
. : milestone, 1098,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6486) - mean (278ms) : 272, 284
. : milestone, 278,
master - mean (278ms) : 272, 283
. : milestone, 278,
section CallTarget+Inlining+NGEN
This PR (6486) - mean (873ms) : 827, 919
. : milestone, 873,
master - mean (871ms) : 837, 904
. : milestone, 871,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6486) - mean (266ms) : 262, 270
. : milestone, 266,
master - mean (267ms) : 261, 272
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6486) - mean (846ms) : 813, 879
. : milestone, 846,
master - mean (853ms) : 811, 895
. : milestone, 853,
|
Datadog ReportBranch report: ✅ 0 Failed, 459687 Passed, 2866 Skipped, 20h 37m 25.97s Total Time ⌛ Performance Regressions vs Default Branch (1)
|
Benchmarks Report for tracer 🐌Benchmarks for #6486 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.160 | 754.55 | 650.64 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 398ns | 0.337ns | 1.31ns | 0.00816 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 619ns | 0.637ns | 2.47ns | 0.0077 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 754ns | 0.597ns | 2.31ns | 0.0915 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 481ns | 0.323ns | 1.25ns | 0.00975 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 797ns | 0.998ns | 3.86ns | 0.00948 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 900ns | 0.439ns | 1.7ns | 0.104 | 0 | 0 | 658 B |
#6486 | StartFinishSpan |
net6.0 | 399ns | 0.216ns | 0.837ns | 0.00799 | 0 | 0 | 576 B |
#6486 | StartFinishSpan |
netcoreapp3.1 | 566ns | 0.493ns | 1.85ns | 0.0079 | 0 | 0 | 576 B |
#6486 | StartFinishSpan |
net472 | 651ns | 0.504ns | 1.95ns | 0.0917 | 0 | 0 | 578 B |
#6486 | StartFinishScope |
net6.0 | 480ns | 0.474ns | 1.83ns | 0.00987 | 0 | 0 | 696 B |
#6486 | StartFinishScope |
netcoreapp3.1 | 805ns | 0.476ns | 1.84ns | 0.00924 | 0 | 0 | 696 B |
#6486 | StartFinishScope |
net472 | 870ns | 0.671ns | 2.51ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 653ns | 0.352ns | 1.36ns | 0.00964 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 886ns | 0.506ns | 1.82ns | 0.0094 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.16μs | 0.67ns | 2.32ns | 0.104 | 0 | 0 | 658 B |
#6486 | RunOnMethodBegin |
net6.0 | 597ns | 0.301ns | 1.17ns | 0.00967 | 0 | 0 | 696 B |
#6486 | RunOnMethodBegin |
netcoreapp3.1 | 913ns | 0.771ns | 2.98ns | 0.0093 | 0 | 0 | 696 B |
#6486 | RunOnMethodBegin |
net472 | 1.09μs | 1.09ns | 4.24ns | 0.104 | 0 | 0 | 658 B |
69845ec
to
2f6b900
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall - we'll need to do a manual test of the Oracle sample
<!-- Latest package https://www.nuget.org/packages/Oracle.ManagedDataAccess/23.7.0 --> | ||
<PackageReference Include="Oracle.ManagedDataAccess" Version="23.7.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs a manual test
Updates the package versions for integration tests.