Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6486

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners December 25, 2024 16:56
@andrewlock
Copy link
Member

andrewlock commented Dec 25, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6486) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 64, 74
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6486) - mean (981ms)  : 954, 1008
     .   : milestone, 981,
    master - mean (972ms)  : 951, 993
     .   : milestone, 972,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6486) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (107ms)  : 104, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6486) - mean (681ms)  : 668, 694
     .   : milestone, 681,
    master - mean (674ms)  : 659, 690
     .   : milestone, 674,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6486) - mean (91ms)  : 89, 94
     .   : milestone, 91,
    master - mean (90ms)  : 89, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6486) - mean (634ms)  : 615, 652
     .   : milestone, 634,
    master - mean (632ms)  : 614, 650
     .   : milestone, 632,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6486) - mean (194ms)  : 187, 201
     .   : milestone, 194,
    master - mean (195ms)  : 188, 201
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (6486) - mean (1,097ms)  : 1068, 1126
     .   : milestone, 1097,
    master - mean (1,098ms)  : 1075, 1121
     .   : milestone, 1098,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6486) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (278ms)  : 272, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6486) - mean (873ms)  : 827, 919
     .   : milestone, 873,
    master - mean (871ms)  : 837, 904
     .   : milestone, 871,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6486) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (267ms)  : 261, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6486) - mean (846ms)  : 813, 879
     .   : milestone, 846,
    master - mean (853ms)  : 811, 895
     .   : milestone, 853,

Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 25, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 2f6b900
Test service: dd-trace-dotnet

✅ 0 Failed, 459687 Passed, 2866 Skipped, 20h 37m 25.97s Total Time
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

  • Baseline_liveheap - scenarios 2.77s (+32.68ms, +1%)

@andrewlock
Copy link
Member

andrewlock commented Dec 25, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6486 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.160
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.94μs 44.5ns 298ns 0.0121 0.00405 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.2μs 54ns 265ns 0.0145 0.00483 0 5.8 KB
master StartStopWithChild net472 16.3μs 46.9ns 182ns 1.05 0.319 0.106 6.21 KB
#6486 StartStopWithChild net6.0 8.09μs 45.2ns 293ns 0.0201 0.00804 0 5.61 KB
#6486 StartStopWithChild netcoreapp3.1 10.1μs 55.2ns 331ns 0.0152 0.00505 0 5.81 KB
#6486 StartStopWithChild net472 16.5μs 50.9ns 197ns 1.03 0.309 0.0975 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 488μs 403ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 324ns 1.25μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 854μs 661ns 2.47μs 0.428 0 0 3.3 KB
#6486 WriteAndFlushEnrichedTraces net6.0 489μs 349ns 1.35μs 0 0 0 2.7 KB
#6486 WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 551ns 2.14μs 0 0 0 2.7 KB
#6486 WriteAndFlushEnrichedTraces net472 852μs 488ns 1.83μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 155μs 857ns 7.81μs 0.152 0 0 14.48 KB
master SendRequest netcoreapp3.1 176μs 1.38μs 13.6μs 0.154 0 0 17.27 KB
master SendRequest net472 2.39E‑05ns 2.16E‑05ns 7.79E‑05ns 0 0 0 0 b
#6486 SendRequest net6.0 150μs 869ns 7.48μs 0.149 0 0 14.47 KB
#6486 SendRequest netcoreapp3.1 173μs 1μs 8.44μs 0.188 0 0 17.27 KB
#6486 SendRequest net472 0.000139ns 7.95E‑05ns 0.000308ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 563μs 3.06μs 24.8μs 0.551 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 669μs 3.8μs 29.2μs 0.322 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 850μs 3.02μs 11.7μs 8.13 2.57 0.428 53.26 KB
#6486 WriteAndFlushEnrichedTraces net6.0 574μs 2.69μs 10.4μs 0.553 0 0 41.69 KB
#6486 WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.82μs 27.3μs 0.338 0 0 41.78 KB
#6486 WriteAndFlushEnrichedTraces net472 829μs 3.92μs 15.7μs 8.13 2.57 0.428 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 1.14ns 4.42ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.7μs 1.43ns 5.17ns 0.0135 0 0 1.02 KB
master ExecuteNonQuery net472 2.08μs 3.37ns 13ns 0.156 0.00103 0 987 B
#6486 ExecuteNonQuery net6.0 1.27μs 1.14ns 4.43ns 0.0142 0 0 1.02 KB
#6486 ExecuteNonQuery netcoreapp3.1 1.74μs 1.54ns 5.97ns 0.0131 0 0 1.02 KB
#6486 ExecuteNonQuery net472 2.07μs 1.98ns 7.67ns 0.157 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.31μs 1.08ns 4.04ns 0.0132 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.57μs 0.594ns 2.14ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.52μs 1.08ns 4.03ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 0.643ns 2.49ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 0.706ns 2.74ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.67μs 1.08ns 4.05ns 0.167 0 0 1.05 KB
#6486 CallElasticsearch net6.0 1.26μs 0.451ns 1.63ns 0.0133 0 0 976 B
#6486 CallElasticsearch netcoreapp3.1 1.6μs 0.758ns 2.84ns 0.0129 0 0 976 B
#6486 CallElasticsearch net472 2.52μs 0.941ns 3.39ns 0.158 0 0 995 B
#6486 CallElasticsearchAsync net6.0 1.37μs 0.481ns 1.86ns 0.0129 0 0 952 B
#6486 CallElasticsearchAsync netcoreapp3.1 1.67μs 1.6ns 5.97ns 0.0134 0 0 1.02 KB
#6486 CallElasticsearchAsync net472 2.57μs 1.09ns 4.21ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.32μs 0.693ns 2.59ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.64μs 1.55ns 6.01ns 0.013 0 0 952 B
master ExecuteAsync net472 1.83μs 0.446ns 1.67ns 0.145 0 0 915 B
#6486 ExecuteAsync net6.0 1.36μs 0.987ns 3.69ns 0.0135 0 0 952 B
#6486 ExecuteAsync netcoreapp3.1 1.67μs 0.627ns 2.43ns 0.0126 0 0 952 B
#6486 ExecuteAsync net472 1.82μs 0.636ns 2.38ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.41μs 1.71ns 6.15ns 0.0308 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.31μs 1.3ns 5.02ns 0.0372 0 0 2.85 KB
master SendAsync net472 7.38μs 1.9ns 7.38ns 0.494 0 0 3.12 KB
#6486 SendAsync net6.0 4.46μs 0.893ns 3.46ns 0.0312 0 0 2.31 KB
#6486 SendAsync netcoreapp3.1 5.3μs 2.74ns 10.6ns 0.037 0 0 2.85 KB
#6486 SendAsync net472 7.42μs 2.45ns 9.5ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.44μs 1.1ns 4.12ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.17μs 1.31ns 4.9ns 0.0218 0 0 1.64 KB
master EnrichedLog net472 2.74μs 1.65ns 6.4ns 0.249 0 0 1.57 KB
#6486 EnrichedLog net6.0 1.43μs 0.634ns 2.45ns 0.0229 0 0 1.64 KB
#6486 EnrichedLog netcoreapp3.1 2.39μs 0.724ns 2.71ns 0.0215 0 0 1.64 KB
#6486 EnrichedLog net472 2.71μs 0.891ns 3.45ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 145ns 563ns 0.0596 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 190ns 710ns 0 0 0 4.28 KB
master EnrichedLog net472 153μs 132ns 511ns 0.687 0.229 0 4.46 KB
#6486 EnrichedLog net6.0 119μs 171ns 663ns 0 0 0 4.28 KB
#6486 EnrichedLog netcoreapp3.1 123μs 123ns 462ns 0 0 0 4.28 KB
#6486 EnrichedLog net472 153μs 193ns 747ns 0.682 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.1μs 1.73ns 6ns 0.0312 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.23μs 1.87ns 6.74ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.9μs 1.3ns 5.04ns 0.319 0 0 2.02 KB
#6486 EnrichedLog net6.0 3.06μs 1.25ns 4.69ns 0.0306 0 0 2.2 KB
#6486 EnrichedLog netcoreapp3.1 4.12μs 2.18ns 8.44ns 0.029 0 0 2.2 KB
#6486 EnrichedLog net472 4.75μs 1.5ns 5.61ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.566ns 2.19ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 2.43ns 9.4ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.1μs 2.21ns 8.55ns 0.183 0 0 1.16 KB
#6486 SendReceive net6.0 1.36μs 0.927ns 3.59ns 0.0157 0 0 1.14 KB
#6486 SendReceive netcoreapp3.1 1.81μs 0.475ns 1.84ns 0.0152 0 0 1.14 KB
#6486 SendReceive net472 2.11μs 3.04ns 11.8ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.83μs 1.43ns 5.53ns 0.0227 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.05μs 2.57ns 9.96ns 0.0222 0 0 1.65 KB
master EnrichedLog net472 4.32μs 3.79ns 14.7ns 0.322 0 0 2.04 KB
#6486 EnrichedLog net6.0 2.74μs 0.998ns 3.87ns 0.0218 0 0 1.6 KB
#6486 EnrichedLog netcoreapp3.1 3.88μs 0.872ns 3.26ns 0.0213 0 0 1.65 KB
#6486 EnrichedLog net472 4.46μs 1.62ns 6.29ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6486

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.160 754.55 650.64

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 398ns 0.337ns 1.31ns 0.00816 0 0 576 B
master StartFinishSpan netcoreapp3.1 619ns 0.637ns 2.47ns 0.0077 0 0 576 B
master StartFinishSpan net472 754ns 0.597ns 2.31ns 0.0915 0 0 578 B
master StartFinishScope net6.0 481ns 0.323ns 1.25ns 0.00975 0 0 696 B
master StartFinishScope netcoreapp3.1 797ns 0.998ns 3.86ns 0.00948 0 0 696 B
master StartFinishScope net472 900ns 0.439ns 1.7ns 0.104 0 0 658 B
#6486 StartFinishSpan net6.0 399ns 0.216ns 0.837ns 0.00799 0 0 576 B
#6486 StartFinishSpan netcoreapp3.1 566ns 0.493ns 1.85ns 0.0079 0 0 576 B
#6486 StartFinishSpan net472 651ns 0.504ns 1.95ns 0.0917 0 0 578 B
#6486 StartFinishScope net6.0 480ns 0.474ns 1.83ns 0.00987 0 0 696 B
#6486 StartFinishScope netcoreapp3.1 805ns 0.476ns 1.84ns 0.00924 0 0 696 B
#6486 StartFinishScope net472 870ns 0.671ns 2.51ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 653ns 0.352ns 1.36ns 0.00964 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 886ns 0.506ns 1.82ns 0.0094 0 0 696 B
master RunOnMethodBegin net472 1.16μs 0.67ns 2.32ns 0.104 0 0 658 B
#6486 RunOnMethodBegin net6.0 597ns 0.301ns 1.17ns 0.00967 0 0 696 B
#6486 RunOnMethodBegin netcoreapp3.1 913ns 0.771ns 2.98ns 0.0093 0 0 696 B
#6486 RunOnMethodBegin net472 1.09μs 1.09ns 4.24ns 0.104 0 0 658 B

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 69845ec to 2f6b900 Compare December 29, 2024 00:27
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall - we'll need to do a manual test of the Oracle sample

Comment on lines +260 to +261
<!-- Latest package https://www.nuget.org/packages/Oracle.ManagedDataAccess/23.7.0 -->
<PackageReference Include="Oracle.ManagedDataAccess" Version="23.7.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs a manual test

@andrewlock andrewlock merged commit 56f4d88 into master Dec 31, 2024
90 of 92 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch December 31, 2024 09:48
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant