-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Visibility] Add missing telemetry metrics #6443
base: master
Are you sure you want to change the base?
[CI Visibility] Add missing telemetry metrics #6443
Conversation
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 463412 Passed, 2876 Skipped, 19h 12m 18.56s Total Time ❌ Failed Tests (1)
⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6443) - mean (68ms) : 65, 71
. : milestone, 68,
master - mean (68ms) : 65, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6443) - mean (980ms) : 954, 1006
. : milestone, 980,
master - mean (977ms) : 953, 1000
. : milestone, 977,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6443) - mean (107ms) : 105, 110
. : milestone, 107,
master - mean (107ms) : 105, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6443) - mean (677ms) : 663, 691
. : milestone, 677,
master - mean (677ms) : 660, 694
. : milestone, 677,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6443) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 89, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6443) - mean (633ms) : 614, 652
. : milestone, 633,
master - mean (633ms) : 615, 650
. : milestone, 633,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6443) - mean (193ms) : 190, 197
. : milestone, 193,
master - mean (194ms) : 190, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6443) - mean (1,100ms) : 1075, 1125
. : milestone, 1100,
master - mean (1,098ms) : 1071, 1125
. : milestone, 1098,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6443) - mean (279ms) : 273, 285
. : milestone, 279,
master - mean (277ms) : 271, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6443) - mean (870ms) : 840, 900
. : milestone, 870,
master - mean (873ms) : 838, 908
. : milestone, 873,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6443) - mean (267ms) : 262, 271
. : milestone, 267,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6443) - mean (853ms) : 825, 882
. : milestone, 853,
master - mean (853ms) : 820, 885
. : milestone, 853,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6443) (11.158M) : 0, 11158175
master (11.221M) : 0, 11220876
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6443) (7.241M) : 0, 7241130
master (7.241M) : 0, 7241087
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.659M) : 0, 7659179
section Manual
master (11.183M) : 0, 11183048
section Manual + Automatic
This PR (6443) (6.572M) : 0, 6572460
master (6.809M) : 0, 6809231
section DD_TRACE_ENABLED=0
master (10.320M) : 0, 10320441
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6443) (9.519M) : 0, 9519202
master (9.619M) : 0, 9619474
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6443) (6.411M) : 0, 6411063
master (6.441M) : 0, 6441493
section Trace stats
master (6.636M) : 0, 6635629
section Manual
master (9.572M) : 0, 9571909
section Manual + Automatic
This PR (6443) (5.909M) : 0, 5908734
master (5.944M) : 0, 5944316
section DD_TRACE_ENABLED=0
master (8.814M) : 0, 8813897
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6443) (10.097M) : 0, 10096913
master (10.190M) : 0, 10190355
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6443) (6.556M) : 0, 6556093
master (6.498M) : 0, 6498441
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.175M) : 0, 7175288
section Manual
master (9.943M) : 0, 9943361
section Manual + Automatic
This PR (6443) (6.005M) : 0, 6004818
master (5.907M) : 0, 5906581
section DD_TRACE_ENABLED=0
master (9.404M) : 0, 9404038
|
Benchmarks Report for tracer 🐌Benchmarks for #6443 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.216 | 646.73 | 786.30 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.155 | 635.11 | 549.68 | several? |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 399ns | 0.211ns | 0.761ns | 0.008 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 625ns | 3.31ns | 17.2ns | 0.008 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 670ns | 0.415ns | 1.55ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 501ns | 0.385ns | 1.49ns | 0.00964 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 646ns | 0.705ns | 2.73ns | 0.00954 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 833ns | 0.993ns | 3.85ns | 0.105 | 0 | 0 | 658 B |
#6443 | StartFinishSpan |
net6.0 | 418ns | 0.22ns | 0.853ns | 0.00813 | 0 | 0 | 576 B |
#6443 | StartFinishSpan |
netcoreapp3.1 | 550ns | 0.316ns | 1.22ns | 0.0077 | 0 | 0 | 576 B |
#6443 | StartFinishSpan |
net472 | 664ns | 0.384ns | 1.49ns | 0.0915 | 0 | 0 | 578 B |
#6443 | StartFinishScope |
net6.0 | 550ns | 0.289ns | 1.08ns | 0.0098 | 0 | 0 | 696 B |
#6443 | StartFinishScope |
netcoreapp3.1 | 787ns | 0.715ns | 2.77ns | 0.00922 | 0 | 0 | 696 B |
#6443 | StartFinishScope |
net472 | 909ns | 1.15ns | 4.16ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6443
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.135
592.35
672.14
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.135 | 592.35 | 672.14 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 592ns | 0.333ns | 1.29ns | 0.00978 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 923ns | 0.403ns | 1.56ns | 0.0094 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.16μs | 0.531ns | 2.06ns | 0.104 | 0 | 0 | 658 B |
#6443 | RunOnMethodBegin |
net6.0 | 672ns | 0.327ns | 1.26ns | 0.00967 | 0 | 0 | 696 B |
#6443 | RunOnMethodBegin |
netcoreapp3.1 | 870ns | 0.378ns | 1.46ns | 0.00913 | 0 | 0 | 696 B |
#6443 | RunOnMethodBegin |
net472 | 1.11μs | 0.924ns | 3.58ns | 0.104 | 0 | 0 | 658 B |
7bff173
to
7f09c50
Compare
Summary of changes
This PR adds missing telemetry metrics.
Ticket: SDTEST-1294
Reason for change
The metric was missing
Other details