[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

GreenMatan · 2024-12-08T13:52:43Z

Summary of changes

Fixed a race condition in ProbeStatusPoller where disposing during active polling could lead to accessing disposed timer objects.

Reason for change

Log describing the error:

[ERR] CheckBuildLogsForErr: 02:32:00 [Error] Probe Status Poller: Resuming the poller has failed. System.ObjectDisposedException: Cannot access a disposed object.
   at System.Threading.TimerQueueTimer.Change(UInt32 dueTime, UInt32 period)
   at System.Threading.Timer.Change(Int64 dueTime, Int64 period)
   at System.Threading.Timer.Change(TimeSpan dueTime, TimeSpan period)
   at Datadog.Trace.Debugger.ProbeStatuses.ProbeStatusPoller.ResumePollerTimer() in /project/tracer/src/Datadog.Trace/Debugger/ProbeStatuses/ProbeStatusPoller.cs:line 98

Implementation details

Added proper disposal state tracking and thread-safe disposal handling to prevent accessing disposed objects.

Test coverage

Added tests verifying proper disposal behavior and thread safety during polling operations.

Other details

Fixes #DEBUG-3173

datadog-ddstaging · 2024-12-08T14:17:22Z

Datadog Report

Branch report: matang/probe-status-poller-dispose-error
Commit report: fee37a1
Test service: dd-trace-dotnet

❌ 30 Failed (0 Known Flaky), 437456 Passed, 3566 Skipped, 32h 26m 35.12s Total Time
⌛ 1 Performance Regression

❌ Failed Tests (30)

This report shows up to 5 failed tests.

WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests

⌛ Performance Regressions vs Default Branch (1)

Baseline_cpu - scenarios 3.56s (+66.11ms, +2%) - Details

andrewlock · 2024-12-09T14:32:43Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6409) (11.242M)   : 0, 11242177
    master (11.225M)   : 0, 11225437
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6409) (7.284M)   : 0, 7283692
    master (7.290M)   : 0, 7290006
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.501M)   : 0, 7501158

    section Manual
    master (11.092M)   : 0, 11091844

    section Manual + Automatic
    This PR (6409) (6.671M)   : 0, 6671311
    master (6.820M)   : 0, 6819596

    section DD_TRACE_ENABLED=0
    master (10.398M)   : 0, 10398468

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6409) (9.693M)   : 0, 9692627
    master (9.342M)   : 0, 9341855
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6409) (6.379M)   : 0, 6378957
    master (6.166M)   : 0, 6166184

    section Trace stats
    master (6.626M)   : 0, 6626206

    section Manual
    master (9.458M)   : 0, 9458427

    section Manual + Automatic
    This PR (6409) (5.754M)   : 0, 5753756
    master (5.932M)   : 0, 5931685

    section DD_TRACE_ENABLED=0
    master (8.708M)   : 0, 8708428

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6409) (10.370M)   : 0, 10369876
    master (10.285M)   : 0, 10285334
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6409) (6.596M)   : 0, 6596429
    master (6.624M)   : 0, 6624079
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.232M)   : 0, 7231697

    section Manual
    master (10.176M)   : 0, 10175601

    section Manual + Automatic
    This PR (6409) (6.129M)   : 0, 6129139
    master (6.441M)   : 0, 6441464

    section DD_TRACE_ENABLED=0
    master (9.663M)   : 0, 9662582

andrewlock · 2024-12-09T15:10:22Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (981ms)  : 958, 1005
     .   : milestone, 981,
    master - mean (988ms)  : 963, 1014
     .   : milestone, 988,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (110ms)  : 107, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (681ms)  : 665, 696
     .   : milestone, 681,
    master - mean (687ms)  : 669, 704
     .   : milestone, 687,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (633ms)  : 613, 654
     .   : milestone, 633,
    master - mean (643ms)  : 626, 660
     .   : milestone, 643,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (191ms)  : 186, 195
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (1,094ms)  : 1068, 1121
     .   : milestone, 1094,
    master - mean (1,091ms)  : 1063, 1119
     .   : milestone, 1091,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (870ms)  : 838, 901
     .   : milestone, 870,
    master - mean (869ms)  : 839, 900
     .   : milestone, 869,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (266ms)  : 262, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (853ms)  : 823, 883
     .   : milestone, 853,
    master - mean (850ms)  : 818, 882
     .   : milestone, 850,

andrewlock · 2024-12-09T21:35:12Z

Benchmarks Report for tracer 🐌

Benchmarks for #6409 compared to master:

2 benchmarks are faster, with geometric mean 1.188
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.97μs	42.7ns	230ns	0.0163	0.00817	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	9.98μs	53.3ns	297ns	0.0206	0.0103	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	27.6ns	107ns	1.04	0.306	0.0994	6.21 KB
#6409	`StartStopWithChild`	net6.0	8.04μs	45.2ns	313ns	0.016	0.00798	0	5.61 KB
#6409	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.9ns	291ns	0.0243	0.00973	0	5.8 KB
#6409	`StartStopWithChild`	net472	16.4μs	40ns	155ns	1.04	0.301	0.0976	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	496μs	239ns	862ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	327ns	1.18μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	837μs	428ns	1.66μs	0.417	3.3 KB
#6409	`WriteAndFlushEnrichedTraces`	net6.0	495μs	329ns	1.23μs	0	2.7 KB
#6409	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	308ns	1.19μs	0	2.7 KB
#6409	`WriteAndFlushEnrichedTraces`	net472	847μs	327ns	1.22μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	151μs	870ns	7.07μs	0.144	14.47 KB
master	`SendRequest`	netcoreapp3.1	167μs	978ns	8.86μs	0.235	17.27 KB
master	`SendRequest`	net472	0.00121ns	0.000593ns	0.00222ns	0	0 b
#6409	`SendRequest`	net6.0	156μs	1.02μs	9.86μs	0.148	14.47 KB
#6409	`SendRequest`	netcoreapp3.1	172μs	1.29μs	12.9μs	0.171	17.27 KB
#6409	`SendRequest`	net472	0.00256ns	0.00116ns	0.00447ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6409

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.86 KB	41.53 KB	-326 B	-0.78%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	591μs	3.25μs	18.7μs	0.581	0	0	41.86 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	676μs	3.19μs	12μs	0.336	0	0	41.77 KB
master	`WriteAndFlushEnrichedTraces`	net472	830μs	3.69μs	13.8μs	8.33	2.5	0.417	53.26 KB
#6409	`WriteAndFlushEnrichedTraces`	net6.0	576μs	3.09μs	16.3μs	0.543	0	0	41.53 KB
#6409	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	3.53μs	19.3μs	0.324	0	0	41.71 KB
#6409	`WriteAndFlushEnrichedTraces`	net472	857μs	3.05μs	11.4μs	8.3	2.62	0.437	53.31 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.29μs	1.61ns	6.23ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.68μs	1.98ns	7.14ns	0.0134	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.04μs	0.876ns	3.03ns	0.157	0.00102	987 B
#6409	`ExecuteNonQuery`	net6.0	1.28μs	1.04ns	4.01ns	0.0141	0	1.02 KB
#6409	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.38ns	5.18ns	0.0139	0	1.02 KB
#6409	`ExecuteNonQuery`	net472	2.08μs	1.53ns	5.72ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.27μs	0.59ns	2.21ns	0.014	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.5μs	2.53ns	9.78ns	0.0136	976 B
master	`CallElasticsearch`	net472	2.67μs	2.27ns	8.78ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.577ns	2.16ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.838ns	3.25ns	0.0142	1.02 KB
master	`CallElasticsearchAsync`	net472	2.65μs	1.52ns	5.87ns	0.167	1.05 KB
#6409	`CallElasticsearch`	net6.0	1.26μs	0.507ns	1.76ns	0.0133	976 B
#6409	`CallElasticsearch`	netcoreapp3.1	1.59μs	0.559ns	2.17ns	0.0127	976 B
#6409	`CallElasticsearch`	net472	2.65μs	1.92ns	7.18ns	0.158	995 B
#6409	`CallElasticsearchAsync`	net6.0	1.35μs	1.03ns	4ns	0.0135	952 B
#6409	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	1.53ns	5.91ns	0.0139	1.02 KB
#6409	`CallElasticsearchAsync`	net472	2.63μs	3.25ns	12.6ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.46μs	1.01ns	3.9ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.646ns	2.5ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.83μs	0.444ns	1.72ns	0.145	915 B
#6409	`ExecuteAsync`	net6.0	1.33μs	1.18ns	4.42ns	0.0132	952 B
#6409	`ExecuteAsync`	netcoreapp3.1	1.64μs	1.05ns	3.95ns	0.0124	952 B
#6409	`ExecuteAsync`	net472	1.81μs	0.453ns	1.75ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.32μs	16.5ns	81ns	0.032	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.27μs	6.65ns	25.8ns	0.0393	2.85 KB
master	`SendAsync`	net472	7.42μs	2.19ns	8.48ns	0.493	3.12 KB
#6409	`SendAsync`	net6.0	4.44μs	2.08ns	7.76ns	0.0334	2.31 KB
#6409	`SendAsync`	netcoreapp3.1	5.45μs	2.9ns	11.2ns	0.0381	2.85 KB
#6409	`SendAsync`	net472	7.41μs	1.6ns	6.21ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.5μs	0.867ns	3.36ns	0.0234	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.32μs	1.28ns	4.79ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.68μs	2.61ns	9.75ns	0.249	1.57 KB
#6409	`EnrichedLog`	net6.0	1.49μs	0.739ns	2.77ns	0.0228	1.64 KB
#6409	`EnrichedLog`	netcoreapp3.1	2.18μs	2.06ns	7.7ns	0.0229	1.64 KB
#6409	`EnrichedLog`	net472	2.76μs	3.28ns	12.7ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	122μs	121ns	469ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	65.6ns	237ns	0	0	4.28 KB
master	`EnrichedLog`	net472	153μs	85.2ns	330ns	0.686	0.229	4.46 KB
#6409	`EnrichedLog`	net6.0	121μs	141ns	545ns	0.0612	0	4.28 KB
#6409	`EnrichedLog`	netcoreapp3.1	124μs	140ns	544ns	0	0	4.28 KB
#6409	`EnrichedLog`	net472	153μs	92.9ns	360ns	0.688	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	1.1ns	4.13ns	0.0308	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	1.78ns	6.9ns	0.0297	2.2 KB
master	`EnrichedLog`	net472	5μs	1.45ns	5.61ns	0.32	2.02 KB
#6409	`EnrichedLog`	net6.0	3.21μs	0.884ns	3.19ns	0.0305	2.2 KB
#6409	`EnrichedLog`	netcoreapp3.1	4.38μs	1.57ns	6.08ns	0.0285	2.2 KB
#6409	`EnrichedLog`	net472	5.02μs	0.501ns	1.74ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.42μs	1.03ns	3.98ns	0.0163	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.75μs	1.09ns	3.94ns	0.0156	1.14 KB
master	`SendReceive`	net472	2.04μs	1.31ns	5.09ns	0.183	1.16 KB
#6409	`SendReceive`	net6.0	1.33μs	3.89ns	15.1ns	0.0158	1.14 KB
#6409	`SendReceive`	netcoreapp3.1	1.78μs	1.05ns	4.07ns	0.0153	1.14 KB
#6409	`SendReceive`	net472	2.14μs	1.13ns	4.36ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.8μs	1ns	3.76ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.95μs	2.84ns	11ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.43μs	6.23ns	24.1ns	0.324	2.04 KB
#6409	`EnrichedLog`	net6.0	2.83μs	3.84ns	14.4ns	0.0213	1.6 KB
#6409	`EnrichedLog`	netcoreapp3.1	3.92μs	1.35ns	5.22ns	0.0216	1.65 KB
#6409	`EnrichedLog`	net472	4.57μs	3.93ns	15.2ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6409

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.228	728.11	593.03
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.149	642.03	558.64

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	406ns	0.519ns	1.87ns	0.00801	576 B
master	`StartFinishSpan`	netcoreapp3.1	642ns	1.36ns	5.28ns	0.0078	576 B
master	`StartFinishSpan`	net472	729ns	0.806ns	3.12ns	0.0915	578 B
master	`StartFinishScope`	net6.0	480ns	0.877ns	3.4ns	0.00973	696 B
master	`StartFinishScope`	netcoreapp3.1	719ns	0.761ns	2.85ns	0.00916	696 B
master	`StartFinishScope`	net472	870ns	1.26ns	4.88ns	0.104	658 B
#6409	`StartFinishSpan`	net6.0	405ns	0.604ns	2.34ns	0.00821	576 B
#6409	`StartFinishSpan`	netcoreapp3.1	557ns	1.06ns	4.1ns	0.00775	576 B
#6409	`StartFinishSpan`	net472	594ns	1.03ns	3.97ns	0.0916	578 B
#6409	`StartFinishScope`	net6.0	482ns	0.706ns	2.73ns	0.00976	696 B
#6409	`StartFinishScope`	netcoreapp3.1	715ns	1.06ns	3.96ns	0.0093	696 B
#6409	`StartFinishScope`	net472	853ns	1.34ns	5.18ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	667ns	0.762ns	2.95ns	0.00968	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	876ns	0.967ns	3.75ns	0.00918	696 B
master	`RunOnMethodBegin`	net472	1.09μs	1.55ns	6ns	0.104	658 B
#6409	`RunOnMethodBegin`	net6.0	677ns	0.525ns	2.03ns	0.00981	696 B
#6409	`RunOnMethodBegin`	netcoreapp3.1	885ns	1.01ns	3.77ns	0.00927	696 B
#6409	`RunOnMethodBegin`	net472	1.12μs	2.06ns	7.7ns	0.105	658 B

Fixed race condition of ProbeStatusPoller dispose

fee37a1

GreenMatan requested a review from a team as a code owner December 8, 2024 13:52

github-actions bot added the area:debugger label Dec 8, 2024

GreenMatan requested a review from dudikeleti December 8, 2024 13:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

GreenMatan commented Dec 8, 2024

datadog-ddstaging bot commented Dec 8, 2024 •

edited

Loading

andrewlock commented Dec 9, 2024

andrewlock commented Dec 9, 2024

andrewlock commented Dec 9, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6409

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6409

Raw results

Raw results

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

Are you sure you want to change the base?

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

Conversation

GreenMatan commented Dec 8, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Dec 8, 2024 • edited Loading

Datadog Report

❌ Failed Tests (30)

⌛ Performance Regressions vs Default Branch (1)

andrewlock commented Dec 9, 2024

Throughput/Crank Report ⚡

andrewlock commented Dec 9, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 9, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6409

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6409

Raw results

Raw results

datadog-ddstaging bot commented Dec 8, 2024 •

edited

Loading