[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

GreenMatan · 2024-12-08T13:52:43Z

Summary of changes

Fixed a race condition in ProbeStatusPoller where disposing during active polling could lead to accessing disposed timer objects.

Reason for change

Log describing the error:

[ERR] CheckBuildLogsForErr: 02:32:00 [Error] Probe Status Poller: Resuming the poller has failed. System.ObjectDisposedException: Cannot access a disposed object.
   at System.Threading.TimerQueueTimer.Change(UInt32 dueTime, UInt32 period)
   at System.Threading.Timer.Change(Int64 dueTime, Int64 period)
   at System.Threading.Timer.Change(TimeSpan dueTime, TimeSpan period)
   at Datadog.Trace.Debugger.ProbeStatuses.ProbeStatusPoller.ResumePollerTimer() in /project/tracer/src/Datadog.Trace/Debugger/ProbeStatuses/ProbeStatusPoller.cs:line 98

Implementation details

Added proper disposal state tracking and thread-safe disposal handling to prevent accessing disposed objects.

Test coverage

Added tests verifying proper disposal behavior and thread safety during polling operations.

Fixes

DEBUG-3173

datadog-ddstaging · 2024-12-08T14:17:22Z

Datadog Report

Branch report: matang/probe-status-poller-dispose-error
Commit report: cc0f966
Test service: dd-trace-dotnet

❌ 14 Failed (0 Known Flaky), 236285 Passed, 2816 Skipped, 32h 36m 37.44s Total Time

❌ Failed Tests (14)

This report shows up to 5 failed tests.

WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests - Details
Expand for error
```
 Assert.Contains() Failure
 Not found: (filter expression)
 In value:  List<ProbeStatus> []
```
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests - Details
Expand for error
```
 Assert.Contains() Failure
 Not found: (filter expression)
 In value:  List<ProbeStatus> []
```
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests
WhenProbeStatusChanges_ShouldUpdateDiagnostics - Datadog.Trace.Tests.Debugger.ProbeStatusPollerTests - Details
Expand for error
```
 Assert.Contains() Failure
 Not found: (filter expression)
 In value:  List<ProbeStatus> []
```

andrewlock · 2024-12-09T14:32:43Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6409) (11.242M)   : 0, 11242177
    master (11.225M)   : 0, 11225437
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6409) (7.284M)   : 0, 7283692
    master (7.290M)   : 0, 7290006
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.501M)   : 0, 7501158

    section Manual
    master (11.092M)   : 0, 11091844

    section Manual + Automatic
    This PR (6409) (6.671M)   : 0, 6671311
    master (6.820M)   : 0, 6819596

    section DD_TRACE_ENABLED=0
    master (10.398M)   : 0, 10398468

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6409) (9.693M)   : 0, 9692627
    master (9.342M)   : 0, 9341855
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6409) (6.379M)   : 0, 6378957
    master (6.166M)   : 0, 6166184

    section Trace stats
    master (6.626M)   : 0, 6626206

    section Manual
    master (9.458M)   : 0, 9458427

    section Manual + Automatic
    This PR (6409) (5.754M)   : 0, 5753756
    master (5.932M)   : 0, 5931685

    section DD_TRACE_ENABLED=0
    master (8.708M)   : 0, 8708428

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6409) (10.370M)   : 0, 10369876
    master (10.285M)   : 0, 10285334
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6409) (6.596M)   : 0, 6596429
    master (6.624M)   : 0, 6624079
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.232M)   : 0, 7231697

    section Manual
    master (10.176M)   : 0, 10175601

    section Manual + Automatic
    This PR (6409) (6.129M)   : 0, 6129139
    master (6.441M)   : 0, 6441464

    section DD_TRACE_ENABLED=0
    master (9.663M)   : 0, 9662582

andrewlock · 2024-12-09T15:10:22Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (983ms)  : 958, 1007
     .   : milestone, 983,
    master - mean (985ms)  : 961, 1010
     .   : milestone, 985,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (686ms)  : 668, 704
     .   : milestone, 686,
    master - mean (684ms)  : 667, 701
     .   : milestone, 684,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (638ms)  : 624, 653
     .   : milestone, 638,
    master - mean (635ms)  : 619, 650
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (190ms)  : 184, 197
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (1,089ms)  : 1054, 1125
     .   : milestone, 1089,
    master - mean (1,087ms)  : 1062, 1113
     .   : milestone, 1087,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (872ms)  : 848, 897
     .   : milestone, 872,
    master - mean (874ms)  : 845, 903
     .   : milestone, 874,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6409) - mean (265ms)  : 259, 270
     .   : milestone, 265,
    master - mean (265ms)  : 262, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6409) - mean (852ms)  : 815, 889
     .   : milestone, 852,
    master - mean (854ms)  : 823, 884
     .   : milestone, 854,

andrewlock · 2024-12-09T21:35:12Z

Benchmarks Report for tracer 🐌

Benchmarks for #6409 compared to master:

3 benchmarks are faster, with geometric mean 1.141
1 benchmarks are slower, with geometric mean 1.125
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.93μs	34.4ns	150ns	0.0159	0.00396	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	46.5ns	180ns	0.0147	0.00491	0	5.81 KB
master	`StartStopWithChild`	net472	16.4μs	47.6ns	184ns	1.04	0.296	0.0986	6.21 KB
#6409	`StartStopWithChild`	net6.0	7.81μs	43.1ns	262ns	0.0162	0.00809	0	5.61 KB
#6409	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.3ns	335ns	0.0195	0.00973	0	5.8 KB
#6409	`StartStopWithChild`	net472	16.3μs	50.2ns	195ns	1.06	0.338	0.113	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	465μs	317ns	1.23μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	293ns	1.13μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	861μs	342ns	1.28μs	0.428	3.3 KB
#6409	`WriteAndFlushEnrichedTraces`	net6.0	483μs	340ns	1.32μs	0	2.7 KB
#6409	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	531ns	1.99μs	0	2.7 KB
#6409	`WriteAndFlushEnrichedTraces`	net472	846μs	526ns	2.04μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	130μs	446ns	1.73μs	0.132	14.47 KB
master	`SendRequest`	netcoreapp3.1	146μs	453ns	1.75μs	0.219	17.27 KB
master	`SendRequest`	net472	0.0127ns	0.00368ns	0.0143ns	0	0 b
#6409	`SendRequest`	net6.0	132μs	231ns	833ns	0.199	14.47 KB
#6409	`SendRequest`	netcoreapp3.1	145μs	250ns	967ns	0.216	17.27 KB
#6409	`SendRequest`	net472	0.00377ns	0.00146ns	0.00548ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	586μs	3.04μs	14.6μs	0.573	0	0	41.69 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	711μs	3.94μs	24μs	0.351	0	0	41.49 KB
master	`WriteAndFlushEnrichedTraces`	net472	869μs	4.42μs	19.3μs	8.19	2.59	0.431	53.31 KB
#6409	`WriteAndFlushEnrichedTraces`	net6.0	559μs	2.95μs	14.5μs	0.532	0	0	41.64 KB
#6409	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	3.32μs	14.5μs	0.324	0	0	41.66 KB
#6409	`WriteAndFlushEnrichedTraces`	net472	840μs	3.97μs	14.8μs	8.45	2.53	0.422	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	1.17ns	4.51ns	0.0145	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	2.25ns	8.73ns	0.0134	0	1.02 KB
master	`ExecuteNonQuery`	net472	1.95μs	2.3ns	8.9ns	0.156	0.000976	987 B
#6409	`ExecuteNonQuery`	net6.0	1.3μs	1.11ns	4.16ns	0.0144	0	1.02 KB
#6409	`ExecuteNonQuery`	netcoreapp3.1	1.71μs	1.65ns	6.17ns	0.0138	0	1.02 KB
#6409	`ExecuteNonQuery`	net472	2.03μs	2.8ns	10.8ns	0.157	0.00101	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6409

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.144	1,304.20	1,139.58

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.3μs	0.645ns	2.41ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	1.2ns	4.63ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.53μs	1.93ns	7.46ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.33μs	0.594ns	2.22ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.998ns	3.73ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.69μs	1.18ns	4.27ns	0.166	1.05 KB
#6409	`CallElasticsearch`	net6.0	1.14μs	0.391ns	1.46ns	0.0135	976 B
#6409	`CallElasticsearch`	netcoreapp3.1	1.54μs	2.55ns	9.53ns	0.013	976 B
#6409	`CallElasticsearch`	net472	2.7μs	2.84ns	11ns	0.158	995 B
#6409	`CallElasticsearchAsync`	net6.0	1.28μs	0.577ns	2.23ns	0.0129	952 B
#6409	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.926ns	3.47ns	0.0136	1.02 KB
#6409	`CallElasticsearchAsync`	net472	2.64μs	1.6ns	6.21ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6409

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.145	1,339.02	1,169.37

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.474ns	1.77ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.58μs	1.62ns	6.07ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.86μs	0.532ns	2.06ns	0.145	915 B
#6409	`ExecuteAsync`	net6.0	1.17μs	0.955ns	3.44ns	0.0131	952 B
#6409	`ExecuteAsync`	netcoreapp3.1	1.55μs	0.95ns	3.55ns	0.013	952 B
#6409	`ExecuteAsync`	net472	1.89μs	0.494ns	1.85ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.35μs	2.24ns	8.39ns	0.0329	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.33μs	2.03ns	7.85ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.34μs	1.84ns	7.11ns	0.495	3.12 KB
#6409	`SendAsync`	net6.0	4.49μs	1.36ns	5.08ns	0.0315	2.31 KB
#6409	`SendAsync`	netcoreapp3.1	5.26μs	2.73ns	9.83ns	0.0395	2.85 KB
#6409	`SendAsync`	net472	7.37μs	1.77ns	6.87ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.43μs	1.14ns	4.25ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.23μs	0.685ns	2.47ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.54μs	1.49ns	5.77ns	0.25	1.57 KB
#6409	`EnrichedLog`	net6.0	1.54μs	0.806ns	2.91ns	0.0231	1.64 KB
#6409	`EnrichedLog`	netcoreapp3.1	2.2μs	1.08ns	4.05ns	0.0224	1.64 KB
#6409	`EnrichedLog`	net472	2.61μs	1.31ns	5.08ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	112ns	433ns	0.0579	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	254ns	951ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	142ns	549ns	0.684	0.228	4.46 KB
#6409	`EnrichedLog`	net6.0	117μs	205ns	796ns	0.0582	0	4.28 KB
#6409	`EnrichedLog`	netcoreapp3.1	120μs	119ns	446ns	0	0	4.28 KB
#6409	`EnrichedLog`	net472	153μs	246ns	952ns	0.676	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.98μs	1.02ns	3.94ns	0.0309	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.13μs	2.63ns	10.2ns	0.0289	2.2 KB
master	`EnrichedLog`	net472	4.98μs	1.33ns	5.13ns	0.32	2.02 KB
#6409	`EnrichedLog`	net6.0	3.07μs	0.973ns	3.77ns	0.0308	2.2 KB
#6409	`EnrichedLog`	netcoreapp3.1	4.27μs	1.79ns	6.69ns	0.0299	2.2 KB
#6409	`EnrichedLog`	net472	4.96μs	1.37ns	5.31ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	0.755ns	2.92ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	0.395ns	1.42ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.22μs	1.12ns	4.33ns	0.183	1.16 KB
#6409	`SendReceive`	net6.0	1.3μs	0.386ns	1.44ns	0.0162	1.14 KB
#6409	`SendReceive`	netcoreapp3.1	1.82μs	0.918ns	3.31ns	0.0155	1.14 KB
#6409	`SendReceive`	net472	2.05μs	1.76ns	6.82ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	1.18ns	4.57ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.81μs	1.45ns	5.63ns	0.021	1.65 KB
master	`EnrichedLog`	net472	4.31μs	6.23ns	24.1ns	0.322	2.04 KB
#6409	`EnrichedLog`	net6.0	2.72μs	0.972ns	3.76ns	0.022	1.6 KB
#6409	`EnrichedLog`	netcoreapp3.1	3.91μs	3.63ns	14ns	0.0215	1.65 KB
#6409	`EnrichedLog`	net472	4.41μs	2.13ns	7.98ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6409

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.133	535.98	473.18

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	452ns	0.614ns	2.38ns	0.00813	576 B
master	`StartFinishSpan`	netcoreapp3.1	564ns	0.835ns	3.01ns	0.00773	576 B
master	`StartFinishSpan`	net472	600ns	1.25ns	4.84ns	0.0918	578 B
master	`StartFinishScope`	net6.0	536ns	0.73ns	2.83ns	0.00984	696 B
master	`StartFinishScope`	netcoreapp3.1	687ns	1.67ns	6.48ns	0.00963	696 B
master	`StartFinishScope`	net472	868ns	1.77ns	6.84ns	0.104	658 B
#6409	`StartFinishSpan`	net6.0	453ns	0.556ns	2.15ns	0.00816	576 B
#6409	`StartFinishSpan`	netcoreapp3.1	557ns	0.946ns	3.67ns	0.00767	576 B
#6409	`StartFinishSpan`	net472	596ns	1.47ns	5.7ns	0.0916	578 B
#6409	`StartFinishScope`	net6.0	473ns	0.641ns	2.48ns	0.00987	696 B
#6409	`StartFinishScope`	netcoreapp3.1	737ns	0.803ns	3.11ns	0.00952	696 B
#6409	`StartFinishScope`	net472	809ns	2.05ns	7.94ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6409

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.125	851.90	958.01

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	626ns	0.918ns	3.56ns	0.00978	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	853ns	1.3ns	5.02ns	0.00942	696 B
master	`RunOnMethodBegin`	net472	1.02μs	2ns	7.73ns	0.104	658 B
#6409	`RunOnMethodBegin`	net6.0	601ns	1.26ns	4.88ns	0.00976	696 B
#6409	`RunOnMethodBegin`	netcoreapp3.1	959ns	1.58ns	6.1ns	0.0093	696 B
#6409	`RunOnMethodBegin`	net472	1.01μs	1.5ns	5.79ns	0.104	658 B

dudikeleti

We talked about it offline

GreenMatan requested a review from a team as a code owner December 8, 2024 13:52

github-actions bot added the area:debugger label Dec 8, 2024

GreenMatan requested a review from dudikeleti December 8, 2024 13:54

Fixed race condition of ProbeStatusPoller dispose

cc0f966

GreenMatan force-pushed the matang/probe-status-poller-dispose-error branch from fee37a1 to cc0f966 Compare January 22, 2025 13:34

dudikeleti approved these changes Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

GreenMatan commented Dec 8, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 8, 2024 •

edited

Loading

andrewlock commented Dec 9, 2024

andrewlock commented Dec 9, 2024 •

edited

Loading

andrewlock commented Dec 9, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6409

Raw results

Faster 🎉 in #6409

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6409

Raw results

Slower ⚠️ in #6409

Raw results

dudikeleti left a comment

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

Are you sure you want to change the base?

[Dynamic Instrumentation] Fixed race condition with ProbeStatusPoller dispose #6409

Conversation

GreenMatan commented Dec 8, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Fixes

datadog-ddstaging bot commented Dec 8, 2024 • edited Loading

Datadog Report

❌ Failed Tests (14)

andrewlock commented Dec 9, 2024

Throughput/Crank Report ⚡

andrewlock commented Dec 9, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 9, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6409

Raw results

Faster 🎉 in #6409

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6409

Raw results

Slower ⚠️ in #6409

Raw results

dudikeleti left a comment

Choose a reason for hiding this comment

GreenMatan commented Dec 8, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 8, 2024 •

edited

Loading

andrewlock commented Dec 9, 2024 •

edited

Loading

andrewlock commented Dec 9, 2024 •

edited

Loading