-
Notifications
You must be signed in to change notification settings - Fork 75
RUM-10805: Remove resolveMeta & resolveMetrics methods in tests #3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: d312ed9 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3005 +/- ##
===========================================
+ Coverage 71.17% 71.22% +0.05%
===========================================
Files 859 859
Lines 31429 31429
Branches 5298 5298
===========================================
+ Hits 22367 22384 +17
+ Misses 7555 7550 -5
+ Partials 1507 1495 -12
🚀 New features to boost your workflow:
|
...d/integration/src/androidTest/kotlin/com/datadog/android/sdk/integration/trace/TracesTest.kt
Outdated
Show resolved
Hide resolved
...d/integration/src/androidTest/kotlin/com/datadog/android/sdk/integration/trace/TracesTest.kt
Show resolved
Hide resolved
| .hasField(TRACER_KEY) { | ||
| hasField(TRACER_VERSION_KEY, context.sdkVersion) | ||
| } | ||
| .hasField(USR_KEY) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there should be something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the fields of SpanEvent.Usr are nullable and they are not used or set for these tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then this is something we shouldn't have. We should either set User object for the test or not add empty UserInfo object (like we do in RUM) to the trace event (or both), because sending object with empty property doesn't really make any sense.
Also I see that UserInfo.anonymousId is not set for the Span event, it is worth checking if it is on purpose or it is a miss.
What does this PR do?
Motivation
resolveMetaandresolveMetricsmethods used production code to generate expected values, then compared those values against the actual output.Review checklist (to be filled by reviewers)