-
Notifications
You must be signed in to change notification settings - Fork 76
Introduce vitalAppLaunchEventMapper #2987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aleksandr-gringauz
wants to merge
10
commits into
aleksandr-gringauz/feature/app-launch-vitals
Choose a base branch
from
aleksandr-gringauz/feature/app-launch-vitals-mapper
base: aleksandr-gringauz/feature/app-launch-vitals
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
75daebe
RUM-11784: Send TTID vital
aleksandr-gringauz a9b889f
RUM-11784: PR fixes
aleksandr-gringauz 49549fa
RUM-12225: Send TTFD Vital
aleksandr-gringauz b68ad3c
RUM-12225: Pr fixes
aleksandr-gringauz 67ea806
RUM-12225: More PR fixes
aleksandr-gringauz c18c507
RUM-12225: Report TTID as TTFD if TTFD reported too early
aleksandr-gringauz e2f6e17
RUM-12225: PR fixes
aleksandr-gringauz 63931a5
Include new RUM Schema changes
aleksandr-gringauz 2708d99
Merge pull request #2985 from DataDog/aleksandr-gringauz/feature/app-…
aleksandr-gringauz 58ca36d
Introduce vitalAppLaunchEventMapper
aleksandr-gringauz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we want to expose them in such shape. Maybe we can group them and introduce a single method here
withVitalEventMappers(operationsMapper = ..., appLaunchMapper = ..., ....).With current layout these methods seems to be very verbose among the other methods in this
Builder.Maybe we need to ask iOS SDK what will be their approach regarding this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we should revert to
setVitaEventMapperand use them for the all thevitalevents 🙂Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satween What arguments should
setVitaEventMapperhave? Same as @0xnm suggested?I was thinking about something like this: https://pl.kotl.in/nNeN0bmfx
Note that currently
VitalEventfrom this example doesn't exist in our code.OperationStepVitalandAppLaunchVitaldon't have a common parent type. We could change it though.But I still lean towards the solution with a separate method per vital type.
We started discussing it with @simaoseica-dd, but not finished yet.