-
Notifications
You must be signed in to change notification settings - Fork 76
PANA-4799: Send text truncation mode #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 53d2a45 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2978 +/- ##
===========================================
- Coverage 70.91% 70.87% -0.04%
===========================================
Files 829 829
Lines 30381 30452 +71
Branches 5184 5201 +17
===========================================
+ Hits 21543 21581 +38
- Misses 7373 7390 +17
- Partials 1465 1481 +16
🚀 New features to boost your workflow:
|
.../kotlin/com/datadog/android/sessionreplay/compose/test/elmyr/TextLayoutInfoForgeryFactory.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/com/datadog/android/sessionreplay/compose/internal/reflection/ComposeReflection.kt
Show resolved
Hide resolved
...c/test/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/SemanticsUtilsTest.kt
Outdated
Show resolved
Hide resolved
| whenever(mockResult.action) doReturn mockAction | ||
| whenever(textLayoutResult.layoutInput) doReturn mockTextLayoutInput | ||
| doAnswer { invocation -> | ||
| @Suppress("UNCHECKED_CAST") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nit: to avoid this Suppress, you can use invocation.getArgument<MutableList<TextLayoutResult>(0) API
What does this PR do?
The wireframe schema has been updated to allow sending text truncation mode. Possible modes are:
headmiddletailclipThis pr:
• Updates the session replay schema
• Captures and sends truncation mode for native
• Captures and sends truncation mode for compose
• Fixes a small issue with the sample application where it wasn't respecting system windows bounds
Depends on DataDog/rum-events-format#318
Related to DataDog/dd-sdk-ios#2550
Motivation
• Align with iOS on sending text truncation
• More accurate presentation of text when it overflows the bounds of the container.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)