Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7870: Remove non-critical Compose reflection error from telemetry #2476

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ambushwork
Copy link
Member

What does this PR do?

In Compose Session Replay, we setup some telemetry to monitor if the reflection is broken on client side, in the current version we noticed that some telemetries are false alert, so we need to remove them.

image

In this PR, we remove following reflection telemetry:

  • paragraphInfoList
  • ContentPainterModifier
  • AsyncImagePainter
  • ContentPainterElement
  • layout
  • paragraph

Motivation

RUM-7870

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork force-pushed the yl/compose/clean-telementry branch from 4fbbf32 to 8b94d73 Compare January 3, 2025 14:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (979bd88) to head (8b94d73).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 39 Missing ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2476      +/-   ##
===========================================
+ Coverage    69.88%   69.88%   +0.01%     
===========================================
  Files          787      787              
  Lines        29435    29469      +34     
  Branches      4909     4920      +11     
===========================================
+ Hits         20568    20594      +26     
- Misses        7495     7514      +19     
+ Partials      1372     1361      -11     
Files with missing lines Coverage Δ
...ionreplay/compose/internal/utils/SemanticsUtils.kt 70.48% <0.00%> (-5.00%) ⬇️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

@ambushwork ambushwork marked this pull request as ready for review January 3, 2025 15:04
@ambushwork ambushwork requested review from a team as code owners January 3, 2025 15:04
@ambushwork ambushwork merged commit 285ae49 into develop Jan 6, 2025
23 checks passed
@ambushwork ambushwork deleted the yl/compose/clean-telementry branch January 6, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants