Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol upload #21

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix symbol upload #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions reporter/symbol_querier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ func (d *DatadogSymbolQuerier) QuerySymbols(ctx context.Context, buildIDs []stri
return nil, fmt.Errorf("error marshaling symbols query request: %w", err)
}

fmt.Printf("Querying symbols with request: %s\n", string(body))

req, err := http.NewRequestWithContext(ctx, http.MethodPost, d.symbolQueryURL, bytes.NewReader(body))
if err != nil {
return nil, fmt.Errorf("failed to create request: %w", err)
Expand Down
4 changes: 3 additions & 1 deletion reporter/symbol_uploader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ func (d *DatadogSymbolUploader) GetExistingSymbolsOnBackend(ctx context.Context,
}
}

log.Debugf("Existing symbols for executable %s with build: %v", e, symbolSource)
return symbolSource, nil
}

Expand Down Expand Up @@ -225,8 +226,9 @@ func (d *DatadogSymbolUploader) upload(ctx context.Context, uploadData uploadDat
}

if existingSymbolSource >= symbolSource {
log.Debugf("Skipping symbol upload for executable %s: existing symbols with source %v", fileName,
log.Infof("Skipping symbol upload for executable %s: existing symbols with source %v", fileName,
existingSymbolSource.String())
return true
}

symbolPath := debugElf.actualFileName
Expand Down