-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hosts endpoint. #878
Open
dongothing-dd
wants to merge
19
commits into
master
Choose a base branch
from
dongothing-dd/add-hosts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add hosts endpoint. #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…__.py got formatted by black
dongothing-dd
added
changelog/Added
Added features results into a minor version bump
kind/feature-request
Feature request related issue
labels
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/Added
Added features results into a minor version bump
kind/feature-request
Feature request related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Add hosts endpoint. See #876.
Description of the Change
Added the hosts endpoint so I can get a host list without having to remember anything.
Alternate Designs
I considered adding to the "host" mode instead of creating a new "hosts" mode. Our endpoint is "hosts" so I used that naming convention.
Possible Drawbacks
N/A?
Verification Process
I tested in an Ubuntu VM with keys to the expert-services sandbox.
I ran flake8 tests via
python -m tox -c tox.ini -e flake8
I ran and passed integration tests via
python -m tox -c tox.ini -- -k hosts
Builds failed, but I assume that has to do with my environment rather than the change.
Additional Notes
I created a PR yesterday without the cassettes because it tested fine in my VM. The automated test failed here, so I added the cassettes today.
Release Notes
Added the hosts endpoints for the Datadog API.
dog hosts list
returns a list of all hosts.dog hosts totals
returns counts of active hosts. Datadog documentation.Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.