Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta support for Agent Data Plane. #1383

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

tobz
Copy link
Member

@tobz tobz commented Aug 29, 2024

What does this PR do?

Adds support for the experimental Agent Data Plane project. This follows a similar path to #1269 where only an experimental CLI flag is exposed for enabling ADP support, and we're leaving the CRDs alone.

Motivation

The ADP deployment model is based around a new container, so Operator changes are necessary for internal testing.

Additional Notes

N/A

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

Not tied to a standard Agent version, as this depends on a custom internal-only Datadog Agent build.

Describe your test plan

  • Deploy the custom Operator image to a designated staging cluster, and enable the newly-added CLI flag.
  • Update that cluster to use an ADP-specific image for the Datadog Agent.
  • Observe that the new container for ADP is created.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tobz tobz mentioned this pull request Aug 29, 2024
2 tasks
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 22.78481% with 61 lines in your changes missing coverage. Please review.

Project coverage is 47.01%. Comparing base (93b9f8f) to head (befe131).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ontrollers/datadogagent/component/agent/default.go 0.00% 36 Missing ⚠️
apis/datadoghq/common/common.go 0.00% 16 Missing ⚠️
...lers/datadogagent/feature/enabledefault/feature.go 75.00% 3 Missing and 1 partial ⚠️
...adogagent/component/clusterchecksrunner/default.go 0.00% 3 Missing ⚠️
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1383      +/-   ##
==========================================
- Coverage   47.29%   47.01%   -0.29%     
==========================================
  Files         217      217              
  Lines       18710    18839     +129     
==========================================
+ Hits         8849     8857       +8     
- Misses       9399     9520     +121     
  Partials      462      462              
Flag Coverage Δ
unittests 47.01% <22.78%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ers/datadogagent/component/clusteragent/default.go 96.85% <100.00%> (ø)
controllers/datadogagent/controller.go 54.83% <100.00%> (+1.50%) ⬆️
controllers/datadogagent/feature/types.go 26.92% <ø> (ø)
controllers/datadogagent/override/global.go 41.42% <100.00%> (+0.24%) ⬆️
controllers/setup.go 56.66% <100.00%> (+0.36%) ⬆️
main.go 0.00% <0.00%> (ø)
...adogagent/component/clusterchecksrunner/default.go 1.07% <0.00%> (ø)
...lers/datadogagent/feature/enabledefault/feature.go 37.90% <75.00%> (+2.30%) ⬆️
apis/datadoghq/common/common.go 12.98% <0.00%> (-1.94%) ⬇️
...ontrollers/datadogagent/component/agent/default.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b9f8f...befe131. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants