Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-741] Add telemetry logs #280

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Send error logs to Datadog's internal telemetry in some cases

Motivation
Improve our ability to troubleshoot library errors

@anmarchenko anmarchenko requested review from a team as code owners January 3, 2025 12:00
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (please see the comment about deduplication)

Comment on lines +77 to +80
# log invalid message once as error to internal telemetry
self.class.log_once.run do
Core::Telemetry::Logger.error(message)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants