Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-228] Send auto_injected: true to internal telemetry when auto instrumentation was used #260

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Adds a couple of small fixes to auto instrumentation:

  • test_session telemetry metric has now auto_injected tag set to true when auto instrumentation was used
  • when auto instrumentation is used on JRuby, we print error message and bail out of instrumenting tests

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.50%. Comparing base (7e3bb16) to head (20357b8).

Files with missing lines Patch % Lines
lib/datadog/ci/auto_instrument.rb 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   98.52%   98.50%   -0.02%     
==========================================
  Files         298      298              
  Lines       14079    14093      +14     
  Branches      680      682       +2     
==========================================
+ Hits        13871    13883      +12     
- Misses        208      210       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko merged commit a2377e4 into main Nov 26, 2024
31 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/telemetry_auto_injected_tag branch November 26, 2024 09:59
@github-actions github-actions bot added this to the 1.9.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants